aboutsummaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2011-04-06Either remove or use unused values found by Coverity. Fixes CIDsGerald Combs3-5/+5
1169-1172. svn path=/trunk/; revision=36500
2011-03-31Don't dereference a NULL pointer. Fixes CID 426.Chris Maynard1-1/+1
svn path=/trunk/; revision=36424
2011-03-29Add a missing break.Anders Broman1-0/+1
CID 487 svn path=/trunk/; revision=36403
2011-03-29Add a missing break.Anders Broman1-0/+1
CID 488 svn path=/trunk/; revision=36402
2011-03-29Add a missing break.Anders Broman1-0/+1
CID 490 svn path=/trunk/; revision=36401
2011-03-29Added FALLTHRU comment to avoid a "missing break" warning.Anders Broman1-0/+1
CID 489 svn path=/trunk/; revision=36400
2011-03-29Don't assign proto_item pointers that are not used.Martin Mathieson1-2/+2
Coverity 1174 svn path=/trunk/; revision=36395
2011-03-28Don't use prohibited strncpy(). Use g_strlcpy() instead. Ensures that "orig"Chris Maynard1-2/+2
will be NULL-terminated, even if len >= SCS_HUGE_SIZE. svn path=/trunk/; revision=36383
2011-03-27Removed uneeded 'continue'.Bill Meier1-1/+0
Fixes Coverity 815 ("UNREACHABLE"). svn path=/trunk/; revision=36367
2011-03-24Don't assign to a proto_item* if the value won't be used: Coverity 1155-1156;Bill Meier1-86/+86
Also: - Fix a few cases of SET_HIDDEN on the wrong item. (The SET_HIDDEN was being done on an already hidden item). - Minor indentation cleanup; svn path=/trunk/; revision=36315
2011-03-24Don't assign to a proto_item* if the value won't be used: Coverity 1151-1154;Bill Meier1-95/+95
svn path=/trunk/; revision=36312
2011-03-24Don't assign to a proto_item* if the value isn't to be used: Coverity 1173;Bill Meier1-135/+141
Also: - Fix 2 cases of an item attached to the wrong subtree; - "localize" & rename some variable definitions; - Minor indentation cleanup. svn path=/trunk/; revision=36310
2011-03-23Removed unused parameter to parseServiceNodeId.Stig Bjørlykke3-6/+4
Coverity 596. svn path=/trunk/; revision=36283
2011-03-23Rewrote check for szStr in dissect_ICBAPhysicalDevice_get_LogicalDevice_rqst.Stig Bjørlykke1-1/+1
Coverity 535. svn path=/trunk/; revision=36282
2011-03-23dont assign to a proto_item* unless we are going to use the valueRonnie Sahlberg1-7/+7
coverity 1157 svn path=/trunk/; revision=36276
2011-03-22Allocate correct size of range.Stig Bjørlykke1-2/+2
Coverity 718. svn path=/trunk/; revision=36262
2011-03-22Fix a typoJeff Morriss1-1/+1
svn path=/trunk/; revision=36249
2011-03-22Coverity 1167Ronnie Sahlberg1-4/+29
Dont assign tlv_item unless we need to dereference it. Also push the variable deeper into the scope where it is used isntead of function wide scope. svn path=/trunk/; revision=36243
2011-03-22Coverity 1168Ronnie Sahlberg1-3/+3
Create the items for 33_ARS under the subtree we create for this type and not under the parent node in the tree. svn path=/trunk/; revision=36242
2011-03-22Coverity 420Ronnie Sahlberg1-7/+4
Remove dead code and add a g_assert_not_reached() at a spot we can definitely never reach. change a if(x)g_free(x) to a g_free(x) since g_free(NULL) is just a nop. svn path=/trunk/; revision=36238
2011-03-21Added some casts to fix coverity 325.Stig Bjørlykke1-2/+2
svn path=/trunk/; revision=36228
2011-03-20From Roland Knall <rknall [AT] gmail.com>: allow heuristic subdissectorsGuy Harris1-0/+14
for SERCOS III packets. svn path=/trunk/; revision=36214
2011-02-24From Roland Knall via bug #5726: Adding a dissector registration, so theStephen Fisher1-0/+2
dissector may be called by other dissectors. svn path=/trunk/; revision=36055
2011-02-18Try to fix some Clan scan-build warnings.Gerald Combs1-1/+11
svn path=/trunk/; revision=36003
2011-02-17Remove some of the many dead assignments found by clangStephen Fisher1-30/+30
svn path=/trunk/; revision=35982
2011-02-08Rename some hf_... vars so name starts with hf_docsis_cmstatusBill Meier1-77/+77
svn path=/trunk/; revision=35873
2011-02-08#if 0 code related to unused "docsis" dissector table;Bill Meier6-3369/+3307
Use consistent indentation & other whitespace cleanup. svn path=/trunk/; revision=35869
2011-02-07From Hendrik Robbel:Jaap Keuter3-0/+294
Dissector for DOCSIS 3.0 CM-STATUS Report Messages. svn path=/trunk/; revision=35866
2011-02-03Just use g_strdup_printf(), rather than doing it ourselves.Guy Harris1-4/+1
svn path=/trunk/; revision=35780
2011-02-02A bit of Windows makefiles rework and cleanup:Bill Meier19-42/+59
- Define macros for certain CFLAGS in config.nmake iso of having defs in each makefile; a. -DHAVE_CONFIG_H and -D_U_="" are now part of a macro named STANDARD_CFLAGS; b. -WX has been replaced by WARNINGS_ARE_ERRORS (defined as -WX in config.nmake) (This allows disabling "Warnings as Errors" by just changing config.nmake) c. CVARSDLL definitions (not usage) have been removed from the various makefiles. XXX: It appears the usage of CVARSDLL can also be removed (not yet done) since: -DWIN32 and -DNULL=0 do not appear to be needed (any more); -D_MT and _D_DLL are not needed since /MP causes these definitions. d. Define a macro WARNINGS_CFLAGS with additional specific compiler (level4) warnings to be enabled. E.G., 4295: array is too small to include a terminating null character - config.nmake: reformat some long lines for readability; - plugins\Makefile.nmake: clean-deps does nothing: remove it (and usage in top-level makefile); - dissectors/Makefile.nmake: test to enable packet-rrc.obj target needs to include MSVC2010 ... svn path=/trunk/; revision=35747
2011-01-30Whitespace cleanup (remove trailing blanks from lines).Bill Meier3-182/+182
svn path=/trunk/; revision=35711
2011-01-30Add a comment about some "unreachable code" indicating possible incorrect ↵Bill Meier1-230/+230
code someplace. Fix some spelling.. svn path=/trunk/; revision=35710
2011-01-21There's no need to pass the result of tvb_get_ptr() as the 'value' inJeff Morriss4-437/+432
proto_tree_add_*(): just use proto_tree_add_item(). Replace some tvb_get_ptr()s with tvb_get_ephemeral_string(). svn path=/trunk/; revision=35603
2011-01-19Don't stop calling subdissectors when there's no tree.Jaap Keuter1-2/+0
svn path=/trunk/; revision=35591
2011-01-19Use Wireshark standard marking for unused parameters.Jaap Keuter7-55/+15
svn path=/trunk/; revision=35590
2011-01-16Do Windows compile with /WX flag: treat warnings as errors.Bill Meier1-1/+1
svn path=/trunk/; revision=35565
2011-01-02Fix some cut-and-pasteos and other typoes.Guy Harris1-7/+7
svn path=/trunk/; revision=35328
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris63-82/+82
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-12-16There is no exceptions.h file here, remove it from DISSECTOR_INCLUDES.Jeff Morriss1-2/+1
svn path=/trunk/; revision=35201
2010-12-16From Guido Reismueller:Jaap Keuter14-7/+4192
packet-mdd.c - TLV 15 fixed packet-tlv.c - Added Support for DOCSIS 3.0 TLVs (38-66) Added Support for the following DOCSIS 3.0 MAC Management Messages - DBC-REQ (packet-dbcreq.c) - DBC-RSP (packet-dbcrsp.c) - DBC-ACK (packet-dbcack.c) - CM-CTRL-REQ (packet-cmctrlreq.c) - CM-CTRL-RSP (packet-cmctrlrsp.c) - DPV-REQ (packet-dpvreq.c) - DPV-RSP (packet-dpvrsp.c) svn path=/trunk/; revision=35193
2010-12-11Added opcua_extensionobjecttable.c from revision 34906.Stig Bjørlykke1-0/+1
svn path=/trunk/; revision=35177
2010-12-04From Gerhard Gappmeier via ↵Jeff Morriss3-15/+40
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5429 : Until now the info column only shows the OPC UA transport protocol type (Hello, Ack, Secure Conversion message). After connections establishment has finished this column shows only Secure Conversion message, because every service is sent over the secure channel. This patch adds the useful support of displaying the service type in the info column. This makes it easier to find specific service calls in huge capture files. svn path=/trunk/; revision=35119
2010-12-04From Gerhard Gappmeier via ↵Jeff Morriss2-4/+336
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5427 : This patch adds support for dissecting all Extension Objects types defined by the OPC Foundation. svn path=/trunk/; revision=35118
2010-12-02From Gerhard Gappmeier:Anders Broman1-12/+12
Fix mapping of datatype strings in opcua plugin https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5428 svn path=/trunk/; revision=35105
2010-11-28From Robert Groenenberg:Anders Broman1-3/+32
Assert when using ASN.1 dissector with loading a 'type table' https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5447 svn path=/trunk/; revision=35055
2010-11-25Fix for bug 5435:Jaap Keuter1-1/+3
Add support for dissecting SLL type 0x17 frames. svn path=/trunk/; revision=35029
2010-11-21Fix properties.Bill Meier1-1/+1
svn path=/trunk/; revision=34997
2010-11-17From David Katz via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5166 :Jeff Morriss3-176/+357
Add a configuration parameter of the NWG version for WiMAX ASN CP dissector. The format and meaning of TLVs, as well as function types and messages changed between the different NWG versions. Added support for the version number of TLVs in the dictionary xml, its parser, and of course in the packet itself. Added support for the version number of function-types and message-types by extending the value_string structure to contain also a "since" version number. Successfully tested with a live capture and capture file, containing WiMAX ASN packets (full Network entry). Also fuzzed 500 passes successfully. The XML doesn't contain all existing NWG versions, only selected ones. This is a little tedious work to go over all TLVs of each version, so I'll add some newer versions later on. can add a short how-to of adding a new version, for others to use, if needed. svn path=/trunk/; revision=34919
2010-11-16From Gerhard Gappmeier via ↵Jeff Morriss6-1/+158
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5410 : This patch adds support for displaying OPC UA ExtensionObjects. An ExtensionObject is a mechanism to transport user defined structures as serialized blobs. Some types of ExtensionObjects are already defined by the OPC Foundation's OPC UA Specifications. These types can be implemented by this dissector, because they are well-known. Real user-defined or vendor-defined types are unlikely to be implemented by a passive dissector, because this would require browsing of the UA server's address space to retrieve the type information. Currently only the following types are supported: * DataChangeNotification * EventNotification Others OPC defined types will follow. From me: fix warnings: "format not a string literal and no format arguments" svn path=/trunk/; revision=34906
2010-11-16From Gerhard Gappmeier via ↵Jeff Morriss1-8/+29
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5409 : This patch fixes displaying OPCUA Strings and ByteStrings. From me: fix warnings: "format not a string literal and no format arguments" svn path=/trunk/; revision=34905
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-31 10:50:11 +0000