aboutsummaryrefslogtreecommitdiffstats
path: root/plugins/wimax
AgeCommit message (Collapse)AuthorFilesLines
2013-09-30Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-2/+2
svn path=/trunk/; revision=52290
2013-09-30Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-3/+3
svn path=/trunk/; revision=52289
2013-09-30Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=52288
2013-09-28Fix various warnings in (hopefully) the right ways.Evan Huus7-12/+5
svn path=/trunk/; revision=52236
2013-09-281. Remove PITEM_FINFO from add_tlv_subtree and add_protocol_subtree (as well ↵Michael Mann16-2017/+1427
as some other minor cleanup) and adjust the calling functions accordingly. 2. Converted several add_protocol_subtree calls to add_tlv_subtree to get true filterability. Many of the add_protocol_subtree are effectively being (ab)used as proto_tree_add_text with different highlighting. 3. Convert tvb_new_subset into tvb_new_subset_length. Still looks like some of the remaining "protocols" need more specific filters, and should just be regular FT_BYTES fields. svn path=/trunk/; revision=52235
2013-09-24Prevent crashing as a result of tree removal in r52208. Tree removal + this ↵Michael Mann1-2/+2
patch should be the "quick" fix to bug 5349 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5349). I knew the tree check was preventing some dissection/column data/etc, but from the comments in bug 5349, the tree check was also protecting this (and maybe other) crashes (due to missed NULL checking). I want to follow up with some massive cleanup (remove PITEM_FINFO calls), but this with r52208 should be good enough to backport to 1.8 and 1.10 to fix bug 5349. Cleanup shouldn't need to be backported. svn path=/trunk/; revision=52209
2013-09-24You are in a twisty little maze of code paths, all different. Get ridGuy Harris1-416/+407
of the if (tree) tests in dissect_mac_header_generic_decoder(), as some of the stuff done inside there should be done even if we're not building a protocol tree, e.g. CRC stuff and calling subdissectors. Get rid of a gratuitous pair of curly braces, and fix the indentation of one line, while we're at it. svn path=/trunk/; revision=52208
2013-09-24Stuff used when checking the CRC needs to be done regardless of whetherGuy Harris1-9/+14
we're building a protocol tree or not. svn path=/trunk/; revision=52207
2013-09-24Get rid of unused variable.Guy Harris1-3/+0
svn path=/trunk/; revision=52206
2013-09-24Fix copy-and-pasteo(?).Guy Harris1-2/+2
svn path=/trunk/; revision=52205
2013-09-24One advantage of making as many things as possible static is that, ifGuy Harris1-1/+4
they're not being used, the compiler can be made to warn about that. In this case, Broadcast_Control_Pointer_IE() was used because of a missing case in a switch statement; put that case in. svn path=/trunk/; revision=52204
2013-09-24Wimax dissector improvements:Michael Mann29-1193/+467
1. Remove message type field from all MAC Management "sub"dissectors and place it in Mac Management subdissector itself. This may cause backwards-compatibility issues (malformed packets) with third-party subdissectors of the MAC Management dissector, but it didn't make sense to have so many filters for a single enumerated value, especially when the various "protocol" filters covers many of them. 2. Removed some if(tree) checks as column info and calling other dissectors are sometimes executed underneath. Some of this is in preparation for addressing bug 5349. 3. Make all dissector functions (and a few others) static, and use register_dissector() when necessary. 4. Convert generic decoder CRC errors into expert info, rather than have it be a "protocol" filter (it just looks funny that way) In general, these dissectors seem "over-protocolized". I understand the need for all of the dissectors, but I don't know if they all need "protocol" status. svn path=/trunk/; revision=52203
2013-09-22Don't declare proto_mac_mgmt_msg_ucd_decoder twice.Jeff Morriss1-1/+0
svn path=/trunk/; revision=52168
2013-09-22Make dissectors register for their MAC Management Message Type and use ↵Michael Mann31-902/+603
dissector_try_uint to do any dissection. Many "outside" (third-party) message types appear to exist. Have the makefiles do all the work setting up proto_register_<dissector> and proto_reg_handoff_<dissector>, rather than sprinkled throughout the dissectors with extern declarations. More is coming to make more functions static (because of current makefile fixes) and cleanup MAC Management dissectors to remove unnecessary/duplicative code, but I wanted to get the build issues squared away. svn path=/trunk/; revision=52167
2013-09-17emem -> wmemPascal Quantin1-2/+2
svn path=/trunk/; revision=52130
2013-07-17Remove fragment_data, add fragment_head, fragment_item - for now alias it to ↵Jakub Zawadzki1-1/+1
the same structure. This is begin of work to split fragment head and fragments items. svn path=/trunk/; revision=50708
2013-07-14Use tvb_new_chain with the tvbuffs from a reassembly.Guy Harris1-2/+2
svn path=/trunk/; revision=50585
2013-07-14A fragment_data structure now contains a pointer to a tvbuff to theGuy Harris1-5/+5
fragment or reassembled data, not a pointer to the data itself; instead of having to construct a tvbuffs for the reassembled data, we can now just use the existing tvbuff. Spell out "fragment" and "fragmentation" in comments while we're at it. svn path=/trunk/; revision=50584
2013-07-06Add our license header to plugin moduleinfo.h files. Cleans up a batch ofEvan Huus1-0/+23
licensecheck warnings. svn path=/trunk/; revision=50407
2013-03-22Don't wire into the reassembly code the notion that reassemblies shouldGuy Harris1-3/+4
be done on flows from one address to another; reassembly for protocols running atop TCP should be done on flows from one TCP endpoint to another. We do this by: adding "reassembly table" as a data structure; associating hash tables for both in-progress reassemblies and completed reassemblies with that data structure (currently, not all reassemblies use the latter; they might keep completed reassemblies in the first table); having functions to create and destroy keys in that table; offering standard routines for doing address-based and address-and-port-based flow processing, so that dissectors not needing their own specialized flow processing can just use them. This fixes some mis-reassemblies of NIS YPSERV YPALL responses (where the second YPALL response is processed as if it were a continuation of a previous response between different endpoints, even though said response is already reassembled), and also allows the DCE RPC-specific stuff to be moved out of epan/reassembly.c into the DCE RPC dissector. svn path=/trunk/; revision=48491
2013-03-20 From beroset:Bill Meier3-12/+12
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10397 svn path=/trunk/; revision=48438
2013-03-18From beroset:Anders Broman1-12/+12
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48399
2013-03-12From David Arnold:Jaap Keuter1-1/+1
Replace use of INCLUDES with AM_CPPFLAGS in all Makefiles to placate recent autotools. svn path=/trunk/; revision=48261
2013-03-01Export libwireshark symbols using WS_DLL_PUBLIC defineBalint Reczey1-1/+1
Also remove old WS_VAR_IMPORT define and related Makefile magic everywhere in the project. svn path=/trunk/; revision=47992
2013-03-01From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 :Pascal Quantin2-47/+47
Remove C++ incompatibilities from WiMAX plugins svn path=/trunk/; revision=47978
2013-02-10Comment out numerous unused hf_.... instances found by checkhf.Bill Meier18-57/+129
svn path=/trunk/; revision=47617
2013-02-09Make the other plugin makefiles use the new style introduced in the MATEGuy Harris3-39/+40
makefiles. svn path=/trunk/; revision=47579
2013-01-26Fix for CID 280529 and 280530.Jaap Keuter1-0/+8
Check the validity of the TLV before using its retreived data. svn path=/trunk/; revision=47294
2012-12-26Fix a bunch of warnings.Guy Harris5-28/+28
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-12-05Fix numerous instances of a variable/parameter name "shadowing" a library ↵Bill Meier1-15/+15
function name; (At least some (gcc ?) compilers give a "shadow" warning for these). svn path=/trunk/; revision=46402
2012-10-26Create SET_ADDRESS_HF that takes an additional hf_ value that can beEvan Huus1-1/+1
used to override the filter generated from the address column. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7728 (again). svn path=/trunk/; revision=45792
2012-10-26Revert revision 44921.Evan Huus1-1/+1
See discussion on https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7728 svn path=/trunk/; revision=45791
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss40-80/+0
svn path=/trunk/; revision=45015
2012-09-15From Pontus Fuchs via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7728Evan Huus1-1/+1
Make right-click + apply-as-filter work in the packet list for non-ethernet frames (such as ieee 802.11 frames). svn path=/trunk/; revision=44921
2012-06-28Update FSF address - part II.Jakub Zawadzki1-2/+2
svn path=/trunk/; revision=43538
2012-06-28Update Free Software Foundation address.Jakub Zawadzki50-50/+50
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-01Set Makefile.common as a plugin.c dependency so plugin.c is rebuilt if ↵Bill Meier1-1/+1
Makefile.common is changed svn path=/trunk/; revision=42972
2012-06-01Windows: Set Makefile.common as a plugin.c dependency so plugin.c is rebuilt ↵Bill Meier1-2/+2
if Makefile.common is changed ToDo: ditto for Makefile.am ? svn path=/trunk/; revision=42971
2012-05-11Get rid of remaining Booleans-as-encoding-arguments inGuy Harris1-4/+18
proto_tree_add_item() calls. Add hf[] entries for some fields that didn't have them. svn path=/trunk/; revision=42588
2012-05-10Better fixes for the last commit.Gerald Combs2-6/+4
svn path=/trunk/; revision=42529
2012-05-09Fix a few scan-build warnings.Gerald Combs5-17/+12
svn path=/trunk/; revision=42528
2012-04-10Add missing consts.Jakub Zawadzki3-3/+3
svn path=/trunk/; revision=42004
2012-04-04Add a "-build" argument to checkAPIs.pl. Use that argument when buildingJeff Morriss2-2/+2
from makefiles (and thus from the buildbot). The intention is to be able to tell when a human is running the tool so we can provide more code-review guidance. As a starter, enable the "too many proto_tree_add_text() calls" check when a human is running the tool. svn path=/trunk/; revision=41943
2012-01-29Add *.sbr files to the clean target.Anders Broman1-1/+1
svn path=/trunk/; revision=40761
2011-10-20Use ENC_NA as proto_tree_add_item() encoding arg for FT_ETHER hf[] field type.Bill Meier6-13/+13
svn path=/trunk/; revision=39490
2011-10-18Do some more conversions of proto_tree_add_item() 'encoding' argBill Meier10-348/+348
(previously missed). svn path=/trunk/; revision=39450
2011-10-15Convert plugin files proto_tree_add_item() 'encoding' arg for field types ↵Bill Meier1-1/+1
FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39429
2011-10-10Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier9-303/+303
plugins/*: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_ITv6 use ENC_NA. (This was missed in an earlier SVN) svn path=/trunk/; revision=39329
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier36-1127/+1127
plugin dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39292
2011-10-05Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier20-162/+162
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|1|0|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39262