aboutsummaryrefslogtreecommitdiffstats
path: root/packet-t38.c
AgeCommit message (Collapse)AuthorFilesLines
2004-05-24Have two strings in an enum_val_t - one that's a short string that isGuy Harris1-5/+5
convenient to put into a command line (no capital letters, no spaces to require quotes), and one that's a detailed description for use in the UI. Allow either of them in the preferences file or "-o" option; use the detailed description in the UI, and also use it when writing the preferences out, so that the preference will be readable by older versions of Ethereal (assuming the preference existed in that version). Update "README.developer" to give more detail about an enum_val_t (and to put the _t in), and to give a more detailed description of the "radio_buttons" argument to "prefs_register_enum_preference()". svn path=/trunk/; revision=10982
2004-01-26Rename "dissect_t38_tcp()" to "dissect_t38_tcp_pdu()" to make itGuy Harris1-52/+64
clearer what it does (dissect a single T.38-over-TCP or T.38-over-TPKT PDU). Have "dissect_t38_udp()" that does T.38-over-UDP dissection and "dissect_t38_tcp()" that does T.38-over-TCP dissection; register handles for them for the appropriate protocols, rather than having a single dissector that checks the IP protocol type. Use -1 rather than "tvb_length(tvb)" as the length for top-level protocol tree items. Clean up indentation. svn path=/trunk/; revision=9870
2004-01-26From Martin Regner:Olivier Biot1-12/+114
- support both T.38IFP/TCP and T38IFP/TPKT/TCP There is one new preference setting tpkt_usage where you can specify if TPKT header is used. With the default setting (tpkt_usage=Maybe) the dissector will look on the first four octets and try to determine if TPKT is used or not. This setting seems to work well with the captures I have tried, but there might be some scenarios where it will be better to set the value to 'Always' or 'Never' dependant on if TPKT header is used or not. There is also a new preference setting regarding TCP desegmentation. TCP desegmentation is currently only supported when TPKT header is used. You will need to set the preference setting "Allow subdisectors to desegment TCP streams" for TCP and also the "Desegment all TPKT messages spanning multiple TCP segments" for TPKT if you want to use this feature. I don't have any T.38 captures with segmented packets so I have not been able to test this so much. - Support for T.38 (2002) ASN.1 specification http://www.itu.int/ITU-T/asn1/database/itu-t/t/t38/2003/T38(2002).html Note: This ASN.1 specification is incompatible with the Pre-Corigendum T.38 ASN.1 specification (1998) so you will need to set the preference setting accordingly. - When there are extra octets after the T.38 UDPTL packet you will now see [Malformed?] in the Info-column. I thought that it was quite irritating that non-T.38 packets could look like they were correctly coded T.38 packets. - There might be several T.38 IFP packets in a TCP packet for the T.38 directly over TCP scenario. There is now at least some support for this, but since TCP desegmentation is only supported for the TPKT scenario this will not work if an IFP packet is splitted into several TCP packets. svn path=/trunk/; revision=9868
2004-01-09From Martin Regner:Guy Harris1-21/+184
temporary hack added to check for packets that look like RTPv2 packets and to dissect them as such (the right fix is to support starting and ending frames in conversations and to have H.245 close UDP conversations when appropriate and start new ones); add preferences for the UDP and TCP port numbers; add a preference to specify whether to use pre-corrigendum T.38 or post-corrigendum T.38; give a summary in the Info column. svn path=/trunk/; revision=9622
2003-10-09Prefix the EXTENSION #defines with ASN1_ as well.Guy Harris1-67/+67
svn path=/trunk/; revision=8653
2003-10-09Prefix OPTIONAL and NOT_OPTIONAL with ASN1_, to avoid collisions withGuy Harris1-10/+10
other definitions of OPTIONAL (such as the one in Windows). svn path=/trunk/; revision=8650
2003-09-11From Hans Viens :Ronnie Sahlberg1-0/+652
T38 dissector svn path=/trunk/; revision=8457