aboutsummaryrefslogtreecommitdiffstats
path: root/packet-ncp2222.inc
AgeCommit message (Collapse)AuthorFilesLines
2003-12-22Don't call "nds_defrag()" for positive ACK packets.Guy Harris1-2/+19
Put in some comments noting problems with NDS reassembly. svn path=/trunk/; revision=9403
2003-12-03The "ptr_u" unions no longer have a "next" pointer - they now just haveGuy Harris1-2/+2
one member - or have one that's not used, so get rid of those unions. svn path=/trunk/; revision=9151
2003-12-02From Didier Gautheron: put an "fvalue_t" structure into a "field_info"Guy Harris1-11/+11
structure, rather than separately allocating "fvalue_t"s and having the "field_info" structure point to them - this appears to speed up protocol tree construction a bit. svn path=/trunk/; revision=9146
2003-11-24Make the recent epan/proto.{c,h} change compile.Guy Harris1-2/+2
svn path=/trunk/; revision=9075
2003-10-23Non-NCP_SERVICE_REQUEST packets don't have a subfunction.Guy Harris1-14/+15
The group for a request isn't part of the packet, so give it an offset and length of 0, so if you select it we doesn't highlight some part of the packet. svn path=/trunk/; revision=8763
2003-09-25In "nds_defrag()", handle "request_value->ncp_rec" being null.Guy Harris1-6/+7
In "dissect_nds_request()", insert the request information into the hash table the first time we see the packet, regardless of whether we created a new conversation or not. svn path=/trunk/; revision=8541
2003-09-24Create a protocol tree if we don't have one, we're constructing the InfoGuy Harris1-111/+96
column, and we need stuff from the protocol tree for the Info column. Go back to the previous scheme for constructing the Info column; the previous change fixes the problems for which the Info column changes were fixes. svn path=/trunk/; revision=8526
2003-09-23From Greg Morris: get the request data before using it, if we don'tGuy Harris1-1/+16
already have it. svn path=/trunk/; revision=8523
2003-09-23From Greg Morris: properly initialize request_value->info_string usingGuy Harris1-5/+5
"strcpy()", not "strcat()". svn path=/trunk/; revision=8518
2003-09-20From Greg Morris: update the Info column even if we're not building aGuy Harris1-89/+107
protocol tree. svn path=/trunk/; revision=8502
2003-08-28Fix signed/unsigned comparison warning.Gilbert Ramirez1-4/+5
svn path=/trunk/; revision=8300
2003-08-25From Greg Morris:Guy Harris1-26/+291
1. Added support for defragmentation of NDS packets 2. Moved the run_info_string logic outside of the pinfo->fd->flags->visited because of the dissection of info strings is not processed on subsequent decodes then the find/string/info will not locate info string values. By moving this outside then when the find logic runs a tvb_dissect_new then the info string gets processed again and all data is visible. Otherwise only info column data that is processed by the NCP dissector is visible not any data from ncp2222.py processed by the info string function. svn path=/trunk/; revision=8257
2003-07-25Fix signed/unsigned comparison warnings.Gilbert Ramirez1-3/+7
svn path=/trunk/; revision=8084
2003-07-21Use "val_to_str()" to translate NDS verb numbers to strings.Guy Harris1-158/+20
svn path=/trunk/; revision=8060
2003-04-25From Greg Morris:Guy Harris1-31/+87
1. Some NCP's that displayed the file/directory path in the summary window would display blank lines on Windows based machines. This was due to unicode or non-displayable characters contained in the character string being added to the column data. I made a change to format/strip out non-displayable characters prior to adding to the column data. 2. Moved ncp_req_hash_value struct to packet-ncp-int.h so that I can use it within a future dissector (NMAS). Clean up white space. svn path=/trunk/; revision=7560
2003-04-09Clean up the handling of the completion code.Guy Harris1-7/+8
svn path=/trunk/; revision=7424
2003-04-08From Greg Morris: update the introductory comment, fix the handlingGuy Harris1-6/+9
of the completion code, and tweak the description of continuation fragments. svn path=/trunk/; revision=7416
2003-02-25From Greg Morris: don't delete the EID hash table after the first pass,Guy Harris1-29/+20
as it's needed whenever a packet is dissected. svn path=/trunk/; revision=7200
2003-02-19Updates from Greg Morris:Guy Harris1-10/+270
1. Added a number of NCP Error return values. 2. Added ability to pass byte strings to summary window. 3. Modified file NCP's to reflect file handle in summary window. 4. Changed all NCP's using QueueID from big endian to little endian. This is different from Novell's NCP documentation but matches same information obtained from NDS dissector. 5. Added over 50 more NDS error return values. 6. Partially fixed NDS Request verb 6 (Search Entries) svn path=/trunk/; revision=7172
2003-02-08The hour and minute fields of times go from 0 to 23 and 0 to 59, soGuy Harris1-3/+3
adding 1 to them is incorrect (and cannot possibly be correct, as that'd rule out 0 as valid values, meaning nothing can ever happen in the first hour after midnight or in the first minute after the hour). svn path=/trunk/; revision=7099
2003-01-22Keep track of and display the time between Call and Reply in NCP packets.Ronnie Sahlberg1-1/+18
svn path=/trunk/; revision=6968
2003-01-06Fix up the display of the "ncp.nds_time_filter" field.Guy Harris1-2/+2
svn path=/trunk/; revision=6852
2002-12-02Don't cast away constness, and fix variable and structure memberGuy Harris1-14/+14
qualifiers as necessary to ensure that we don't have to. "strcmp()", "strcasecmp()", and "memcmp()" don't return booleans; don't test their results as if they did. Use "guint8", not "guchar", for a pointer to (one or more) 8-bit bytes. Update Michael Tuexen's e-mail address. svn path=/trunk/; revision=6726
2002-10-22Put in a note about the completion code not appearing to be present inGuy Harris1-1/+7
replies to continuation messages (or, at least, not present in the obvious place). svn path=/trunk/; revision=6470
2002-10-21From Greg Morris:Guy Harris1-155/+665
Various NDS dissector enhancements including NDS verb 0x07, and proper ping flags for NDS ping version 10 request. Updated error codes for several NCP reply packets. NDPS enhancements. svn path=/trunk/; revision=6463
2002-10-19Get rid of all places where "vstring" is set to point to a null stringGuy Harris1-161/+17
constant, as that won't work with "get_string()" (it'll try to overwrite the constant, and either crash, trash memory, or both). svn path=/trunk/; revision=6460
2002-10-19From Greg Morris: put a buffer into "nw_uni_t", and make "get_string()"Guy Harris1-25/+10
fill that in. svn path=/trunk/; revision=6456
2002-10-16Clean up white space.Guy Harris1-32/+50
Clean up the stuff to handle MVTYPE_PROC_ENTRY_SPECIFIERS a bit, and put in comments explaining what's going on for that and MVTYPE_ATTR_REQUEST. svn path=/trunk/; revision=6439
2002-10-16Use #defines for multivalue types.Guy Harris1-69/+84
svn path=/trunk/; revision=6438
2002-10-16Make some counters 32-bit, as the upper limit on the loop in whichGuy Harris1-86/+86
they're used is 32-bit. Use "%u" rather than "%d" to print unsigned values. svn path=/trunk/; revision=6437
2002-10-16Use #defines for vtype values, rather than numbers.Guy Harris1-262/+272
svn path=/trunk/; revision=6436
2002-10-16Make arrays of "nds_val" structures rather than declaring a bunch ofGuy Harris1-2765/+2130
individual structures, and initialize them, and put them into the protocol tree, in a loop. svn path=/trunk/; revision=6435
2002-10-15Fully initialize an ncp_req_hash_value after allocating it.Guy Harris1-1/+4
svn path=/trunk/; revision=6431
2002-10-15We'll be building a protocol tree for all NDS Ping packets, so we canGuy Harris1-39/+35
just wrap the entire dissection in an "if", as was done before. (Actually, we can just skip the "if" entirely, I guess....) svn path=/trunk/; revision=6429
2002-10-15Set the "req_nds_flags" field for an NDS Ping request regardless ofGuy Harris1-100/+90
whether we're building a protocol tree or not. Set the separator if we put "Revision" into the summary. Check for a remaining length >= 8, not > 8, to check for an NDS version 10 or later ping, and check the reported length, not the captued length. svn path=/trunk/; revision=6428
2002-10-14Create the temporary tree if we're *not* building a protocol treeGuy Harris1-2/+2
already, not if we *are*. svn path=/trunk/; revision=6414
2002-10-11Make the flag buffer in "dissect_ping_req()" large enough to hold theGuy Harris1-8/+7
longest possible flag string. Don't create a temporary protocol tree unless we're not filling in a protocol tree. The NDS version isn't present in NDS pings prior to version 10; dissect it only if it's present. svn path=/trunk/; revision=6412
2002-10-11Note that "dissect_ping_req()" duplicates a bunch of stuff inGuy Harris1-6/+10
"dissect_ncp_request()". Fix "dissect_ping_req()" to properly put the NDS version in a ping request into the tree (although that field isn't present in the ping requests I've seen, so perhaps it's only in NDS version 10 and later), as big-endian (change FALSE to TRUE if it's little-endian). Get rid of the unused "ncp_nds_verb" variable (set, but not used) in "dissect_ncp_common()". Call "dissect_ping_req()" from "dissect_ncp_common()" again. svn path=/trunk/; revision=6411
2002-10-10Fix some spelling errors.Guy Harris1-50/+50
svn path=/trunk/; revision=6410
2002-10-10Rename "ncp.nds_string" to "ncp.nds_tree_name", as it's not a genericGuy Harris1-15/+10
string, it's a tree name (as the field's display name suggests). Get rid of the unused "ncp.nds_string_value" field. Fix up the names of some fields, and use "proto_tree_add_uint()" rather than "proto_tree_add_uint_format()" to add them to the protocol tree. svn path=/trunk/; revision=6408
2002-10-10Fix up the handling of bitfields in NDS messages - get rid of extraGuy Harris1-78/+74
blanks, and don't put the list of flag values in if no bits are set. svn path=/trunk/; revision=6407
2002-10-10"proto_tree_add_string_format()" requires that the string value beGuy Harris1-13/+16
passed as an argument before the format string; fix some calls to do so. svn path=/trunk/; revision=6405
2002-10-10When deciding whether to put "NDS" into the protocol field in the packetGuy Harris1-15/+17
list, check whether the protocol field is enabled, not whether the info field is enabled. Update the protocol field before trying to look at the packet, so it gets updated even for short packets. Only parse service reply packets as NDS packets; don't parse positive ack packets that way. svn path=/trunk/; revision=6404
2002-10-10Don't attach the string for an NDS error to the completion code - attachGuy Harris1-30/+8
the string for the completion code. Do put the string for the NDS error into the summary line, however. Don't clear the NDS error code if we can't translate it to a string. svn path=/trunk/; revision=6400
2002-10-10"#if 0" out the code in "get_string()", as it will probably causeGuy Harris1-3/+15
crashes on many platforms, and other random behavior on others. Don't create a temporary tree with an NCP tree underneath it if we already have an NCP tree; we don't want the results of a dissection to be stuck in an invisible temporary tree if we're supposed to be generating a protocol tree. svn path=/trunk/; revision=6399
2002-10-08From cjs 2895: get rid of C++ comments, so IBM's Visual Age C compilerGuy Harris1-3/+3
can compile the code. Note that Bill Fumerola rewrote the Cisco NetFlow dissector. Update a bunch of addresses in the Ethereal man page, and put some missing addresses in. svn path=/trunk/; revision=6380
2002-10-08Make some variables unsigned to remove some compiler warnings.Guy Harris1-3/+3
svn path=/trunk/; revision=6377
2002-09-26Warning fixes for the ncp code by Greg Morris and J�rg Mayer.Jörg Mayer1-25/+12
svn path=/trunk/; revision=6338
2002-09-25Greg Morris:Jörg Mayer1-49/+81
This update adds NCP 87/66. Also add additional error codes, added hf_definition for super class (NDS). Cleaned up some unused variables (Warnings when building Ethereal). Fixed NCP type 0x9999 (server busy packets to echo information to summary information), Added subtree format to NDS dissector to cleanup display. svn path=/trunk/; revision=6331
2002-09-22Fix some (but not all) compiler warnings.Gerald Combs1-10/+10
svn path=/trunk/; revision=6317
generated by cgit v1.2.3 (git 2.25.1) at 2024-04-27 09:12:21 +0000