aboutsummaryrefslogtreecommitdiffstats
path: root/gtk
AgeCommit message (Collapse)AuthorFilesLines
2002-08-02Replace the types from sys/types.h and netinet/in.h by their glib.hJörg Mayer14-103/+39
equivalents for the gtk/ directory. svn path=/trunk/; revision=5930
2002-08-01Fix a few more memleaks found by valgrind (all derivingJörg Mayer2-4/+10
from the get_persconffile_path mess). svn path=/trunk/; revision=5927
2002-07-30From Graeme Hewson:Guy Harris1-1/+61
Ethereal sometimes creates a progress dialog bar and then, if the processing is fast, quickly destroys it. The resulting "flash" can be disconcerting. This set of patches ensures a progress bar is either not created or is displayed for a minimum time. svn path=/trunk/; revision=5916
2002-07-30#ifdef out some variables not used on Windows.Guy Harris1-30/+32
If printing a single packet to a file, don't use the "print to a printer" code for Windows. Only free "print_args.dest" *after* the last usage. svn path=/trunk/; revision=5913
2002-07-29From Joerg Mayer:Guy Harris1-2/+5
gtk/colors.c: Fix a memleak found by valgrind (Note that there are similar bugs in other functions that use the same construct with path!) svn path=/trunk/; revision=5910
2002-07-17From Joerg Mayer:Guy Harris3-15/+3
dftest.c: Remove #if-0-ed includes packet-ieee80211.c, packet-wtls.c, packet-afp.c, packet-wsp.c, packet-wtp.c, ethereal_gen.py: Remove redundant include varargs (already in snprintf.h, and required only for snprintf.h) Remove unused include of snprintf.h from files not using "snprintf()". svn path=/trunk/; revision=5889
2002-07-17Get rid of some "unused variable" and "unused static function" warnings,Guy Harris2-26/+71
and some compile errors in Tethereal, when compiling without libpcap. If libpcap is missing (whether that's detected at compile time or, as on Windows, at run time), don't call any of the "capture_prefs" routines - the routine to create the capture preferences page wasn't called, so the other routines can try to refer to non-existent widgets and other items and crash. Get rid of the stub routines in "capture_prefs()" used when compiling without libpcap, as they're no longer called. svn path=/trunk/; revision=5888
2002-07-07Fields can be up to 2^32-1 bytes long, as they may have come from aGuy Harris1-3/+5
reassembled packet and are thus not limited to the maximum frame size; leave room for a Really Big number in the length item in the status bar, and use "snprintf()" to format the length item Just To Be Sure. svn path=/trunk/; revision=5839
2002-07-07From Liviu Daia <Liviu.Daia[AT]imar.ro>: move "col_init()" call afterGuy Harris1-3/+3
the command-line options are processed, so that we don't crash if you've set the "column.format" preference from the command line. Fix a grammaro in a comment. svn path=/trunk/; revision=5838
2002-07-06From a suggestion by PEN <codes [at] lycos.com>, add the length in bytes toGerald Combs1-5/+12
the status bar when a tree item is selected. svn path=/trunk/; revision=5825
2002-06-28Trim leading and trailing white space from the capture device in theGuy Harris1-3/+12
preference setting, and, if it's empty, treat that as an indication that the user doesn't want to wire in a default device, and just wants the first device in the list chosen. svn path=/trunk/; revision=5773
2002-06-27From Anand V. Narwani: add in two missing files, so they're put into theGuy Harris1-4/+5
source tarball. Update Gerald's e-mail address. svn path=/trunk/; revision=5769
2002-06-24Update the URL for WinPcap.Guy Harris1-2/+2
svn path=/trunk/; revision=5759
2002-06-24As we've done with the hex dump output for printing, use as many digitsGuy Harris1-22/+135
to display the offset as are necessary to show the largest offset - which could be bigger than 65535, so there may be more than 4 digits. svn path=/trunk/; revision=5751
2002-06-22From Devin Heitmueller: give the user a warning if they click "New" inGuy Harris1-1/+8
the filter list editing code without having specified a filter name and string. svn path=/trunk/; revision=5737
2002-06-19Added MS Window printing to ethereal.Jeff Foster4-34/+320
svn path=/trunk/; revision=5711
2002-06-16Handle the "bool" members the same way we handled the members forGuy Harris1-7/+7
enumerated values - "boolp" for pointers, "boolval" for values. svn path=/trunk/; revision=5678
2002-06-16From Chris Waters: don't use "bool" as a variable name or structureGuy Harris1-7/+7
member, as it's a C++ keyword. svn path=/trunk/; revision=5677
2002-06-04From Graeme Hewson: varargs code cleanup in "simple_dialog.c".Guy Harris1-1/+2
svn path=/trunk/; revision=5617
2002-06-04Clean up white space.Guy Harris1-2/+2
svn path=/trunk/; revision=5615
2002-06-04Get rid of the "data_src" member of the "frame_data" structure; put itGuy Harris4-62/+46
in the "packet_info" structure instead, as we don't need a pointer for every single frame in the capture file, just for each frame for which we currently have an open "epan_dissect_t". svn path=/trunk/; revision=5614
2002-05-30Don't assume that just because a purported font name begins with "-"Guy Harris1-4/+23
it's an XLFD font name. svn path=/trunk/; revision=5596
2002-05-27Clean up the data structures for the color filter code a bit. The oldGuy Harris4-168/+173
"colfilter" structure contained items of use only when the colorizing dialog was up, so make the items in it private to "gtk/color_dlg.c". Make the "Edit" and "Delete" buttons sensitive only when a row is selected, and make the "Up" and "Down" buttons sensitive only when a row is selected *and* that row has somewhere to move in the specified direction. svn path=/trunk/; revision=5575
2002-05-24Get rid of an unused variable.Guy Harris1-2/+1
svn path=/trunk/; revision=5540
2002-05-23Save the whole capture device name in the preferences file. UnderGerald Combs1-7/+4
Windows, this saves the description + device name. svn path=/trunk/; revision=5534
2002-05-22Command-line interface cleanups, from Graeme Hewson:Guy Harris1-35/+60
- Exit if an error is found in the options or arguments. - In print_usage(), improve the visibility of any getopt() error message by suppressing the version information when -h is not specified, and by adding an empty line. Ethereal: - If the -k option is specified, use the interface in the preferences file, if present. - Prevent the user from specifying any hidden options which are used internally in -S mode. Tethereal: - Fix a memory leak in the processing of the -f option. - In print_usage(), change "capture file type" to "output file type", which I think is clearer; move the -q flag from the non-libpcap case to the libpcap case. svn path=/trunk/; revision=5525
2002-05-18In the Windows capture dialog, place the interface description before theGerald Combs1-2/+8
interface name. svn path=/trunk/; revision=5499
2002-05-14Use "-G fields" rather than "-G" in Makefiles.Guy Harris1-1/+6
Print an error and exit if an invalid option is given for the "-G" flag. svn path=/trunk/; revision=5466
2002-05-14Make the "-G" flag take an argument. If no arugment is specified, or ifGuy Harris1-8/+20
the argument is "fields", dump out a table of the fields, as we currently do; if the argument is "protocols", dump out a table of the protocols. svn path=/trunk/; revision=5462
2002-05-03From Didieer Gautheron:Guy Harris3-3/+37
Don't show progress bar for quick "Find Frame" searches Add "Find Next" and "Find Previous" to repeat searches Add documentation for "Find Next" and "Find Previous". svn path=/trunk/; revision=5378
2002-05-03Make the filter list combo box case-sensitive, as filter expressions areGuy Harris1-1/+3
case-sensitive. Squelch a compiler complaint. svn path=/trunk/; revision=5369
2002-05-03Clean up the handling of filter strings:Guy Harris3-41/+49
have "filter_packets()" make a copy of the filter string handed to it, as it may save the filter string in the "capture_file" structure, and the caller of "filter_packets()" shouldn't have to worry about the string it passed to "filter_packets()" being stashed away somewhere so that it can't just free that string or change it; have callers of "filter_packets()" free up the string they handed to it, if the string was allocated and they're done with it; plug some memory leaks in "match_selected_cb_do()". Check for an illegal "action" argument being passed to "match_selected_cb_do()". Move some keys out of "keys.h" into "gtk/main.c", as they're only used in "gtk/main.c". Make the pointer to the filter list a data item for the combo box, as it's a copy of the list of strings for the combo box, rather than attaching it to the widgets that activate the filter (a pointer to the combo box *itself* is a data item for those widgets). In "filter_activate_cb()", make a copy of the text from the text entry field as soon as we fetch it, and use that copy. Free that copy if we didn't add the filter to the filter list. Don't make a copy of the entire filter list and use that to set the combo box's list of items - just use the list itself. Also, when the list is changed, make the new value the data for the combo box (the list pointer will actually not be changed, because we happen to be using "g_list_append()", but let's not rely on that). svn path=/trunk/; revision=5368
2002-05-02Remove some no-longer-applicable XXX comments.Guy Harris1-33/+42
When you click "OK" on the dialog box, destroy the dialog box *before* activating any text widget into which we've stuffed the filter expression, so we don't get the dialog box destroyed out from under us before we try to destroy it ourselves. svn path=/trunk/; revision=5367
2002-04-29Removal (or, at least, #ifdeffing out) of unused variables andGuy Harris1-2/+5
functions, from David Frascone. svn path=/trunk/; revision=5288
2002-04-23Use the value of "bv_size" as the size of a byte view notebook whenGuy Harris1-1/+2
creating it. svn path=/trunk/; revision=5229
2002-04-23Get rid of unused variables, and mark unused arguments as such.Guy Harris1-5/+2
svn path=/trunk/; revision=5228
2002-04-22Eliminate some unused variables.Guy Harris1-7/+5
svn path=/trunk/; revision=5224
2002-04-22Polish the column prefs a bit. Make the column tile entry and formatGerald Combs1-161/+179
menu modify the currently-selected item directly. Remove the "Change" button since it's no longer needed. Make the column list a clist, and add a column which shows the format. Make the format option menu not fill the entire table cell. Update the man page accordingly. svn path=/trunk/; revision=5214
2002-04-20On Windows, include "capture-wpcap.h", to define "has_wpcap".Guy Harris1-1/+7
svn path=/trunk/; revision=5209
2002-04-19On Windows, don't put the capture preferences item into theGuy Harris1-2/+9
"Preferences" dialog box if we couldn't load WinPcap. svn path=/trunk/; revision=5204
2002-04-14Update wiretapped mirror links.Gerald Combs1-2/+2
svn path=/trunk/; revision=5156
2002-04-14Change "http://netgroup-mirror.ethereal.com/winpcap" URLs toGerald Combs1-2/+2
"http://winpcap.mirror.ethereal.com/", since that's how we're mirroring the Politecnico di Torino sites now. svn path=/trunk/; revision=5155
2002-04-08More static-ization.Gilbert Ramirez1-2/+2
svn path=/trunk/; revision=5131
2002-04-08"expand_tree()" and "collapse_tree()" can be called on leaf nodes, soGuy Harris1-9/+19
don't blow up if "finfo->tree_type" is -1, just don't expand anything. svn path=/trunk/; revision=5127
2002-04-01Start assigning ett_ values at 0, rather than 1; get rid of the reservedGuy Harris1-1/+4
ETT_NONE entry. Initialize the "tree_type" field of a "field_info" structure to -1, meaning "this has not been given a subtree". Add checks before using that field that it's in range. That way, you have to create a subtree before putting protocol tree items under another item. We allocate the "tree_is_expanded" array when we've registered all dissectors; there's no need to allocate it while we're registering dissectors and, in fact, doing so means we leak memory (the memory for the version we allocated while registering dissectors). svn path=/trunk/; revision=5068
2002-03-31Get rid of unused arguments.Guy Harris4-17/+15
Use the "nb" argument to "redraw_hex_dump()", so we redraw the specified byte view pane, rather than always redrawing the main window's byte view pane (and never redrawing the byte view pane of additional packet windows, so that the font for them doesn't change if you change the font preference). svn path=/trunk/; revision=5066
2002-03-31Get rid of an unused argument to "set_active_all()".Guy Harris1-6/+6
Mark as unused arguments that are now unused as a result of not passing them to "set_active_all()". svn path=/trunk/; revision=5065
2002-03-31From Joerg Mayer: get rid of unused arguments, and mark those that can'tGuy Harris1-2/+2
be eliminated (because the function is called through a pointer, and other functions called through the same pointer *do* use the argument) as unused. svn path=/trunk/; revision=5050
2002-03-16A double-click in a filter name in the list-of-filters dialog box shouldGuy Harris1-9/+28
activate the text widget into which the filter text is put only if clicking "OK" in the list-of-filters dialog box does so. Make it so. svn path=/trunk/; revision=4955
2002-03-12Get rid of the "--enable-snmp" option; instead, use "--with-ucdsnmp".Guy Harris1-5/+3
Make the directory option to "--with-ucdsnmp" optional. Handle "--with-ucdsnmp" similar to the way "--with-pcap" is handled. Get rid of unnecessary #defines in "packet-cops.c". Get rid of no-longer-necessary include of "dlfcn.h" in "packet-snmp.c". svn path=/trunk/; revision=4930