path: root/gtk
AgeCommit message (Collapse)AuthorFilesLines
2006-04-12From Jaap Keuter, fix for 871: split interface details statistics into it's ↵Ulf Lamping1-3/+15
own tab, making the dialog a lot smaller. svn path=/trunk/; revision=17850
2006-04-10Add 2px height to avoid a vertical scrollbar with Gtk-WimpJaap Keuter1-1/+1
svn path=/trunk/; revision=17846
2006-04-08Fix for bug 848. Make a scrollable window when more than 10 interfaces are ↵Jaap Keuter1-4/+21
listed. svn path=/trunk/; revision=17844
2006-04-04From Irene: Make buttons unselecable when nothing would happen.Michael Tüxen1-4/+10
svn path=/trunk/; revision=17803
2006-04-03Set the right structure member.Guy Harris1-1/+1
svn path=/trunk/; revision=17792
2006-04-03In Tethereal, don't save to a temporary file if "-w" isn't specified,Guy Harris1-0/+2
even if doing a live capture; just print the packets without saving them. In dumpcap: default to the capturing the entire packet; don't do the "Press any key" stuff when debugging on UN*X; do console logging (to the standard error) even when we're running as the capture child (the sync pipe should only be the standard output, not the standard error). svn path=/trunk/; revision=17786
2006-03-30From Irene: Fix problems with off screen drawingsMichael Tüxen4-21/+133
Make rectangle clickable. svn path=/trunk/; revision=17778
2006-03-30fix for Bug 849Luis Ontanon1-2/+4
svn path=/trunk/; revision=17777
2006-03-30remove some useless code.Luis Ontanon1-9/+7
svn path=/trunk/; revision=17776
2006-03-30TextWindow:Luis Ontanon1-8/+64
- add buttons - make editable svn path=/trunk/; revision=17773
2006-03-28Make sure the export dialog is large enough. Fix a Unicode issue whileGerald Combs1-3/+3
we're at it. svn path=/trunk/; revision=17754
2006-03-20waste a couple of bytes per tcp conversation and make the tree for ↵Ronnie Sahlberg4-0/+4
acked_packets (i.e. packets that have interesting tcp properties such as being retransmissions etc) hang off the per conversation tcpd struct instead of being global. while this should improve performance by unmeasurably little it does have the sideeffect that once we finish the rewrite tcp analysis might actually work and work well even for tcp over tcp tunnelling. this also means that if you include packet-tcp.h you also need to include emem.h . svn path=/trunk/; revision=17681
2006-03-19Make the GUIDs in various data structures e_guid_t's rather than arraysGuy Harris3-14/+13
of 16 bytes. Use "sizeof" for the size of e_guid_t's, and use structure assignment to copy GUID values. Make functions such as append_h225ras_call() and new_h225ras_call() take pointers to e_guid_t's as arguments. Define GUID_LEN in epan/guid-utils.h and use it as the length of a GUID in a packet. (Note that "sizeof e_guid_t" is not guaranteed to be 16, although it is guaranteed to be the size of an e_guid_t.) When constructing a display filter that matches a GUID, use guid_to_str() to construct the string for the GUID. svn path=/trunk/; revision=17676
2006-03-19Get rid of extra arguments in g_strdup_printf() calls (the end of theGuy Harris1-193/+193
list of arguments is determined by the format string; there's no need for a NULL terminator). Fix indentation. svn path=/trunk/; revision=17674
2006-03-19Get rid of a declaration of a non-existent function.Guy Harris1-1/+0
svn path=/trunk/; revision=17673
2006-03-16Check struct pointer before dereferencing it. Jaap Keuter1-1/+1
Coverity CID 142 svn path=/trunk/; revision=17644
2006-03-15From Greg Morris:Anders Broman1-0/+1
Modification to (proto.h) is made to add an additional expert group type of PI_REQUEST_CODE to allow Request tag information to be passed to the expert tap. This is for such reasons where a dissector would like to echo specific information about certain types of requests. For example: NCP connection request is really a request not a REPLY_CODE. Same is true for the TCP SYN request. Changes to packet-ncp.c 1. Server broadcast message flag. Now indicates if the message is a pending message or an oplock clear notification. 2. Cleanup of packet signature detection process. Previous method had some flaws so I redesigned it. Appears to be solid now. 3. Echo NCP Server Session information to expert tap. Note on item #3: NCP Connection+Task = NCP Session, a Single connection can have many tasks. The server sees each connection/task as a unique session. For this reason the NCP session information is now echoed to the expert composite statistics so that you can easily identify the different NCP processes and sessions. It is important to NCP analysis to understand that each session is most likely a different program on the requesting host sharing the same NCP connection. Changes to packet-ncp2222.inc 1. Comment out the echo of NCP connection info to expert tap. Replaced by NCP sessions. 2. Add displayEID in request decode (resolves Coverity defect for dead code in NCP dissector) Changes to ncp2222.py 1. Fix for endian display of bindery object type in NCP 0x1720. 2. Fix for size of bindery object type to 2 bytes instead of 4 to match other bindery NCP's. svn path=/trunk/; revision=17636
2006-03-15Fix bug 710 and avoid having it crash when more than one instance are open ↵Luis Ontanon1-7/+35
at once. I think that whoever wrote the whole stats_tree thing should rewrite it ASAP, because it sucks! I did ?!?!?? ooops! svn path=/trunk/; revision=17627
2006-03-14From Laurent Rabret, Anders Broman2-27/+29
2 patches for the "flow graph" display. It is better not to insert invalid packets into the list than to control the list is correct while using it... svn path=/trunk/; revision=17622
2006-03-09Fix Coverity CID 129: initialize a couple of variables.Gerald Combs1-2/+2
svn path=/trunk/; revision=17560
2006-03-09Make sure we can't pass NULL to strcmp. Fixes Coverity CID 34. Fix up Gerald Combs1-8/+4
whitespace. svn path=/trunk/; revision=17555
2006-03-09There is a one-to-one mapping between each graph and its "toplevel" andGerald Combs1-85/+18
drawing_area widgets. Instead of canoodling around with a global list of graphs, simply associate a graph to its widgets using OBJECT_SET_DATA. This should take care of Coverity CIDs 50 - 59. Clean up whitespace. svn path=/trunk/; revision=17554
2006-03-09Remove MIN and MAX defines, which GLib provides.Gerald Combs2-45/+41
svn path=/trunk/; revision=17551
2006-03-09coverity #62Ronnie Sahlberg1-0/+2
potential null dereference svn path=/trunk/; revision=17549
2006-03-09From Laurant Rabret:Jaap Keuter2-13/+21
Please find enclosed 2 patches. - Voip_calls_dlg.c.patch fixes a problem that appears with a release compiled with GTK 2.8 + Visual Studio 2003. It seems g_snprintf can corrupt memory when a length bigger than the array size is provided in the second parameter (even if the generated string is smaller than the array actual size!!) - graph_analysis.c.patch fixes a memory corruption problem easy to reproduce. Just open the pcap file enclosed, select "Statistics"->"Flow Graph" and activate the "Network source/destination addresses" radio button before pressing OK. You'll see a crash dump. Thanks to check in Best Regards Laurent svn path=/trunk/; revision=17543
2006-03-08Use Unicode for all native Win32 calls. Unicode Windows applicationsGerald Combs4-131/+148
use UTF-16 internally and GTK+ 2.x uses UTF-8, which means we have to do a lots of conversions. Add utf_8to16() and utf_16to8 convenience functions to strutil.c. svn path=/trunk/; revision=17534
2006-03-08Make calculation of TCP Graph bounds more robust. The calculation might have ↵Lars Roland1-13/+17
failed in unusual conditions. This bug was discovered while looking at defects #130 and #131 discovered by coverity. This patch also fixes these non-severe defects. svn path=/trunk/; revision=17531
2006-03-08Fix left open file (coverity CID 108) and g_string leak. Clean up double ↵Jaap Keuter1-13/+14
width line drawing. svn path=/trunk/; revision=17515
2006-03-07Fix what Coverity CID 61 was actually complaining about: Don't pass a NULLGerald Combs1-5/+8
value to get_interface_descriptive_name(). svn path=/trunk/; revision=17513
2006-03-07Fix Coverity run 12 CID 61: In main_cf_cb_live_capture_update_started(),Gerald Combs1-0/+1
make sure capture_opts isn't NULL before we try to use it. svn path=/trunk/; revision=17504
2006-03-07Solving various uninitialized variable warnings.Jaap Keuter1-8/+14
coverity reports 132, 133 and 134 svn path=/trunk/; revision=17501
2006-03-07Use g_assert to save us from dereferencing a NULL pointer. g_warning is not ↵Lars Roland1-4/+4
strong enough. This should fix a defect discovered by coverity. svn path=/trunk/; revision=17493
2006-03-05wrong name.Luis Ontanon1-1/+1
svn path=/trunk/; revision=17464
2006-03-05+ retap_packets()Luis Ontanon1-5/+52
+ complete gtk TextWindow + fix elua_dumper + fix elua_proto svn path=/trunk/; revision=17462
2006-03-04From Florent Drouin:Anders Broman1-1/+1
Just a little correction. In the last patch for gtk/gsm_map_stat.c applied, the variable "j" was changed to "i" . svn path=/trunk/; revision=17459
2006-03-02From Greg Morris:Anders Broman5-7/+104
- Change to display NCP connection for each conversation - New NCP Endpoints. Please apply expert_comp_table - Use local variable space instead of pointer. The previous implementation utilized pointers and the values would change the table data. svn path=/trunk/; revision=17446
2006-03-02In order to reduce the height of the Preference dialog moving several items ↵Jaap Keuter2-137/+266
from the User Interface page to the Layout page. svn path=/trunk/; revision=17444
2006-03-01The sequence and ack numbers in a TCP are guint32's, which means theyGuy Harris1-35/+35
should be printed with "%u", not "%lu" (especially on LP64 platforms). Fix up indentation. svn path=/trunk/; revision=17432
2006-02-27From: Florent Drouin:Anders Broman1-7/+13
Add a test to avoid divide by zero during stat. display. Use new variable j, instead of i, already used in the loop. svn path=/trunk/; revision=17416
2006-02-25From Martin MathiesonAnders Broman1-0/+1
- add SIP response code 412 ("Conditional Request Failed") to stats taps. svn path=/trunk/; revision=17409
2006-02-24add the dumpcap manpage to the menuUlf Lamping3-0/+5
svn path=/trunk/; revision=17402
2006-02-24Fix bug 769. Print seq# and ack# as _unsigned_ int in the comment.Jaap Keuter1-1/+1
svn path=/trunk/; revision=17400
2006-02-23when including menu.h we also need to include stdio.h to get FILERonnie Sahlberg1-0/+1
svn path=/trunk/; revision=17391
2006-02-23Fix bug 741. Menu/Toolbar follow auto scroll checkbox in capture options.Jaap Keuter1-0/+2
svn path=/trunk/; revision=17389
2006-02-23From Alejandro Vaquero:Anders Broman2-24/+26
a patch for the VoipCalls to fix a couple of issues: - a problem with the RTP Events (RFC2833) not been handle correctly - Display the RTP stream in time order when the setup frame is after the RTP stream. - fix a init issue that caused the H245 packet to not been displayed correctly. svn path=/trunk/; revision=17383
2006-02-22From Irene Ruengler:Michael Tüxen1-19/+29
Fix bug regarding the lower left edge and the handling of points outside the displayed region. svn path=/trunk/; revision=17373
2006-02-22Remove svn:executable property from source filesJaap Keuter2-0/+0
svn path=/trunk/; revision=17370
2006-02-21I commented out this a while ago as they caused a crash in GTK2.8/cairo on ↵Luis Ontanon1-12/+0
my box. I checked it in by mistake with a lot of more files, even worst I did not pay attention to an e-mail on the list regarding the damage caused. Luckily Alejandro Vaquero contacted me directly. svn path=/trunk/; revision=17363
2006-02-19For the "there's already a file with that name" dialog, use a wordingGuy Harris1-2/+3
more like the one used by gedit. (Note that the file in question might not be a capture file, although it probably is.) svn path=/trunk/; revision=17355
2006-02-18squelch some compiler warningsUlf Lamping1-3/+3
svn path=/trunk/; revision=17343