aboutsummaryrefslogtreecommitdiffstats
path: root/gtk/dfilter_expr_dlg.c
AgeCommit message (Collapse)AuthorFilesLines
2009-12-18If we don't have PCRE and we do have GLib >= 2.14, use GRegexes for theGerald Combs1-3/+3
"matches" operator. svn path=/trunk/; revision=31302
2009-12-12Rename BASE_STRUCTURE_RESET to BASE_DISPLAY_E_MASK, to clarify that it'sGuy Harris1-1/+1
a mask to select the base_display_e value from a display field in a header_field_info structure. Never select that value by masking out the BASE_RANGE_STRING flag bit, as that won't continue to work if more flag bits, or other bitfields, are added. Instead, mask with BASE_DISPLAY_E_MASK. Note that the base_display_e value and BASE_RANGE_STRING flag are only for integral field types, and clarify what BASE_DISPLAY_E_MASK is. Give at least one of the reasons why hiding protocol fields is not considered a good idea. svn path=/trunk/; revision=31249
2009-11-10Removed some unused variables and unused assignments.Stig Bjørlykke1-7/+0
svn path=/trunk/; revision=30918
2009-10-01Return from dfilter_expr_dlg_accept_cb() if nothing selected.Stig Bjørlykke1-0/+3
svn path=/trunk/; revision=30235
2009-07-03From Kovarththanan Rajaratnam: Fixes for bug #3536Bill Meier1-20/+17
(plus some additional changes by me). Handle BASE_RANGE_STRING display types properly We always treat header field info strings as value_string's undiscriminated. However, if the header field info display is marked as BASE_RANGE_STRING, we need to treat them as range_string's. This wasn't properly handled in the filter expression dialog and in the filter toolbar which would cause a crash upon referencing any fields marked as BASE_RANGE_STRING. svn path=/trunk/; revision=28931
2009-06-01dfilter_expr_dlg: fix several very minor memory leaks;Bill Meier1-0/+3
svn path=/trunk/; revision=28565
2009-05-25Squelch an uninitialized variable complaint from older versions of GCCGuy Harris1-1/+1
(which presumably don't know that g_assert_not_reached() never returns). svn path=/trunk/; revision=28470
2009-05-18Use g_strdup_printf() instead of g_snprintf() with a fixed buffer.Stig Bjørlykke1-11/+9
svn path=/trunk/; revision=28402
2009-04-21Turn on -Wshorten-64-to-32 by default, and fix some issues that turnedGuy Harris1-5/+5
up (99 44/100% of which were assignments of double-precision floating-point constants to floats). Hopefully this will catch at least some P64 issues on UN*X. svn path=/trunk/; revision=28108
2009-04-15size_t fixes.Gerald Combs1-4/+4
svn path=/trunk/; revision=28059
2009-03-13From Jakub Zawadzki (bug 3331):Stig Bjørlykke1-6/+3
g_free() is NULL safe, so we don't need check against it. svn path=/trunk/; revision=27718
2009-03-09Handle BASE_NONE as BASE_DEC until we get a proper handling of integerStig Bjørlykke1-0/+1
values with BASE_NONE and a value string. svn path=/trunk/; revision=27669
2008-10-24Show both short and long protocol name in the Filter Expression dialog.Stig Bjørlykke1-4/+7
svn path=/trunk/; revision=26537
2008-06-29Fix some simple cases of GTK2 deprecated API usage by using a renamed or ↵Bill Meier1-5/+5
equivalent API gtk_container_border_width() ==> gtk_container_set_border_width() gtk_container_children() ==> gtk_container_get_children() gtk_entry_new_with_max_length() ==> gtk_entry_new(); gtk_entry_set_max_length() gtk_menu_append() ==> gtk_menu_shell_append() gtk_menu_prepend() ==> gtk_menu_shell_prepend() gtk_notebook_set_page() ==> gtk_notebook_set_current_page() gtk_paned_gutter_size() ==> gtk_paned_set_gutter_size() gtk_radio_button_group() ==> gtk_radio_button_get_group() gtk_signal_connect() ==> g_signal_connect() gtk_signal_disconnect() ==> g_signal_handler_disconnect() gtk_signal_emit_by_name() ==> g_signal_emit_by_name() gtk_signal_handler_block_by_data() ==> g_signal_handlers_block_matched() gtk_signal_handler_block_by_func() ==> g_signal_handlers_block_by_func() gtk_signal_handler_unblock_by_data() ==> g_signal-handlers_unblock_matched() gtk_signal_handler_unblock_by_func() ==> g_signal-handlers_unblock_by_func() gtk_spin_button_get_value_as_float() ==> gtk_spin_button_get_value() gtk_toggle_button_set_state() ==> gtk_toggle_button_set_active() svn path=/trunk/; revision=25634
2008-04-14From Jim Young (bug 2212):Sake Blok1-1/+1
Add the profile name to the title of all the configuration windows. (this is a rewrite of Jim's patch) svn path=/trunk/; revision=25016
2008-04-13sort #includes by directoriesUlf Lamping1-10/+12
svn path=/trunk/; revision=24968
2008-04-12where it's not necessary, remove #include "compat_macros.h"Ulf Lamping1-1/+0
svn path=/trunk/; revision=24922
2008-04-11second round to replace SIGNAL_CONNECT with g_signal_connectUlf Lamping1-11/+10
This requires some casts to be added and I just don't want to add casts at all possible places. So I compile and only add casts where the (MSVC) compiler has a hard time. Unfortunately this won't find any problems in Linux/Unix only code - I'll keep an eye on the buildbot and try to fix things as I'm going on ... svn path=/trunk/; revision=24913
2008-04-11replace SIGNAL_DISCONNECT_BY_FUNC with g_signal_handlers_disconnect_by_funcUlf Lamping1-1/+1
svn path=/trunk/; revision=24911
2008-04-11replace WIDGET_SET_SIZE with gtk_widget_set_size_requestUlf Lamping1-1/+1
svn path=/trunk/; revision=24910
2008-04-11replace RADIO_BUTTON_NEW_WITH_MNEMONIC with ↵Ulf Lamping1-9/+9
gtk_radio_button_new_with_mnemonic_from_widget svn path=/trunk/; revision=24908
2008-04-11OBECT_..._DATA --> g_object_..._dataBill Meier1-39/+39
svn path=/trunk/; revision=24893
2008-04-06remove GTK1 codeUlf Lamping1-289/+0
svn path=/trunk/; revision=24816
2008-04-03http://www.wireshark.org/lists/wireshark-dev/200803/msg00308.htmlLuis Ontanon1-0/+2
proto.[hc] define new APIs to allow delayed registration of protocol fields, so that dissectors with "flexible" fields like xml, radius, diameter, snmp do not have to load their files at startup but can do so as late as possible. gtk/dfilter_expr_dlg.c : have the expression dialog registering all prefixes so that all fileds appear in the dialog tshark.c register all prefixes when called with -G epan/radius_dict.l epan/dissectors/packet-radius.c epan/dissectors/packet-radius.h refactor registration to delay dictionary loading as long as possible svn path=/trunk/; revision=24762
2008-03-06Fix some typos; Fix some indenting to be at least locally consistentBill Meier1-38/+38
svn path=/trunk/; revision=24575
2008-02-29Next attempt to cleanup some string functions, including:Stig Bjørlykke1-2/+2
strncpy -> g_strlcpy, strncat -> g_strlcat svn path=/trunk/; revision=24504
2008-02-01Rewrote some prohibited APIs in gtk/ (sprintf, strcpy, strcat).Stig Bjørlykke1-2/+2
If we get some truncated strings we probably overwrote some buffers... svn path=/trunk/; revision=24239
2007-07-16Fix a couple "cast to pointer from integer of different size" warnings when ↵Jeff Morriss1-1/+1
building with GTK1.2 on Redhat AS4 64-bit svn path=/trunk/; revision=22329
2007-06-17Fix bug #1334 and a problem where a user couldn't interact with theStephen Fisher1-1/+3
filter dialog's add expression dialog when going to it through file->open or file->merge (because dialogs in between are set to modal). svn path=/trunk/; revision=22115
2006-12-22hmmRonnie Sahlberg1-0/+1
best to revert this for a while. revert all changes from previous patch. svn path=/trunk/; revision=20195
2006-12-22change some slab allocated memory into ep/emem allocated structures instead.Ronnie Sahlberg1-1/+0
this primarily removes code and simplifies (==eliminates) the need to track the data that is allocated and should potentially be slightly faster than a slab allocator. however these functions are called A LOT so there might be a performance hit when using emem with full debugging canary values and all the bells and whistles activated. this change also makes any future attempt to parallellize dissection of frames easier if we just make the ep allocator allocate from a threads specific ep pool. (something we would have to do anyway to make ep allocations multithreaded) this works in all my tests so far but needs more test coverage. svn path=/trunk/; revision=20194
2006-10-23Fix for bug 1178. Allow FT_?INT24 BASE_DEC VALs in the expression selection ↵Jaap Keuter1-1/+3
dialog. svn path=/trunk/; revision=19666
2006-05-22Get rid of a bunch of "Ethereal"s and "ethereal"s in comments, GUIGuy Harris1-1/+1
strings, and function names. svn path=/trunk/; revision=18205
2006-05-21name changeRonnie Sahlberg1-2/+2
svn path=/trunk/; revision=18197
2006-03-09Make sure we can't pass NULL to strcmp. Fixes Coverity CID 34. Fix up Gerald Combs1-8/+4
whitespace. svn path=/trunk/; revision=17555
2005-08-20renamed ui_util.c/.h to gui_utils.c/.h to prevent confusion with identical ↵Ulf Lamping1-1/+1
named ui_util.h in / dir svn path=/trunk/; revision=15465
2005-08-10removed tons of MSVC const related warnings.Ulf Lamping1-6/+6
This might at some places interfere with the changes for gcc4, we might have to negotiate in that case :-) Please note that a lot of these warnings were GTK1.x related only! svn path=/trunk/; revision=15286
2005-08-05More char -> const char warning fixes.Jörg Mayer1-4/+4
Removed (very few) casts that only change the warning message but don't remove it (with gcc-4). svn path=/trunk/; revision=15227
2005-07-24Constify to remove a bunch of warnings. Add some casts to squelchGuy Harris1-2/+2
(presumably-)harmless-but-otherwise-unremovable const-to-nonconst warnings. In the TACACS dissector, clean up the variables used in option parsing to avoid some const-to-nonconst warnings. Clean up some white space. svn path=/trunk/; revision=15043
2005-06-24Constify a bunch of structure members and function arguments, to squelchGuy Harris1-2/+2
compiler warnings. Clean up indentation. svn path=/trunk/; revision=14739
2004-12-29Make the tone of the error messages a bit less formal, by usingGuy Harris1-2/+2
contractions. (Safari does, at least when you're trying to open a file to which you don't have read access.) svn path=/trunk/; revision=12852
2004-08-08From Stas Grabois: make the previous change not to show disabledGuy Harris1-2/+7
protocols in the "Add Expression" and "Decode As" dialogs work with GTK+ 2.x. svn path=/trunk/; revision=11626
2004-07-19renamed filter_prefs to filter_dlg, as the filter settings are (well, for a ↵Ulf Lamping1-1/+1
long time) no longer part of the preferences dialog. svn path=/trunk/; revision=11436
2004-07-18Set the svn:eol-style property on all text files to "native", so thatGuy Harris1-1/+1
they have LF at the end of the line on UN*X and CR/LF on Windows; hopefully this means that if a CR/LF version is checked in on Windows, the CRs will be stripped so that they show up only when checked out on Windows, not on UN*X. svn path=/trunk/; revision=11400
2004-06-10Move "dfilter_expr_dlg_delete_event_cb()" afterGuy Harris1-10/+10
"dfilter_expr_dlg_cancel_cb()" to avoid use-before-declaration warnings. svn path=/trunk/; revision=11136
2004-06-10"delete_event" is an event, so its handler takes three arguments, notGuy Harris1-2/+12
two, and it returns a gboolean. svn path=/trunk/; revision=11133
2004-06-10From Stas Grabois: don't show disabled protocols in the "Add Expression"Guy Harris1-1/+11
and "Decode As" dialogs (so that you can cut down the size of the protocol lists in those dialogs by disabling "uninteresting" protocols). svn path=/trunk/; revision=11132
2004-05-27use gtk_window_set_default_size() instead of WIDGET_SET_SIZE() for the dialogs,Ulf Lamping1-3/+4
as WIDGET_SET_SIZE() will prevent the user from shrinking the dialog, and gtk_window_set_default_size() will not svn path=/trunk/; revision=11021
2004-05-26more code cleanup from dialog things:Ulf Lamping1-25/+23
changed window_xy (dialog) function calling in a lot of gtk files cleanup of file selection code cleanup in dlg_utils/file_dlg/ui_util Please report any problems!!! svn path=/trunk/; revision=11003
2004-03-13replaced snprintf by g_snprintf and removed #include "snprintf.h"Ulf Lamping1-15/+11
svn path=/trunk/; revision=10370