aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2016-09-18[Automatic update for 2016-09-18]Gerald Combs2-27/+357
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I1fb3ac4b7bd4f44dfcf7b40b28b0b2aa89ca4d3e Reviewed-on: https://code.wireshark.org/review/17778 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-09-18ISAKMP: Reduce code duplicationMirko Parthey1-248/+221
Equalize attribute dissecting functions: * Convert all attribute type names to range_string. Add "Unassigned" and "Private use" ranges while we are at it. * Swap the order of format and type fields for config attributes. Move common code into the new function dissect_attribute_header(). Try to keep the parameter list short: * Group the hfindex values for attribute details into a struct. * Merge attribute subtree types. Add a colon in the main attribute item label for visual separation. Skip dissection of config attributes for unknown IKE versions. Change-Id: I6e6286f3d4cf16f3cd16a23aca540c4af72f3442 Reviewed-on: https://code.wireshark.org/review/17663 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-09-18update bacapp vendor id to name mapping from BACnetBACdaBASpert1-7/+154
Change-Id: Ibd09e3d8ec167a9270545e37365a2370ac6c2c28 Reviewed-on: https://code.wireshark.org/review/17753 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-09-17The full identity string was added above.Guy Harris1-1/+0
Change-Id: I0945cb9cb6a9d5ccf3756b887654d73a28035a49 Reviewed-on: https://code.wireshark.org/review/17768 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-09-17Update a comment.Guy Harris1-6/+3
In one of the two cases where we treat the first byte of an identity as a prefix, we know it's EAP-AKA. (In the other, we do *not* know that!) Change-Id: I16625f7193eb3ab0840739ec37dbd64e2a5a0fb5 Reviewed-on: https://code.wireshark.org/review/17767 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-09-17Fix handling of EAP identity.Guy Harris1-20/+47
There's no guarantee that the identity is a string whose first character is a prefix indicating the type of identity; only display it as a prefix if it's one of the known types. We really may need some other mechanism to determine how to parse the identity, perhaps based on what the protocol layers below it are. Put back the display of the full string in one case where that was inadvertently removed. Change-Id: I2e3324f964fa25ebd7065ddb0de82ffae6597509 Reviewed-on: https://code.wireshark.org/review/17764 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-09-17eap: make eap_identity_prefix a numeric itemMartin Kaiser1-11/+10
This used to be string item, its value was not 0-terminated. This resulted in out-of-bounds mem acceess when eap_identity_prefix was used by proto_tree_add_string_format(). ==14744== Conditional jump or move depends on uninitialised value(s) ==14744== at 0x4C294F8: strlen (mc_replace_strmem.c:390) ==14744== by 0xC19C97F: g_strdup (gstrfuncs.c:355) ==14744== by 0x739CA75: string_fvalue_set_string (ftype-string.c:51) ==14744== by 0x67136A9: proto_tree_add_string (proto.c:3515) ==14744== by 0x6713870: proto_tree_add_string_format (proto.c:3547) ==14744== by 0x69BB494: dissect_eap (packet-eap.c:838) ==14744== by 0x66FD0B4: call_dissector_work (packet.c:649) As the content is a number anyway, the simplest solution is to make eap_identity_prefix a numeric item and use proto_tree_add_uint_format_value(). Bug: 12913 Change-Id: I907b1d3555a96e9662b1d8253d17d35adfdada48 Reviewed-on: https://code.wireshark.org/review/17760 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-09-17eap: (trivial) reformat a commentMartin Kaiser1-2/+2
Change-Id: I2c8a8066f1591004ace6362e24be57b6cec747d1 Reviewed-on: https://code.wireshark.org/review/17762 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-09-17eap: remove unnecessary if (tree) checksMartin Kaiser1-55/+33
Change-Id: If42a5d610eea7c7818a0d37dd5878c84ba7f7d81 Reviewed-on: https://code.wireshark.org/review/17761 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-09-17ISUP: do not display Called Party Number twicePascal Quantin1-3/+0
Bug: 12911 Change-Id: I3632ffbeb85a96d9268eca6ddc0f8b38587688c4 Reviewed-on: https://code.wireshark.org/review/17758 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-09-17p_XXX_proto_data: only allow the use of pinfo and file scopesPascal Quantin7-95/+104
Those are the only ones meaningful. Let's convert the buggy dissectors and add an assert to avoid the misuse of the pool parameter in the future Change-Id: I65f470b757f163f11a25cd352ffe168d1f8a86d3 Reviewed-on: https://code.wireshark.org/review/17748 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-09-16TLS(1.3): Add Share Key (40) Hello extensionAlexis La Goutte2-2/+93
Bug: 12779 Change-Id: I5cbc911f2c7818558c5182d2e3ccf9235be9281b Reviewed-on: https://code.wireshark.org/review/17301 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-09-16TLS: Pass directly the handshake_type to dissect_hnd_hello_extAlexis La Goutte1-19/+34
with TLS 1.3, there is a new 'Hello' type (Hello Retry Request) Change-Id: If7a11b70a5b0a69044126c50e1d6ab4e1d443f77 Reviewed-on: https://code.wireshark.org/review/17573 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-09-16TLS(1.3): Add new Hello extension listAlexis La Goutte2-0/+8
* Key share (40) * Pre-Shared Key (41) * Early Data (42) * Cookie (44) Bug: 12779 Change-Id: I16e3cf691ae66e244608db233db180e24538a68d Reviewed-on: https://code.wireshark.org/review/17239 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-09-16TLS(1.3): Add (experimental) extension 'Draft version TLS 1.3'Alexis La Goutte2-1/+16
Coming from https://github.com/tlswg/tls13-spec/wiki/Implementations#version-negotiation Bug: 12779 Change-Id: Ieca74eac737b5ba6c101b719e2e5e3aecf931279 Reviewed-on: https://code.wireshark.org/review/17226 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-09-16TLS(1.3): Fix Server HelloAlexis La Goutte2-38/+54
There is no session_id and compression method with TLS 1.3 Server Hello Also no time on first bytes of random field Bug: 12779 Change-Id: Id79221c2ad50695cf6d46cd5c9255deab99e2d2c Reviewed-on: https://code.wireshark.org/review/17225 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-09-16TLS(1.3): Add TLS 1.3 value for version HandshakeAlexis La Goutte2-0/+4
Bug: 12779 Change-Id: I298ecf4a0537df2e88354aed6912d4298a094216 Reviewed-on: https://code.wireshark.org/review/17224 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-09-16M3AP: remove Procedure Code from info columnPascal Quantin3-40/+34
Change-Id: I69aebed5000f6544eede69e7435fb49e4e0ce179 Reviewed-on: https://code.wireshark.org/review/17744 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-09-16M2AP: remove Procedure Code from info columnPascal Quantin3-47/+41
Change-Id: I965cc0455f5f3ac8a676cc0e3453e8a449d76109 Reviewed-on: https://code.wireshark.org/review/17743 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-09-16eap: add identity details.Dario Lombardo1-3/+55
Change-Id: I60e017ac48d9daf52b8a40809625dc1ae09c9d8e Reviewed-on: https://code.wireshark.org/review/17735 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-09-16Have TPKT support a TCP port range preference instead of having ↵Michael Mann15-461/+202
"subdissectors?" register their own. There are a number of dissectors who are subdissectors of TPKT (and OSITP) that are not called by TCP dissector directly, yet can possibly register a TCP port "on the behalf" of TPKT. Just allow TPKT to support a range of ports to possibly include these protocols. Remove the preferences from these dissectors, but add backwards compatibility for the preferences by hooking into set_prefs and have the preferences just hook into Decode As functionality directly. Change-Id: Ic1b4959d39607f2b6b20fa6508da8d87d04cf098 Reviewed-on: https://code.wireshark.org/review/17476 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-09-16VTP: Always display reserved/unsed fieldsAlexis La Goutte1-2/+9
Change-Id: Ib0b065c20e599567224c05068dad5bd24a711609 Reviewed-on: https://code.wireshark.org/review/17728 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-09-16ZigBee: Fix reassembly of APS fragments.Kenneth Soerensen1-1/+2
The unsigned variable num_blocks was initialized to -1. Which caused the dissector to set the total length to 4294967295 fragments when the second fragment was processed. This made the dissector unable to reassemble data made of more than two fragments. Change-Id: I120af090ed29ac73a1fa699bea2bfc91798ef92b Reviewed-on: https://code.wireshark.org/review/17712 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-09-16ssl-utils: fix -Wshorten-64-to-32 and other warningsPeter Wu1-2/+1
Fixes -Wshorten-64-to-32 from v2.3.0rc0-697-gb1d36fe ("ssl-utils: remove block and key sizes from cipher suites table"), -Wpointer-sign, -Wunreachable-code-break. Change-Id: I37ca5e9effe5d6560d49ccef53e9feb096cd2ad6 Reviewed-on: https://code.wireshark.org/review/17727 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-09-16Squelch some compiler warnings.Guy Harris1-3/+3
gcry_cipher_get_algo_keylen() returns a size_t, which is bigger than a guint on most if not all 64-bit platforms; however, if the key is bigger than 2^32 bytes, we have bigger problems, so just cast it down. Change-Id: Ia7c97d2742686daf2e42f634c6e349cb580fa9df Reviewed-on: https://code.wireshark.org/review/17731 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-09-16ssl-utils: fix runtime memory leakPeter Wu1-5/+21
Ensure that Libgcrypt and zlib memory are freed when closing a pcap. Change-Id: I420f9950911d95d59ff046fee57900ca6f7e9621 Reviewed-on: https://code.wireshark.org/review/17718 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-09-16ssl-utils: remove block and key sizes from cipher suites tablePeter Wu3-331/+390
There was an implicit dependency between the block size in the cipher suites table and the size expected by Libgcrypt. Just remove the block size from the table and rely on the value from Libgcrypt to avoid the risk of mismatching values (which could lead to a buffer overflow). While at it, remove the size of the key ("bits") and the size of key material ("eff_bits") too. Move the key material sizes for export ciphers away from the table and use byte quantities instead of bits. Additionally, this fixes an issue where 8 bytes of uninitialized stack memory is written to the SSL debug log for stream ciphers like RC4. The size of the Write Key is also corrected for export ciphers, now it prints the actual (restricted) number of bytes that are used. Change-Id: I71d3c83ece0f02b2e11e45455dc08c41740836be Reviewed-on: https://code.wireshark.org/review/17714 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-09-16ssl-utils: fix buffer overrun (read) with AEAD cipher suitesPeter Wu1-3/+6
ssl_cipher_init should only set the IV for CBC cipher suites. NULL cipher suites will not invoke gcry_cipher_setiv and AEAD ciphers will set the nonce in a different place anyway. Fixes a buffer overrun (read) by 12 bytes for any AES-CCM and AES-GCM cipher suite because the "block size" is set to 4 bytes while the reported block size for AES is 16 bytes (128 bit). (The four bytes are the "salt" part of the nonce that is extracted from the "client/server write IV" part of the key block.) Observed with the DTLS packet capture from https://ask.wireshark.org/questions/55487/decrypt-application-data-pending-dtls-abbreviated-handshake-using-psk Change-Id: I4cc7216f2d77cbd1eac9a40dca3fdfde7e7b3680 Reviewed-on: https://code.wireshark.org/review/17713 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-09-15[SIP] Make it possible to call a subdisector for the VIA branch parameter.AndersBroman1-2/+12
Change-Id: I7d91780f130105f04648489d6ed0bf2a320edce9 Reviewed-on: https://code.wireshark.org/review/17711 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-09-15S1AP: add dissection of NB-IoT transparent containersPascal Quantin6-972/+1771
To do so, memorize whether a given eNB UE S1AP ID belongs to a NB-IoT TAI or not. Also add a preference allowing to force dissection as legacy LTE or NB-IoT if automatic mode fails. While we are at it, let's remove the global variables and introduce a S1AP private data info stored in pinfo. Change-Id: I7e30b3d59d909684e5cfe13510293ed38ad52574 Reviewed-on: https://code.wireshark.org/review/17709 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-09-15eap: fix EAPOL conversation tracking, fixes TLS decryptionPeter Wu2-15/+51
Use new heuristics based on the EAP Code field to determine whether a field originates from the client or server. This is more reliable than using "pinfo->match_uint" for two reasons: (1) the heuristics dissector does not set "match_uint" (resulting in an arbitrary match on the previous value) and (2) with EAP over EAPOL, there is no matching port number (resulting in two conversations with different addresses and port number zero). To fix TLS decryption, make sure to create a single conversation for both direction and allow the port type to be PT_NONE (to avoid reporting all packets as originating from the server). Bug: 12879 Change-Id: I7b4267a27ffcf68bf9d3f6a90d6e6e2093733f51 Reviewed-on: https://code.wireshark.org/review/17703 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-09-13X2AP: remove Procedure Code from info columnPascal Quantin3-196/+191
Change-Id: I8d4632ef3b338063e96f4a417f0e3280489968a4 Reviewed-on: https://code.wireshark.org/review/17692 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-09-13S1AP: remove Procedure Code from info columnPascal Quantin3-335/+330
Change-Id: I53ece74627adc038ee6ff2af2959f2dae76ab879 Reviewed-on: https://code.wireshark.org/review/17691 Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-09-13NAS EPS: add an option to dissect User Data Container as IP packetPascal Quantin1-3/+42
Change-Id: I7d1196b79c22df5abe7d399bd9bea5c3d60bff7f Reviewed-on: https://code.wireshark.org/review/17690 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-09-13nfs: Primary Data's NFSv4 DataSphere filehandle decoderTom Haynes1-1/+52
Change-Id: I0d339f69f37fd3b6a2f7b37b1c239edb2a4cf7a5 Signed-off-by: Tom Haynes <loghyr@primarydata.com> Reviewed-on: https://code.wireshark.org/review/17676 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-09-13addr_resolv: use ws_strtou8 function.Dario Lombardo1-6/+7
This change prevents to accept netmasks as /24x. The mask must be an clean integer. Change-Id: I46aeb089dd6538b5cc4bde7efd4dc317621a5245 Reviewed-on: https://code.wireshark.org/review/17612 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-09-13Fix indentation.Guy Harris1-1/+1
Change-Id: I2b2d1cd584eb1ec56ec5cdcd33fb789843c8192c Reviewed-on: https://code.wireshark.org/review/17680 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-09-13Bluetooth: HCI vendor: Add support for some Intel commands/eventsMichal Labedzki1-426/+1783
This change based on BlueZ code on the same license that Wireshark is. It seems that a lot of commands/events are incomplete or unknown, however better to have them. Also rename variables (etc.) of the first dissector to contain vendor name like new one, to distinguish them. Change-Id: I2db3ed73d477699032a44bac2d3c88a9230b0095 Reviewed-on: https://code.wireshark.org/review/17657 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-09-12telnet: get rid of atoi().Dario Lombardo1-4/+1
Change-Id: Id445aef1af21fcf176611122a757482c0b22f4bd Reviewed-on: https://code.wireshark.org/review/17662 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-09-12dmp: Code cleanupStig Bjørlykke1-52/+84
Change-Id: I06c80ca44e8f727c9dc8ec552117ff60e44a7ef4 Reviewed-on: https://code.wireshark.org/review/17659 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-09-12dmp: Remove obsolete structured id handlingStig Bjørlykke1-128/+5
The structured id handling is not in use by anyone. Change-Id: I643fb03f642a5c1900aaec7d41e2b66dba5a2b05 Reviewed-on: https://code.wireshark.org/review/17655 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-09-12[SELFM] Fix reassembly, tcp_dissect_pdus() can't be used as the realAndersBroman1-56/+85
length of the PDU is not known(length is exluding escape bytes). Change-Id: I762419f12ca80f6597163e232c4b853819927b65 Reviewed-on: https://code.wireshark.org/review/17302 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-09-12S1AP: add missing messages in info columnPascal Quantin2-141/+253
While we are at it, let's reorder them in the .cnf file to match their definition in S1AP-PDU-Contents.asn and ease review Change-Id: I4c433fa862d83053d8b01cc951e756379356fa57 Reviewed-on: https://code.wireshark.org/review/17649 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-09-12Fix memleaks in capture file dialogPeter Wu1-0/+2
Tried to poke various fields (including the capture filter field), this revealed some memleaks. Change-Id: I1eca431a09839906a4b3c902ad85e55bffc71ca8 Reviewed-on: https://code.wireshark.org/review/17648 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-09-12epl: fix memleaksPeter Wu1-7/+5
Fixes a memleak that occurs on (re)loading a pcap. While at it, remove some unnecessary variables. Change-Id: Ibb662e5c608881bc7dfde9d12cdb77f699ff6542 Reviewed-on: https://code.wireshark.org/review/17639 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-09-11X2AP: add dissection of X2AP-Message information elementPascal Quantin3-57/+80
Change-Id: I2993e1a9ebad1660573bce8a61b44962af08bbb3 Reviewed-on: https://code.wireshark.org/review/17652 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-09-11mqtt: Only suback has failure in QoS valuesStig Bjørlykke1-1/+1
Change-Id: Ib308090dfc0911a9bb7580e601cab0bfbfe58efe Reviewed-on: https://code.wireshark.org/review/17644 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-09-11mqtt: Fix subscribe/suback QoS valuesStig Bjørlykke1-8/+6
Change-Id: I15424b768e6e0fe2e8268db69b82d81351146155 Reviewed-on: https://code.wireshark.org/review/17643 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-09-11MySQL: verify connection state before dissecting as greeting/login.Matt Lawrence1-2/+2
Change-Id: I419fad047c91ff1d8544eb3458534c132ec23821 Bug: 12791 Reviewed-on: https://code.wireshark.org/review/17368 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-09-11mqtt: Added elements from version 3.1.1Stig Bjørlykke1-79/+144
Added version 3.1.1 CONNACK session present flag and SUBACK failure indication. Adjusted SUBSCRIBE and SUBACK QoS values. Added string length values. Removed the message type subtree as it had no purpose. Put the message type in the top tree mqtt node instead. Removed unused code and fixed code layout. Change-Id: I8a9ae26ac9a2af04dc6f8d08ac46aa305c225c4f Reviewed-on: https://code.wireshark.org/review/17590 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>