aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2013-06-04From Anthony Coddington:Anders Broman1-0/+6
show_fragment_seq_tree does not add reassembled data tree item https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8766 svn path=/trunk/; revision=49751
2013-06-04From Anthony Coddington:Anders Broman4-43/+134
SDH dissector calculation fixes. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8767 svn path=/trunk/; revision=49750
2013-06-04Fix the fuzz failure reported (by me) in ↵Jeff Morriss1-7/+14
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8764 : Apply the fix from bug 8539 (r48796) to another function (dissect_r3_upstreamcommand_queryconfig()): Bail out of the item length we get (which we use to increment the offset) is 0. Otherwise the offset does not advance and we loop forever. While we're in there: get the item length just once (there's no need to call tvb_get_guint8() a half dozen times when one will do). svn path=/trunk/; revision=49744
2013-06-04From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8762 :Jeff Morriss1-9/+5
Remove dead code (condition can never happen). svn path=/trunk/; revision=49743
2013-06-03From William Sims via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8755Evan Huus1-2/+16
The entity offset variable parameter uses either offset or orientation but not both, this caused the data displayed to be skewed. svn path=/trunk/; revision=49736
2013-06-03From Marko Hrastovec via ↵Evan Huus1-2/+196
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8737 Add dissection of Category 009 to the ASTERIX dissector. svn path=/trunk/; revision=49734
2013-06-03From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8707 :Jeff Morriss1-10/+12
As suggested by Jakub, don't use strlen() when g_string->len will do. From me: Don't assume that just because we "got_val" that the value has a length. Checking it first eliminates this warning from Valgrind: ==11954== Invalid read of size 1 ==11954== at 0x61D1466: read_prefs_file (prefs.c:3012) ==11954== by 0x61D1841: read_prefs (prefs.c:2955) ==11954== by 0x409901: main (tshark.c:1137) ==11954== Address 0xc05244f is 1 bytes before a block of size 16 alloc'd ==11954== at 0x4A08A6E: realloc (vg_replace_malloc.c:662) ==11954== by 0x3CF8C4D736: g_realloc (in /usr/lib64/libglib-2.0.so.0.3400.2) ==11954== by 0x3CF8C66226: ??? (in /usr/lib64/libglib-2.0.so.0.3400.2) ==11954== by 0x3CF8C66ACE: g_string_insert_c (in /usr/lib64/libglib-2.0.so.0.3400.2) ==11954== by 0x61D1566: read_prefs_file (gstring.h:139) ==11954== by 0x61D1841: read_prefs (prefs.c:2955) ==11954== by 0x409901: main (tshark.c:1137) svn path=/trunk/; revision=49731
2013-06-03From chen liMartin Kaiser1-0/+4
handle list ending delimiter in bt-dth peer list https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8759 svn path=/trunk/; revision=49729
2013-06-03rename expert module to expert_iso7816Martin Kaiser1-4/+4
remove unnecessary comma svn path=/trunk/; revision=49728
2013-06-03Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8739 :Pascal Quantin1-1/+1
Move offset to end of line without assuming that we always have \r\n at the end of it svn path=/trunk/; revision=49722
2013-06-03Enhance CERT DNS TypeAlexis La Goutte1-26/+30
svn path=/trunk/; revision=49720
2013-06-03Enhance KX DNS TypeAlexis La Goutte1-7/+17
(and fix a minor bug.. KX Preference is always = 0...) svn path=/trunk/; revision=49719
2013-06-03Enhance NXT DNS TypeAlexis La Goutte1-23/+10
svn path=/trunk/; revision=49718
2013-06-03Enhance NSEC DNS TypeAlexis La Goutte1-3/+8
svn path=/trunk/; revision=49717
2013-06-03Enhance LOC DNS TypeAlexis La Goutte1-15/+63
svn path=/trunk/; revision=49716
2013-06-03Enhance DNAME DNS TypeAlexis La Goutte1-3/+9
svn path=/trunk/; revision=49715
2013-06-03Enhance A6 DNS TypeAlexis La Goutte1-8/+22
svn path=/trunk/; revision=49714
2013-06-03Enhance AAAA DNS TypeAlexis La Goutte1-2/+9
svn path=/trunk/; revision=49713
2013-06-03Enhance IPSECKEY DNS TypeAlexis La Goutte1-27/+70
svn path=/trunk/; revision=49712
2013-06-03Enhance KEY TypeAlexis La Goutte1-47/+71
svn path=/trunk/; revision=49711
2013-06-03cc1: warnings being treated as errorsAnders Broman1-3/+3
../../asn1/nbap/packet-nbap-template.c: In function 'add_hsdsch_bind': ../../asn1/nbap/packet-nbap-template.c:349: warning: unused parameter 'tree' svn path=/trunk/; revision=49708
2013-06-03Convert ASN.1 dissectors to use filterable expert info.Michael Mann20-235/+520
NOTE: Kerberos ASN.1 template was updated, but not generated to source. svn path=/trunk/; revision=49707
2013-06-03Put a space between "because" and the next word.Guy Harris1-2/+2
svn path=/trunk/; revision=49706
2013-06-02Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8756 :Pascal Quantin1-5/+7
Compute the number of septets needed for an alphanumeric address svn path=/trunk/; revision=49698
2013-06-02Remove unused cc_type parameterPascal Quantin1-3/+3
svn path=/trunk/; revision=49696
2013-06-02Get out of global variable hell and other optimizations.Michael Mann1-388/+263
I'm stil not sure the copying of the packet_info structure is necessary (or what the consequences are), but at least it's not global anymore. col_set_fence may be needed to prevent overwriting by PPP dissector, Caching COL_INFO (or the other columns) into it's own string was way more work than necessary and could lead to no column info on a malformed packet. svn path=/trunk/; revision=49689
2013-06-01Fix an infinite loop in the GSM CBCH dissector.Evan Huus1-3/+13
The looping logic is a bit odd, and there was a case where we were never incrementing any of the multiple loop variables. I suspect the entire function could be simplified, but this commit fixes the hang and is better suited to backporting than anything complex. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8730 svn path=/trunk/; revision=49686
2013-06-01Also notify CMAS alertsPascal Quantin1-0/+4
svn path=/trunk/; revision=49685
2013-06-01Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8745 :Pascal Quantin1-17/+51
Upgrade AP-title ASN.1 description svn path=/trunk/; revision=49684
2013-06-01Make Earthquake and Tsunami Warning Sytem indications stand out aMartin Mathieson1-0/+3
bit more. svn path=/trunk/; revision=49683
2013-06-01Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8744 :Pascal Quantin1-13/+13
Display C12.22 Invocation Id as unsigned integer svn path=/trunk/; revision=49682
2013-06-01More constification.Guy Harris1-2/+2
svn path=/trunk/; revision=49681
2013-06-01More constification.Guy Harris1-5/+5
svn path=/trunk/; revision=49680
2013-06-01More constification.Guy Harris1-4/+4
svn path=/trunk/; revision=49678
2013-06-01Check on fh_tree is already done within add_ethernet_trailer()Sake Blok1-5/+3
svn path=/trunk/; revision=49676
2013-06-01Add ethernet protocol preference to manually set the trailer length.Sake Blok1-8/+41
(some TAPs can slice packets and then add a custom trailer) svn path=/trunk/; revision=49675
2013-06-01More constification.Guy Harris1-5/+5
svn path=/trunk/; revision=49674
2013-06-01When allocating the frame table for a NetMon file, use g_try_malloc(),Guy Harris1-0/+43
and fail with ENOMEM if that fails (and the frame table is not empty - g_try_malloc() will return NULL if you ask it to allocate zero bytes). Have an error message for ENOMEM on an open that attempts to tell the user what the problem is without making their head explode. svn path=/trunk/; revision=49673
2013-06-01Note which *particular* IDL this is. (Actually, is that the OSF's DCEGuy Harris1-5/+5
RPC IDL, Microsoft's DCE RPC IDL, or Samba's DCE RPC IDL?) Constify some stuff to squelch warnings. svn path=/trunk/; revision=49672
2013-06-01Fix buildbot:Jörg Mayer1-12/+12
cc1: warnings being treated as errors packet-wccp.c: In function 'wccp_fmt_ipadddress': packet-wccp.c:555: warning: declaration of 'index' shadows a global declaration /usr/include/string.h:125: warning: shadowed declaration is here packet-wccp.c: In function 'dissect_wccp2_alternate_mask_value_set_element': packet-wccp.c:2570: warning: declaration of 'index' shadows a global declaration /usr/include/string.h:125: warning: shadowed declaration is here make[5]: *** [libdissectors_la-packet-wccp.lo] Error 1 make[5]: *** Waiting for unfinished jobs.... svn path=/trunk/; revision=49667
2013-05-31Peter Van Eynde <pevaneyn@cisco.com>Jörg Mayer1-1320/+3090
via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8635 This is an enhanced WCCP decoder handling the new draft 2.01 standard from http://tools.ietf.org/html/draft-mclaggan-wccp-v2rev1 svn path=/trunk/; revision=49666
2013-05-31Try to port glbp dissector to new expert info infrastructure.Jörg Mayer1-4/+36
Compile tested only. svn path=/trunk/; revision=49665
2013-05-31nameres.hosts_file_handling shouldn't affect loading the profile "hosts"Gerald Combs1-7/+5
file. That should be loaded no matter what if we have name resolution enabled. Add a name resolution test suite. Currently disabled until I can test it on Windows. svn path=/trunk/; revision=49657
2013-05-31Add UDT dissector. Bug 8741 ↵Michael Mann3-0/+460
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8741) From Chas Williams svn path=/trunk/; revision=49654
2013-05-31Report the operation number in all places where we note that we don'tGuy Harris1-8/+16
know about a given operation number. svn path=/trunk/; revision=49653
2013-05-31Fix the integer overflow case Jakub caught inEvan Huus1-5/+15
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3290#c26 Also use indentation consistent with the rest of the file. svn path=/trunk/; revision=49652
2013-05-31Check USB CCID length to see if subdissectors should be called instead of ↵Michael Mann1-107/+80
doing it blindly (which could lead to malformed packets). Bug 8735 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8735) Also minor cleanup of column info. svn path=/trunk/; revision=49651
2013-05-31Don't intentionally use -1 as an hfindex: while only naughty before, with theJeff Morriss1-3/+5
changes from r49644 you'll get complaints about the hf being unregistered... Note that this code also intentionally passes -1 as an ett_index. It doesn't currently complain so I'm leaving it alone for now... svn path=/trunk/; revision=49648
2013-05-31Get rid of most of the if(tree) checks: the proto_tree_add_*() functionsJeff Morriss1-72/+49
don't need them any more and, as shown in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3290#c16 we really want to check if we're looking at something beyond the end of the TVB (in order to break out of very long loops). svn path=/trunk/; revision=49645
2013-05-31(Finally!) check in part of Didier's patch to fixJeff Morriss1-3/+28
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3290 (TRY_TO_FAKE_THIS_ITEM disables bounds errors): Before calling TRY_TO_FAKE_THIS_ITEM() check if the length given (or, in the case of FT_UINT_{STRING,BYTES}, the length we retrieve from the TVB) exceeds what's left in the TVB. Do this only for proto_tree_add_item() for now (it's the most commonly used and thus the biggest trouble maker in this area). Similar changes for other APIs will come later (if nothing blows up). Despite the fuzz failures this bug has caused I'm not sure about back-porting it... svn path=/trunk/; revision=49644
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-10 13:03:19 +0000