Age | Commit message (Collapse) | Author | Files | Lines |
|
Use "tvb_format_stringzpad()" rather than "tvb_format_text()" on
strings, as some of them are null-padded. (XXX - are they null-padded
or null-terminated?)
Clean up the TLV length checks, and do many more such checks.
svn path=/trunk/; revision=15809
|
|
our own.
Get rid of MAC_to_str() - ether_to_str() suffices.
Don't copy to on-the-stack fixed-size string buffers, just save the
results of various formatting calls as pointers.
Use tvb_format_text() to get displayable versions of text strings.
Use tvb_get_ipv4() and tvb_get_ipv6().
Don't put an item into the protocol tree as text and then put in a
hidden item that, if unhidden, would display the same or almost exactly
the same; just put the item into the tree unhidden.
svn path=/trunk/; revision=15808
|
|
and the stuff you have to do is compiler-dependent, so use
G_GINT64_CONSTANT()).
Properly handle formatting 64-bit quantities (they don't format
correctly by magic, and the stuff you have to do is compiler-dependent,
so use PRI[duoxX]64).
Don't copy the result of tvb_bytes_to_str() to a string buffer and then
only use it as an argument to a "%s" - just use the result directly.
Don't copy constant strings to a buffer - just use the strings directly.
Fetch 64-bit integral quantities with tvb_get_ntoh64(); they're
presumably in a standard byte order, which is probably big-endian for
Internet-family protocols, and using tvb_memcpy() is *guaranteed* to be
wrong on some platforms.
Fix up a format string.
Fix up indentation a bit.
svn path=/trunk/; revision=15807
|
|
svn path=/trunk/; revision=15806
|
|
svn path=/trunk/; revision=15803
|
|
I added a description for the call to DISSECTOR_ASSERT in proto.c to be
printed to stderr.
svn path=/trunk/; revision=15802
|
|
svn path=/trunk/; revision=15801
|
|
Our company (Mitel) has developed an LLDP-MED plug-in for Ethereal.
svn path=/trunk/; revision=15800
|
|
Support some new messages and fix a couple of bugs.
packet-fc.h - Added a #define for a Cisco MDS-specific frame called OHMS (online health mgmt srv) packet-fc.c - Support for OHMS frame, fixed an incorrect "malformed frame" error caused on ACK1 frames (they
don't contain anything but (encap hdr + FC hdr + encap trailer), fixed incorrect detection of
last-data-frame
packet-fcct.h - Support for new service type, "Fabric Controller", used in conjunction with FC-SW3 ESS message,
exported the service name value string definitions and
packet-fcct.c - Support for recognizing "Fabric Controller" service type and "vendor-specific" service
packet-fcswils.h - Support for ESS & MRRA messages, defined as part of FC-SW3 packet-fcswils.c - Support for ESS & MRRA messages, defined as part of FC-SW3
packet-scsi.c - Support for Verify and Write&Verify SBC commands.
svn path=/trunk/; revision=15799
|
|
svn path=/trunk/; revision=15798
|
|
svn path=/trunk/; revision=15797
|
|
it is detected the pdu is "short"
svn path=/trunk/; revision=15796
|
|
subset tvb of what we have and use that instead of bailing out completely.
svn path=/trunk/; revision=15795
|
|
the kerberos dissector and do not strip the ber tag and lengths off
svn path=/trunk/; revision=15794
|
|
fragment size. The limit is conservatively set at 65536 bytes. It may
have to be increased. Fixes bug 421.
Add an entry to the release notes.
svn path=/trunk/; revision=15789
|
|
svn path=/trunk/; revision=15786
|
|
svn path=/trunk/; revision=15785
|
|
svn path=/trunk/; revision=15783
|
|
comment from Guy why this (usually) isn't a bug (because of a short snapshot length).
svn path=/trunk/; revision=15781
|
|
First phase of testing revealed the following errors
svn path=/trunk/; revision=15780
|
|
Some updates to the winsrepl-dssector to add COL_INFO strings...
svn path=/trunk/; revision=15779
|
|
A new dissector - cimd dissector. CIMD stands for Computer Interface to Message Distribution and it's used to transfer short messages between applications and Nokia Short Message Service Center.
svn path=/trunk/; revision=15777
|
|
column-utils.h, and add it to expert.h, so we check the arguments to
"expert_add_info_format()", at least if the format argument is a
constant string.
Fix some more calls to "expert_add_info_format()" to pass it a format
string.
Don't record BoundsError exceptions as expert events - they merely
reflect a capture done with a snapshot length too short to capture all
of the packet (any case where it's caused by something else is a bug).
svn path=/trunk/; revision=15776
|
|
format string - the arbitrary string might contain "%" characters, so
the routine might then fetch arbitrary junk and try to use it as, for
example, a string pointer.
svn path=/trunk/; revision=15775
|
|
calls to "tvb_get_ipv4()" and "tvb_get_ipv6()".
Fix a call in the BGP dissector to properly fetch an IEEE floating-point
number.
Update some I-D info.
svn path=/trunk/; revision=15774
|
|
svn path=/trunk/; revision=15771
|
|
Get rid of all the Flex-generated (and Lemon-generated) files on a
"nmake -f Makefile.nmake distclean".
svn path=/trunk/; revision=15770
|
|
parser, or vice versa.
svn path=/trunk/; revision=15769
|
|
svn path=/trunk/; revision=15768
|
|
doing so.
svn path=/trunk/; revision=15767
|
|
with some unrelated changes; it got rid of some calls to get IPv4/IPv6
addresses and add them to the protocol tree, replacing them with
proto_tree_add_item() calls, and fixed up the length of one protocol
tree item.
Note that we have (at least) three count 'em three different routines
for dissecting/displaying NSAPs (there might be more - I might have
missed some), and suggest that we might want to reduce that to one.
Update the URL for ICP values for IPv{4,6} addresses inside NSAPs.
Fix the offset in the call to add the IPv6 address part of an NSAP
containing such an address, and the length in the call adding the DSP
for an NSAP containing an IPv4 address.
Fix up indentation a bit.
svn path=/trunk/; revision=15766
|
|
- http://www.ietf.org/internet-drafts/draft-ietf-tsvwg-sctpimpguide-15.txt
- http://www.ietf.org/internet-drafts/draft-ietf-tsvwg-addip-sctp-13.txt
- http://www.ietf.org/internet-drafts/draft-stewart-sctp-pktdrprep-02.txt
- http://www.ietf.org/internet-drafts/draft-ietf-tsvwg-sctp-auth-01.txt
- http://www.ietf.org/internet-drafts/draft-ladha-sctp-nonce-02.txt
svn path=/trunk/; revision=15765
|
|
platforms in ipv6-utils.h.
svn path=/trunk/; revision=15764
|
|
Unfortunately, I don't have a capture file to test this...
svn path=/trunk/; revision=15763
|
|
fragment_add_seq_next() function instead of fragment_add()
in addition, I had to implement fragment_get_reassembled() in addition to fragment_get(), which works with reassembled_table
svn path=/trunk/; revision=15762
|
|
svn path=/trunk/; revision=15761
|
|
"unknown" for frame numbers. Note that in epan/frame_data.h, and make
the frame number in experts unsigned, and use 0 for "unknown", and
display it as an unsigned number - and, if it's 0, don't display it at
all.
Fix the signature of "expert_dlg_draw()" to match what a tap's draw
routine's signature is expected to be.
svn path=/trunk/; revision=15760
|
|
Fix up indentation.
svn path=/trunk/; revision=15759
|
|
and that extract IPv6 addresses into a "struct e_in6_addr", with
tvb_get_ipv4() and tvb_get_ipv6() calls - except for some that we
remove, by using proto_tree_add_item(), rather than replacing.
Have epan/tvbuff.h include epan/ipv6-utils.h, to define "struct
e_in6_addr" (not necessary to declare the tvbuff routines, but including
it there means "struct e_in6_addr" is guaranteed to be defined before
those declarations, so we don't get compiler complaints if we define it
*after* those declarations).
svn path=/trunk/; revision=15758
|
|
as connection oriented (cn) and connectionless (dg) DCE/RPC uses different ways to handle defragmentation and this function is only used for dg
svn path=/trunk/; revision=15757
|
|
svn path=/trunk/; revision=15756
|
|
dependencies)
svn path=/trunk/; revision=15755
|
|
where others might have a look and probably already find it useful :-). Anyway, we can easily disable it at one or two places in the code if it get's in our way of a new release.
Please see: http://wiki.ethereal.com/Development/ExpertInfo for a complete overview of the intended feature and it's current state of implementation.
While I'm working on this, I've also added some more status result codes to the DCE/RPC and DCOM dissectors.
svn path=/trunk/; revision=15754
|
|
IPv6 addresses. Use "tvb_get_ipv4()" in the WINS Replication dissector,
so that it gets the right answer on little-endian *AND* big-endian
machines.
svn path=/trunk/; revision=15753
|
|
negative value, so we reject the packet as "not SIP".
Add a "dissect_sip_tcp_heur()" that's heuristic - it'll return FALSE if
the first packet doesn't look like SIP, but once it's dissected one
packet it'll just treat subsequent SIP packets as continuations if they
don't look right.
Clean up indentation a bit.
svn path=/trunk/; revision=15752
|
|
svn path=/trunk/; revision=15751
|
|
svn path=/trunk/; revision=15750
|
|
dtd_preparse.obj : error LNK2001: Nichtaufgeloestes externes Symbol _fgetln
MSVC doesn't support fgetln!
svn path=/trunk/; revision=15749
|
|
svn path=/trunk/; revision=15748
|
|
svn path=/trunk/; revision=15747
|