aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2019-09-04packet-gmr1_rr: Add support for Immediate Assignement Type 4 decodingsylvain/gmr1Sylvain Munaut1-9/+717
This includes all the CSN.1.infrastructure and all the IEs needed for this particular message. Change-Id: I297ecb408952453878c0eaf0e5211e9cd1a3cdcc Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2019-09-01packet-gmr1_rr: Update Request Reference IE to GMR-1 3GSylvain Munaut1-13/+20
Change-Id: I248ad927f4616d172f955fb70d1a6abc46960aae Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2019-09-01packet-gmr1_rr: Add new RR message names from v3.4.1 of GMR-1 3G 44.008Sylvain Munaut1-1/+17
Change-Id: I4212e7ea323a7ebd24cfa49f02c0a9315be2f6f5 Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2019-08-30isakmp: Fix Dead StoreAlexis La Goutte1-2/+0
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I318fec3f9cf8d86eaa4260f00e8747683a049e6e Reviewed-on: https://code.wireshark.org/review/34407 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-30ieee1722: Fix Dead StoreAlexis La Goutte1-2/+0
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ia056c5591369924f88762490b22e72e10f3bc392 Reviewed-on: https://code.wireshark.org/review/34406 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-30NAS 5GS: update 5GSM capability IE dissectionPascal Quantin1-2/+8
Change-Id: I64b063aba78e64193fa5e8dc5e15955bd93093de Reviewed-on: https://code.wireshark.org/review/34409 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-30NAS 5GS: fix PDU session identity dissectionPascal Quantin1-4/+4
Values 1 to 4 are allowed Change-Id: Ifa0bc9185af9a16c261d7cbd939a07f77f03b330 Reviewed-on: https://code.wireshark.org/review/34408 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-30NAS 5GS: update 5GSM cause tablePascal Quantin1-4/+8
Change-Id: I88c9015e0ec31c6d04fe653aee1753d2a604976f Reviewed-on: https://code.wireshark.org/review/34405 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-30NAS 5GS: small cleanupPascal Quantin1-8/+1
Remove a useless assignment and a few useless return. Change-Id: I38d868fe8cb81cd86683cf660a6a6699c1e8a54b Reviewed-on: https://code.wireshark.org/review/34403 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-30NAS 5GS: fix dissection of 5GSM capability IEPascal Quantin1-4/+7
This IE has a variable length to allow future extension. Change-Id: I158ef8a8aa2f5cace992113a9efeb324beebe1aa Reviewed-on: https://code.wireshark.org/review/34402 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-30NAS 5GS: add dissection of Maximum number of supported packet filters IEPascal Quantin1-4/+23
Change-Id: I771cb6d2542a5069641fd5c57836e776802da199 Reviewed-on: https://code.wireshark.org/review/34401 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-30ASTERIX: addition of CAT021 v0.23 and v0.26 decodingIvan Quach1-1/+323
Added ability to decode CAT021 version 0.23 and version 0.26 ASTERIX messages Change-Id: I242ae3055f0af805e3a9eb126494d545702f836f Reviewed-on: https://code.wireshark.org/review/34343 Reviewed-by: Ivan Quach <ivan.quach@aireon.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-30genl: Always call subdissectorIdo Schimmel2-9/+14
Commit 61c5e8e76d21 ("genl: make subdissectors responsible for header") changed the generic netlink dissector to only call a sub-dissector if there is a payload after the generic netlink header. However, there are commands in certain generic netlink families that do not have any payload. For example, 'NET_DM_CMD_START' in the 'NET_DM' family. This means that the command will not be dissected by the subdissector, as it will never be invoked. Change the generic netlink dissector to always call a subdissector, if it is present. Prevent the subdissectors from trying to dissect past the end of the packet by adding checks in the two existing subdissectors, for the 'nlctrl' and 'nl80211' families. Change-Id: I4d2f48531dee92b11dc45000081a8d2d3dd875c6 Signed-off-by: Ido Schimmel <idosch@mellanox.com> Reviewed-on: https://code.wireshark.org/review/34350 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-29mpeg(dsmcc): Fixed default switch conditionAnthony Crawford1-0/+2
A default condition was missing within the switch statement in dissect_dsmcc_un_session_resources Bug: 16025 Change-Id: I34a2c3715923ba80be456aa9b03f84f1dae58bd3 Reviewed-on: https://code.wireshark.org/review/34399 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-29Add proto_tree_add_item_ret_time_stringMichael Mann14-222/+236
A few dissectors need the functionality of adding a time field to a proto_tree while also needing the "time to string" value (typically to show on a tree above). The functionality to do "get value from tvb and convert to string" was being done in packet-ntp.c. Instead proto_tree_add_item_ret_time_string can be used with various encoding to get the necessary functionality with less code duplication. ENC_TIME_MIP6 was added as a result of the refactoring. ABSOLUTE_TIME_NTP_UTC was added as another potential "base" type for time fields. Change-Id: Ie460c33370b0af59ef60bdab893ce9d6eb23b94f Reviewed-on: https://code.wireshark.org/review/34390 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-28DOCSIS: FDX: Added decoding for SW-RBABruno Verstuyft1-1/+97
Change-Id: Ic55c2393e20c69866a266a5a8213faa84e17fac1 Reviewed-on: https://code.wireshark.org/review/34389 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-28eCPRI: Update value string.Anders Broman1-3/+19
Change-Id: I7e5f5fa00b168578e00191089b482082e290f2d0 Reviewed-on: https://code.wireshark.org/review/34388 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-28Use g_hash_table_replace() when key depends on dataTomasz Moń1-1/+1
Using g_hash_table_insert() in cases where the key is contained within value is error prone. Use g_hash_table_replace() to eliminate the risk of ending up with incoherent hash table state. Change-Id: I595457476a2682e927d2c56b2692404aef4dc43a Reviewed-on: https://code.wireshark.org/review/34385 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-27Kafka: fixed OffsetForLeaderEpoch dissectionPiotr Smolinski1-132/+155
Bug: 16023 Change-Id: I78e1354ac5509707c818d7968c7067583fb469ba Reviewed-on: https://code.wireshark.org/review/34379 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-27kafka: remove unused hf/ei entries.Dario Lombardo1-15/+0
Change-Id: I98a3a1456fbfeb726a1a81a0b46714556fe951cd Reviewed-on: https://code.wireshark.org/review/34383 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-27SMTP: Add support for multiline responsesMichael Mann1-22/+53
Commands with "-" at the end mean another line with the same command will follow. Group all of those lines in a single response tree and don't append the command value in the Info column for the additional lines. Bug: 15933 Change-Id: Icba167f2f1d22ebaf53a6844285ba83ed8a20106 Reviewed-on: https://code.wireshark.org/review/34381 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-27DCERPC: workaround that pidl always emits dissect_deferred_pointers()Ralph Boehme1-2/+7
Commit f57cf9e56c90c0c0c724f415eff35821afaaf849 introduced a DISSECTOR_ASSERT() that revealed a deficiency in pidl: currently pidl unconditionally adds calls to dissect_deferred_pointers() which breaks dissecting any RPC function that has only scalar arguments: Warn Dissector bug, protocol RPCMDSSVC, in packet 51: epan/dissectors/packet-dcerpc.c:2940: failed assertion "list_ndr_pointer_list" Bug: 16022 Change-Id: I9d3522a3e17ef79b9a8a5acb018104ab398a512a Reviewed-on: https://code.wireshark.org/review/34364 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-27DCERPC: update mdssvc DCERPC dissector from upstream SambaRalph Boehme2-99/+278
Change-Id: I13871e093b294a1865be6c47cb86275165002855 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-on: https://code.wireshark.org/review/34365 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26coap: Distinguish observe option for request and responseStig Bjørlykke3-11/+24
The observe option has different values for request and response. For request it identifies register or deregister, and for response it is a sequence number for reordering detection. RFC 7641 chapter 2. Change-Id: I09515864997a32f7259e344532ea770b74030b04 Reviewed-on: https://code.wireshark.org/review/34368 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-26coap: Improve request/response trackingStig Bjørlykke2-23/+50
Use both Token and Message ID in request/response tracking and retransmission detection. The token is the same when using observables but the message id is increasing. Change-Id: I545416ce139328e6a8eb67258d7b51bddb6b278e Reviewed-on: https://code.wireshark.org/review/34367 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-26SCTP: Use proto_tree_add_bitmask_list() for data chunk flags.Anders Broman1-11/+18
Change-Id: I9da080982d5ca85cbd3747008cd1f2b3670b6baa Reviewed-on: https://code.wireshark.org/review/34369 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26ISAKMP: Correct typos in new GDOI fieldsMichael Mann1-3/+3
Change-Id: I29872cb116dfc66c93d59b51a44161e627d3cfec Reviewed-on: https://code.wireshark.org/review/34363 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26ISAKMP: added support for GDOIGandharav Katyal1-64/+262
Bug: 15693 Change-Id: I790da95c1fa64596bd5131b491237fa084c0be49 Reviewed-on: https://code.wireshark.org/review/33382 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26NFS: Fix hash table key memory corruptionTomasz Moń1-1/+1
When the same (as determined by key_equal_func) key gets added to the GHashTable, old value gets freed and replaced with the new one. This is fine for hash tables where the key validity is not tightly coupled to the actual data. In the nfs_name_snoop_matched hash table the key becomes invalid once the value gets destroyed (because it shares the data pointed to by fh, which gets freed once the value is destroyed). A problematic capture includes packets such that the matching fh gets added twice to the nfs_name_snoop_matched hash table. Prior to this change the hash table would end up in a state where the new value is associated with the old key (which contains pointer to already freed memory). According to the nfs_name_snoop_matched_equal(), the old key was equal to the key intended for new value *at the time* of insertion. This change fixes the bug by using g_hash_table_replace() which does update the key in case it already exists in the GHashTable. Bug: 16017 Bug: 16019 Change-Id: Ib3943f1e27e82c05d9abaa1e436554b37a98488e Reviewed-on: https://code.wireshark.org/review/34360 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26SIP: Ensure session-id is not emptyMichael Mann1-6/+14
Add expert info if session-id is empty. Bug: 15951 Change-Id: I48ffe4ca26fd94f522ad1a668c99ed8f1f5e2c01 Reviewed-on: https://code.wireshark.org/review/34356 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-25show interface name in frame line caption if setMartin Fesser1-1/+8
Change-Id: Ib6cb86bc20dae9f88fdeb469983c2380bcc9216d Reviewed-on: https://code.wireshark.org/review/34335 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-08-25usb-audio: fix conflictAlexis La Goutte1-3/+3
'usbaudio.as_if_gen.bmFormats.rsv' exists multiple times with NOT compatible types: FT_UINT32 and FT_BOOLEAN Change-Id: I908b815bfa0f96f2ec421367995d971040f423a1 Reviewed-on: https://code.wireshark.org/review/34283 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-25[Automatic update for 2019-08-25]Gerald Combs1-0/+6
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I4ed4ada929881a78beefc34012a9898caa92d649 Reviewed-on: https://code.wireshark.org/review/34353 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-24ELF: do not create lots of tree items for Entry Size 1Peter Wu1-2/+4
Change-Id: Ief8db4a833099c53adb1695129d435c3b89c2680 Reviewed-on: https://code.wireshark.org/review/34347 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-24Modbus: Unit and Transaction Id for request/response identificationThomas Wiens4-28/+65
Use Unit and Transaction Identifier to identify the correct request to a response. The Transaction Identifier is only available in Modbus TCP. Bug: 15698 Change-Id: Ic3a279ce200bee9e9274aaec66bd9dc2f1c096b9 Reviewed-on: https://code.wireshark.org/review/34274 Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-24mpeg(dsmcc): Fixed range valuesAnthony Crawford1-2/+2
Fixed range values in message_discriminator_vals and rsrc_attribute_vals. Bug: 16015 Change-Id: Ib04b0be32fb8d58138913e643a38b95e64cdad7f Reviewed-on: https://code.wireshark.org/review/34344 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-08-24ELF: update e_machine table, update linksPeter Wu1-7/+33
Use HTTPS for links when possible and update the e_machine entries by post-processing a copy from the table on the website: awk -F $'\t' '$1 ~ /^EM/ && $3 ~ /./ {printf " { %3d, \"%s\" },\n", $2, $3}' Manually added the reserved entries for 182 and 184. Additionally added Linux kernel BPF (247) and C-SKY (252). Change-Id: I28ad07377a20499014437919da8e6871db2b8e59 Ping-Bug: 16016 Reviewed-on: https://code.wireshark.org/review/34346 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-08-23BLIP: Fix issues with message decompressionJim Borden1-42/+67
Due to the way the BLIP compresses its messages, it quickly falls apart when the messages are not examined exactly in order (as is the case when selecting random frames inside of a capture). The only solution I can see is to only decompress once and store the result somewhere that is persistent at the file level. Change-Id: I38c781222c8efbbcded2446ae02fa7cb57c71509 Reviewed-on: https://code.wireshark.org/review/33827 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-23Pegasus LSC: Added Status CodesAnthony Crawford1-0/+3
Comcast NGOD C1 LSC specification 'Comcast-SP-NGOD-SRM-S1C1_DSMCC-I03-100731', Page 25, Table 11, extends the list of status codes to include 0x01, 0x04, and 0x05. Change-Id: Ib208d1b409af62aa25cb5d7d6fee47ffc10dc880 Reviewed-on: https://code.wireshark.org/review/34342 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-23mpeg(dsmcc): Fix Dead StoreAlexis La Goutte1-2/+2
Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Iea244eac276f6e37590b04cfbb53c3d7c802c7ae Reviewed-on: https://code.wireshark.org/review/34320 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anthony Crawford <anthony.r.crawford@charter.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-08-22Updated EVS packet description for Compact format with bitrate.Morten Tryfoss1-9/+9
Description for packet with length 480 was incorrent (EVS Primary 24.0 instead of AMR-WB IO 23.85) Change-Id: I1625635468ce06a0057beb32d9558cbb71d6583f Reviewed-on: https://code.wireshark.org/review/34338 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-22packet-ieee1722: Added TSCF and NTSCF control frames supportDmitry Linikov1-2/+1249
Only CAN, CAN_BRIEF and LIN messages supported. Change-Id: Id79574bcdab9f1ec66390357dd5860c73f194ccc Reviewed-on: https://code.wireshark.org/review/31765 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-21GSM A DTAP: Try to ensure that global variable sccp_assoc is cleared.Anders Broman2-1/+3
Change-Id: I970e9314724c55c19d0b98578e54a5d1b598e307 Reviewed-on: https://code.wireshark.org/review/34336 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20RTCP: fix reference time typeAlexis La Goutte1-2/+2
from draft-holmer-rmcat-transport-wide-cc-extensions-01 reference time field is a Signed Integer Bug: 16007 Change-Id: I5686e43f2817b626ef45b07dd9fcec0c9bcc1cfb Reviewed-on: https://code.wireshark.org/review/34330 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20Kafka: include zstd compression in Kafka message batchesPiotr Smolinski3-0/+52
Change-Id: I1d06486ccf7b174ee9aa621fa3d8acb8b3673777 Reviewed-on: https://code.wireshark.org/review/34222 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20SCTP: Make association amalysis a prference defaulting to FALSE.Anders Broman1-32/+43
Association analysis causes long loops if there is a lot off associations or IMIT ABORTS. On a 679K packets trace loading with amalysis takes 3.31.660 without 0.3.275. The culprit is the for loop in find_assoc_index(). Change-Id: I07ae0e826c08aded3eb0e7dc3474dcf5cdd556f9 Reviewed-on: https://code.wireshark.org/review/34333 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20Kafka: fix the name shadowingPiotr Smolinski1-4/+8
Post-merge fix. Change-Id: I712d275f90c5a1e425865654143ead7c3a04998b Reviewed-on: https://code.wireshark.org/review/34332 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20Kafka: add support for Kafka 2.3+ dissectionPiotr Smolinski1-516/+5318
Existing Apache Kafka support in Wireshark ends at version 0.10. The version 0.11 (June 2017) brought significant changes to the message format. This change makes the Wireshark Kafka dissector obsolete. The recently released Kafka 2.3 has a lot of additions to the wire protocol, which should be also addressed. Major changes: * Applied Kafka protocol changes since 0.10 * Zstd-packed message decompression (since Kafka 2.1) * Added support for Kafka over TLS decryption Bug: 15988 Change-Id: I2bba2cfefa884638b6d4d6f32ce7d016cbba0e28 Reviewed-on: https://code.wireshark.org/review/34224 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20ZigBee OTA: Fix GetProfileResponse end time decodingMartin Boye Petersen1-1/+5
Added missing time offset to GetProfileResponse end time. Change-Id: I47f31cea709ccc600c9ea182c4bf6cf96410ff78 Reviewed-on: https://code.wireshark.org/review/34322 Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20USBLL: Use custom address dissector instead of usb oneKrzysztof Opasiak1-25/+142
Usage of USB address dissector creates several challenges. In order to improve user experience let's create a custom address dissector. This allows us to not only drop the busid parameter but also replace endpoint parameter with hub port for SPLIT transactions. The address may be one of 3 forms: - host - <device address>.<endpoint> - <hub address>:<hub port> (for SPLIT transactions) This also adds 3 new fields (source, destination and addr) with exactly the same meaning as in usb. It also renames current addr field to device_addr. Strongly based on initial work by: Maciej Purski <maciej.purski@gmail.com> Ping-Bug: 15908 Change-Id: I5702295d7ef9076c3e0373de35ea4ac3cb2a0709 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Reviewed-on: https://code.wireshark.org/review/34279 Reviewed-by: Tomasz Moń <desowin@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-02 23:45:56 +0000