Age | Commit message (Collapse) | Author | Files | Lines |
|
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') (Double space between star and $Id$)
Change-Id: If9b8f345e3b6493de0b573600e60005c8b0b33c3
Reviewed-on: https://code.wireshark.org/review/877
Reviewed-by: Evan Huus <eapache@gmail.com>
|
|
The majority of the fixes are for calls to uat_new(). Instead of
having each caller cast its private data to (void**), we use void*
in the uat_new() API itself. Inside uat_new(), we cast the void*
to void**.
Some dissectors use val64_string arrays, so a VALS64() macro was
added for those, to avoid using VALS(), which is useful only for
value_string arrays.
packet-mq.c was changed because dissect_nt_sid() requires
a char**, not a guint**. All other callers of dissect_nt_sid() use
char*'s (and take the address of it) for their local storage. So,
this was changed to follow the other practices.
A confusion between gint and absolute_time_display_e in packet-time.c
was cleared up.
The ugliest fix is the addition of ip6_guint8_to_str(), for exactly
one caller. The caller uses one type of ip6 address byte array,
while ip6_to_str() expects another. This new function is in place
until the various address implementations can be consolidated.
Add VALS64() to the developer documentation.
Change-Id: If93ff5c6c8c7cc3c9510d7fb78fa9108e4552805
Reviewed-on: https://code.wireshark.org/review/48
Reviewed-by: Evan Huus <eapache@gmail.com>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
|
|
svn path=/trunk/; revision=53906
|
|
pointer target type
svn path=/trunk/; revision=53875
|
|
Leave typedef (uat_t) unchanged.
svn path=/trunk/; revision=53767
|
|
XXX ncp2222 dissector is using dfilter_compile(), why?
svn path=/trunk/; revision=53766
|
|
svn path=/trunk/; revision=53230
|
|
../../epan/uat.h:245:23: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
* @param num_items_ptr
~~~~~~~~~~~~~~~~~~~^
1 error generated.
svn path=/trunk/; revision=51257
|
|
C++-ize the UAT headers.
Add an ElidedLabel widget. Use it in the File Set, Profile, and UAT
dialogs.
Update the Qt README.
svn path=/trunk/; revision=50896
|
|
remove C++ incompatibilities from UAT_VS_DEF macro and all uses
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416
svn path=/trunk/; revision=48259
|
|
Also remove old WS_VAR_IMPORT define and related Makefile magic
everywhere in the project.
svn path=/trunk/; revision=47992
|
|
Also addresses an implicit cast in the epan/uat.h file
Bug 8342 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8342)
svn path=/trunk/; revision=47721
|
|
svn path=/trunk/; revision=47560
|
|
int" instead.
bugs 7825-7827 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7825)
svn path=/trunk/; revision=46928
|
|
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
sizeof.
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
strtol() and strtoul().
Change some data types to avoid those implicit conversion warnings.
When assigning a constant to a float, make sure the constant isn't a
double, by appending "f" to the constant.
Constify a bunch of variables, parameters, and return values to
eliminate warnings due to strings being given const qualifiers. Cast
away those warnings in some cases where an API we don't control forces
us to do so.
Enable a bunch of additional warnings by default. Note why at least
some of the other warnings aren't enabled.
randpkt.c and text2pcap.c are used to build programs, so they don't need
to be in EXTRA_DIST.
If the user specifies --enable-warnings-as-errors, add -Werror *even if
the user specified --enable-extra-gcc-flags; assume they know what
they're doing and are willing to have the compile fail due to the extra
GCC warnings being treated as errors.
svn path=/trunk/; revision=46748
|
|
implicitly by the #define name and string they were defined to; not all
UATs neatly fit into any of the categories, so some of them were put
into categories that weren't obviously correct for them, and one - the
display filter macro UAT - wasn't put into any category at all (which
caused crashes when editing them, as the GUI code that handled UAT
changes from a dialog assumed the category field was non-null).
The category was, in practice, used only to decide, in the
aforementioned GUI code, whether the packet summary pane needed to be
updated or not. It also offered no option of "don't update the packet
summary pane *and* don't redissect anything", which is what would be
appropriate for the display filter macro UAT.
Replace the category with a set of fields indicating what the UAT
affects; we currently offer "dissection", which applies to most UATs
(any UAT in libwireshark presumably affects dissection at a minimum) and
"the set of named fields that exist". Changing any UAT that affects
dissection requires a redissection; changing any UAT that affects the
set of named fields that exist requires a redissection *and* rebuilding
the packet summary pane.
Perhaps we also need "filtering", so that if you change a display filter
macro, we re-filter, in case the display is currently filtered with a
display filter that uses a macro that changed.
svn path=/trunk/; revision=43603
|
|
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
|
|
svn path=/trunk/; revision=42401
|
|
This fixes a crash when changing settings for fields used as a custom column.
svn path=/trunk/; revision=41840
|
|
modify the string in place, they return a g_mallocated modified version
of the string passed into them.
svn path=/trunk/; revision=40727
|
|
svn path=/trunk/; revision=39700
|
|
Add a File/Directory Dialog as a field type for UAT preferences.
svn path=/trunk/; revision=39058
|
|
Both _set_cb and chk_range uses fld_data as max in range_convert_str().
This bug was found when the range max check from bug 4768 was fixed
in revision 34698.
svn path=/trunk/; revision=34722
|
|
the callbacks we have use that argument - is it really needed?).
svn path=/trunk/; revision=34694
|
|
check routine.
Also, a field type which is an enumerated string value.
svn path=/trunk/; revision=33343
|
|
Add a callback to UAT to be called after the table has being updated,
use it to renew the snmp_ue_cache.
svn path=/trunk/; revision=32112
|
|
svn path=/trunk/; revision=31898
|
|
svn path=/trunk/; revision=29882
|
|
svn path=/trunk/; revision=28094
|
|
buildbot; based on a patch from Chris Maynard, with some additional
changes to squelch GCC warnings on UN*X.
svn path=/trunk/; revision=28093
|
|
than 2^31-1 (if they are, truncating the length to 32 bits is probably
the least of our problems).
svn path=/trunk/; revision=27735
|
|
g_free() is NULL safe, so we don't need check against it.
svn path=/trunk/; revision=27718
|
|
can be free'ed before we use it. Allocate the string like we do for
other strings and copy/free the memory in the appropriate copy_cb/free_cb
functions. This is only used in the DLT_USER table yet.
svn path=/trunk/; revision=27663
|
|
displayed to the user.
svn path=/trunk/; revision=27462
|
|
svn path=/trunk/; revision=25937
|
|
from a couple of variables.
svn path=/trunk/; revision=25935
|
|
freeing the contained buffer ( The client might have passed the
contained buffer to avoid read-after-free )
svn path=/trunk/; revision=25928
|
|
selected profile.
Don't save SMI Paths and SMI Modules in the profiles because reloading
currently doesn't work (bug 2309).
svn path=/trunk/; revision=24580
|
|
to override UAT entries from the command line, e.g.
-o "uat:user_dlts:\"User 0 (DLT=147)\",\"http\",\"0\",\"\",\"0\",\"\""
Fix up white space.
svn path=/trunk/; revision=24338
|
|
svn path=/trunk/; revision=24229
|
|
made some cleanups in profile_dlg.
svn path=/trunk/; revision=24136
|
|
configure and use more than one set of preferences and configuration files.
This can be found in the "Configuration Profiles..." menu item from the Edit
menu, or by pressing Shift-Ctrl-A. It's also possible to start wireshark
and tshark with a named profile by using the "-C ProfileName" option.
A new status pane in the main window will show the current profile.
The configuration files currently stored in the Profiles are:
- Preferences
- Capture Filters
- Display Filters
- Coloring Rules
- Disabled Protocols
- User Accessible Tables
The recent data are by design not added to the profile.
Planned future enhancements:
- make a more convenient function to switch between profiles
- add a "clone profile" button to copy an existing profile
- make the profiles list active and accept return as OK
- save users "Decode as" in the profile
- make new, clone and deletion of profiles more secure
- make some of the recent values available in the profile
This patch also fixes:
- setting default status pane sizes
- a bug setting status pane for packets when not having main lower pane.
svn path=/trunk/; revision=24089
|
|
- As noted by Thomas Anders values are not added to the tree anymore. Move the calling of subdissectors to the end of the function, so that the value is added to the tree.
- add port 8161 to be decoded as SNMP (hey, it's on IANA's services file!)
UAT:
- do not have the uat reloaded.
OIDS:
- do not complain if renaming an OID to an identical name
svn path=/trunk/; revision=22704
|
|
dissector and the handle
- packet-user_encap.c: use the new UAT_PROTO_DEF
- gtk/uat_gui.c: change the order of "containment" of the widgets to have the clist fields sized to the scrolledwindow instead of the whole window
svn path=/trunk/; revision=21934
|
|
--enable-extra-gcc-checks set.
If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.
Constify a bunch of stuff, and make some other changes, to get rid of
warnings.
Clean up some indentation.
svn path=/trunk/; revision=21526
|
|
svn path=/trunk/; revision=21423
|
|
Add a table of DPCs and SSNs that allow to override the protocol that would be choosen
so that the same SSN can use two different protocols in two different DPCs.
I did not believe it someone could have done it, then I saw the captures...
svn path=/trunk/; revision=21321
|
|
svn path=/trunk/; revision=21296
|
|
can be used inside.
Fixes bug 1502
svn path=/trunk/; revision=21294
|
|
svn path=/trunk/; revision=20849
|