aboutsummaryrefslogtreecommitdiffstats
path: root/epan/req_resp_hdrs.c
AgeCommit message (Collapse)AuthorFilesLines
2015-11-27Officially remove tvb_get_string and tvb_get_stringz.Michael Mann1-3/+3
Almost all replacements were done awhile ago, just put the final nail in the coffin. Change-Id: I0a708d886da5a500c2a1e2c9ee2736794bdb9411 Reviewed-on: https://code.wireshark.org/review/12206 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-30Fix some cases where we're shifting a signed 1 left.Guy Harris1-1/+1
Shift 1U instead, to make sure it's unsigned; the result of, for example, the result of shifting a signed value left is undefined if the value times 2^{shift count} doesn't fit in the *signed* type of the shifted value. That means, in particular, that the result of shifting 1 left by {number of bits in an int - 1} is undefined. (In *practice*, it'll probably be -2^32, with the bit you want set, but that's not guaranteed, and GCC 5.1 seems not to like it.) Change-Id: I0d27565c382a04ceda9eec65f45a430ceb74cf53 Reviewed-on: https://code.wireshark.org/review/8255 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-16Fix spelling: cant-->can't, wont-->won't, etcBill Meier1-2/+2
Change-Id: Ia6c3e7a25615bf8e052c3bacf096d76df775c9c2 Reviewed-on: https://code.wireshark.org/review/4126 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-05-14- Replace tvb_length_remaining -> tvb_captured_length_remaining,AndersBroman1-7/+7
- Use length_remaining in tvb_find_line_end() rather than -1 it should give a faster code path. Change-Id: Ia6c289f1701add48429b25152db8a8e5cea9e053 Reviewed-on: https://code.wireshark.org/review/1632 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-31Use tvb_get_string_enc() with UTF_8 when checking headers as it's faster.AndersBroman1-1/+1
Change-Id: I88cd6f71c1fcbf67948dd0ebdc6e5641d6ba111c Reviewed-on: https://code.wireshark.org/review/891 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-09-22emem -> wmem conversion:Pascal Quantin1-3/+3
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-05As per the HTTP spec, prefer chunked transfer-encoding to content-length if weEvan Huus1-38/+38
get both. Fixes reassembly for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9101 svn path=/trunk/; revision=51785
2013-05-24Add an optimization to req_resp_hdrs_do_reassembly that shaves about 20% offEvan Huus1-0/+23
the load time of one of my sample captures that is HTTP-but-not-really. Also add modelines. svn path=/trunk/; revision=49551
2012-12-26Fix a bunch of warnings.Guy Harris1-3/+7
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-2/+0
svn path=/trunk/; revision=45016
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-05-22HTTP: RPC/HTTP do a better detection and parsing of RPC over HTTPRonnie Sahlberg1-0/+21
From Matthieu Patou <mat@matws.net> svn path=/trunk/; revision=42773
2010-05-26Try to optimize a bit.Anders Broman1-21/+10
svn path=/trunk/; revision=32973
2009-10-03Fix a typoJeff Morriss1-1/+1
svn path=/trunk/; revision=30267
2009-10-03Since chunk_size is now unsigned, check to ensure that it is not "too big."Jeff Morriss1-10/+15
(Prior to rev 30233 there was a check to make sure it was not negative. This effectively puts that same check back in.) Fixes the fuzz failure seen in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4083 svn path=/trunk/; revision=30260
2009-10-01Added a cast to avoid another warning.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=30237
2009-10-01Fixed input argument for sscanf "%x" (shall be unsigned int).Stig Bjørlykke1-4/+3
Check that this value has been set. svn path=/trunk/; revision=30233
2009-08-26(FWIW) One step towards including stdio.h & stdlib.h only when req'd.Bill Meier1-1/+3
svn path=/trunk/; revision=29568
2009-04-08More size_t fixes. Use a string buffer in range.c.Gerald Combs1-1/+1
svn path=/trunk/; revision=27999
2008-04-09Remove:Anders Broman1-4/+0
#ifdef NEED_G_ASCII_STRCASECMP_H #include "g_ascii_strcasecmp.h" #endif svn path=/trunk/; revision=24859
2007-11-27strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delendaGuy Harris1-2/+6
est. Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our own versions if they're missing from GLib (as is the case with GLib 1.x). In the code to build the list of named fields for Diameter, don't use g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping in the hash function and use g_ascii_strcasecmp() in the compare function. We do this because there is no guarantee that toupper(), tolower(), and functions that use them will, for example, map between "I" and "i" in all locales; in Turkish locales, for example, there are, in both upper case and lower case, versions of "i" with and without a dot, and the upper-case version of "i" is "I"-with-a-dot and the lower-case version of "I" is "i"-without-a-dot. This causes strings that should match not to match. This finishes fixing bug 2010 - an earlier checkin prevented the crash (as there are other ways to produce the same crash, e.g. a bogus dictionary.xml file), but didn't fix the case-insensitive string matching. svn path=/trunk/; revision=23623
2007-11-19From Yaniv kaul:Mike Duigou1-8/+12
Adds const declarations to req_resp_hdrs_do_reassembly() and re-orders some actions to occur after tests which may decide that the actions were not required. svn path=/trunk/; revision=23504
2007-10-03Fixes reassembly of chunked http-responses spanning multiple tcp segmentsSake Blok1-3/+1
(bugs 1581,1851 and 1868) svn path=/trunk/; revision=23061
2007-08-21From Mike Duigou <wireshark@duigou.org> (bug 1698):Richard van der Hoff1-3/+3
Enclosed is a patch with fixes problems with the desegmentation of chunked HTTP message bodies. ... Changing the value of pinfo->desegment_len to DESEGMENT_ONE_MORE_SEGMENT rather than the current 1 or 2 seems to make everything work. (I'm kind of confused as to why the headers resassembly code already used DESEGMENT_ONE_MORE_SEGMENT and the body reassembly code did not). svn path=/trunk/; revision=22570
2007-03-28Remove almost all of the casts I committed recently and in place ofStephen Fisher1-4/+4
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it. svn path=/trunk/; revision=21253
2007-03-26Fix a bunch more warnings. Add -Werror when using --with-warnings-as-errorsStephen Fisher1-4/+4
under gcc to tools/lemon, plugins/mate and epan/ svn path=/trunk/; revision=21204
2006-11-10fix for bug 1142Ronnie Sahlberg1-8/+30
if we dont have a content-length but we do have a keepalive in the header then we should not do reassemble-until-fin. convert some tvb_get_String into tvb_get_ephemeral_string at the same time svn path=/trunk/; revision=19874
2006-11-07fix for bug 1200Ronnie Sahlberg1-2/+2
there used to be a bug in tcp reassembly that even if the dissector only asked for x more bytes from the next segment the entire segment would still be added to reassembly. this caused some issues when there was a new multisegment pdu that started at the end of the segment but this bug was fixed when tcp reassembly was refactored semi-recently. there was also another "bug" in the http reassembly that it would only ask for one more byte at a time when doing reassembly. this did work well however when we still had the bug in tcp reassembly but made wireshark become very very very slow once this tcp bug was fixed since it is very very very slow to reassemble a huge http pdu just one byte at a time. this patch adds partial support (what we need for http which does not use tcp_dissect_pdus() ) for the desegmentation flag : DESEGMENT_ONE_MORE_SEGMENT and also to the http dissector so that reassembly of http headers spanning multiple semgents now become fast again svn path=/trunk/; revision=19859
2006-09-10implement support to reassemble tcp sessions until the end of the session (FIN)Ronnie Sahlberg1-0/+25
add required code to the http (and others) code in req_resp_hdrs.c to signal to tcp when it wants a session to be reassembled to the FIN. This is currently done for all HTTP packets where we have a Content-type in the header but no content-length. svn path=/trunk/; revision=19185
2006-05-21name changeRonnie Sahlberg1-2/+2
svn path=/trunk/; revision=18197
2005-01-20There's no guaranteee that "req_resp_hdrs_do_reassembly()" gets calledGuy Harris1-2/+1
only at the beginning of a tvbuff, so it needs an argument that's the starting offset in the tvbuff. svn path=/trunk/; revision=13128
2005-01-07From Chris Maynard: free strings fetched with "tvb_get_string()" whenGuy Harris1-0/+2
we're done with them. svn path=/trunk/; revision=12975
2004-09-29Move the request/response header helper routines to the epan directory.Guy Harris1-0/+339
svn path=/trunk/; revision=12129