aboutsummaryrefslogtreecommitdiffstats
path: root/epan/prefs.c
AgeCommit message (Collapse)AuthorFilesLines
2013-05-30From Cal Turney:Anders Broman1-1/+9
Preferences with trailing commas are ignored. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8707 svn path=/trunk/; revision=49629
2013-05-21From Cal Tunney:Guy Harris1-21/+34
contify some arrays; don't complain about "print.command" on Windows, just ignore it, as it's valid on non-Windows platforms; fix some comparisons for preferences moved elsewhere; clean up some comments. svn path=/trunk/; revision=49485
2013-05-21Clean up white space.Guy Harris1-55/+56
svn path=/trunk/; revision=49484
2013-05-20From Cal Turney:Anders Broman1-6/+8
When another profile is selected, its column.hidden preference is ignored. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8696 svn path=/trunk/; revision=49434
2013-04-22Tell the user tha gui.update.channel probably shouldn't be changed.Gerald Combs1-1/+1
svn path=/trunk/; revision=48970
2013-04-09Don't try to open <home>/.wireshark on Windows: Wireshark hasn't written toJeff Morriss1-2/+2
that directory since 2001 and reading from that directory was only left in for backwards compatibility with versions prior to r4702. I think it's now safe to remove that backwards compatibility. This eliminates the last argument of get_persconffile_path(). https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8437 svn path=/trunk/; revision=48797
2013-03-20 From beroset:Bill Meier1-3/+3
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10397 svn path=/trunk/; revision=48438
2013-03-13Add interface options preferences.Irene Rüngeler1-0/+4
svn path=/trunk/; revision=48275
2013-03-07Try to fix the buildbots.Michael Tüxen1-0/+2
The patch for capture_dlg.c is from Anders... svn path=/trunk/; revision=48164
2013-03-07Add buffersize and snap length to the preferences.Irene Rüngeler1-0/+8
svn path=/trunk/; revision=48163
2013-03-07Use explicit casts.Anders Broman1-25/+25
svn path=/trunk/; revision=48162
2013-02-26it's ==> its & its ==> it's as needed.Bill Meier1-3/+3
svn path=/trunk/; revision=47896
2013-02-19Register the gui.update.interval preference.Gerald Combs1-0/+6
svn path=/trunk/; revision=47750
2013-02-19Enable automatic updates for Win64. Fix a copy/paste error.Gerald Combs1-1/+1
svn path=/trunk/; revision=47749
2013-02-19Add automatic software update checks for Win32 using WinSparkle. AddGerald Combs1-0/+18
preferences (currently hidden) to disable updates, set the update frequency, and set the update "channel" (stable vs development). Add a "Help" menu item to manually check for updates. svn path=/trunk/; revision=47748
2013-02-08Add a directory name preference type (PREF_DIRNAME) and registrationGerald Combs1-1/+26
routine (prefs_register_directory_preference). Add PREF_FILENAME and PREF_DIRNAME support to the Qt module preferences. Change a couple of preferences to directory names. Clean up some names and default settings. svn path=/trunk/; revision=47573
2013-01-31Use a not-quite-black background for marked packets.Gerald Combs1-2/+2
http://ianstormtaylor.com/design-tip-never-use-black/ svn path=/trunk/; revision=47392
2013-01-24Add font and color preferences. Unfortunately Qt doesn't have a colorGerald Combs1-4/+8
picker widget so we're back to popping up dialogs. Move the contents of monospace_font.{cpp,h} to wireshark_application.{cpp,h}. Pango and Qt use completely different string representations for fonts. Add a separate gui.qt.font_name preference so that they don't clobber each other. svn path=/trunk/; revision=47240
2013-01-22GTK+:Gerald Combs1-17/+3
Get rid of user-hostile behavior. In the layout preferences pane 2 & 3 radio buttons overrode the user's selection if a duplicate item was selected. Now we assume that the user knows what he or she is doing and steal duplicate selections from the other panes. Qt: Match the new GTK+ behavior in the layout preferences. Add padding around the layout images. Add toolbar style preferences to the Appearance pane (instead of the layout pane). All: Remove the selection mode and scrollbar placement prefs and mark them obsolete as recently discussed on -dev. Adjust the layout images yet again after more Awful Monitor Testing. svn path=/trunk/; revision=47214
2013-01-20Fix CID 966637 and CID 966638Jaap Keuter1-2/+2
Check pointers before using them. svn path=/trunk/; revision=47186
2013-01-18Rename the "saved_val" preference element to "stashed_val" in order toGerald Combs1-35/+49
more clearly indicate that it's a copy of a preference value rather than something we've saved in the preferences file. Update prefs_pref_to_str() to handle default, stashed, and current prefs. Create ui/preference_utils.[ch] and move some common routines there. Use prefs_pref_type_name() in the GTK+ preferences dialog. Make the "OK" button in the Qt preferences dialog work. We simply write the prefs and redissect on "OK" and do nothing on "Cancel". This is intentionally different from the Apply/OK/Cancel behavior in the GTK+ version. Add a general "emitAppSignal" method to wsApp and use it for packet dissection and preference changes. Suggest that we might want to create a WsString class to make conversion between QStrings, gchar *s, and GStrings easier. svn path=/trunk/; revision=47139
2013-01-14strcmp → g_strcmp0. Fixes a crash on Windows.Gerald Combs1-3/+3
svn path=/trunk/; revision=47085
2013-01-14When the user is editing text or selecting from a combo box, don'tGerald Combs1-11/+3
immediately close the dialog if he or she presses the escape or enter keys. Revert the value if the user presses escape. Properly handle the base for uint preferences. Fix a NULL pointer dereference. Add a gchar_free_to_qstring utility routine which creates a QString from a g_malloced string and frees it. svn path=/trunk/; revision=47083
2013-01-07Allow editing via the advanced preferences tree. Double-clicking anGerald Combs1-9/+22
item's name, status, or type resets it to its default value. Double-clicking the item's value lets you edit it. Implement the advanced search field. (Clicking OK and Cancel still doesn't yet do anything.) Note that we could probably use a prefs_register_{uint16|port}_preference routine for 16-bit values. Make reset_pref public. Update some names and descriptions. svn path=/trunk/; revision=46986
2013-01-06Fix some Dead Store (Dead initialization) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=46978
2013-01-05Constify a couple of variables and export a couple of functions.Gerald Combs1-4/+5
svn path=/trunk/; revision=46943
2013-01-05Break out preference type names, type descriptions, stringGerald Combs1-323/+642
representations, and default status out of write_prefs and into their own routines. Split the corresponding custom preference write callbacks. Fix an apparent memory leak in the hidden column callback. Add an initial preferences dialog to the Qt port. Use the new preference routines to implement an "Adavanced" page similar to the "about:config" page available in many web browsers. Standard pages will hopefully follow soon. Remove some QDebug includes and make sure our QTreeWidgets have uniform row heights set. svn path=/trunk/; revision=46942
2012-12-29Remove some duplicate code from ui/profile.c and move in more code fromGerald Combs1-0/+7
ui/gtk/profile_dialog.c. Use the correct profile list in profile_dialog.c so that deletion works. Add a profile dialog to the Qt port. For some reason it crashes when changing configuration profiles, which might be related to bug 7722. Move the Qt configuration profile initialization from main.cpp to wireshark_application.cpp. Make sure QMenuBar doesn't grab the configuration profiles action on OS X. Add more role color names to tango_colors.h. svn path=/trunk/; revision=46834
2012-12-26Tabs -> spaces.Guy Harris1-1/+1
svn path=/trunk/; revision=46800
2012-12-26Update a comment.Guy Harris1-4/+2
svn path=/trunk/; revision=46799
2012-12-26Fix a bunch of warnings.Guy Harris1-64/+22
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-11-03Rename wmem_permanent_scope -> wmem_epan_scope to reflect the fact that itEvan Huus1-2/+2
is technically scoped to the library, not the process. It's also shorter :) svn path=/trunk/; revision=45877
2012-10-27Don't leak memory when registering duplicate preferences subtree modules. TakeEvan Huus1-3/+7
wmem_permanent copies of the substrings we actually need, and g_free the temporary tokenized copy. svn path=/trunk/; revision=45813
2012-10-27There's no need to g_strdup our default prefs - setting them as literalsEvan Huus1-10/+12
works just fine and doesn't leak any memory. Use wmem_permanent_scope() for the one string we do have to copy, to ensure it doesn't leak either. svn path=/trunk/; revision=45812
2012-10-05We are already saving size and maximized state by default. Save position too.Chris Maynard1-1/+1
svn path=/trunk/; revision=45334
2012-09-30Trivial: LEDs -> IconsChris Maynard1-2/+2
svn path=/trunk/; revision=45223
2012-09-27Don't pass a null pointer to strcmp.Gerald Combs1-72/+72
svn path=/trunk/; revision=45175
2012-09-21Fix bug #7669: Preference editor removes (does not save) column definitions ↵Jakub Zawadzki1-26/+26
after the 27th. put_string_list() was generating string with list of columns to be saved to preference file, but buffer is limited to MAX_FMT_PREF_LEN (1024 bytes). It looks like 1024 bytes is not enough. Fix bug by writting directly to file. svn path=/trunk/; revision=45043
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45016
2012-08-18Fix bug 7650 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7650)Michael Mann1-27/+51
prefs.gui_colorized_fg and prefs.gui_colorized_bg not properly integrated into newer preference architecture svn path=/trunk/; revision=44557
2012-08-17Squelch a few "dereferencing type-punned pointer" warnings when compiling ↵Pascal Quantin1-6/+6
with GCC 4.1.3 svn path=/trunk/; revision=44553
2012-08-09Bugfix 7608 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7608)Michael Mann1-4/+4
svn path=/trunk/; revision=44376
2012-08-09Bugfix capture column preferencesMichael Mann1-13/+6
svn path=/trunk/; revision=44370
2012-08-08Complete compiler warnings from r44348Michael Mann1-22/+1
svn path=/trunk/; revision=44364
2012-08-08Get it compiling on Mac OS X.Michael Tüxen1-2/+4
svn path=/trunk/; revision=44363
2012-08-08Compiler error fixes resulting from r44348Michael Mann1-104/+113
svn path=/trunk/; revision=44359
2012-08-08Have (almost) all preferences use the generic preferences API (per ↵Michael Mann1-1178/+1187
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7402). This cleaned up a lot of hardcoded code and allows breaking up the prefs structure (or at least prevent it from growing too large) if desired. Bugfixed problems mentioned in http://www.wireshark.org/lists/wireshark-dev/201208/msg00001.html Column preferences now support default '#' character svn path=/trunk/; revision=44348
2012-08-08Base framework to allow all preferences to be part of generic preferences ↵Michael Mann1-39/+159
API. Implementation will follow, but I wanted the framework in place first. svn path=/trunk/; revision=44331
2012-08-04Plug a memory leak introduced with r44239. Resolves Coverity CID 714243: ↵Chris Maynard1-1/+0
Unused pointer value. (Previous commit actually resolved Coverity CID 714242.) svn path=/trunk/; revision=44266
2012-08-04Plug a memory leak introduced with r44239. Resolves Coverity CID 714243: ↵Chris Maynard1-1/+0
Unused pointer value. svn path=/trunk/; revision=44265