aboutsummaryrefslogtreecommitdiffstats
path: root/epan/prefs.c
AgeCommit message (Collapse)AuthorFilesLines
2013-09-09From Dean Lee via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8597 ↵Alexis La Goutte1-0/+1
Qtshark: Chinese Simp translation From me : Add to the (new) Qtshark Language selector svn path=/trunk/; revision=51871
2013-09-09Add Preference to change Language (in QtShark)Alexis La Goutte1-0/+14
Need restart application to change language svn path=/trunk/; revision=51869
2013-08-13When freeing the preferences of a module, also free the preferences of itsEvan Huus1-2/+7
submodule. svn path=/trunk/; revision=51328
2013-07-31Fix the most egregious of the newly exposed leaks, about 28KB.Evan Huus1-1/+1
svn path=/trunk/; revision=51047
2013-07-31Convert preferences to wmem. Exposes some more memory leaks that didn't show upEvan Huus1-19/+19
before. svn path=/trunk/; revision=51046
2013-07-29Clean up white space a bit, make the description of the capture columnGuy Harris1-58/+63
type depend on what values are supported, add some comments. Regularize the curly bracket style a bit. svn path=/trunk/; revision=50998
2013-07-25Add a UAT dialog. Make UAT preferences uat_t * instead of void *.Gerald Combs1-2/+2
C++-ize the UAT headers. Add an ElidedLabel widget. Use it in the File Set, Profile, and UAT dialogs. Update the Qt README. svn path=/trunk/; revision=50896
2013-07-21Don't report a syntax error if a preference name without a "." isGuy Harris1-13/+3
specified, report it as "no such preference" instead. That should be less confusing; see http://stackoverflow.com/questions/17757659/how-to-apply-and-override-preferences-with-tshark for an example of confusion. #BACKPORT 1.10, 1.8 svn path=/trunk/; revision=50745
2013-07-19From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8942 :Pascal Quantin1-11/+7
Fix segmentation fault when reading pref file svn path=/trunk/; revision=50737
2013-07-18Temporarily disable offending code triggering a segmentation fault on Linux ↵Pascal Quantin1-0/+2
(see bug 8942) svn path=/trunk/; revision=50725
2013-07-18From Cal Turney:Anders Broman1-21/+55
Unrecognized preferences and color filters created in proprietary or older versions are discarded when saved. If the user attempts to save the preferences or colorfilters file, a popup is displayed that warns that unrecognized prefs or color filters have been detected and will be discarded if the save operation is allowed to proceed. In the case of Preferences, the popup message includes the version at which the file was last saved. A "Continue without Saving" button is provided so that the user can save the profile under a different name. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8942 svn path=/trunk/; revision=50716
2013-07-17Backing out r50690 (exept simple_dialog)Anders Broman1-50/+21
struct FILE is different on windows vs *nix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8942 svn path=/trunk/; revision=50691
2013-07-17From Cal Turney:Anders Broman1-21/+50
Unrecognized preferences and color filters created in proprietary or older versions are discarded when saved. If the user attempts to save the preferences or colorfilters file, a popup is displayed that warns that unrecognized prefs or color filters have been detected and will be discarded if the save operation is allowed to proceed. In the case of Preferences, the popup message includes the version at which the file was last saved. A "Continue without Saving" button is provided so that the user can save the profile under a different name. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8942 svn path=/trunk/; revision=50690
2013-07-16Fix one that got missed.Guy Harris1-1/+1
svn path=/trunk/; revision=50660
2013-07-16Revert r50655 for this file.Chris Maynard1-13/+13
svn path=/trunk/; revision=50659
2013-07-16This should fix warning: to be safe all intermediate pointers in cast from ↵Chris Maynard1-33/+33
'gchar **' to 'const char **' must be 'const' qualified. svn path=/trunk/; revision=50655
2013-07-14Fix some of the preferences leaks. Don't strdup the defaults, as they will beEvan Huus1-10/+9
strduped again immediately when they are registered. To make this safe, tweak the flow a bit so that they are guaranteed to be registered immediately after being set here. svn path=/trunk/; revision=50563
2013-07-09prefs.c: In function 'capture_column_set_cb':Anders Broman1-1/+0
prefs.c:1745: warning: unused variable 'syntax_error' svn path=/trunk/; revision=50457
2013-07-09From Cal Turney:Anders Broman1-92/+139
Wireshark crashes when switching from a v1.11.0 profile to a v1.4.6 prof and then to a v1.5.1 profile. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8884 #BACKPORT 1.10 svn path=/trunk/; revision=50455
2013-06-30From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8876 :Jeff Morriss1-5/+8
Errors in preferences preceding "gui.console_open" are not immediately displayed in the console: If a gui.console_open is set to "AUTOMATIC" or "ALWAYS" and an error or warning occurs in a preference previous to it, the warning is not displayed in the console window because the window is not yet open. However, if the user switches to another profile and returns, the messages will be displayed. Fix: Move the gui.console_open to the top of the list in prefs_register_modules() of prefs.c. Existing preferences files can be corrected by saving them. svn path=/trunk/; revision=50269
2013-06-28Make colors used by colorize_filter_te_as_* as preferences. Bug 5413 ↵Michael Mann1-0/+21
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5413) svn path=/trunk/; revision=50203
2013-06-03From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8707 :Jeff Morriss1-10/+12
As suggested by Jakub, don't use strlen() when g_string->len will do. From me: Don't assume that just because we "got_val" that the value has a length. Checking it first eliminates this warning from Valgrind: ==11954== Invalid read of size 1 ==11954== at 0x61D1466: read_prefs_file (prefs.c:3012) ==11954== by 0x61D1841: read_prefs (prefs.c:2955) ==11954== by 0x409901: main (tshark.c:1137) ==11954== Address 0xc05244f is 1 bytes before a block of size 16 alloc'd ==11954== at 0x4A08A6E: realloc (vg_replace_malloc.c:662) ==11954== by 0x3CF8C4D736: g_realloc (in /usr/lib64/libglib-2.0.so.0.3400.2) ==11954== by 0x3CF8C66226: ??? (in /usr/lib64/libglib-2.0.so.0.3400.2) ==11954== by 0x3CF8C66ACE: g_string_insert_c (in /usr/lib64/libglib-2.0.so.0.3400.2) ==11954== by 0x61D1566: read_prefs_file (gstring.h:139) ==11954== by 0x61D1841: read_prefs (prefs.c:2955) ==11954== by 0x409901: main (tshark.c:1137) svn path=/trunk/; revision=49731
2013-05-30From Cal Turney:Anders Broman1-1/+9
Preferences with trailing commas are ignored. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8707 svn path=/trunk/; revision=49629
2013-05-21From Cal Tunney:Guy Harris1-21/+34
contify some arrays; don't complain about "print.command" on Windows, just ignore it, as it's valid on non-Windows platforms; fix some comparisons for preferences moved elsewhere; clean up some comments. svn path=/trunk/; revision=49485
2013-05-21Clean up white space.Guy Harris1-55/+56
svn path=/trunk/; revision=49484
2013-05-20From Cal Turney:Anders Broman1-6/+8
When another profile is selected, its column.hidden preference is ignored. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8696 svn path=/trunk/; revision=49434
2013-04-22Tell the user tha gui.update.channel probably shouldn't be changed.Gerald Combs1-1/+1
svn path=/trunk/; revision=48970
2013-04-09Don't try to open <home>/.wireshark on Windows: Wireshark hasn't written toJeff Morriss1-2/+2
that directory since 2001 and reading from that directory was only left in for backwards compatibility with versions prior to r4702. I think it's now safe to remove that backwards compatibility. This eliminates the last argument of get_persconffile_path(). https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8437 svn path=/trunk/; revision=48797
2013-03-20 From beroset:Bill Meier1-3/+3
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10397 svn path=/trunk/; revision=48438
2013-03-13Add interface options preferences.Irene Rüngeler1-0/+4
svn path=/trunk/; revision=48275
2013-03-07Try to fix the buildbots.Michael Tüxen1-0/+2
The patch for capture_dlg.c is from Anders... svn path=/trunk/; revision=48164
2013-03-07Add buffersize and snap length to the preferences.Irene Rüngeler1-0/+8
svn path=/trunk/; revision=48163
2013-03-07Use explicit casts.Anders Broman1-25/+25
svn path=/trunk/; revision=48162
2013-02-26it's ==> its & its ==> it's as needed.Bill Meier1-3/+3
svn path=/trunk/; revision=47896
2013-02-19Register the gui.update.interval preference.Gerald Combs1-0/+6
svn path=/trunk/; revision=47750
2013-02-19Enable automatic updates for Win64. Fix a copy/paste error.Gerald Combs1-1/+1
svn path=/trunk/; revision=47749
2013-02-19Add automatic software update checks for Win32 using WinSparkle. AddGerald Combs1-0/+18
preferences (currently hidden) to disable updates, set the update frequency, and set the update "channel" (stable vs development). Add a "Help" menu item to manually check for updates. svn path=/trunk/; revision=47748
2013-02-08Add a directory name preference type (PREF_DIRNAME) and registrationGerald Combs1-1/+26
routine (prefs_register_directory_preference). Add PREF_FILENAME and PREF_DIRNAME support to the Qt module preferences. Change a couple of preferences to directory names. Clean up some names and default settings. svn path=/trunk/; revision=47573
2013-01-31Use a not-quite-black background for marked packets.Gerald Combs1-2/+2
http://ianstormtaylor.com/design-tip-never-use-black/ svn path=/trunk/; revision=47392
2013-01-24Add font and color preferences. Unfortunately Qt doesn't have a colorGerald Combs1-4/+8
picker widget so we're back to popping up dialogs. Move the contents of monospace_font.{cpp,h} to wireshark_application.{cpp,h}. Pango and Qt use completely different string representations for fonts. Add a separate gui.qt.font_name preference so that they don't clobber each other. svn path=/trunk/; revision=47240
2013-01-22GTK+:Gerald Combs1-17/+3
Get rid of user-hostile behavior. In the layout preferences pane 2 & 3 radio buttons overrode the user's selection if a duplicate item was selected. Now we assume that the user knows what he or she is doing and steal duplicate selections from the other panes. Qt: Match the new GTK+ behavior in the layout preferences. Add padding around the layout images. Add toolbar style preferences to the Appearance pane (instead of the layout pane). All: Remove the selection mode and scrollbar placement prefs and mark them obsolete as recently discussed on -dev. Adjust the layout images yet again after more Awful Monitor Testing. svn path=/trunk/; revision=47214
2013-01-20Fix CID 966637 and CID 966638Jaap Keuter1-2/+2
Check pointers before using them. svn path=/trunk/; revision=47186
2013-01-18Rename the "saved_val" preference element to "stashed_val" in order toGerald Combs1-35/+49
more clearly indicate that it's a copy of a preference value rather than something we've saved in the preferences file. Update prefs_pref_to_str() to handle default, stashed, and current prefs. Create ui/preference_utils.[ch] and move some common routines there. Use prefs_pref_type_name() in the GTK+ preferences dialog. Make the "OK" button in the Qt preferences dialog work. We simply write the prefs and redissect on "OK" and do nothing on "Cancel". This is intentionally different from the Apply/OK/Cancel behavior in the GTK+ version. Add a general "emitAppSignal" method to wsApp and use it for packet dissection and preference changes. Suggest that we might want to create a WsString class to make conversion between QStrings, gchar *s, and GStrings easier. svn path=/trunk/; revision=47139
2013-01-14strcmp → g_strcmp0. Fixes a crash on Windows.Gerald Combs1-3/+3
svn path=/trunk/; revision=47085
2013-01-14When the user is editing text or selecting from a combo box, don'tGerald Combs1-11/+3
immediately close the dialog if he or she presses the escape or enter keys. Revert the value if the user presses escape. Properly handle the base for uint preferences. Fix a NULL pointer dereference. Add a gchar_free_to_qstring utility routine which creates a QString from a g_malloced string and frees it. svn path=/trunk/; revision=47083
2013-01-07Allow editing via the advanced preferences tree. Double-clicking anGerald Combs1-9/+22
item's name, status, or type resets it to its default value. Double-clicking the item's value lets you edit it. Implement the advanced search field. (Clicking OK and Cancel still doesn't yet do anything.) Note that we could probably use a prefs_register_{uint16|port}_preference routine for 16-bit values. Make reset_pref public. Update some names and descriptions. svn path=/trunk/; revision=46986
2013-01-06Fix some Dead Store (Dead initialization) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=46978
2013-01-05Constify a couple of variables and export a couple of functions.Gerald Combs1-4/+5
svn path=/trunk/; revision=46943
2013-01-05Break out preference type names, type descriptions, stringGerald Combs1-323/+642
representations, and default status out of write_prefs and into their own routines. Split the corresponding custom preference write callbacks. Fix an apparent memory leak in the hidden column callback. Add an initial preferences dialog to the Qt port. Use the new preference routines to implement an "Adavanced" page similar to the "about:config" page available in many web browsers. Standard pages will hopefully follow soon. Remove some QDebug includes and make sure our QTreeWidgets have uniform row heights set. svn path=/trunk/; revision=46942
2012-12-29Remove some duplicate code from ui/profile.c and move in more code fromGerald Combs1-0/+7
ui/gtk/profile_dialog.c. Use the correct profile list in profile_dialog.c so that deletion works. Add a profile dialog to the Qt port. For some reason it crashes when changing configuration profiles, which might be related to bug 7722. Move the Qt configuration profile initialization from main.cpp to wireshark_application.cpp. Make sure QMenuBar doesn't grab the configuration profiles action on OS X. Add more role color names to tango_colors.h. svn path=/trunk/; revision=46834