aboutsummaryrefslogtreecommitdiffstats
path: root/epan/filter_expressions.c
AgeCommit message (Collapse)AuthorFilesLines
2021-06-23Qt: Undo MR 3422 (filter button separator hint)Chuck Craft1-1/+1
See discussion attached to !3422
2021-06-21Qt: Filter button label syntax for groups - add hintChuck Craft1-1/+1
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-28Fix minor leak in filter_expression_new.Darius Davis1-4/+4
filter_expression_new was g_strdup()ing each of the strings in the "expression" structure, but UAT is just going to immediately deep copy the structure (via display_filter_copy_cb), so the copies made here are immediately leaking. We could either free() these copies immediately after uat_add_record returns, or skip the g_strdup altogether (which necessitates casting away the "const"). I chose the latter. Testing Done: Linux x64 build. With a display filter configured in ~/.wireshark/preferences, Valgrind no longer reports three leaks from here. Change-Id: I7913f260875ced597b9027c8ae92a4d6d44f6414 Reviewed-on: https://code.wireshark.org/review/27157 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-04-17Remove some GTK+-only code.Gerald Combs1-1/+0
Change-Id: Ic2498c7acd6a1a522be45094148402ee34a6b4d1 Reviewed-on: https://code.wireshark.org/review/26958 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-08epan: use SPDX indentifiers.Dario Lombardo1-13/+1
Skipping dissectors dir for now. Change-Id: I717b66bfbc7cc81b83f8c2cbc011fcad643796aa Reviewed-on: https://code.wireshark.org/review/25694 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-09Filter expressions: Rename UAT field to make it more obvious what it doesMichael Mann1-1/+1
"Enabling" a filter expression means putting it in the toolbar, so state that. Change-Id: Ifa4ef053cf741a5aa269031e6983c7989ca1e64c Reviewed-on: https://code.wireshark.org/review/22569 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-26Add support for comments for a display filter buttonMichael Mann1-1/+7
Add a field to the display filter button UAT to allow comments to be displayed as part of the tooltip to the diplay filter button Bug: 13814 Change-Id: I74459e4102856258d31d6429e2fd924a9f798cd5 Reviewed-on: https://code.wireshark.org/review/22390 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-26Convert filter expressions preference data to a UAT.Michael Mann1-36/+78
The filter expressions data was shoved into the preference file in a very loose, non-arrayed form. It's much easier to manage in code (and for users in a separate file) as a UAT. The GTK GUI was hacked to use the existing UAT dialog rather than rewrite the pref_filter_expressions.c to support a UAT. Should be okay since it's deprecated. Change-Id: I688cebb4b7b6594878c1398365e79a205f1902d9 Ping-Bug: 13814 Reviewed-on: https://code.wireshark.org/review/22354 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-26filter: rename shadow varDario Lombardo1-1/+1
Change-Id: Idc18f2988754fc21b1f8f2dcadfe5e3dd31d5545 Reviewed-on: https://code.wireshark.org/review/16102 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-23Plug memory leak in filter_expression_freeStig Bjørlykke1-0/+1
The list_head itself will leak in filter_expression_free(), so ensure we also free this. Change-Id: Ide6ef0c013d172b0c0120c744ce4ed46ee4321e0 Reviewed-on: https://code.wireshark.org/review/12837 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-19Get rid of the argument to filter_expression_init().Guy Harris1-9/+8
It's always TRUE. Clean up indentation while we're at it. Change-Id: I11f5b849274b68bbda4fa32a8d909d6d5e71cbb1 Reviewed-on: https://code.wireshark.org/review/12732 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-10-29Qt: Add the ability to add filter expressions.Gerald Combs1-7/+1
Add a "+" icon to the display filter toolbar which allows the addition of a new filter expression button. (Hopefully this will be the last main window UI change before 2.0.) Change-Id: I52bf56bf699dddb7b387b9f4de1bf8b35eb3c4ce Reviewed-on: https://code.wireshark.org/review/11375 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-20Clear the filter expression list in prefs.c.Gerald Combs1-0/+12
Move filter_expression_nuke from ui/gtk to epan and rename it to filter_expression_free. Call it in prefs_reset along with the other preference reset routines. This keeps the Qt filter toolbar from filling up with duplicate expressions when the profile changes. Change-Id: I9fae9a7b48944079ea342a126979d9e79af0d22b Reviewed-on: https://code.wireshark.org/review/7281 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-10-10Add editor modelines; Adjust whitespace as needed.Bill Meier1-1/+14
Change-Id: I3dc57f4c2ca57585103e3b71503ac4c332903e50 Reviewed-on: https://code.wireshark.org/review/4594 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-21Add missing includesJakub Zawadzki1-0/+1
svn path=/trunk/; revision=54332
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45016
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2011-09-08From Edwin Groothuis via bug 6207:Stig Bjørlykke1-0/+80
Added Filter Toolbar Save functionality. From me: Removed unused code. svn path=/trunk/; revision=38937
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-07 19:03:40 +0000