aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors
AgeCommit message (Collapse)AuthorFilesLines
2018-04-12Update a comment.Guy Harris1-18/+46
We don't just reassemble DOCSIS MAC frames, we reassemble other forms of higher-level packet atop an MPEG Transport Stream as well. Change-Id: If6e709a8d2d3e574fbaedb1fcac74797c5664aa5 Reviewed-on: https://code.wireshark.org/review/26905 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-12Need to flag a variable as volatile, due to the use of exceptions.Guy Harris1-3/+3
The exception mechanism is setjmp/longjmp-based, so we need to mark offset as volatile, otherwise the longjmp might not restore its value. Change-Id: Ib63070bbbbe1f16a93cb58aa7ee5ef2a5488df8a Reviewed-on: https://code.wireshark.org/review/26901 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-12If a subdissector throws an exception, catch it and continue.Guy Harris1-1/+30
That way, some exception thrown higher in the protocol stack doesn't stop us from dissecting the next TSP. Change-Id: Ib756e5d62806caf0edd4e4ded18bb94000653d39 Reviewed-on: https://code.wireshark.org/review/26897 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-11kafka: check lz4 version in a single point.Dario Lombardo1-4/+5
This allows a better check of the required version. Change-Id: I6c4aab67c73434aff4ad744caa2d0add9ec6225c Reviewed-on: https://code.wireshark.org/review/26889 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-11Netlink: Add rtnetlink attribute dissectingFilip Sohajek1-23/+396
This patch adds dissecting of several attributes in RTM_NEWLINK and RTM_NEWADDR. Change-Id: Iab476e7439a9bcbc25e70cded67bc371788baec4 Reviewed-on: https://code.wireshark.org/review/26830 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-11LPP: fix a typo in ASN.1 filePascal Quantin1-1/+1
Change-Id: Id3189b5617aff853d85029624d7e160d48dd1f36 Reviewed-on: https://code.wireshark.org/review/26896 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-11PFCP: Added dissection of IEs 127-131Matej Tkac1-12/+79
According to 3GPP TS 29.244 v15.1.0 Change-Id: Idcaad3eccf0bd5c9cc57eca5038313fd14916963 Reviewed-on: https://code.wireshark.org/review/26859 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-11user_encap: Avoid a hash lookup to get dissector nameStig Bjørlykke1-4/+4
The dissector handle is already known so it's no need to fetch this again using find_dissector(). Change-Id: Id48066ab881f2b80ec9e3a6e86bc1e41f32cd1ec Reviewed-on: https://code.wireshark.org/review/26873 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-04-11ZigBee: MGMT Unsolicited Enh NWKUpdate dissectorDana Sy3-0/+44
Added a dissector for the mgmt_nwk_unsolicited_enhanced_update_notify from the R22 spec (clusterID = 0x003b) Change-Id: I5d60ef0a762f932a7f814743d1c219428c8f9e73 Reviewed-on: https://code.wireshark.org/review/26865 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-11zbee zcl: fill constant ett arrays at declaration timeMartin Kaiser1-106/+85
This dissector defines a bunch of ett arrays, most of which contain a constant list of ett entries. Fill those arrays directly when they're declared, this is what the vast majority of other dissectors do. Fix some whitspace things while at it. Change-Id: Iae85e2449024ef04b2a44bd847c45515f8efc903 Reviewed-on: https://code.wireshark.org/review/26869 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-11zbee_zcl: (trivial) clean up decode_color_xy()Martin Kaiser1-2/+1
remove unnecessary return statement remove a wrong comment Change-Id: I40afd8144178a2cccba67289d5a3120dd5719ad0 Reviewed-on: https://code.wireshark.org/review/26868 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-11pfcp: correction of lengthJoakim Karlsson1-2/+2
flags are uint8 but the whole list was set as uint16 Change-Id: I8726fe533253fd1339351f581e7a2fe01c0edce2 Reviewed-on: https://code.wireshark.org/review/26849 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Matej Tkac <matej.tkac.mt@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-11NBSS: take into account snaplen when creating the TVB subsetPascal Quantin1-4/+1
Otherwise you can trigger an exception interrupting the packet dissection when the snaplen defined is shorter than the payload length Bug: 14598 Change-Id: Ibeb6482495ed67c7669574bdcd7c429523318428 Reviewed-on: https://code.wireshark.org/review/26858 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2018-04-11Zigbee: Decode the ZCL extension field sets in the scenes cluster.Paul Zander2-6/+286
Change-Id: Ida564e8c292819508fd2dd0fb5b650e95356459a Reviewed-on: https://code.wireshark.org/review/26852 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2018-04-10"#if 0" out some currently-unused value_strings.Guy Harris1-0/+2
Change-Id: I1535b8ec430bbf119c6cc58464da820603454265 Reviewed-on: https://code.wireshark.org/review/26862 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-10Add, and use, "fetch signed value" for lengths < 40 bits.Guy Harris23-82/+81
Add 8-bit, 16-bit, 24-bit, and 32-bit "fetch signed value" routines, and use them rather than casting the result of the 8/16/24/32-bit "fetch unsigned value" routines to a signed type (which, BTW, isn't sufficient for 24-bit values, so this appears to fix a bug in epan/dissectors/packet-zbee-zcl.c). Use numbers rather than sizeof()s in various tvb_get_ routines. Change-Id: I0e48a57fac9f70fe42de815c3fa915f1592548bd Reviewed-on: https://code.wireshark.org/review/26844 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-10NR (5G) PDCPMartin Mathieson5-1/+1786
Tested with some hand-generated PDUs. Change-Id: Ic603d0ca4578d23121e438ac2458be34e63492d2 Reviewed-on: https://code.wireshark.org/review/26755 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2018-04-10gsm_ipa: remove unnecessary if (tree) checksMartin Kaiser1-29/+21
Change-Id: I4d6bd9d296fcbd35551e3da9d60e20848865330b Reviewed-on: https://code.wireshark.org/review/26846 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-04-10RRC: upgrade dissector to v15.2.0Pascal Quantin8-3278/+4392
Change-Id: I874466e05bbc1ff11c286078b482de2f27eccf8b Reviewed-on: https://code.wireshark.org/review/26851 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-10Replace lbmpdm_fetch_uintN_encoded() with tvb_get_guintN().Guy Harris1-65/+20
They do the same thing. Change-Id: I0ff800efca9e6812ae416677023c955869bbc0cc Reviewed-on: https://code.wireshark.org/review/26850 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-10PFCP: Added dissection of new IEs 123-126Matej Tkac1-23/+174
In accordance with the latest spec - 3GPP TS 29.244 v15.1.0 Change-Id: I1267590dc25ec946f4a33b5813b1a00deff357c1 Reviewed-on: https://code.wireshark.org/review/26826 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-10The message length is unsigned, not signed; treat it as such.Guy Harris1-3/+3
Add explicit checks for values that don't fit in a gint, rather than relying on testing for < 1 catching that case. Change-Id: I4181087e3499537da88117b710d56c6b5fe9ceaa Reviewed-on: https://code.wireshark.org/review/26843 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-10Get rid of get_opaque_length() and unneeded length arguments.Guy Harris1-62/+36
In most calls to get_opaque_length(), the length is a constant, so just directly fetch the length value. In the calls in dissect_nodeid_list() and dissect_kindid_list(), the length is an argument to the routine making the call, and *those* arguments are, for each of the routines, the same constant for all calls to the routine in question, so just directly fetch the length value in those routines. This lets us avoid checks for a valid length-of-length, so we don't need to have the length-of-length be a signed value with -1 meaning "invalid". That's good, because nothing was actually *checking* for an invalid length-of-length. Change-Id: I58264c133977266f3214d6e4ca361f71ecc0b69a Reviewed-on: https://code.wireshark.org/review/26842 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-10Nb is an unsigned value; treat it as such.Guy Harris1-3/+2
Use proto_tree_add_item_ret_uint() to get its value, while we're at it. Change-Id: I734da5f588d9a89e810490d657c09b9ad2ff08dd Reviewed-on: https://code.wireshark.org/review/26841 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-10MySQL: Add initial support for command 30 (binlog dump gtid)Daniël van Eeden1-1/+7
Change-Id: I1442e401e4b5dbd07ae16bd21944bfb10f54cf53 Reviewed-on: https://code.wireshark.org/review/26833 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-09user_encap: Copy all user_encap_t valuesStig Bjørlykke1-1/+7
Copy all values for user_encap_t in user_copy_cb() when duplicating an entry in the DLT User table. Change-Id: Ic695a6213e12d42b62c2a0614c7f598e57833cdf Reviewed-on: https://code.wireshark.org/review/26827 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-09ieee80211: fixes min and max power values in item text (they are signed).Adrian Granados1-2/+2
This change further extends the fix for bug 14593 by making sure the values min, max values shown in the item's info text match the item's children values. Change-Id: Ibac39e1f21a892a02753c3cf1604ed3b14eadc52 Reviewed-on: https://code.wireshark.org/review/26832 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-09gsm_ipa: Make sure the Osmo Extended IPA stream ID type is printedHarald Welte1-6/+6
Currently, each tree item of the IPA sub-tree will only list the IPA stream identifier. However, for the osmocom-specific sub-streams, this is always "OSMO EXT", which is not very informative. Make sure the tree item states something like "OSMO EXT GSUP" or "OSMO EXT MGCP" to indicate the actual payload type based on the osmocom sub-type. Change-Id: Ic1536574c8679de778d5b3cfc680b85284d1b503 Reviewed-on: https://code.wireshark.org/review/26795 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2018-04-09iso14443: make the payload dissector configurableMartin Kaiser2-2/+13
Add an iso14443.subdissector table where other protocols can register themselves for iso14443's payload. Register iso7816 dissector in this table. Change-Id: Idb17ae014449443448ec4c64017531bc69d806b3 Reviewed-on: https://code.wireshark.org/review/26821 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-09iso14443: decode the bitrates in the attrib messageMartin Kaiser1-0/+28
Change-Id: I10bd77d72984fcf045a3c80e900c034393b444ae Reviewed-on: https://code.wireshark.org/review/26822 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-08Mark some fields as being in units of dBm.Guy Harris1-9/+9
Fix some formats to print unsigned values with %u while we're at it. Change-Id: If4a8793c77d4fbff0dd19f17e31cd18107db02ba Reviewed-on: https://code.wireshark.org/review/26810 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-08No need to display *signed* power values in hex.Guy Harris1-2/+2
Change-Id: I8356dc3c2667a7bd55d3bb75b88f7ed758cecb72 Reviewed-on: https://code.wireshark.org/review/26807 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-08Max and min transmit power, in the Power Capabilities IE, are signed.Guy Harris1-2/+2
To quote IEEE Std 802.11-2016, section 9.4.2.15 "Power Capability element": The Minimum Transmit Power Capability field is set to the nominal minimum transmit power with which the STA is capable of transmitting in the current channel, with a tolerance B1 5 dB. The field is coded as a signed integer in units of decibels relative to 1 mW. Further interpretation of this field is defined in 11.8.4. The Maximum Transmit Power Capability field is set to the nominal maximum transmit power with which the STA is capable of transmitting in the current channel, with a tolerance B1 5 dB. The field is coded as a signed integer in units of decibels relative to 1 mW. Further interpretation of this field is defined in 11.8.4. Bug: 14593 Change-Id: Ibc4e4a11d71ac1894d03d33f5762a7b0d1d70085 Reviewed-on: https://code.wireshark.org/review/26804 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-08mqtt: Add option to uncompress message when decodingStig Bjørlykke1-4/+30
Add support for uncompressing message data before dissecting based on topic. Bug: 14591 Change-Id: Ibaead205a4df791d8e903935dfd29b9b8c13ddc5 Reviewed-on: https://code.wireshark.org/review/26794 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Christopher Maynard <Christopher.Maynard@gtech.com> Tested-by: Petri Dish Buildbot
2018-04-07BSSMAP: Fix definition of Speech Version Indication for EFR (FR2)Harald Welte1-1/+1
3GPP TS 48.008 Section 3.2.2.11 is quite clear on the definitions of the "permitted speech version indication". The Wireshark BSSMAP dissector so far got it wrong: * 0x11 is "Full Rate Version 2" (aka GSM-EFR) * the short version is not FR12 but FR2 Change-Id: I6835083389e465c791cea5a240ebc434f677b82c Reviewed-on: https://code.wireshark.org/review/26790 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-07X2AP: upgrade dissector to v15.1.0Pascal Quantin9-365/+654
Change-Id: I61867f0bcd8cff1d7469e3344b2fb21f5ed3bd77 Reviewed-on: https://code.wireshark.org/review/26787 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-07ZigBee: Fixed ZDP typo from nwk addr to ext addrDana Sy1-4/+5
Fixed typos where Nwk Addr is used as a label to the extended address. Changed Nwk Addr to Ext Addr where appropriate. Change-Id: Ia7f80b07e9cbad2285810c7eb6cd31a4d25f4ff7 Reviewed-on: https://code.wireshark.org/review/26779 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-06S1AP: upgrade dissector to v15.1.0Pascal Quantin10-227/+330
Change-Id: Ib3728a35f3635b58da2a10736799fd825c34e58b Reviewed-on: https://code.wireshark.org/review/26782 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-06F1AP: upgrade dissector to v15.1.0Pascal Quantin12-1289/+4124
Change-Id: I82720a4d6a49f11165635e9cf76c6fbc1555188d Reviewed-on: https://code.wireshark.org/review/26778 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-06pdcp-lte: Various improvements spotted while reviewing pdcp-nr.Martin Mathieson1-100/+57
Prune list of possible ROHC modes. Avoid separately extracting lots of values, instead use _ret_uint variant while adding item. Change-Id: I8d75fe670fe02f1ae6c1da34b3ac6e0a22a0b894 Reviewed-on: https://code.wireshark.org/review/26777 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2018-04-06NR RRC: upgrade dissector to v15.1.0Pascal Quantin18-8868/+27958
Change-Id: If34d8627e8dee0e9dd7c1dc72701aec57df68853 Reviewed-on: https://code.wireshark.org/review/26774 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-06dissector/ptp: use BASE_OUI for organizationIdAdam Wujek1-20/+9
Bug: 14578 Change-Id: I5633a4c210da3201bb25684f276504efae9f8317 Signed-off-by: Adam Wujek <adam.wujek@cern.ch> Reviewed-on: https://code.wireshark.org/review/26749 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-06dissector/ptp: Add dissection of White Rabbit TLVAdam Wujek1-1/+383
Based on White Rabbit Specification - latest version https://www.ohwr.org/documents/160 For more information about The White Rabbit Project: http://cern.ch/white-rabbit Bug: 14578 Change-Id: Ie63a1f4ad501e0fc13fbd2205e2fcf94e175a7e4 Signed-off-by: Adam Wujek <adam.wujek@cern.ch> Reviewed-on: https://code.wireshark.org/review/23962 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-05SIP: Fix handling of response timeUli Heilmeier1-0/+1
Set p_val->request_time when we set p_val->frame_number so that response time matches request frame. Bug: 14551 Change-Id: I5f8dd9405b9b1eb61a1ca184b15d3fdc436546e1 Reviewed-on: https://code.wireshark.org/review/26762 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-05The CPU mode values might be function-dependent.Guy Harris2-5/+21
Have separate ones for function 3A and function 80. Change-Id: I44560099de269ea809092d5bc7ad88308c9082be Reviewed-on: https://code.wireshark.org/review/26767 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-05RLC-NR: fix bearerType and bearerId lengthPascal Quantin1-2/+2
Change-Id: Ib328c9ad60f22d68c0978d77d759dec0c879d41f Reviewed-on: https://code.wireshark.org/review/26765 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-05Interpretation of PCCC function codes depends on the command code value.Guy Harris2-17/+51
We can't have a single table to map function codes to names; we need separate tables for different command codes. We also can't have a single field for the function code; we need separate fields for different command codes. While we're at it, use proto_tree_add_item_ret_uint() to add the command code and function code, rather than separately fetching those values. Change-Id: Ic2646da6c6a1cae13c513874c5c003f32fce434e Reviewed-on: https://code.wireshark.org/review/26764 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-05Sort the PCCC_ES values, as required in a value_string_ext.Guy Harris2-6/+6
Change-Id: If3f093ba19cce1a69c1540518e622e4098ba82b6 Reviewed-on: https://code.wireshark.org/review/26763 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-05rpcrdma: add check to prevent null dereference (found by clang).Dario Lombardo1-1/+1
Change-Id: Iff3e3a348d40e42569135179953a957f9012fd3f Reviewed-on: https://code.wireshark.org/review/26730 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-04-05SIP: Change filter Retry-After to an FT_UINT32AndersBroman1-1/+19
Change-Id: I745d0aa390b95d42ea9ed4ea645a157677bce948 Reviewed-on: https://code.wireshark.org/review/26753 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-02 20:15:42 +0000