aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors
AgeCommit message (Collapse)AuthorFilesLines
2019-08-27DCERPC: update mdssvc DCERPC dissector from upstream SambaRalph Boehme2-99/+278
Change-Id: I13871e093b294a1865be6c47cb86275165002855 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-on: https://code.wireshark.org/review/34365 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26coap: Distinguish observe option for request and responseStig Bjørlykke3-11/+24
The observe option has different values for request and response. For request it identifies register or deregister, and for response it is a sequence number for reordering detection. RFC 7641 chapter 2. Change-Id: I09515864997a32f7259e344532ea770b74030b04 Reviewed-on: https://code.wireshark.org/review/34368 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-26coap: Improve request/response trackingStig Bjørlykke2-23/+50
Use both Token and Message ID in request/response tracking and retransmission detection. The token is the same when using observables but the message id is increasing. Change-Id: I545416ce139328e6a8eb67258d7b51bddb6b278e Reviewed-on: https://code.wireshark.org/review/34367 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-26SCTP: Use proto_tree_add_bitmask_list() for data chunk flags.Anders Broman1-11/+18
Change-Id: I9da080982d5ca85cbd3747008cd1f2b3670b6baa Reviewed-on: https://code.wireshark.org/review/34369 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26ISAKMP: Correct typos in new GDOI fieldsMichael Mann1-3/+3
Change-Id: I29872cb116dfc66c93d59b51a44161e627d3cfec Reviewed-on: https://code.wireshark.org/review/34363 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26ISAKMP: added support for GDOIGandharav Katyal1-64/+262
Bug: 15693 Change-Id: I790da95c1fa64596bd5131b491237fa084c0be49 Reviewed-on: https://code.wireshark.org/review/33382 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26NFS: Fix hash table key memory corruptionTomasz Moń1-1/+1
When the same (as determined by key_equal_func) key gets added to the GHashTable, old value gets freed and replaced with the new one. This is fine for hash tables where the key validity is not tightly coupled to the actual data. In the nfs_name_snoop_matched hash table the key becomes invalid once the value gets destroyed (because it shares the data pointed to by fh, which gets freed once the value is destroyed). A problematic capture includes packets such that the matching fh gets added twice to the nfs_name_snoop_matched hash table. Prior to this change the hash table would end up in a state where the new value is associated with the old key (which contains pointer to already freed memory). According to the nfs_name_snoop_matched_equal(), the old key was equal to the key intended for new value *at the time* of insertion. This change fixes the bug by using g_hash_table_replace() which does update the key in case it already exists in the GHashTable. Bug: 16017 Bug: 16019 Change-Id: Ib3943f1e27e82c05d9abaa1e436554b37a98488e Reviewed-on: https://code.wireshark.org/review/34360 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26SIP: Ensure session-id is not emptyMichael Mann1-6/+14
Add expert info if session-id is empty. Bug: 15951 Change-Id: I48ffe4ca26fd94f522ad1a668c99ed8f1f5e2c01 Reviewed-on: https://code.wireshark.org/review/34356 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-25show interface name in frame line caption if setMartin Fesser1-1/+8
Change-Id: Ib6cb86bc20dae9f88fdeb469983c2380bcc9216d Reviewed-on: https://code.wireshark.org/review/34335 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-08-25usb-audio: fix conflictAlexis La Goutte1-3/+3
'usbaudio.as_if_gen.bmFormats.rsv' exists multiple times with NOT compatible types: FT_UINT32 and FT_BOOLEAN Change-Id: I908b815bfa0f96f2ec421367995d971040f423a1 Reviewed-on: https://code.wireshark.org/review/34283 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-25[Automatic update for 2019-08-25]Gerald Combs1-0/+6
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I4ed4ada929881a78beefc34012a9898caa92d649 Reviewed-on: https://code.wireshark.org/review/34353 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-24ELF: do not create lots of tree items for Entry Size 1Peter Wu1-2/+4
Change-Id: Ief8db4a833099c53adb1695129d435c3b89c2680 Reviewed-on: https://code.wireshark.org/review/34347 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-24Modbus: Unit and Transaction Id for request/response identificationThomas Wiens4-28/+65
Use Unit and Transaction Identifier to identify the correct request to a response. The Transaction Identifier is only available in Modbus TCP. Bug: 15698 Change-Id: Ic3a279ce200bee9e9274aaec66bd9dc2f1c096b9 Reviewed-on: https://code.wireshark.org/review/34274 Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-24mpeg(dsmcc): Fixed range valuesAnthony Crawford1-2/+2
Fixed range values in message_discriminator_vals and rsrc_attribute_vals. Bug: 16015 Change-Id: Ib04b0be32fb8d58138913e643a38b95e64cdad7f Reviewed-on: https://code.wireshark.org/review/34344 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-08-24ELF: update e_machine table, update linksPeter Wu1-7/+33
Use HTTPS for links when possible and update the e_machine entries by post-processing a copy from the table on the website: awk -F $'\t' '$1 ~ /^EM/ && $3 ~ /./ {printf " { %3d, \"%s\" },\n", $2, $3}' Manually added the reserved entries for 182 and 184. Additionally added Linux kernel BPF (247) and C-SKY (252). Change-Id: I28ad07377a20499014437919da8e6871db2b8e59 Ping-Bug: 16016 Reviewed-on: https://code.wireshark.org/review/34346 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-08-23BLIP: Fix issues with message decompressionJim Borden1-42/+67
Due to the way the BLIP compresses its messages, it quickly falls apart when the messages are not examined exactly in order (as is the case when selecting random frames inside of a capture). The only solution I can see is to only decompress once and store the result somewhere that is persistent at the file level. Change-Id: I38c781222c8efbbcded2446ae02fa7cb57c71509 Reviewed-on: https://code.wireshark.org/review/33827 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-23Pegasus LSC: Added Status CodesAnthony Crawford1-0/+3
Comcast NGOD C1 LSC specification 'Comcast-SP-NGOD-SRM-S1C1_DSMCC-I03-100731', Page 25, Table 11, extends the list of status codes to include 0x01, 0x04, and 0x05. Change-Id: Ib208d1b409af62aa25cb5d7d6fee47ffc10dc880 Reviewed-on: https://code.wireshark.org/review/34342 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-23mpeg(dsmcc): Fix Dead StoreAlexis La Goutte1-2/+2
Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Iea244eac276f6e37590b04cfbb53c3d7c802c7ae Reviewed-on: https://code.wireshark.org/review/34320 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anthony Crawford <anthony.r.crawford@charter.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-08-22Updated EVS packet description for Compact format with bitrate.Morten Tryfoss1-9/+9
Description for packet with length 480 was incorrent (EVS Primary 24.0 instead of AMR-WB IO 23.85) Change-Id: I1625635468ce06a0057beb32d9558cbb71d6583f Reviewed-on: https://code.wireshark.org/review/34338 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-22packet-ieee1722: Added TSCF and NTSCF control frames supportDmitry Linikov1-2/+1249
Only CAN, CAN_BRIEF and LIN messages supported. Change-Id: Id79574bcdab9f1ec66390357dd5860c73f194ccc Reviewed-on: https://code.wireshark.org/review/31765 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-21GSM A DTAP: Try to ensure that global variable sccp_assoc is cleared.Anders Broman2-1/+3
Change-Id: I970e9314724c55c19d0b98578e54a5d1b598e307 Reviewed-on: https://code.wireshark.org/review/34336 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20RTCP: fix reference time typeAlexis La Goutte1-2/+2
from draft-holmer-rmcat-transport-wide-cc-extensions-01 reference time field is a Signed Integer Bug: 16007 Change-Id: I5686e43f2817b626ef45b07dd9fcec0c9bcc1cfb Reviewed-on: https://code.wireshark.org/review/34330 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20Kafka: include zstd compression in Kafka message batchesPiotr Smolinski1-0/+42
Change-Id: I1d06486ccf7b174ee9aa621fa3d8acb8b3673777 Reviewed-on: https://code.wireshark.org/review/34222 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20SCTP: Make association amalysis a prference defaulting to FALSE.Anders Broman1-32/+43
Association analysis causes long loops if there is a lot off associations or IMIT ABORTS. On a 679K packets trace loading with amalysis takes 3.31.660 without 0.3.275. The culprit is the for loop in find_assoc_index(). Change-Id: I07ae0e826c08aded3eb0e7dc3474dcf5cdd556f9 Reviewed-on: https://code.wireshark.org/review/34333 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20Kafka: fix the name shadowingPiotr Smolinski1-4/+8
Post-merge fix. Change-Id: I712d275f90c5a1e425865654143ead7c3a04998b Reviewed-on: https://code.wireshark.org/review/34332 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20Kafka: add support for Kafka 2.3+ dissectionPiotr Smolinski1-516/+5318
Existing Apache Kafka support in Wireshark ends at version 0.10. The version 0.11 (June 2017) brought significant changes to the message format. This change makes the Wireshark Kafka dissector obsolete. The recently released Kafka 2.3 has a lot of additions to the wire protocol, which should be also addressed. Major changes: * Applied Kafka protocol changes since 0.10 * Zstd-packed message decompression (since Kafka 2.1) * Added support for Kafka over TLS decryption Bug: 15988 Change-Id: I2bba2cfefa884638b6d4d6f32ce7d016cbba0e28 Reviewed-on: https://code.wireshark.org/review/34224 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20ZigBee OTA: Fix GetProfileResponse end time decodingMartin Boye Petersen1-1/+5
Added missing time offset to GetProfileResponse end time. Change-Id: I47f31cea709ccc600c9ea182c4bf6cf96410ff78 Reviewed-on: https://code.wireshark.org/review/34322 Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20USBLL: Use custom address dissector instead of usb oneKrzysztof Opasiak1-25/+142
Usage of USB address dissector creates several challenges. In order to improve user experience let's create a custom address dissector. This allows us to not only drop the busid parameter but also replace endpoint parameter with hub port for SPLIT transactions. The address may be one of 3 forms: - host - <device address>.<endpoint> - <hub address>:<hub port> (for SPLIT transactions) This also adds 3 new fields (source, destination and addr) with exactly the same meaning as in usb. It also renames current addr field to device_addr. Strongly based on initial work by: Maciej Purski <maciej.purski@gmail.com> Ping-Bug: 15908 Change-Id: I5702295d7ef9076c3e0373de35ea4ac3cb2a0709 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Reviewed-on: https://code.wireshark.org/review/34279 Reviewed-by: Tomasz Moń <desowin@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-19MB-34017: Add HCS to SnapshotMarkerBen Huddleston1-7/+7
Add the optional HCS field to the snapshot marker (only send on when non-zero for disk snapshots). Also, remove the durability timeout field from DCP_PREPARE as it is not sent and the UI warns about invalid extras length. Change-Id: I46955e2a719d28a70377bc6addb65fa3356ea1d4 Reviewed-on: https://code.wireshark.org/review/34323 Reviewed-by: Jim Walker <jim@couchbase.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-19NAS 5GS: decode LPP payloadPascal Quantin1-0/+7
Change-Id: I086370088e9ecf56e0871e2dbedb367a23633ce7 Reviewed-on: https://code.wireshark.org/review/34326 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-19tds: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
Change-Id: I948f9cc9ef22798fd5e24d078e4749cb68548aec Reviewed-on: https://code.wireshark.org/review/34319 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-19EAP: use new tls_set_appdata_dissector API to set the dissectorPeter Wu1-5/+5
Passing the appdata dissector via the data parameter caused crashes due to type confusion, use an alternative, indirect method instead. Change-Id: I1de3de4e7daf4504c176a6ad8947037606aa20bb Depends-On: I4770d03f912dd75f92878dd74ad830ebb7eb1431 Reviewed-on: https://code.wireshark.org/review/34312 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-19TLS: add mechanism to set the TLS appdata protocolPeter Wu2-10/+37
For use by EAP-TTLS which embeds TLS. Change-Id: I4770d03f912dd75f92878dd74ad830ebb7eb1431 Reviewed-on: https://code.wireshark.org/review/34311 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-19obd-ii: Add support for decoding 29bit query and responsesjfp_martin1-13/+82
This patch adds support for decoding 29bit CAN IDs. Much of the existing code was in place for handling 29bit IDs but lacked the ability to check for the correct 29bit request and response IDs. This patch adds that ability and correctly selects for use of either 11bit or 29bit CAN IDs. Change-Id: I7cf10a56aa93d951c3ffa45734139689b3f3af4c Reviewed-on: https://code.wireshark.org/review/34297 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-18mswsp: check pipe name in case insensitive mannerJiajun Wang1-1/+1
Change-Id: I33cde794a3a7314247b46b6e8fded6ee528450cc Reviewed-on: https://code.wireshark.org/review/34304 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-17ZigBee: Replace AT_STRINGZ with a dedicated address typeKenneth Soerensen1-24/+43
Change-Id: If9bdc776e249e969f76fdbf86313e7095266ae66 Reviewed-on: https://code.wireshark.org/review/34251 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-08-17MAC-NR: replace the SFN/SF timestamp by SFN/SlotPascal Quantin2-13/+48
A subframe number is not as useful as in LTE due to the different sub-carrier spacing in NR; use the slot number instead. While we are at it, uniformize a bit the label and info display. Change-Id: I432546ab38b07e7f256493ece25595a10613841d Reviewed-on: https://code.wireshark.org/review/34314 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-17Revert "TLS: allow dissectors to set the appdata protocol via the data param"Peter Wu1-15/+5
This reverts commit ede7be3440689cee51489361934704467f2b2ffb. The TLS dissector can be called via multiple entrypoints. It could be called directly (the EAP-TTLS/EAP-PEAP case with an explicit dissector name), but also through dissector tables. The TCP and SCTP dissectors however pass a data parameter of a different type, resulting in crashes due to type confusion. Change-Id: I1d21cb5e31eb09689970ff3bdc7a63c6b7965d49 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=16442 Link: https://www.wireshark.org/lists/wireshark-dev/201908/msg00037.html Reviewed-on: https://code.wireshark.org/review/34310 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-08-16DNS: fix bytes highlight for name length and labels countPascal Quantin1-2/+2
Those generated fields are linked to the dns.qry.name field, so highlight the same bytes. Bug: 15999 Change-Id: Ia989b79a9ec14140472b79fdf7acea6e67baee68 Reviewed-on: https://code.wireshark.org/review/34299 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-15Pegasus LSC: LSC_DONE updated to send Status Code fieldAnthony Crawford1-14/+14
LSC_DONE messages should dissect the Status Code field. Status Code provides error code information to client devices. Bug: 15997 Change-Id: I40f3b2835189047ee428cfc8376065c5eaff6eb4 Reviewed-on: https://code.wireshark.org/review/34280 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-15Diameter: Add MS-CHAP/MS-CHAPv2 AVP support for EAP-TLSPeter Wu1-0/+12
Created the Microsoft Diameter file based on MS-CHAP-* AVPs listed at https://www.iana.org/assignments/eap-numbers/eap-numbers.xhtml#eap-numbers-10 Many values are displayed as bytes for simplicit. The MS-CHAP2-Success attribute could for example be dissected further as 1 byte followed by a string, but that requires more effort. Allow padding to be missing since the eap-ttls-mschapv2.pcapng capture would throw a Malformed Packet exception otherwise. Bug: 15603 Change-Id: I9efc322a86802e78bb6cd4bc3df1c1282a45fe9e Reviewed-on: https://code.wireshark.org/review/34291 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-15EAP: add support for EAP-PEAPPeter Wu1-0/+3
Tested with the three captures from the linked bug: eap-peap-gtc.pcapng, eap-peap-md5.pcapng, eap-peap-mschapv2.pcapng. Bug: 15597 Change-Id: Idb1fb2809d05648a3b961af8dbdd9b35c3284c13 Reviewed-on: https://code.wireshark.org/review/34294 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-15EAP, Diameter: add EAP-TTLS and EAP-Message dissection supportPeter Wu2-53/+116
Add support for dissecting the decrypted TLS payload as Diameter. Add support for dissecting the EAP-Message attribute as EAP. Disable retransmission detection when EAP-Message is detected (EAP in TLS in EAP) since this results in false positives. Tested with captures from Bug 15603: * eap-ttls-pap.pcapng - ok, User-Name and User-Password AVPs. * eap-ttls-eap-gtc.pcapng, eap-ttls-eap-md5.pcapng - EAP-Message AVP. * eap-ttls-mschapv2.pcapng - partially supported, does not conform to Diameter AVP requirements as it is not padded. Microsoft vendor types are also not yet supported. To be fixed later. * eapttls-diameter-avp.pcapng (Bug 12880) - EAP-Message AVP. Bug: 12880 Bug: 15603 Change-Id: Ie7ea282d05c1d3ff8463c34bf259107562714440 Reviewed-on: https://code.wireshark.org/review/34281 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-15TLS: allow dissectors to set the appdata protocol via the data paramPeter Wu1-5/+15
For use by EAP-TTLS which knows the next protocol that must be set. Similar to the ssl_starttls functions, but simpler as the caller does not switch the transport protocol to TLS. Change-Id: Idadb6f33e5e1182bf7b3b0b5134df9af2717a592 Reviewed-on: https://code.wireshark.org/review/34293 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-15EAP: show expert info for bad EAP lengthsPeter Wu1-2/+7
The EAP length field must cover at least Code (1 byte), ID (1 byte), Length (1 byte) and not have missing data afterwards. Bug: 14406 Change-Id: I829e2aa33e5f286d55d2e8249457e118e7c3ebcc Reviewed-on: https://code.wireshark.org/review/34292 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-14Try to fix Wpointer-sign warnings.Anders Broman11-63/+63
Change-Id: I52d24560d4061c996c25b290ee347cc55404c216 Reviewed-on: https://code.wireshark.org/review/33914 Tested-by: Petri Dish Buildbot Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-08-14MPEG DSM-CC: Added U-N Session MessagesAnthony Crawford1-223/+2309
ISO/IEC 13818-6 DSM-CC section 4 U-N Session messages have been added. Bug: 15994 Change-Id: I76e65e9feabe54809184a446b160367e9f520ec1 Reviewed-on: https://code.wireshark.org/review/34258 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-14f5ethtrailer: fix type descripter in dissector table registrationJason Cohen1-2/+2
Bug: 15996 Change-Id: Ic6f616a0a0461adca6e44f8c5a0c20b0083ead1a Reviewed-on: https://code.wireshark.org/review/34286 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-08-14EAP: rename some identity fieldAlexis La Goutte1-2/+2
Bug: 15991 Change-Id: Ie180f4d8e018e31a138bfaf526fc8538d110901c Reviewed-on: https://code.wireshark.org/review/34285 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-14Add dissector for OsmoTRX protocolHarald Welte2-0/+724
This protocol is a non-standard, ad-hoc protocol to pass baseband GSM bursts between the modem (osmo-trx) and the encoder / decoder (osmo-bts-trx). Osmocom inherited this when forking OsmoTRX off the OpenBTS "Transceiver" program. Change-Id: I31f5071d08eff1731f1d602886e204c87eed107c Related: OS#4081 (https://osmocom.org/issues/4081) Bug: 14814 Reviewed-on: https://code.wireshark.org/review/26796 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Dario Lombardo <lomato@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-18 18:47:41 +0000