aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/pidl
AgeCommit message (Collapse)AuthorFilesLines
2017-05-05tnef: fix conflicting entry in its value_stringAlexis La Goutte1-1/+1
Field 'Type' (tnef.property.tag.type) has a conflicting entry in its value_string: 4126 is at indices 24 (PT_MV_STRING8) and 25 (PT_MV_TSTRING)) Change-Id: I306ba69b954f22781bbafe4400993d73c9be5811 Reviewed-on: https://code.wireshark.org/review/21511 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-05mapi: fix conflicting entry in its value_stringAlexis La Goutte1-1/+1
Field 'Value' (mapi.SPropValue.value) has a conflicting entry in its value_string: 4126 is at indices 24 (PT_MV_STRING8) and 25 (PT_MV_TSTRING)) Field 'Value' (nspi.SPropValue.value) has a conflicting entry in its value_string: 4126 is at indices 24 (PT_MV_STRING8) and 25 (PT_MV_TSTRING)) Change-Id: Icc1060804ced2887a34ffe81cf473fbe8154ce18 Reviewed-on: https://code.wireshark.org/review/21510 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-10Rename tvb_new_subset() to tvb_new_subset_length_caplen().Guy Harris3-4/+4
This emphasizes that there is no such thing as *the* routine to construct a subset tvbuff; you need to choose one of tvb_new_subset_remaining() (if you want a new tvbuff that contains everything past a certain point in an existing tvbuff), tvb_new_subset_length() (if you want a subset that contains everything past a certain point, for some number of bytes, in an existing tvbuff), and tvb_new_subset_length_caplen() (for all other cases). Many of the calls to tvb_new_subset_length_caplen() should really be calling one of the other routines; that's the next step. (This also makes it easier to find the calls that need fixing.) Change-Id: Ieb3d676d8cda535451c119487d7cd3b559221f2b Reviewed-on: https://code.wireshark.org/review/19597 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-10-27wkssvc(dcerpc): fix spelling typo found by lintianAlexis La Goutte1-1/+1
Change-Id: I899cd6fd108ff7fe3ec8908e8cd575c2dc520735 Reviewed-on: https://code.wireshark.org/review/18504 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-09add clusapi (Windows Cluster Management API) from Samba git tree.Günther Deschner4-0/+2661
We avoid compiling clusapi_PROPERTY_LIST using pidl. This struct contains inline arrays and is not strictly needed by clusapi therefor disable it. Change-Id: I86efa0c725667083cb252e5df3bfc69118df3059 Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-on: https://code.wireshark.org/review/16719 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-22Convert more glib memory to wmem pinfo poolPascal Quantin2-6/+4
Change-Id: I4cc23bc19a6bd8c6a8e0389eaf939dbb60fe0ca3 Reviewed-on: https://code.wireshark.org/review/16562 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-05Rename PIDL MakefileJoão Valverde2-1/+1
Otherwise it will get overwritten by the in-tree cmake build. Issue reported by Rémy Léone. Change-Id: I0d908973386bcb70585f5e32c36456230967bb7f Reviewed-on: https://code.wireshark.org/review/16305 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-19cmake: add PIDL dissector generation supportPeter Wu2-0/+170
The dissectors list is generated based on regex magic on pidl/Makefile. A dssetup.cnf file is added because all other protocols already have this file. The srvsvc and wkssvc protocols cannot be built for some reason, so just disable it (this mirrors the original Makefile). Add frsrpc and samr to PIDL_DISSECTOR_SRC list which was missing compared to autotools. Tested with an out-of-tree and in-tree build with cmake (make and ninja): cmake -GNinja && ninja -v pidl-dissectors touch epan/dissectors/pidl/dfs/dfs.idl && ninja generate_dissector-dcerpc-dfs cmake . && make -C epan/dissectors/pidl generate_dissector-dcerpc-dfs Change-Id: Id8bf34e76c20053a8a393024560d90a048473e03 Reviewed-on: https://code.wireshark.org/review/15962 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-18DCE/RPC: fix array of pointers with NULLBinh Trinh3-10/+20
Change-Id: Ie89f8fd4ec744d427d41866206d5a6784c5b224f Reviewed-on: https://code.wireshark.org/review/16004 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-16DCE/RPC proto_tree_add_boolean -> proto_tree_add_bitmask_valueMichael Mann3-76/+116
Change-Id: I88398aa1923e86bb83b97cc3904529a5810f6c40 Reviewed-on: https://code.wireshark.org/review/15978 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-02Revert "PIDL: Remove _U_ and remove unused-parameter via pragma"Guy Harris8-55/+55
This reverts commit db4f7fcdeac833f24807994b372d1e42479754bf. That doesn't work with the compiler being used on the OS X buildbot; that compiler is probably some version of llvm-gcc, which might be based on an older version of GCC without support for that pragma, or might not support it properly courtesy of the GCC front end and the LLVM back end not quite fitting together Change-Id: I6cd5f1322b4872ef0c4eb5695f021cec00ba85b7 Reviewed-on: https://code.wireshark.org/review/15246 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-05-02PIDL: Remove _U_ and remove unused-parameter via pragmaAlexis La Goutte8-55/+55
Change-Id: Ic40f86850dc94338a8c2205e04679793f368672f Reviewed-on: https://code.wireshark.org/review/14967 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-25Remove .gitignore file in pidl folderJoão Valverde1-1/+0
Otherwise it will end up in the source distribution tarball. Change-Id: Ieeafd5dbaebe3930c3769bfcbce538da5d36b7d3 Reviewed-on: https://code.wireshark.org/review/14624 Reviewed-by: João Valverde <j@v6e.pt>
2016-03-24Add basic PIDL MakefileJoão Valverde48-3754/+162
Change-Id: I8f4c8e312df73b70f3cacd0df768375b46197ae6 Reviewed-on: https://code.wireshark.org/review/14507 Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-06MAPI (dcerpc): fix no previous prototype for 'mapi_dissect_struct_request' / ↵Alexis La Goutte1-5/+5
'mapi_dissect_struct_EcDoRpc_MAPI_REQ' [-Wmissing-prototypes] Change-Id: If5ff7835f931213f1b846776a3ea9dfa6a1952b1 Reviewed-on: https://code.wireshark.org/review/14352 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-24Add the packet number to the packet_info structure, and use it.Guy Harris2-2/+2
That removes most of the uses of the frame number field in the frame_data structure. Change-Id: Ie22e4533e87f8360d7c0a61ca6ffb796cc233f22 Reviewed-on: https://code.wireshark.org/review/13509 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-11-03packet-dcerpc-witness: initial implementation based on the idl file from sambaGregor Beck2-0/+355
See [MS-SWN], https://msdn.microsoft.com/en-us/library/hh536748.aspx Change-Id: Ie92dad2c229ec08e7f7e31be9422450305b3908a Signed-off-by: Gregor Beck <gbeck@sernet.de> Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-on: https://code.wireshark.org/review/11366 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-14Correct eventlog.eventlog_OpenEventLogW.Module dissection by providing ↵Michael Mann1-14/+1
lsa_String type in .cnf There seem to be multiple definitions of an "lsa_String" depending on the DCE/RPC dissector, so change was made just in EventLog. Bug: 10264 Change-Id: I32e97c2a537b01d3bfe9dd03452b8ee1af4d1c2e Reviewed-on: https://code.wireshark.org/review/9598 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-06-23Remove deprecated tvb_length from PIDL dissectorsEvan Huus4-7/+7
Also regenerate all to pick up the usage of https in some comment links. Change-Id: Ic17b6368d2118627178b0b560031450d98e5b5e5 Reviewed-on: https://code.wireshark.org/review/9060 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-10-12PIDL (DCERPC misc): enhance dissectorAlexis La Goutte1-28/+1
* Fix -Wunused-function (Set NOEMIT winreg_Data and remove unused function) * Remove dissector DCERPC misc from DIRTY list Change-Id: If59b14f8db33354a2d5248e8bc256cadee3ea4bf Reviewed-on: https://code.wireshark.org/review/4345 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-29PIDL (DCERPC mapi): enhance dissectorAlexis La Goutte2-14/+2
Correctly regenerate mapi dissector (launch via make in pidl/mapi folder) * Fix -Wunused-variable (fix in request/response.cnf files) * Fix trailing whitespace Not yet ready to remove from DIRTY list (there is always some warning about unused tree) Change-Id: I9759202e320e90f0cb91db5c7dd9650ff62bbadd Reviewed-on: https://code.wireshark.org/review/4347 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-29PIDL (DCERPC mdssvc): enhance dissectorAlexis La Goutte1-0/+2
* Fix -Wunused-function (Add functions to mdssvc.cnf with NOEMIT) * Remove dissector DCERPC mdssvc from DIRTY list Change-Id: Ic097b0067a44fcfd9298ace1abeb7ca8f0daf00b Reviewed-on: https://code.wireshark.org/review/4346 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-28PIDL (DCERPC lsa): enhance dissectorAlexis La Goutte1-16/+10
* Fix -Wunused-function (Add functions to lsa.cnf with NOEMIT) * Remove also some MANUAL function (no unused too..) * Remove dissector DCERPC lsa from DIRTY list Change-Id: I7b7f924f244757207f378b8650b8dd30e739da08 Reviewed-on: https://code.wireshark.org/review/4325 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-28PIDL (DCERPC eventlog): enhance dissectorAlexis La Goutte1-1/+2
* Fix -Wunused-function (Add functions to eventlog.cnf with NOEMIT) * Remove dissector DCERPC eventlog from DIRTY list Change-Id: I29710ce4f548a6e4d9bf1dd6e652acf1eeaddf2c Reviewed-on: https://code.wireshark.org/review/4324 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-28PIDL (DCERPC dnsserver): enhance dissectorAlexis La Goutte1-0/+5
* Fix -Wunused-function (Add functions to dnsserver.cnf with NOEMIT) * Remove dissector DCERPC dnsserver from DIRTY list Change-Id: Id1d4f43784bfbf417156353fd3254375365c35c8 Reviewed-on: https://code.wireshark.org/review/4323 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-28PIDL (DCERPC winreg): enhance dissectorAlexis La Goutte1-6/+3
* Fix PIDL generator for NOEMIT Element (fix -Wunused-function for DCERPC winreg dissector) * Fix indent (use tabs) * Remove DCERPC winreg dissector from DIRTY list Change-Id: I5d16cbfe8481a5e5f7e5df9b51735c93ae4375a7 Reviewed-on: https://code.wireshark.org/review/4322 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-27PIDL: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-1/+0
Change-Id: I7f6f974732b7905f4ea4686e1a79ca6fbef78fa8 Reviewed-on: https://code.wireshark.org/review/4319 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-09-27"declare" apparently isn't a valid keyword; use typedef instead.Guy Harris2-3/+3
These changes came from the versions of those files at the tip of the Samba trunk, and fix the failures to compile with pidl. Change-Id: Ifc3276d4bc2ff1cfdb19819811f5b8d1b91961b5 Reviewed-on: https://code.wireshark.org/review/4329 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-26Note that errors are generated for dnsserver.idl and eventlog.idl.Guy Harris1-2/+6
Also fix a typo. Change-Id: Id0713fbb722e88a911cae4ef4371b528fe73e048 Reviewed-on: https://code.wireshark.org/review/4321 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-20Restore the inclusion of request.cnf.c and response.cnf.c in the generated ↵Michael Mann3-95/+76
DCE/RPC MAPI dissector. Also remove the use of proto_tree_add_text for something filterable. Change-Id: I7c252fb24f5ab51e4d1913fe3b0e520a4150baec Reviewed-on: https://code.wireshark.org/review/4214 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-20proto_tree_add_text -> proto_tree_add_subtree[_format] for DCE/RPC dissectors.Michael Mann3-8/+4
Change-Id: I84755d059ef70ca98b0e7626b6425360daf0529d Reviewed-on: https://code.wireshark.org/review/4199 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-19Update generated DCE/RPC dissectors.Michael Mann8-72/+10
Now all generated dissectors can successfully compile. Change-Id: I74728926915d5a9f1694cc49c753b80f213df767 Reviewed-on: https://code.wireshark.org/review/2598 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-08Fix automatic generation of the dcerpc-eventlog dissector.Jeff Morriss3-21/+16
The problem described in the README is simply because the conformance file hadn't been updated. Remove trailing white space from the .idl and .cnf files. Change-Id: I778f206aa103e5f60574fe2c5c699597969dc644 Reviewed-on: https://code.wireshark.org/review/4042 Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-07-31Add more files to the release tarball.Guy Harris1-0/+4
Change-Id: I02ce275154979ff56f8f8929e5909f3035f62c47 Reviewed-on: https://code.wireshark.org/review/3286 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Revert "Update PIDL source files with the API changes done in g021e7af"Pascal Quantin4-7/+7
This reverts commit e09d127a9a08b587903a957145d3df655b190954. Change-Id: Id34b9f5875b1d63aaeed96b3ffdc8ece63ab4134 Reviewed-on: https://code.wireshark.org/review/2436 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-18Update PIDL source files with the API changes done in g021e7afPascal Quantin4-7/+7
Change-Id: I2917cbae077865f9ec171900810f85f54b349c2c Reviewed-on: https://code.wireshark.org/review/2394 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-09Fix some C++ warnings about implicit casts.Guy Harris2-2/+2
Change-Id: I19730e723700f0cc7dcc7ba0db2689f076c7bb5b Reviewed-on: https://code.wireshark.org/review/1034 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-04-06Apply found fix-encoding-args.pl errors in the dissector directory.Michael Mann3-8/+8
I coincidentally found a few files with errors, so I thought it might be time to run it on the whole directory again. Change-Id: Ia32e54b3b1b94e5a418ed758ea79807c8bc7e798 Reviewed-on: https://code.wireshark.org/review/978 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-04-06Bugfix AFP dissection within MDSSRV. Part of bug 9950.Michael Mann1-1/+1
Change-Id: Ibe2aa48284fe7a507133f5b70a22110bb3bb56cb Reviewed-on: https://code.wireshark.org/review/973 Reviewed-by: Ralph Böhme <rb@sernet.de> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-04-04New DCE/RPC MDSSVC dissector. Bug 9950Michael Mann2-0/+83
Change-Id: I8832c139938e767de71b2cc74ca41208f509e478 Reviewed-on: https://code.wireshark.org/review/959 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-31Continue to remove $Id$ from top of fileAlexis La Goutte2-4/+0
(Using sed : sed -i '/^\# \$Id\$/,+1 d') (start with dash) Change-Id: Ia4b5a6c2302f6a531f6a86c1ec3a2f8205c8c2dd Reviewed-on: https://code.wireshark.org/review/881 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-31Continue to remove $Id$ from top of fileAlexis La Goutte4-8/+0
(Using sed : sed -i '/^ \$Id\$/,+1 d') (No star only 2 spaces before) Change-Id: Id7b254031769a9dca2941304e4d3a0f4bdbc3f54 Reviewed-on: https://code.wireshark.org/review/883 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-05Introduce end-of-line normalizationPascal Quantin1-1/+1
Change-Id: Ie6991af2432b193fbdc23bbbd335f83c091f14e8 Reviewed-on: https://code.wireshark.org/review/114 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-01-21Get rid of tvb_get_faked_unicode() - tvb_get_string_enc() does the jobGuy Harris1-36/+12
better. We don't need eventlog_get_unicode_string_length() in the eventlog dissector, either - tvb_unicode_strsize() does the job just as well. svn path=/trunk/; revision=54874
2014-01-13lsarpc_dissect_sec_desc_buf() and lsarpc_dissect_struct_dom_sid2() areGuy Harris1-2/+11
used in the Netlogon dissector, so don't make them static. Now that we've added HEADER START/HEADER END to Pidl, use it to declare those routines in packet-dcerpc-lsa.h. Don't declare them in packet-dcerpc-netlogon.c, as they're now declared in the header. svn path=/trunk/; revision=54723
2014-01-13Make routines not used outside packet-dcerpc-lsa.c static.Guy Harris1-3/+3
svn path=/trunk/; revision=54712
2013-12-15Fix a cut-and-pasteo.Guy Harris1-1/+1
svn path=/trunk/; revision=54111
2013-11-24Note that I've filed a Samba bug for one of the problems.Guy Harris1-1/+33
svn path=/trunk/; revision=53555
2013-11-24Actually, the "1632" types do exist, and are 16-bit for NDR and 32-bitGuy Harris1-2/+9
for NDR64, and we handle them. The real problems are elsewhere. svn path=/trunk/; revision=53543
2013-11-24These are two of the problems that pidl has with dfs.idl.Guy Harris1-4/+2
svn path=/trunk/; revision=53542
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-31 04:26:50 +0000