aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-spice.c
AgeCommit message (Collapse)AuthorFilesLines
2014-07-09convert to proto_tree_add_subtree[_format]Michael Mann1-140/+70
Change-Id: I8d66b1bc7dbdfee3d4bf6fd3b3c21c6323b66f44 Reviewed-on: https://code.wireshark.org/review/2946 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-20Rename dissector_add_handle() to dissector_add_for_decode_as().Guy Harris1-1/+1
Hopefully that name makes it clear what the routiner's purpose is, and will encourage people to use it rather than using dissector_add_uint() with a bogus integer value. Change-Id: Ic5be456d0ad40b176aab01712ab7b13aed5de2a8 Reviewed-on: https://code.wireshark.org/review/2483 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-7/+7
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-7/+7
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-3/+3
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-06Apply found fix-encoding-args.pl errors in the dissector directory.Michael Mann1-1/+1
I coincidentally found a few files with errors, so I thought it might be time to run it on the whole directory again. Change-Id: Ia32e54b3b1b94e5a418ed758ea79807c8bc7e798 Reviewed-on: https://code.wireshark.org/review/978 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-10- Forward declaration of register functions.Anders Broman1-4/+7
svn path=/trunk/; revision=53918
2013-11-23Create the ability to have packet scoped "proto" data. Bug 9470 ↵Michael Mann1-2/+2
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9470) I'm not sold on the name or module the proto_data functions live in, but I believe the function arguments are solid and gives us the most flexibility for the future. And search/replace of a function name is easy enough to do. The big driving force for getting this in sooner rather than later is the saved memory on ethernet packets (and IP packets soon), that used to have file_scope() proto data when all it needed was packet_scope() data (technically packet_info->pool scoped), strictly for Decode As. All dissectors that use p_add_proto_data() only for Decode As functionality have been converted to using packet_scope(). All other dissectors were converted to using file_scope() which was the original scope for "proto" data. svn path=/trunk/; revision=53520
2013-10-23#if 0 numerous "unused const variables" (mostly value-string-arrays);Bill Meier1-1/+4
Also; fix a few "set but not used" warnings. svn path=/trunk/; revision=52780
2013-10-21Update spice protocol dissector. Bug 9143 ↵Michael Mann1-888/+1094
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9143) From Jonathon Jongsma Note that the new packet-spice.h is auto-generated outside of Wireshark. svn path=/trunk/; revision=52737
2013-09-22More emem -> wmem conversion:Pascal Quantin1-1/+1
- tvb_get_g_stringz()/tvb_get_ephemeral_stringz()/tvb_get_seasonal_stringz() -> tvb_get_stringz() - tvb_get_g_stringz_enc()/tvb_get_ephemeral_stringz_enc() -> tvb_get_stringz_enc() - tvb_get_ephemeral_unicode_stringz() -> tvb_get_unicode_stringz() - tvb_bcd_dig_to_ep_str() -> tvb_bcd_dig_to_wmem_packet_str() - update docs accordingly svn path=/trunk/; revision=52180
2013-09-12More wmem.Evan Huus1-3/+3
svn path=/trunk/; revision=51968
2013-05-27Batch of filterable expert infosMichael Mann1-1/+11
svn path=/trunk/; revision=49600
2013-05-12Add the posibillity to use a key for per-packet-data.Anders Broman1-2/+2
svn path=/trunk/; revision=49259
2013-04-24Convert a few proto_tree_add_text to proto_tree_add_items. The dissector ↵Michael Mann1-23/+98
was originally under the 50% mark that checkAPIs.pl like, but subsequent patches pushed it over the limit, so I thought I'd knock it back down. svn path=/trunk/; revision=49023
2013-04-16remove unused structs and definesMartin Kaiser1-31/+0
(the unnamed union caused a compiler warning on fedora 14) svn path=/trunk/; revision=48886
2013-03-19From beroset:Anders Broman1-3/+3
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48430
2012-12-26Fix a bunch of warnings.Guy Harris1-24/+24
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-10-14Minor changes:Bill Meier1-97/+102
- Init COL_PROTOCOL before fetching from tvb; - Remove some unneeded variable initializers; - Localize some variables; - Misc including whitespace revisions. svn path=/trunk/; revision=45537
2012-10-14remove unused variable; fixes compile error.Bill Meier1-1/+0
svn path=/trunk/; revision=45536
2012-10-14From Yaniv Kaul: Spice protocol fixes and enhancementsBill Meier1-40/+167
- Dissection of monitors config message (SPICE_DISPLAY_MONITORS_CONFIG message) - Better dissection of capabilities (added several more capabilities for main and display channels) From me: - Remove (now) unused variables. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7859 svn path=/trunk/; revision=45534
2012-10-11Change 'for (i=1; i<=n;...' to 'for (i=0; i<n; ...)Bill Meier1-1/+1
The changes fix definite problems or are done "just in case" for cases not esily determined to be a problem by quick inspection. Note: in some cases for loop index variables have been renamed to ensure all required codes changes detected. ##backport svn path=/trunk/; revision=45477
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-3/+3
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-08-01remove unnecessary underscores from display filtersMichael Mann1-1/+1
svn path=/trunk/; revision=44181
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-05-17Fix spice.common_cap_byte1 filter I changed by mistake in r42664pascal1-6/+6
svn path=/trunk/; revision=42675
2012-05-16Use BASE_DEC for spice.common_cap_byte1. (Hopefully that's correct.)Gerald Combs1-3/+2
svn path=/trunk/; revision=42668
2012-05-16From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7264 :pascal1-15/+60
Enhance the Spice dissector to deal with sized data streams and playback data From me: fix a few hf entries svn path=/trunk/; revision=42664
2012-04-26Fix some "conflicting" value_string warnings.Jakub Zawadzki1-3/+3
copy & paste errors, not 0-terminated value_string arrays, etc. svn path=/trunk/; revision=42260
2012-04-18From Yaniv Kaul:Anders Broman1-11/+63
Enhance the Spice dissector to dissect KEY_DOWN, KEY_UP, {RECORD|PLAYBACK}_{VOLUME|MUTE} https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7133 svn path=/trunk/; revision=42130
2012-04-16From Evan Huus:Anders Broman1-1/+0
Duplicate and misplaced 'break' statements. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7106 svn path=/trunk/; revision=42091
2012-04-13Remove doubled semicolons and semicolons outside function.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=42053
2012-03-21'tab-width/tabstop/tabSize' in editor modelines should really always be 8;Bill Meier1-131/+137
Also: In some cases do some whitespace cleanup and some minor reformatting. svn path=/trunk/; revision=41724
2012-03-20From Yaniv Kaul:Anders Broman1-1/+42
Enhance the Spice dissector to deal with VM name and UUID messages. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6971 svn path=/trunk/; revision=41686
2012-02-23From Yaniv Kaul:Anders Broman1-43/+98
Enhance the Spice dissector - small additional dissections. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6857 svn path=/trunk/; revision=41150
2012-01-25Use a bitwise & when checking with a mask.Michael Tüxen1-1/+1
svn path=/trunk/; revision=40720
2012-01-23From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6743 :Jeff Morriss1-12/+19
The dissection [added with the previous patch on this bug] was not complete. Attaching a diff on top of the existing SVN to properly dissect small packets with mini header. svn path=/trunk/; revision=40666
2012-01-18From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6743Alexis La Goutte1-67/+132
[PATCH] Enhance the Spice dissector to deal with mini headers Spice recently gained the ability to use smaller packet headers. This patch adds support to it, along with small other fixes/enhancements - none of which really interesting. From me : Fix a Clang Warning : packet-spice.c:1303:5: warning: Value stored to 'offset' is never read svn path=/trunk/; revision=40573
2011-12-13Prevent memory leakage of uncompress tvb and associated data buffer (step 1).Bill Meier1-1/+1
(tvb memory leak will actually remain until a bug in tvbuff.c is also fixed). svn path=/trunk/; revision=40171
2011-11-29Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-22/+13
svn path=/trunk/; revision=40041
2011-11-27Various Minor cleanup:Bill Meier1-43/+93
- Remove unneeded #includes; - Use val_to_str_const() in several places; - Reformat long lines; - Fix whitepace and indentation. svn path=/trunk/; revision=40016
2011-11-21'dissect_ImageLZ_JPEG()' is apparently not used; #if 0 the code for now.Bill Meier1-0/+2
svn path=/trunk/; revision=39973
2011-11-21From Yaniv Kaul: Some enhancements, some fixes, to the Spice dissector:Bill Meier1-184/+247
- SASL authentication support - improved (and correct) state machine. - indention, tab fixes - macro to fetch PDU, simplifying the code (and improving its readability) - properly show the length of agent messages and align them under the right tree. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6589 From me: Fix some indentation & remove some trailing whitespace. svn path=/trunk/; revision=39972
2011-11-17distribute -> redistribute.Chris Maynard1-1/+1
svn path=/trunk/; revision=39903
2011-11-16Avoid using "POINT" as it causes compiler errors on some systems. Add ↵Chris Maynard1-32/+41
modelines that match the current file's format. This dissector is now ready to be spiceistributed. svn path=/trunk/; revision=39890
2011-11-02From Yaniv Kaul:Anders Broman1-155/+435
Many enhancements, and some fixes, to the Spice dissector: - SASL authentication support - indention, tab fixes - LZ image dissection (fixing at least one TODO item) - dissect Spice client agent data - fix some proto_tree_add_item() offsets - probably some more that I forgot. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6535#attach_7355 svn path=/trunk/; revision=39710
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵Bill Meier1-1/+1
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39426
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-5/+5
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-07 08:52:40 +0000