aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-smb2.c
AgeCommit message (Collapse)AuthorFilesLines
2010-11-03From Claes Nasten, submitted in bug 2952:Chris Maynard1-9/+60
Here's a patch updating the decoding of write request/responses, decodes the 16 unknown bytes in write requests, decodes the 8 unknown bytes in write responses and renames length to count as per the SMB2 spec. svn path=/trunk/; revision=34760
2010-10-29Use value_string_ext fcns to access certain value_string arrays.Bill Meier1-3/+6
svn path=/trunk/; revision=34692
2010-09-23Replace blurbs that match the name (case insensitive) with NULL.Jeff Morriss1-8/+8
svn path=/trunk/; revision=34227
2010-09-21As suggested by Kovarththanan Rajaratnam in ↵Jeff Morriss1-6/+6
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 : Clean up hf fields some more: mostly removing leading and trailing spaces from names and blurbs. svn path=/trunk/; revision=34165
2010-09-06From yami via bug 3310:Stig Bjørlykke1-28/+174
SMB2 create context response fix. svn path=/trunk/; revision=34070
2010-09-02Apply the quick fix from bug 2952.Stig Bjørlykke1-3/+8
And it's true, this dissector really needs an overhaul! svn path=/trunk/; revision=34048
2010-08-10Dissect SMB_FILE_ATTRIBUTES, when used as file attributes rather thanGuy Harris1-9/+9
search attributes, as a 16-bit quantity, with only the bits specified by section 2.2.1.2.4 of [MS-CIFS]. Use dissect_file_ext_attr() in all cases where we're dissecting SMB_EXT_FILE_ATTR, as specified by section 2.2.1.2.3 of [MS-CIFS]. svn path=/trunk/; revision=33753
2010-05-13As suggested in ↵Jeff Morriss1-18/+13
http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html (as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 : Write a new convenience routine for finding a conversation and, if it is not found, create it. The frame number and addresses are taken from pinfo (as is the common case). Use this function in a bunch of dissectors. svn path=/trunk/; revision=32790
2010-02-04From MetzeRonnie Sahlberg1-3/+0
Subject: [PATCH 2/7] packet-smb2.c: fix handling of compounded SMB2 PDUs svn path=/trunk/; revision=31793
2009-12-19For fields of type FT_ABSOLUTE_TIME, have the "display" value be one ofGuy Harris1-7/+7
ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL == (int)BASE_NONE, so there's no source or binary compatiblity issue, although we might want to eliminate BASE_NONE at some point and have the BASE_ values used with integral types start at 0, so that you can't specify BASE_NONE for an integral field. svn path=/trunk/; revision=31319
2009-12-07A fix for bug 4301:Stig Bjørlykke1-1/+2
Check sip->extra_info for SMB_EI_NTI before usage. svn path=/trunk/; revision=31187
2009-10-04we must create a fake dcerpc_call_value strucure before we call into the Ronnie Sahlberg1-2/+4
dcerpc helpers svn path=/trunk/; revision=30288
2009-09-24Don't guard col_append_str with check_colKovarththanan Rajaratnam1-6/+2
svn path=/trunk/; revision=30125
2009-08-16Switch a bunch of dissectors over to using tvb_new_subset_remaining()Kovarththanan Rajaratnam1-1/+1
svn path=/trunk/; revision=29446
2009-08-09Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-3/+1
svn path=/trunk/; revision=29345
2009-07-14Header field cleanup.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=29090
2009-07-13From Chris Costa:Anders Broman1-7/+30
SMB2 Error Response doesn't decode properly. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3609 svn path=/trunk/; revision=29083
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-73/+73
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2009-06-05Have tap listeners specify whether the "packet" routine requiresGuy Harris1-1/+2
a protocol tree; the column values. This includes stats-tree listeners. Have the routines to build the packet list, and to retap packets, honor those requirements. This means that cf_retap_packets() no longer needs an argument to specify whether to construct the column values or not, so get rid of that argument. This also means that there's no need for a tap to have a fake filter to ensure that the protocol tree will be built, so don't set up a fake "frame" filter. While we're at it, clean up some cases where "no filter" was represented as a null string rather than a null pointer. Have a routine to return an indication of the number of tap listeners with filters; use that rather than the global num_tap_filters. Clean up some indentation and some gboolean vs. gint items. svn path=/trunk/; revision=28645
2009-05-01From Reinhard Speyerer:Jaap Keuter1-1/+1
This patch fixes several misspellings/typos in Wireshark SVN revision 28201. svn path=/trunk/; revision=28227
2009-03-31#include reassemble.h not req'dBill Meier1-1/+0
svn path=/trunk/; revision=27911
2008-08-21Modified version of a fix from Christopher Maynard as reported in bug 2822.Bill Meier1-2/+1
svn path=/trunk/; revision=26054
2008-05-26dissect te lock structures in the LOCK requestRonnie Sahlberg1-25/+74
svn path=/trunk/; revision=25378
2008-05-23add more dissection of FIND infolevelsRonnie Sahlberg1-10/+177
update the BREAK dissection svn path=/trunk/; revision=25371
2008-05-23add dissectors for some more FIND info levels FileBothDirectoryInfo andRonnie Sahlberg1-0/+256
FileIdBothDirectoryInfo svn path=/trunk/; revision=25366
2008-05-23enhance the FIND dissectorRonnie Sahlberg1-28/+177
svn path=/trunk/; revision=25365
2008-05-23update the dissection of NOTIFYRonnie Sahlberg1-13/+49
svn path=/trunk/; revision=25364
2008-05-23updte the CLOSE dissectorRonnie Sahlberg1-2/+25
svn path=/trunk/; revision=25359
2008-05-23update to the ioctl dissectorRonnie Sahlberg1-10/+43
svn path=/trunk/; revision=25358
2008-05-23iupdates to the dissection of READ and LOCK for smb2Ronnie Sahlberg1-13/+61
svn path=/trunk/; revision=25355
2008-02-14fixup and improve createRonnie Sahlberg1-50/+63
svn path=/trunk/; revision=24327
2008-02-14fixum tree disconnectRonnie Sahlberg1-4/+2
svn path=/trunk/; revision=24326
2008-02-14fixup tree connectRonnie Sahlberg1-5/+125
svn path=/trunk/; revision=24325
2008-02-14fixup sessionlogoffRonnie Sahlberg1-4/+2
svn path=/trunk/; revision=24324
2008-02-14fixup sessionsetupRonnie Sahlberg1-18/+90
svn path=/trunk/; revision=24323
2008-02-14update dissection of negprotRonnie Sahlberg1-14/+167
svn path=/trunk/; revision=24322
2008-02-14fixup SMB2 header and decode async commands correctlyRonnie Sahlberg1-96/+140
svn path=/trunk/; revision=24321
2007-11-09Apply yet another set of the optimization patches:Anders Broman1-1/+1
When offset parameter is 0 replace tvb_bytes_exist() with the faster tvb_length(). On the other hand if (tvb_bytes_exist(tvb, 0, 20) is more readable than if (tvb_length(tvb) >= 20 so only do it in heuristic function svn path=/trunk/; revision=23412
2007-10-23Apply the small performance enhancment patches for:Anders Broman1-3/+3
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster. Replace - col_append_fstr() with faster col_append_str() - col_add_str() with col_set_str() when it's safe svn path=/trunk/; revision=23252
2007-10-17Flag errorJaap Keuter1-1/+1
svn path=/trunk/; revision=23218
2007-08-28rename dcerpc_smb_store_pol_name to dcerpc_store_polhnd_nameRonnie Sahlberg1-2/+2
rename dcerpc_smb_fetch_pol to dcerpc_fetch_polhnd_data and also make it take an additional parameter to return the "type" of the policy handle, if such a type was stored. extend the pol_value structure used to track policy handles to also store a type to represent what created the policy handle types could be USER/ALIAS/CONNECT/... etc handles returned from the SAMR interface add a new helper function dcerpc_store_polhnd_type() track policy handles between request/responses for dcerpc update the samr.cnf file to make the samr dissectors for SetSecurity/QuerySecurity dissect the specific bits for the security descriptor correctly based on whether the policy handle refers to a CONNECT/DOMAIN/USER/ALIAS or GROUP svn path=/trunk/; revision=22703
2007-05-29Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLibGuy Harris1-2/+2
routines and routines using those routines. GLib might use different modifiers for 64-bit quantities than the platform's C library does. svn path=/trunk/; revision=21990
2007-05-21additional smb2 fixes from metzeRonnie Sahlberg1-6/+40
svn path=/trunk/; revision=21860
2007-05-21from metzeRonnie Sahlberg1-77/+132
improved handling of smb2 errors svn path=/trunk/; revision=21859
2007-05-16from metzeRonnie Sahlberg1-14/+13
prettify dissection of multiple chained smb2 pdus in one frame svn path=/trunk/; revision=21801
2007-05-15when spawning off to the next smb2 pdu in a chain we need to create a Ronnie Sahlberg1-2/+7
new tvb for it or else the offset/length calculations for where blobs a next_tvb=tvb_new_subset(tvb, chain_offset, MIN((int)len, tvb_length_remaining(tvb, off)), len); re in the packets are wrong. svn path=/trunk/; revision=21795
2007-05-15add dissection of the end_of_chain bit in the header flagsRonnie Sahlberg1-0/+10
svn path=/trunk/; revision=21794
2007-05-15from metzeRonnie Sahlberg1-50/+153
patch to find and enhancement of extra_info handling svn path=/trunk/; revision=21793
2007-05-15from metzeRonnie Sahlberg1-19/+39
add support for smb2 chaining rename sessionsetupandz to sessionsetup svn path=/trunk/; revision=21792
2007-05-07add dissection of smb1 ioctl data by tying it into the dissectors for Ronnie Sahlberg1-17/+11
ioctl data that already exists for smb2 svn path=/trunk/; revision=21713