aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-smb-pipe.c
AgeCommit message (Collapse)AuthorFilesLines
2012-07-27Fix a few Clang warnings (dead increment, dead assignment)pascal1-12/+5
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@44082 f5534014-38df-0310-8fa8-9805f1628bb7
2012-06-28Update Free Software Foundation address.darkjames1-1/+1
(COPYING will be updated in next commit) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43536 f5534014-38df-0310-8fa8-9805f1628bb7
2012-06-20Use separate filters for the RTT found on a SACK and the RTT found on amorriss1-14/+33
DATA chunk: having them in both places is helpful when looking at the messages but having them separate is helpful when graphing the RTTs. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43406 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.wmeier1-2/+2
Also: remove trailing whitespace for a number of files. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39503 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵wmeier1-7/+7
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39426 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵wmeier1-11/+11
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39288 f5534014-38df-0310-8fa8-9805f1628bb7
2011-06-20Fix some gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings;wmeier1-2/+2
(Code commented out since it may be required in the future (at least in some cases). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37723 f5534014-38df-0310-8fa8-9805f1628bb7
2011-02-10Modify proto_tree_add_bytes_format() and proto_tree_add_bytes_format_value()morriss1-1/+1
so that if the start_ptr is NULL the bytes are extracted from the given TVB using the given offset and length. Replace a bunch of: proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, tvb_get_ptr(tvb, offset, length), [...]) with: proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, NULL, [...]) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35896 f5534014-38df-0310-8fa8-9805f1628bb7
2011-01-30Introduce "Fragment count" filter element for all protocols doing reassembly.stig1-0/+5
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35705 f5534014-38df-0310-8fa8-9805f1628bb7
2011-01-16There's no need to pass the result of tvb_get_ptr() as the 'value' inmorriss1-8/+5
proto_tree_add_*(): just use proto_tree_add_item(). Replace some tvb_get_ptr()s with tvb_get_ephemeral_string() or tvb_get_const_stringz(). Use tvb_memeql() & tvb_memcmp(). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35558 f5534014-38df-0310-8fa8-9805f1628bb7
2010-10-29Use value_string_ext to access 'commands' value_string.wmeier1-6/+8
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34690 f5534014-38df-0310-8fa8-9805f1628bb7
2010-09-23Replace blurbs that match the name (case insensitive) with NULL.morriss1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34227 f5534014-38df-0310-8fa8-9805f1628bb7
2010-05-17Don't pass a NULL pointer to what is supposed to be (according to the ↵morriss1-1/+1
format) a string: some implementations of vsnprintf() will core on that. (Unfortunately it seems that g_vsnprintf() doesn't protect us from this...) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32848 f5534014-38df-0310-8fa8-9805f1628bb7
2010-04-03Remove unneeded #include <stdio.h>wmeier1-2/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32367 f5534014-38df-0310-8fa8-9805f1628bb7
2010-02-06Renamed some reassembled data texts.stig1-1/+1
Removed some check_col(). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31809 f5534014-38df-0310-8fa8-9805f1628bb7
2010-02-03Changed "reassembled_length" -> "reassembled.length".stig1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31776 f5534014-38df-0310-8fa8-9805f1628bb7
2010-02-02Introduce "Reassembled length" filter element for all protocols doingstig1-0/+5
reassembly. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31767 f5534014-38df-0310-8fa8-9805f1628bb7
2009-12-19For fields of type FT_ABSOLUTE_TIME, have the "display" value be one ofguy1-7/+7
ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL == (int)BASE_NONE, so there's no source or binary compatiblity issue, although we might want to eliminate BASE_NONE at some point and have the BASE_ values used with integral types start at 0, so that you can't specify BASE_NONE for an integral field. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31319 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-09Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_checkkrj1-6/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29345 f5534014-38df-0310-8fa8-9805f1628bb7
2009-06-21From Kovarththanan Rajaratnam via bug 3548:stig1-2/+2
More header_field_info cleanup. From me: Don't fix the empty name for hf_nisplus_dummy. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28792 f5534014-38df-0310-8fa8-9805f1628bb7
2009-05-13Apply some of the patches from:etxrab1-4/+2
http://wiki.wireshark.org/Development/Optimization git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28356 f5534014-38df-0310-8fa8-9805f1628bb7
2008-12-19Back out r27047 and r27053.gerald1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27062 f5534014-38df-0310-8fa8-9805f1628bb7
2008-12-18Update calls to proto_tree_add_bytes_format to reflect r27047.gerald1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27053 f5534014-38df-0310-8fa8-9805f1628bb7
2008-10-31Fix some "format not a string literal and no format arguments" warnings.stig1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26648 f5534014-38df-0310-8fa8-9805f1628bb7
2008-08-26#include <emem.h> not req'dwmeier1-1/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26091 f5534014-38df-0310-8fa8-9805f1628bb7
2008-02-07Removed even more "statement not reached" warnings.stig1-2/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24286 f5534014-38df-0310-8fa8-9805f1628bb7
2007-11-08Apply yet another set of the optimization patches:etxrab1-1/+1
When offset parameter is 0 replace tvb_bytes_exist() with the faster tvb_length(). non heuristic dissectors git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23405 f5534014-38df-0310-8fa8-9805f1628bb7
2007-10-17Flag errorjake1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23218 f5534014-38df-0310-8fa8-9805f1628bb7
2007-09-26"fix" some warnings about "might be used uninitialized" variablesjmayer1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22983 f5534014-38df-0310-8fa8-9805f1628bb7
2007-05-15since the fid dissector helper now adds a lot of extra info to the treesahlberg1-1/+1
we must now pass it a (semi-)valid tvb. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21783 f5534014-38df-0310-8fa8-9805f1628bb7
2007-05-10prettify dissection of FIDs,sahlberg1-2/+2
put the filename, if known, on the fid expansion line also place a "generated" fid in failed ntcreateandx so it is easier to quickly see which file the ntcreateandx failed for git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21739 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-30Fix more warningssfisher1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21286 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-23fix some more warnings (type casts)ulfl1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21141 f5534014-38df-0310-8fa8-9805f1628bb7
2006-09-23replace a rotating buffer in smb with ep allocated memorysahlberg1-12/+3
dont try dcerpc reassembly of fragments if we dont have the entire pdu only call the heuristical dissectors once from smb/pipe as per guy(?)s comments about idempotence. when doing reassembly, the dcerpc dissector is indeed not idempotent any more. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19304 f5534014-38df-0310-8fa8-9805f1628bb7
2006-06-18track smb FIDFs when tehy are opened and closed.sahlberg1-2/+2
add an expansion to the fid that display which frame itr was opened in and when it was closed. someone may want to add tracking of actual filenames here as well. i am not sure i need that feature myself so ... git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18512 f5534014-38df-0310-8fa8-9805f1628bb7
2006-06-18rename add_fid() to dissect_smb_fid() as a firsdt step towards adding ↵sahlberg1-2/+2
tracking of filename/openedframe/closedframe tracking for smb fids git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18506 f5534014-38df-0310-8fa8-9805f1628bb7
2006-05-21change a whole bunch of ethereal into wiresharksahlberg1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18196 f5534014-38df-0310-8fa8-9805f1628bb7
2006-03-23Coverity CID 48 is still complaining about a NULL dereference. Hopefully gerald1-10/+11
this will fix it. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17708 f5534014-38df-0310-8fa8-9805f1628bb7
2006-03-14coverity bug 44sahlberg1-2/+4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17621 f5534014-38df-0310-8fa8-9805f1628bb7
2006-03-08remove a redundant if statementsahlberg1-3/+2
this if statement always evaluate to true since it is called from a single place that is only entered if the very same expression is also true there. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17524 f5534014-38df-0310-8fa8-9805f1628bb7
2006-03-08for really really weird malformed lanman packets it is theoretically possiblesahlberg1-0/+4
that trp is uniunitialized. coverity bug 46 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17523 f5534014-38df-0310-8fa8-9805f1628bb7
2006-03-07fix a potential null dereferencesahlberg1-3/+8
found in coverity cid:48 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17509 f5534014-38df-0310-8fa8-9805f1628bb7
2005-09-28Have show_exception() take a "const char *" as its exception message,guy1-0/+1
and not free the string to which it points. Pass to REPORT_DISSECTOR_BUG() strings allocated with ep_strdup_printf(), so that they're freed automatically. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@16039 f5534014-38df-0310-8fa8-9805f1628bb7
2005-09-17Move some headers for stuff defined by a dissector into epan/dissectorsguy1-1/+1
- and rename smb.h to packet-smb.h, as it's packet-smb.c's header file. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15845 f5534014-38df-0310-8fa8-9805f1628bb7
2005-09-17Move a pile of protocol-related headers from the top-level sourceguy1-1/+1
directory to the epan directory. Some of them should perhaps ultimately be moved to epan/dissectors, if they pertain only to stuff exported by a particular dissector. Fix Gerald's e-mail address in files we're moving. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15844 f5534014-38df-0310-8fa8-9805f1628bb7
2005-06-10just to get things straight: a dissector should *never* do any g_assert() calls!ulfl1-3/+3
in a simple approach, I've replaced all g_assert() and g_assert_not_reached() calls by their exception throwing counterparts DISSECTOR_ASSERT() and DISSECTOR_ASSERT_NOT_REACHED() this will replace application crash by showing a dissector bug, which is the desired behaviour there were some g_assert calls in the protocol registering functions, which might not be acting as expected now, but to be able to simply search for g_assert in the future I've replaced that calls too one g_assert remained, the one when someone throws an unknown exception "into" packet_frame.c, but IMHO this one should remain. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14608 f5534014-38df-0310-8fa8-9805f1628bb7
2005-06-02add a generated toplevel line between the TCP protocol and the desegmented ↵ulfl1-2/+3
content, to better understand what's going on while desegmenting. We'll have to add similar mechanisms for other protocols as well... git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14527 f5534014-38df-0310-8fa8-9805f1628bb7
2005-05-10Make a field type check more strict. Remove some unnecessary code.gerald1-18/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14338 f5534014-38df-0310-8fa8-9805f1628bb7
2005-04-30Make sure we don't pass an invalid length to proto_tree_add_item(). Foundgerald1-2/+24
during fuzz testing. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14237 f5534014-38df-0310-8fa8-9805f1628bb7
2005-04-28In dissect_pipe_lanman(), return FALSE if p_tvb is null, no matter what.gerald1-1/+1
Fixes bug 132. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14221 f5534014-38df-0310-8fa8-9805f1628bb7