aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-rtse.c
AgeCommit message (Collapse)AuthorFilesLines
2013-12-09Reject the packet if data is NULL without doing anything else.Chris Maynard1-13/+7
Note: We *might* want to do _something_ but that _something_ should be well-defined and consistent across all dissectors. Previously, some dissectors called proto_tree_add_text() to add some error message text to the tree, while others called DISSECTOR_ASSERT(). svn path=/trunk/; revision=53895
2013-12-08- Forward declaration of register functions.Anders Broman1-5/+8
svn path=/trunk/; revision=53861
2013-11-05In an effort to reduce the use of pinfo->private_data (and some true global ↵Michael Mann1-47/+53
variables), I converted the ASN.1 dissectors that use pinfo->private_data to exchange a SESSION_DATA_STRUCTURE to instead only exchange it in the context of ASN.1. This meant converting dissectors to the "new" style to pass the SESSION_DATA_STRUCTURE as well as providing a pointer to it in asn1_ctx_t.private_data. Yes, it's still "private data", but it's not used by all dissectors like pinfo->private data is. svn path=/trunk/; revision=53090
2013-11-02Require dissector_try_string to pass a data parameter to its subdissectors. ↵Michael Mann1-1/+1
There weren't that many calls, so might as well modify the function than create a need for dissector_try_string_new. svn path=/trunk/; revision=53049
2013-10-30Update the ASN.1 generated dissectors that were missed as part of the ↵Michael Mann1-3/+3
patches in bug 9344 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344) svn path=/trunk/; revision=52978
2013-09-09expert_add_info_format_text -> expert_add_info_formatMichael Mann1-1/+1
svn path=/trunk/; revision=51851
2013-07-17Remove fragment_data, add fragment_head, fragment_item - for now alias it to ↵Jakub Zawadzki1-1/+1
the same structure. This is begin of work to split fragment head and fragments items. svn path=/trunk/; revision=50708
2013-06-14Remove check_col() from ASN.1 dissectorsMichael Mann1-2/+2
svn path=/trunk/; revision=49927
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-2/+1
svn path=/trunk/; revision=49921
2013-06-03Convert ASN.1 dissectors to use filterable expert info.Michael Mann1-10/+17
NOTE: Kerberos ASN.1 template was updated, but not generated to source. svn path=/trunk/; revision=49707
2013-05-27Postfix FT_NONE fields with "_element" string to reduce number of ↵Pascal Quantin1-8/+8
incompatible filters in ASN.1 dissectors https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2402 svn path=/trunk/; revision=49599
2013-04-11Update the ASN.1 based dissectors following the changes done in r48812Pascal Quantin1-2/+2
svn path=/trunk/; revision=48820
2013-03-22Don't wire into the reassembly code the notion that reassemblies shouldGuy Harris1-10/+10
be done on flows from one address to another; reassembly for protocols running atop TCP should be done on flows from one TCP endpoint to another. We do this by: adding "reassembly table" as a data structure; associating hash tables for both in-progress reassemblies and completed reassemblies with that data structure (currently, not all reassemblies use the latter; they might keep completed reassemblies in the first table); having functions to create and destroy keys in that table; offering standard routines for doing address-based and address-and-port-based flow processing, so that dissectors not needing their own specialized flow processing can just use them. This fixes some mis-reassemblies of NIS YPSERV YPALL responses (where the second YPALL response is processed as if it were a continuation of a previous response between different endpoints, even though said response is already reassembled), and also allows the DCE RPC-specific stuff to be moved out of epan/reassembly.c into the DCE RPC dissector. svn path=/trunk/; revision=48491
2013-02-19How can I get a new tvbuff that starts at an offset within a givenGuy Harris1-1/+1
tvbuff and runs to the end of the tvbuff? Let me count the ways.... Replace a bunch of different ways of doing that (some incorrect, in that they're not properly handling tvbuffs where the captured and reported lengths are different) with tvb_new_subset_remaining(). svn path=/trunk/; revision=47751
2012-12-26Fix a bunch of warnings.Guy Harris1-2/+2
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-09-24Regenerate asn.1 dissectors.Jakub Zawadzki1-5/+5
svn path=/trunk/; revision=45110
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-10Propage changes done in generated dissectors to asn1/Jakub Zawadzki1-3/+3
svn path=/trunk/; revision=44845
2012-09-07From Robert Bullen via ↵Jeff Morriss1-14/+16
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7683 : The reassembled fragments tree in the Packet Details view is awesome, but it lacks one thing: a field that exposes the reassembled data. tcp.data already exists for exposing a single TCP segment's payload as a byte array. It would be handy to have something similar for a single application layer PDU when TCP segment reassembly is involved. I propose tcp.reassembled.data, named and placed after the already existing field tcp.reassembled.length. My primary use case for this feature is outputting tcp.reassembled.data with tshark for further processing with a script. The attached patch implements this very feature. Because the reassembled fragment tree code is general purpose, i.e. not specific to just TCP, any dissector that relies upon it can add a similar field very cheaply. In that vein I've also implemented ip.reassembled.data and ipv6.reassembled.data, which expose reassembled fragment data as a single byte stream for IPv4 and IPv6, respectively. All other protocols that use the reassembly code have been left alone, other than inserting NULL into their initializer lists for the newly introduced struct field reassemble.h:fragment_items.hf_reassembled_data. svn path=/trunk/; revision=44802
2012-07-17Use G_MININT32 instead of -2^31 so as to get rid of 'this decimal constant ↵Pascal Quantin1-2/+2
is unsigned only in ISO C90' warning svn path=/trunk/; revision=43764
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-01-13Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
svn path=/trunk/; revision=40468
2011-10-15Update generated ASN1 *.[hc] files after recent work done by Jeff Morriss;Bill Meier1-1/+1
The only change in each file is in a comment showing the asn2wrs cmd used to build that file. svn path=/trunk/; revision=39427
2011-09-27Get rid of check_col, while at it set ENC.Anders Broman1-4/+4
svn path=/trunk/; revision=39164
2011-07-19Use ENC_NA as encoding for FT_PROTOCOL, FT_NONE and FT_BYTES.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=38122
2011-07-19Use correct encoding for proto_tree_add_item().Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=38107
2011-04-12Regenerate more ASN.1 dissectors for Coverity.Gerald Combs1-27/+27
svn path=/trunk/; revision=36609
2011-01-30Introduce "Fragment count" filter element for all protocols doing reassembly.Stig Bjørlykke1-3/+8
svn path=/trunk/; revision=35705
2010-09-30Cleanup reassembly hf entries.Stig Bjørlykke1-11/+10
svn path=/trunk/; revision=34291
2010-08-24Display octet string fragments for RTSE segment data.Stig Bjørlykke1-7/+10
svn path=/trunk/; revision=33911
2010-08-24Indicate abort and abort-reason in info column.Stig Bjørlykke1-17/+33
svn path=/trunk/; revision=33908
2010-08-16Added Info for RTTPapdu.Stig Bjørlykke1-4/+15
svn path=/trunk/; revision=33809
2010-06-10Display RefuseReason in Info column.Stig Bjørlykke1-3/+17
svn path=/trunk/; revision=33206
2010-05-11Add a little more code to avoid not-very-useful blurbs:Jeff Morriss1-7/+7
- Change spaces in the name to underscores before comparing it to the blurb. - Check if the type simply as T_ prepended to the name. - Don't put in a blurb of "NULL". and regenerate the dissectors. svn path=/trunk/; revision=32748
2010-05-11Regenerate a few more of the ASN.1 dissectorsJeff Morriss1-24/+24
svn path=/trunk/; revision=32746
2010-04-07#include <string.h> and/or #include <stdio.h> not needed.Bill Meier1-7/+5
svn path=/trunk/; revision=32417
2010-04-06#include <stdio.h> not needed.Bill Meier1-6/+5
svn path=/trunk/; revision=32405
2010-02-02Introduce "Reassembled length" filter element for all protocols doingStig Bjørlykke1-3/+9
reassembly. svn path=/trunk/; revision=31767
2009-10-11Make all proto_* values static.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=30516
2009-10-09Regenerate asn1 dissectors (no change, only some line offset changes)Kovarththanan Rajaratnam1-2/+2
svn path=/trunk/; revision=30454
2009-08-09Don't guard col_clear with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29344
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-7/+7
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2009-05-20Added expert info for Unknown RTSE PDU.Stig Bjørlykke1-3/+11
svn path=/trunk/; revision=28424
2009-05-20Added expert info for OID not implemented.Stig Bjørlykke1-11/+10
svn path=/trunk/; revision=28423
2009-05-16Regenerate all asn2wrs generated dissectors.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=28379
2008-11-04asn2wrs generated files changed as a result of recent asn1 template changes Bill Meier1-11/+15
svn path=/trunk/; revision=26698
2008-11-01Regenerate all asn2wrs generated dissectorsAnders Broman1-1/+1
svn path=/trunk/; revision=26670
2008-08-01Regenerated to use the new decode function for UTCTime.Stig Bjørlykke1-3/+1
svn path=/trunk/; revision=25898
2008-01-16- Removed some unused variables in asn1 dissectorsStig Bjørlykke1-14/+11
- Fixed last parameter to cry_cipher_open() in pkcs12 svn path=/trunk/; revision=24116