aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-rsvp.c
AgeCommit message (Collapse)AuthorFilesLines
2014-01-27Fix hf[] entries with refs to range_string arraysBill Meier1-7/+7
to add missing BASE_RANGE_STRING and to use RVALS instead of VALS. Fixes crashes in 'tshark -G values' and presumably also fixes crashes when used in a dissection. Introduced in SVN #54449. (I suspect that ' convert_proto_tree_add_text.pl' may need some work to handle range_strings). svn path=/trunk/; revision=54984
2014-01-26Fix encoding arg for RSVP dissector (with fix-encodings-args toolsAlexis La Goutte1-7/+7
svn path=/trunk/; revision=54963
2014-01-23From me for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9519 RSVP ↵Alexis La Goutte1-1/+48
dissector does not decode Session Object (1) C-type (13) message svn path=/trunk/; revision=54932
2013-12-26Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-7/+0
svn path=/trunk/; revision=54458
2013-12-24Make many fields filterable. Used convert_proto_tree_add_text.pl to do a ↵Michael Mann1-722/+701
"first pass" at converting proto_tree_add_text calls since this dissector is the worse (ab)user (by volume) of proto_tree_add_text and the "coding style" is very conducive to having convert_proto_tree_add_text.pl correctly guessing the field info. Another pass or two of convert_proto_tree_add_text.pl (with more manual intervention) is needed to be a "proper" dissector, but it gets it off of the checkAPIs.pl "naughty list" in time for Christmas. svn path=/trunk/; revision=54449
2013-12-23Make C-type filterable.Michael Mann1-232/+191
If someone wanted to make more hf_ variables accompanied by a variety of value_strings for each category, they are certainly more than welcome. For now it just cuts down on the proto_tree_add_text (ab)use. "Comment out" unused hf_ variable found. svn path=/trunk/; revision=54425
2013-12-21Add missing includesJakub Zawadzki1-0/+1
svn path=/trunk/; revision=54332
2013-12-19Rename a couple of to_str functions to have ep_ in the name. This makes itEvan Huus1-9/+9
obvious that the returned string is ephemeral, and opens up the original names in the API for versions that take a wmem pool (and thus can work in any scope). svn path=/trunk/; revision=54249
2013-12-14Remove not needed ';'Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=54088
2013-12-12The dissector table has never been used, and the name of the dissectorGuy Harris1-5/+0
table doesn't correspond to any obvious field, so I'm not sure why it needs to exist. Remove it. svn path=/trunk/; revision=53996
2013-11-22Create multiple dissection functions if packet_info->ipproto is used to ↵Michael Mann1-11/+28
distinguish behavior. svn path=/trunk/; revision=53504
2013-11-10Add missing includes in order to remove exceptions.h from proto.h (next commit).Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53230
2013-10-23#if 0 numerous "unused const variables" (mostly value-string-arrays);Bill Meier1-0/+2
Also; fix a few "set but not used" warnings. svn path=/trunk/; revision=52780
2013-09-29As pointed out in bug 9127, tcpdump dissects Juniper AttributesJörg Mayer1-16/+166
quite well - reimplement that in Wireshark. There is room for improvement in this patch, e.g. use subtrees for the subattributes. svn path=/trunk/; revision=52278
2013-09-27Hack forJörg Mayer1-5/+74
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9127 With 6 unknown bytes leading to the two known values for the last two bytes this cannot yet be properly dissected. Dissect the one known case. More traces with additional properties required to get more sense into the first 6 bytes. svn path=/trunk/; revision=52233
2013-09-25Beginning to work on bug 9127 (Juniper proprietary TLV in RSVP):Jörg Mayer1-12/+50
- Print hexdump of unknown or vendor specific toplevel TLVs - Try to print the name of type 204 (something still missing) svn path=/trunk/; revision=52212
2013-09-22emem -> wmem conversion:Pascal Quantin1-2/+2
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-15emem -> wmemMartin Kaiser1-33/+44
svn path=/trunk/; revision=52072
2013-09-15TABs -> spacesMartin Kaiser1-57/+70
add editor modelines svn path=/trunk/; revision=52070
2013-09-09coverity 996921: add missing breakMartin Kaiser1-0/+1
svn path=/trunk/; revision=51867
2013-08-24From Tommy Wu:Anders Broman1-46/+61
Handle ERROR-SPEC: mandatory object, with an empty value. svn path=/trunk/; revision=51507
2013-08-08From Francesco Fondelli via ↵Jeff Morriss1-1/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9024 : In dissect_rsvp_lsp_attributes() there is a check for invalid Attributes TLV length that is no more correct in light of changes described in Section 14 of RFC 5420. This patch fixes that. svn path=/trunk/; revision=51224
2013-08-07From Francesco Fondelli via ↵Jeff Morriss1-14/+427
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8954 : This patch adds XRO (Exclude Routes) support to RSVP dissector. It also extends coverage of some new Attribute Flags (LSP_ATTRIBUTES object). svn path=/trunk/; revision=51199
2013-07-06Fix display filter errors caught by checkfiltername.plMichael Mann1-1/+1
svn path=/trunk/; revision=50399
2013-04-23Restore a lost hf def.Anders Broman1-0/+5
svn path=/trunk/; revision=48995
2013-04-19Remove duplicate hf array entry.Evan Huus1-5/+0
svn path=/trunk/; revision=48936
2013-04-19Fix apparent copy-paste error leading to a 'used-uninitialized' warning.Evan Huus1-1/+1
svn path=/trunk/; revision=48929
2013-04-19Add dissection of QoS blob.Anders Broman1-6/+169
svn path=/trunk/; revision=48927
2013-04-04Remove a shadow variable.Jaap Keuter1-3/+3
svn path=/trunk/; revision=48735
2013-04-04- Dissect Packet filters and QoS list(partly).Anders Broman1-128/+420
- Update value_strings. svn path=/trunk/; revision=48734
2013-04-03Get rid of a shadowed variable and remove a set-but-not-used variable. ↵Jeff Morriss1-108/+104
Reindent a little. svn path=/trunk/; revision=48723
2013-04-03Dissect more of 3GPP Object.Anders Broman1-2/+142
svn path=/trunk/; revision=48719
2013-04-02Remove non ASCII charactersPascal Quantin1-4/+4
svn path=/trunk/; revision=48695
2013-04-02Dissect more of 3GPP2_OBJECT.Anders Broman1-6/+117
svn path=/trunk/; revision=48694
2013-03-31Unused parameter.Anders Broman1-1/+1
svn path=/trunk/; revision=48681
2013-03-31Initial decoding of 3GPP2_OBJECT.Anders Broman1-3/+80
svn path=/trunk/; revision=48679
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus1-1/+1
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-03-23Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-3/+0
svn path=/trunk/; revision=48501
2013-03-19From beroset:Anders Broman1-1/+1
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48430
2013-03-01Fix Coverity CID 280396: Logically dead code.Chris Maynard1-12/+4
svn path=/trunk/; revision=47973
2013-02-27Move show_exception() and show_reported_bounds_error() toGuy Harris1-6/+0
epan/show_exception.c, as it's used outside epan/dissectors/packet-frame.c. Update their callers to include <epan/show_exception.h> to get their declaration. Add a CATCH_NONFATAL_ERRORS macro that catches all exceptions that, if there's more stuff in the packet to dissect after the dissector call that threw the exception, doesn't mean you shouldn't go ahead and dissect that stuff. Use it in all those cases, including ones where BoundsError was inappropriately being caught (you want those passed up to the top level, so that the packet is reported as having been cut short in the capture process). Add a CATCH_BOUNDS_ERRORS macro that catches all exceptions that correspond to running past the end of the data for a tvbuff; use it rather than explicitly catching those exceptions individually, and rather than just catching all exceptions (the only place that DissectorError should be caught, for example, is at the top level, so dissector bugs show up in the protocol tree). Don't catch and then immediately rethrow exceptions without doing anything else; just let the exceptions go up to the final catcher. Use show_exception() to report non-fatal errors, rather than doing it yourself. If a dissector is called from Lua, catch all non-fatal errors and use show_exception() to report them rather than catching only ReportedBoundsError and adding a proto_malformed item. Don't catch exceptions when constructing a trailer tvbuff in packet-ieee8023.c - just construct it after the payload has been dissected, and let whatever exceptions that throws be handled at the top level. Avoid some TRY/CATCH/ENDTRY cases by using checks such as tvb_bytes_exist() before even looking in the tvbuff. svn path=/trunk/; revision=47924
2012-12-26Fix a bunch of warnings.Guy Harris1-2/+2
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-12-02Introduce, and start using, TVB_SET_ADDRESS() and TVB_SET_ADDRESS_HF(). TheyJeff Morriss1-13/+8
are like the non-TVB versions except that they take a TVB and an offset instead of (frequently) a pointer into the TVB. Calling tvb_get_ptr() before modifying the rest of the fields should help fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7960 (though I can't reproduce that problem). Replace a bunch of calls like: SET_ADDRESS(..., AT_XXX, length, tvb_get_ptr(tvb, offset, length)); with: TVB_SET_ADDRESS(..., AT_XXX, tvb, offset, length); svn path=/trunk/; revision=46324
2012-11-29Make all enum_val_t's const.Jeff Morriss1-2/+2
svn path=/trunk/; revision=46292
2012-10-30Fix Incorrect decoding of RSVP RECORD_ROUTE Object.Anders Broman1-20/+13
"in RSVP RESV message there incorrect explanation of field "Flags" of Label subobject is appeared in Packet Details section: value 0x01 of Flags field mistakenly defined as "Local Protection Available" (I guess that this is borrowed from Flags field of IPv4 Address subobject). Flags 0x01 in Label subobject means that particular label is global (RFC 3209, Clause 4.4.1.3)." https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7876 svn path=/trunk/; revision=45835
2012-09-24replaced decode_boolean_bitfield calls with itemized filtersMichael Mann1-395/+798
svn path=/trunk/; revision=45082
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-08-25Extern (and use) extended value string instead of the associated value ↵Bill Meier1-3/+3
string array. svn path=/trunk/; revision=44665
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-11Re-order 2 value_string arrays so that entries are in ascending order by value.Bill Meier1-15/+66
svn path=/trunk/; revision=43216
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-05 18:33:20 +0000