aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-rpki-rtr.c
AgeCommit message (Collapse)AuthorFilesLines
2017-09-15epan: Fix misuse of comma operatorStig Bjørlykke1-1/+1
Change-Id: I349dc9896db0bd306bc92f92eb9d4a65d98d309c Reviewed-on: https://code.wireshark.org/review/23558 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-03-04RPKI-RTR: Add new error codeAlexis La Goutte1-0/+1
From RFC-ietf-sidr-rpki-rtr-rfc6810-bis-09 Change-Id: Ice24416515448c633eb436f5f08320561c2a6a6a Reviewed-on: https://code.wireshark.org/review/20384 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-31Dissectors don't need a journey of self discovery.Michael Mann1-3/+3
They already know who they are when they register themselves. Saving the handle then to avoid finding it later. Not sure if this will increase unnecessary register_dissector functions (instead of using create_dissector_handle in proto_reg_handoff function) when other dissectors copy/paste, but it should make startup time a few microseconds better. Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43 Reviewed-on: https://code.wireshark.org/review/19481 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-08Combine Decode As and port preferences for tcp.port dissector table.Michael Mann1-18/+10
This patch introduces new APIs to allow dissectors to have a preference for a (TCP) port, but the underlying data is actually part of Decode As functionality. For now the APIs are intentionally separate from the regular APIs that register a dissector within a dissector table. It may be possible to eventually combine the two so that all dissectors that register with a dissector table have an opportunity to "automatically" have a preference to adjust the "table value" through the preferences dialog. The tcp.port dissector table was used as the guinea pig. This will eventually be expanded to other dissector tables as well (most notably UDP ports). Some dissectors that "shared" a TCP/UDP port preference were also converted. It also removed the need for some preference callback functions (mostly when the callback function was the proto_reg_handoff function) so there is cleanup around that. Dissectors that has a port preference whose default was 0 were switched to using the dissector_add_for_decode_as_with_preference API rather than dissector_add_uint_with_preference Also added comments for TCP ports used that aren't IANA registered. Change-Id: I99604f95d426ad345f4b494598d94178b886eb67 Reviewed-on: https://code.wireshark.org/review/17724 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09new_create_dissector_handle -> create_dissector_handle for dissector directory.Michael Mann1-1/+1
Some of the ASN.1 dissectors still generate a new_create_dissector_handle from the tool itself, so leave those for now. Change-Id: Ic6e5803b1444d7ac24070949f5fd557909a5641f Reviewed-on: https://code.wireshark.org/review/12484 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-27Lua: Expose tcp_dissect_pdus() to LuaHadriel Kaplan1-1/+1
Provide a way for Lua-based dissectors to invoke tcp_dissect_pdus() to make TCP-based dissection easier. Bug: 9851 Change-Id: I91630ebf1f1fc1964118b6750cc34238e18a8ad3 Reviewed-on: https://code.wireshark.org/review/6778 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Tested-by: Hadriel Kaplan <hadrielk@yahoo.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-3/+1
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-13Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...Bill Meier1-3/+3
(for some dissectors which fetch all other integral fields using ENC_BIG_ENDIAN). Change-Id: Ic18e3172aad76af12b12d6732c88497be22aed56 Reviewed-on: https://code.wireshark.org/review/5748 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-06RPKI-RTR: Missing break in switch (CID 1233099)Alexis La Goutte1-0/+1
Change-Id: I01f01ce51fb1c9deb857ef01696b406b97dca3a9 Reviewed-on: https://code.wireshark.org/review/5616 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-19Do encoding-arg changes (all benign)Bill Meier1-1/+1
For: - FT_BYTES: Always use just ENC_NA - integral/floating (other than FT_[U]INT8): Do ENC_NA --> ENC_BIG_ENDIAN Also: - FT_UINT... --> FT_UINT8 in a few cases (to match proto_tree_add_item...) - Change one case of incorrect '||' to '|' Change-Id: I427e0e61618ff8faf55691c8a695930f67d455b0 Reviewed-on: https://code.wireshark.org/review/4184 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-03RPKI RTR: Add support draft-ietf-sidr-rpki-rtr-rfc6810-bis-01Alexis La Goutte1-7/+113
Add new PDU : Router Key (9) Add new field (Expire, Retry... interval) for END OF DATA PDU Ping-Bug:8296 Change-Id: Ic30ab0ff9d0f9989eb7d157f85b74a54d09fb0e7 Reviewed-on: https://code.wireshark.org/review/3948 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-08-28RPKI-RTR: enhance dissectorAlexis La Goutte1-14/+16
* fix no display all append COL_INFO... (reset by col_set_clear...) * fix dissection when type is unknown * fix warning about soft-deprecated (tvb_length..) * fix indent * fix some typo (IPV6 => IPv6...) Ping-Bug:8296 Change-Id: I246b04098200afd1528f632cc709f631422e745b Reviewed-on: https://code.wireshark.org/review/3888 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-08-25RPKI RTR: Wrong decoding of RPKI RTR End of Data PDUAlexis La Goutte1-1/+1
The decoding of the End of Data PDU ignores the Serial Number, i.e., the last 32 bit of this PDU. Instead of that the current dissector implementation starts to decode a new RTR PDU. Details of packet format see http://tools.ietf.org/html/rfc6810#section-5.8 Found by Matthias Wählisch Bug: 10411 Change-Id: I8451b5fbda18a034022b97ff442ddb2a2dabed7b Reviewed-on: https://code.wireshark.org/review/3832 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-2/+2
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-2/+2
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-12- Make local functions static.Anders Broman1-0/+1
- Forward declaration of register functions. svn path=/trunk/; revision=53958
2013-11-09Add data parameter to tcp_dissect_pdus() as well as convert it to using ↵Michael Mann1-5/+8
"new" style dissectors. Now that "bytes consumed" can be determined, should tcp_dissect_pdus() take advantage of that? Should tcp_dissect_pdus return length (bytes consumed)? There are many dissectors that just call tcp_dissect_pdus() then return tvb_length(tvb). Seems like that could all be rolled into one. svn path=/trunk/; revision=53198
2013-03-17Support (TCP) fragmentation for RPKI-RTR Protocol (Using tcp_dissect_pdus)Alexis La Goutte1-4/+22
svn path=/trunk/; revision=48362
2013-03-10Use col_append_sep_str instead of col_set_str. Fixes another piece ofEvan Huus1-1/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8456 Fix suggested by Jakub in comment #5. svn path=/trunk/; revision=48235
2013-02-05Misc:Bill Meier1-104/+106
- Add col_clear(..., COL_INFO); - Use val_to_str() (not val_to_str_consr()) with "format" arg; - Indentation/whitespace; - Add svn:keywords & svn:eol-style properties. svn path=/trunk/; revision=47482
2013-02-04From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8296 Add ↵Alexis La Goutte1-0/+391
RPKI-RTR Dissector (RFC6810) Support all PDU Type (IPv4/6 Prefix, Serial Notify/Query...) Not supported the packet with a lot of PDU (fragmentation) svn path=/trunk/; revision=47470
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-29 05:44:42 +0000