aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-reload.c
AgeCommit message (Collapse)AuthorFilesLines
2012-08-10Use val_to_str_const() where appropriate;wmeier1-11/+11
Also (for a few files): - create/use some extended value strings; - remove unneeded #include files; - remove unneeded variable initialization; - re-order fcns slightly so prefs_reg_handoff...() at end, etc git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@44438 f5534014-38df-0310-8fa8-9805f1628bb7
2012-07-28Fix a 'dead increment' warning forgotten in r44084pascal1-1/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@44090 f5534014-38df-0310-8fa8-9805f1628bb7
2012-07-27Fix 'dead increment' and 'dereference of null pointer' Clang warningspascal1-12/+8
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@44084 f5534014-38df-0310-8fa8-9805f1628bb7
2012-07-08UATs could be put into "categories". The categories were defined onlyguy1-3/+3
implicitly by the #define name and string they were defined to; not all UATs neatly fit into any of the categories, so some of them were put into categories that weren't obviously correct for them, and one - the display filter macro UAT - wasn't put into any category at all (which caused crashes when editing them, as the GUI code that handled UAT changes from a dialog assumed the category field was non-null). The category was, in practice, used only to decide, in the aforementioned GUI code, whether the packet summary pane needed to be updated or not. It also offered no option of "don't update the packet summary pane *and* don't redissect anything", which is what would be appropriate for the display filter macro UAT. Replace the category with a set of fields indicating what the UAT affects; we currently offer "dissection", which applies to most UATs (any UAT in libwireshark presumably affects dissection at a minimum) and "the set of named fields that exist". Changing any UAT that affects dissection requires a redissection; changing any UAT that affects the set of named fields that exist requires a redissection *and* rebuilding the packet summary pane. Perhaps we also need "filtering", so that if you change a display filter macro, we re-filter, in case the display is currently filtered with a display filter that uses a macro that changed. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43603 f5534014-38df-0310-8fa8-9805f1628bb7
2012-06-28Update FSF address - part II.darkjames1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43538 f5534014-38df-0310-8fa8-9805f1628bb7
2012-06-20Use separate filters for the RTT found on a SACK and the RTT found on amorriss1-486/+518
DATA chunk: having them in both places is helpful when looking at the messages but having them separate is helpful when graphing the RTTs. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43406 f5534014-38df-0310-8fa8-9805f1628bb7
2012-01-23Fix some duplicate display filter names.cmaynard1-9/+9
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@40669 f5534014-38df-0310-8fa8-9805f1628bb7
2011-11-15Rewrite some odd code. Clang Cat does not want:guy1-2/+1
packet-reload.c:2875:13: warning: Although the value stored to 'local_offset' is used in the enclosing expression, the value is never actually read from 'local_offset' although as I read the C90 spec the code is doing pretty much what it should be doing and the rewritten code does the same thing. However, it's also a bit more complicated and harder to read than the rewritten code. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39840 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-25Fix proto_tree_add_item() encoding args.wmeier1-33/+34
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39580 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-24Fix encoding arg for various fcn calls:wmeier1-8/+8
- proto_tree_add_bits_item - proto_tree_add_bits_ret_val - proto_tree_add_bitmask - tvb_get_bits - tvb_get_bits16 - tvb_get_bits24 - tvb_get_bits32 - tvb_get_bits64 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39539 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.wmeier1-1/+1
Also: remove trailing whitespace for a number of files. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39503 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵wmeier1-2/+2
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39426 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-13Make clang on Mac OS X 10.7.2. happy.tuexen1-1/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39406 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-12When looping, be sure to iterate over the right number of elements. Fixes ↵cmaynard1-5/+5
Coverity OVERRUN_STATIC errors reported in CID's 1305 and 1306. Also, fix the 3 offending display filter names discovered with tools/checkfiltername.pl. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39393 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-12Fix some proto_tree_add_item() FT_ABSOLUTE_TIME encoding parameters:wmeier1-4/+4
Again: a tip o'the hat to Guy. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39383 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-10 Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵wmeier1-7/+7
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39328 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-08From Stéphane Bryant: fixes in reload fragmentation handlingwmeier1-105/+111
-Fixes in reload fragmentation -also updated the code to reflect draft-zong-p2psip-drr-01 From me: Remove one line of the patch which appears to be incorrect: At about line 4118 (in dissect_reload_message()) - pinfo->fragmented = save_fragmented; + pinfo->fragmented = pinfo->fragmented; git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39309 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-08From Stéphane Bryant: remove the variables that the previous patch left unusedwmeier1-22/+8
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6317 From me: Add hf[] entry for 'hf_reload_dmflag_underlay_hop' git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39308 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-06Use '"%" G_GINT64_MODIFIER "d"' instead of "%ld" to format a guint64.wmeier1-1/+1
Fixes a compile warning git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39302 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-06From Stéphane Bryant: improvements in RELOAD dissectionwmeier1-1092/+4253
- Follow closely draft-ietf-p2psip-base-18 - Added support for draft-ietf-p2psip-base-18, draft-ietf-p2psip-sip-06, draft-ietf-p2psip-service-discovery-03, draft-ietf-p2psip-self-tuning-04, draft-ietf-p2psip-diagnostics-06, draft-zong-p2psip-drr-00, - Handoff to the xml dissectors for configuration data - export the message content dissection function in the new packet-reload.h file for use in related protocols (draft-hautakorpi-p2psip-with-hip-01) https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6317 From me: - Fix a few C++ style comments; - Fix: packet-reload.c(2156) ... conversion from 'guint64' to 'guint32', possible loss of data packet-reload.c(3528) ... conversion from 'guint64' to 'guint32', possible loss of data Note: Additional fix yet req'd since checkhf.pl gives: ERROR: NO ARRAY: packet-reload.c, hf_reload_dmflag_underlay_hop Unused entry: packet-reload.c, hf_reload_storeddata_signature Unused entry: packet-reload.c, hf_reload_storeddataspecifiers (Compile is OK). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39301 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵wmeier1-40/+40
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39288 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-04Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵wmeier1-57/+57
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39260 f5534014-38df-0310-8fa8-9805f1628bb7
2011-09-21Fix vi "modeline" so it works;wmeier1-1/+1
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39074 f5534014-38df-0310-8fa8-9805f1628bb7
2011-05-29- Added new SignatureIdentity values.etxrab1-47/+11
From Marc Petit-Huguenin: - Removed directResponseForwarding. - The certificate_type enum is now defined as RFC 6091's CertificateType so moved the definition to packet-ssl-utils.[ch]. - Fixed invalid values for CERTIFICATE_BY_NODE and CERTIFICATE_BY_USER Kinds. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5967 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37452 f5534014-38df-0310-8fa8-9805f1628bb7
2011-05-18Remove altogether code '#if 0'd in SVN #37229.wmeier1-26/+0
Further research shows that registering the dissector to "tcp.port" and "udp.port" was explicitly removed in SVN #34969 and thus the code to create tcp and udp handles and the associated dissect_reload_tcp() and dissect_reload_udp() code is no longer needed. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37231 f5534014-38df-0310-8fa8-9805f1628bb7
2011-05-18#if 0 some unused code & vars: Coverity 1018 & 1019;wmeier1-0/+7
Add a comment the unused code. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37229 f5534014-38df-0310-8fa8-9805f1628bb7
2011-05-17Use val_to_str() instead of blindly passing the return value from match_strval()morriss1-5/+2
into a format routine (to ensure a non-NULL string pointer). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37203 f5534014-38df-0310-8fa8-9805f1628bb7
2011-05-11Use consistent casing in hf_ descriptions and expert infos.morriss1-112/+112
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37057 f5534014-38df-0310-8fa8-9805f1628bb7
2011-05-06Prefix the message class names with RELOAD_ to prevent collisions.morriss1-9/+9
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37006 f5534014-38df-0310-8fa8-9805f1628bb7
2011-05-06From Marc Petit-Huguenin via ↵morriss1-92/+73
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5894 : - Use "RELOAD" everywhere. - Fix invalid variable name "reload_framing.probe_information.type". - Fix various names to match the spec. - Dissect the X.509 certificate embedded in RELOAD messages. - Use tls_signature_algorithm and tls_hash_algorithm tables in packet-ssl-utils. From me: take out the tabs. Keep the long dissector name when registering the protocols. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37003 f5534014-38df-0310-8fa8-9805f1628bb7
2011-01-30Introduce "Fragment count" filter element for all protocols doing reassembly.stig1-0/+10
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35705 f5534014-38df-0310-8fa8-9805f1628bb7
2011-01-27From Stéphane Bryant: bug fixes and improvements in RELOAD dissector:wmeier1-371/+401
*Bug Fixes *NodeId length is now configurable *Added missing messages See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5620 From me: -Remove trailing blanks from a few lines; -Put "editor mode lines" at the end of the source file. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35674 f5534014-38df-0310-8fa8-9805f1628bb7
2010-11-22From Stephane Bryant via ↵morriss1-6/+0
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5358 : This is a dissector for reload framed message: ReLOAD packets can be inserted in frame message, as described in draft-ietf-p2psip-base-10 From me: remove some unnecessary includes. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35005 f5534014-38df-0310-8fa8-9805f1628bb7
2010-11-19Remove some unnecessary includes.morriss1-5/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34969 f5534014-38df-0310-8fa8-9805f1628bb7
2010-11-19From Stephane Bryant via ↵morriss1-11/+170
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5412 : Update ReLOAD dissector to reflect draft-ietf-p2psip-base-12 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34966 f5534014-38df-0310-8fa8-9805f1628bb7
2010-10-02Add col_clear; Also: Small reformatting and whitespace changeswmeier1-270/+283
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34332 f5534014-38df-0310-8fa8-9805f1628bb7
2010-10-02Remove trailing spaces from a couple of hf namesmorriss1-129/+129
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34321 f5534014-38df-0310-8fa8-9805f1628bb7
2010-10-01Add a couple of casts to make it compile.etxrab1-3/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34306 f5534014-38df-0310-8fa8-9805f1628bb7
2010-10-01Try to fix the Mac build.jake1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34304 f5534014-38df-0310-8fa8-9805f1628bb7
2010-09-30Make it compile.stig1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34301 f5534014-38df-0310-8fa8-9805f1628bb7
2010-09-30From Stéphane Bryant:jake1-0/+2636
New Dissector for the ReLOAD dissector. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34297 f5534014-38df-0310-8fa8-9805f1628bb7
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-09 10:27:49 +0000