aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-parlay.c
AgeCommit message (Collapse)AuthorFilesLines
2020-05-06IDL: Clean up IDL based dissector generationJaap Keuter1-6/+3
Clean up the generators and generated dissectors a bit by updating the header, removing unwanted includes and completing the modelines block. Change-Id: I8ff80b05bb598c3fa5a5f91a24d5caba87eb712e Reviewed-on: https://code.wireshark.org/review/37154 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-05-05IDL: make code generation reproducibleJaap Keuter1-1017/+1017
The current state of generated code from the IDL specification is not reproducible with the current omniidl backend. This change brings the backend in line with the currently committed generated source code. The exception to this is that the exceptions (no pun intended) were collected in a dictionary of unspecified ordering, therefore inherently non-reproducible. These thus differ from the previously committed source code (packet-parlay.c), but do contain the same lines. Also this rolls back commit 443df9389661901e8347f33864e2cd7539dbda9f because the committed generated source files were not created with the backend with this change, nor do they fail to build, as claimed in that commit. Special thanks to Luke Mewburn for working on the dictionary problem. Change-Id: I7707746d263c7556eb06883c877f70f0e9b357c5 Reviewed-on: https://code.wireshark.org/review/37153 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-06idl2wrs: regenerated dissectorsYannik Enss1-1015/+1015
Change-Id: I5ed527df5d0fb6cc4213dbb6b8003a19bc260474 Reviewed-on: https://code.wireshark.org/review/33502 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-04-04epan: Convert our PROTO_ITEM_ macros to inline functions.Gerald Combs1-1/+1
Convert our various PROTO_ITEM_ macros to inline functions and document them. Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c Reviewed-on: https://code.wireshark.org/review/32706 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-29parlay: Add another pragma to disable warningJoão Valverde1-3/+8
Use our DIAG_OFF macros instead while at it. Change-Id: I01d8d71a42fb108be156a68f8552ce537a1e2484 Reviewed-on: https://code.wireshark.org/review/15467 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2015-09-28idl2wrs: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangMichael Mann1-2990/+888
It looks like "items" could have contributed to fields/data being at an incorrect level off of a tree. Change-Id: I93616ef8b6b364c578f989882045dee42cb6d3c3 Reviewed-on: https://code.wireshark.org/review/8558 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-07Remove proto_tree_add_text from idl2wrs generation.Michael Mann1-5/+6
Change-Id: Iab9df3e68d2a3878c3081c6352c45f7c329b983e Reviewed-on: https://code.wireshark.org/review/8323 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-05-06Fix the need to manually adjust packet-gias.c (take 2)Michael Mann1-92/+0
Need to have packet-gias.c in the DIRTY_CORBA_IDL_DISSECTOR_SRC grouping to work around the warnings still generated. Change-Id: I08ea1f7d90577cc112b85e7fc00171827f58d6d2 Reviewed-on: https://code.wireshark.org/review/8266 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-05-01Revert "Fix the need to manually adjust packet-gias.c"Alexis La Goutte1-0/+92
This reverts commit 3ca9318d8215738b8d4edcde0598226cfc6cf031. Mac OS X buildbot are not happy packet-gias.c:356: warning: 'hf_UCO_InvalidInputParameter_details' defined but not used packet-gias.c:359: warning: 'hf_UCO_ProcessingFault_details' defined but not used packet-gias.c:360: warning: 'hf_UCO_SystemFault_details' defined but not used packet-gias.c:5275: warning: 'decode_UCO_Ratio_st' defined but not used packet-gias.c:5303: warning: 'decode_UCO_DirectAccessLocation_st' defined but not used packet-gias.c:5588: warning: 'decode_UCO_Coordinate3d_st' defined but not used packet-gias.c:5612: warning: 'decode_UCO_Circle_st' defined but not used packet-gias.c:5625: warning: 'decode_UCO_Ellipse_st' defined but not used packet-gias.c:5656: warning: 'decode_UCO_SimpleGSImage_st' defined but not used packet-gias.c:5671: warning: 'decode_UCO_SimpleCImage_st' defined but not used packet-gias.c:5694: warning: 'decode_UCO_CompressedImage_st' defined but not used packet-gias.c:5836: warning: 'decode_GIAS_ImageSpec_st' defined but not used Change-Id: Iee076c00eb4e48571a99f6b854b7e3e52983c2f8 Reviewed-on: https://code.wireshark.org/review/8265 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-05-01Fix the need to manually adjust packet-gias.cMichael Mann1-92/+0
Change-Id: I11beada78d2f2b4359d3638cdbcb6f43623fd10c Reviewed-on: https://code.wireshark.org/review/8262 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-04-23idl2wrs: don't use -1 for the protocol-item length.Jeff Morriss1-1/+1
It doesn't work any more for empty (length==0) PDUs. Similar to bug 10646/Ifb96768969a43c59367b73e7bb940ceeb02cf6b0 (for RPC). Untested as I'm not set up to build IDL dissectors now. Bug: 11134 Change-Id: I77aacc2590acbacbe02edb1768e754f92f87bc23 Reviewed-on: https://code.wireshark.org/review/8163 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-04-25Cleanup "excess" from trying to support sequence of "native types". Last ↵Michael Mann1-1821/+952
installment of bug 9532. Cleaned up wireshark_gen.py so that it no longer generates duplicate fields and greatly minimized the number of useless hf_ variables generated. Change-Id: I26b2ddb5b65fcde99787cc2771348aa1b37f919f Reviewed-on: https://code.wireshark.org/review/1329 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-23Continuation of bug 9532.Michael Mann1-614/+1086
Ie4d1edfd67a8e6f02834573f29f07baf79058534 created a several duplicate hf_ registrations. That led to the exposure of some other potential problems with generating sequences. Still not quite complete, but want to pacify the buildbots, so there is a small amount of manual editing to comment out a few duplicated hfs in packet-parlay.c. Change-Id: I0ff8a9795e213ab966db8d6333b9477bad06250b Reviewed-on: https://code.wireshark.org/review/1302 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-04-23Bugfix generating a sequence of "native" types. Bug 9532.Michael Mann1-14/+336
Previously a sequence of "native" types (int, float, etc) generated a proto_tree_add_uint (for the loop over the sequence) and a proto_tree_add_XXX (for the "native" type), but only 1 hf variable was created for the "loop" field, so DISSECTOR_ASSERT_NOT_REACHED would be generated if "native" type != uint. Now a separate hf_ variable is generated for the "loop" and "native" type. Also update existing IDL dissectors with new generator logic. Change-Id: Ie4d1edfd67a8e6f02834573f29f07baf79058534 Reviewed-on: https://code.wireshark.org/review/1274 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-23Fix generator to remove Dead Store (Dead assignement/Dead increment) warning ↵Michael Mann1-748/+745
found by Clang. (not sure why, but regeneration also "moved" some hf_ variables from previous version) Change-Id: I197eacbb3f892dbdca6e6bc354fc88240c1bfb34 Reviewed-on: https://code.wireshark.org/review/1291 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-22Manual fix of Dead Store (Dead assignement/Dead increment) warning found by ↵Alexis La Goutte1-2/+2
Clang No found how to fix the generator... Change-Id: Ic49e8904b44ff733cca0df916b6677e6fb86d9ba Reviewed-on: https://code.wireshark.org/review/1209 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-10Fix warnings in packet-parlay.cAlexis La Goutte1-1/+1
packet-parlay.c:53643:9: warning: passing argument 2 of 'get_CDR_wchar' from incompatible pointer type [enabled by default] packet-parlay.c:53667:9: warning: passing argument 2 of 'get_CDR_wstring' from incompatible pointer type [enabled by default] Change-Id: I027809139e74b563e759f28e2e141951166e53d0 Reviewed-on: https://code.wireshark.org/review/170 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Anders Broman <a.broman58@gmail.com>
2013-12-04Regenerate dissector after change to add prototypeAlexis La Goutte1-747/+750
svn path=/trunk/; revision=53779
2013-12-03Manual fix of Dead Store (Dead assignement/Dead increment) warning found by ↵Alexis La Goutte1-2/+2
Clang No found how to fix the generator... svn path=/trunk/; revision=53757
2013-12-03Regenerate idl dissector after last change in generator !Alexis La Goutte1-5185/+5198
svn path=/trunk/; revision=53756
2013-12-03- copy paste error in parlayAnders Broman1-1/+1
- Add pragmas to remove warnings, this should go into the generation script. svn path=/trunk/; revision=53740
2013-12-02Character conversion error.Anders Broman1-1/+1
svn path=/trunk/; revision=53731
2013-12-02Add pragmas to remove warnings, this should go into the generation script.Anders Broman1-1/+4
svn path=/trunk/; revision=53730
2013-09-08expert_add_info_format_text -> expert_add_info_textMichael Mann1-1866/+1866
svn path=/trunk/; revision=51849
2013-05-24Use new expert info API in idl dissectors. These generated about 50% of the ↵Michael Mann1-1993/+2010
add_expert_info_format() calls. svn path=/trunk/; revision=49561
2013-01-22Fix for CID 761911-761984 and CID 761985-761994.Jaap Keuter1-924/+2148
Try to convince Coverity that the passed in item pointer is appreciated, but not used. This time see if it pleases the Windows compiler too. svn path=/trunk/; revision=47217
2013-01-22Revert 47201 it does not compile on Windows.Anders Broman1-3011/+913
svn path=/trunk/; revision=47208
2013-01-21Fix for CID 761911-761984 and CID 761985-761994.Jaap Keuter1-913/+3011
Try to convince Coverity that the passed in item pointer is appreciated, but not used. svn path=/trunk/; revision=47201
2013-01-18Try and see if we can suppress about half of the Coverity issues.Jaap Keuter1-973/+1831
svn path=/trunk/; revision=47157
2012-12-26Change wireshark_gen.py to make the operation argument to routines aGuy Harris1-1653/+1653
"const char *", as it is now expected to be. Regenerate the dissectors. Update the URL for OmniOrb. In README.parlay, use idl2wrs in the sample command. svn path=/trunk/; revision=46765
2012-11-13Use proto_tree_add_<signed integer> functions for signed giop datatypesMichael Mann1-880/+880
svn path=/trunk/; revision=46021
2012-11-05Add a few more expert_add_info_format calls to giop dissector which requires ↵Michael Mann1-25466/+4096
packet_info* structure and proto_item* to be filtered down through the generated functions. Also removed some excessive whitespace. svn path=/trunk/; revision=45911
2012-10-11Make idl2wrs dissectors filterable - Part 1Michael Mann1-31996/+17575
Updated wireshark_gen.py to generate hf_ variables for all of the IDL "types". The "simple" types use proto_tree_add_* (not text), while the "complex" types use the GIOP dissector API. checkhf.pl generates some warnings because (some of) the hf_ variables are being generated for the "complex" types, but are not being used. That will be done in Part 2. expert_add_info_format now linked to a real item instead of being attached to a duplicative proto_tree_add_text(). This cleaned up literally thousands of unnecessary proto_tree_add_text()s svn path=/trunk/; revision=45472
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-05Replace process_RequestOperation macro by a real function to speedup ↵Pascal Quantin1-938/+946
compilation time svn path=/trunk/; revision=44779
2012-08-14Bug 3725 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3725)Michael Mann1-755/+751
Have giop dissector use more ephemeral memory. Update idl2wrs dissector generator accordingly. svn path=/trunk/; revision=44498
2012-08-08From Michael Mann on -dev:Jeff Morriss1-1/+1
The idl2wrs generated dissectors don't follow the convention of using the filter name registered with the protocol as the start of any display filter name. This patch fixes that. svn path=/trunk/; revision=44325
2012-08-08Use expert infos instead of g_warning when something unexpected is found.Jeff Morriss1-5598/+11197
svn path=/trunk/; revision=44324
2012-07-08Add a function to packet-giop.c that does what the code that Jeff Morriss1-9041/+1150
template_get_CDR_string (in wireshark_gen.py) did. This eliminates another whole pile of function-local variables in packet-parlay.c. Unfortunately it doesn't seem to speed up compilation (or eliminate the variable tracking size limit problem). But it does eliminate a lot of lines of code... svn path=/trunk/; revision=43610
2012-07-08Eliminate a lot of function-local variables by not storing the result ofJeff Morriss1-9303/+8083
(several of the) get_CDR_*() functions: instead call the function directly in the proto_tree_add_text() calls. Eliminate a lot of global variables that are only later used in (a single) strcmp(). All the GIOP dissectors are built-in now; don't include the (#if'd out) plugin registration code in the generated dissector. Try to clean up the formatting of the generated code a bit. Regenerate the IDL dissectors; as noted in r39932, this seems to involve a lot of function re-ordering in packet-parlay.c (making the delta bigger). These changes decrease the time to compile packet-parlay.c by, on my system, about half. But it still complains: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without and it still takes "too long." svn path=/trunk/; revision=43609
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-04Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+2
(Manual Fix, not found how to fix the generator...) svn path=/trunk/; revision=43090
2012-06-01Make the parlay dissector a buil tin dissector.Anders Broman1-0/+105135
svn path=/trunk/; revision=42964
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-23 08:05:12 +0000