aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-ocfs2.c
AgeCommit message (Collapse)AuthorFilesLines
2017-08-09ofcs2: fix 'data' was marked unused but was used [-Wused-but-marked-unused]Alexis La Goutte1-1/+1
Change-Id: Ic04842280e829b30230c7196ab0ba1f49462f295 Reviewed-on: https://code.wireshark.org/review/23016 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-02Use col_append_sep_str() for fixed stringsStig Bjørlykke1-3/+3
Change from col_append_sep_fstr() to col_append_sep_str() when appending strings without formatting. Change-Id: I315aca9b815c204a5bc78f7326402c40d1325f0e Reviewed-on: https://code.wireshark.org/review/20846 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-08Combine Decode As and port preferences for tcp.port dissector table.Michael Mann1-1/+1
This patch introduces new APIs to allow dissectors to have a preference for a (TCP) port, but the underlying data is actually part of Decode As functionality. For now the APIs are intentionally separate from the regular APIs that register a dissector within a dissector table. It may be possible to eventually combine the two so that all dissectors that register with a dissector table have an opportunity to "automatically" have a preference to adjust the "table value" through the preferences dialog. The tcp.port dissector table was used as the guinea pig. This will eventually be expanded to other dissector tables as well (most notably UDP ports). Some dissectors that "shared" a TCP/UDP port preference were also converted. It also removed the need for some preference callback functions (mostly when the callback function was the proto_reg_handoff function) so there is cleanup around that. Dissectors that has a port preference whose default was 0 were switched to using the dissector_add_for_decode_as_with_preference API rather than dissector_add_uint_with_preference Also added comments for TCP ports used that aren't IANA registered. Change-Id: I99604f95d426ad345f4b494598d94178b886eb67 Reviewed-on: https://code.wireshark.org/review/17724 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-09-08OCFS2: dissector incorrectly parses LVB data and claims malformed messageMakoto Shimamura1-26/+46
Some messages related to LVB data are mistakenly treated as malformed. This patch fixes it by checking LVB flags before parsing LVB data. I found that "Convert lock" and "Unlock" use PUT_LVB flags, but "Proxy AST" uses GET_LVB flags. Ping-Bug: 12122 Change-Id: I2c62c8cc9f9bd84abaf92de9f216550101962520 Reviewed-on: https://code.wireshark.org/review/17532 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-09-07OCFS2: dissector incorrectly takes pdu length as little endianMakoto Shimamura1-1/+1
This patch fixes incorrect endian conversion in pdu length. Actually pdu length is big endian. Ping-Bug: 12122 Change-Id: I9f8827293e684a5b4c957138f5879efdd140c500 Reviewed-on: https://code.wireshark.org/review/17533 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-09-07OCFS2: dissector incorrectly treats keepalive messages as unknown typeMakoto Shimamura1-2/+13
Keepalive req/resp messages are shown as "Unknown type (0x00)" in info column. This patch fixes them to "Keepalive Request" and "Keepalive Response". Ping-Bug: 12122 Change-Id: If09192067736b78c7785ba1ff05ae62a05d3dc23 Reviewed-on: https://code.wireshark.org/review/17497 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-20Create call_data_dissector() to call data dissector.Michael Mann1-6/+1
This saves many dissectors the need to find the data dissector and store a handle to it. There were also some that were finding it, but not using it. For others this was the only reason for their handoff function, so it could be eliminated. Change-Id: I5d3f951ee1daa3d30c060d21bd12bbc881a8027b Reviewed-on: https://code.wireshark.org/review/14530 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09new_create_dissector_handle -> create_dissector_handle for dissector directory.Michael Mann1-1/+1
Some of the ASN.1 dissectors still generate a new_create_dissector_handle from the tool itself, so leave those for now. Change-Id: Ic6e5803b1444d7ac24070949f5fd557909a5641f Reviewed-on: https://code.wireshark.org/review/12484 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-24NULL terminate some hf_ arrays used in proto_tree_add_bitmask_xxx calls.Michael Mann1-1/+2
I thought this was already caught by one of the check*.pl scripts, but I ran into the one in packet-nfs.c and decided to manually check the dissector directory. Change-Id: I8df83227255818eabc43763e3cf760cf762797cc Reviewed-on: https://code.wireshark.org/review/11230 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-06-17[ocfs2] trivial changes: unneeded initializer; indentation/whitespaceBill Meier1-118/+118
Change-Id: Icef38e94d5c3e9f5598d55c3e988c94b2798f81f Reviewed-on: https://code.wireshark.org/review/8963 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-06-08Add editor-modelines; Don't use tabwidth=4; Adjust whitespace.Bill Meier1-3/+3
Change-Id: I7c287b176002c48dee6ae44334ee9fad221b4cd3 Reviewed-on: https://code.wireshark.org/review/8816 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-04-09OCFS2: fix some GCC / Clang warningsAlexis La Goutte1-3/+5
packet-ocfs2.c:249: comma at end of enumerator list [-Wpedantic] packet-ocfs2.c:1171: no previous prototype for 'proto_register_ocfs2' [-Wmissing-prototypes] packet-ocfs2.c:1651: no previous prototype for 'proto_reg_handoff_ocfs2' [-Wmissing-prototypes] packet-ocfs2.c:1678:4: no newline at end of file [-Wnewline-eof] Remove also unneed glib.h include Change-Id: I47a03dbc9f175a0e2453dd90a733144ac9f95fc4 Reviewed-on: https://code.wireshark.org/review/8007 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-07Add OCFS2 dissector.Sunil Mushran1-0/+1675
Bug: 5553 Change-Id: If297036b6d7a7afe163d97b05bc4a319d6cf2e97 Reviewed-on: https://code.wireshark.org/review/7949 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-04 04:43:29 +0000