aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-nstrace.c
AgeCommit message (Collapse)AuthorFilesLines
2017-03-28packet-nstrace.c: Ensure value_strings end with {0, NULL}Michael Mann1-2/+2
Change-Id: I548c51dd7333b0dc26a84f77b1e848530b79dde3 Reviewed-on: https://code.wireshark.org/review/20772 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-19nstrace: Updating Additional TCP debugrec labels according to tracedebug optionApeksha Singhal1-14/+387
Change-Id: I4fc9efba068078f9ae6be4d74fb6fbcb9a6545c3 Reviewed-on: https://code.wireshark.org/review/20450 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-05nstrace: fix this statement may fall through [-Werror=implicit-fallthrough=] ↵Alexis La Goutte1-5/+5
found by gcc7 Change-Id: I1943798d8dc7449e962856fef6286b9d74be0d34 Reviewed-on: https://code.wireshark.org/review/20407 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-09-22Dropped packet: Add dropped packets info in netscaler tracePriyanka Mondal1-0/+6
Change-Id: I2a9806026413c5971e5ecad17cd80787130cb9ed Reviewed-on: https://code.wireshark.org/review/17803 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-21nstrace: fix Control flow issues (UNREACHABLE) found by Coverity (CID 1371612)Alexis La Goutte1-4/+3
Change-Id: I76b3956d5b346412af5ff3aa5e0f6263dcb525a4 Reviewed-on: https://code.wireshark.org/review/17202 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-14nstrace: Modified the nstrace dissector to dissect the tcp debug2, tcp cc, ↵Priyanka Mondal1-41/+504
httpinfo and trcdbg records. bug: 12685 Change-Id: I5e224c38c52d7b6635fba1334d9e310ce1eaea23 Reviewed-on: https://code.wireshark.org/review/16338 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-01Reorder ns_dir_vals into numerical orderMichael Mann1-39/+40
Change-Id: I21a50015dd382c62aa2dc84d90bbb4b86ea8b1dc Reviewed-on: https://code.wireshark.org/review/16825 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-31packet-nstrace.c: General cleanupMichael Mann1-228/+127
Motivation was to clean up the use of offsetof() as the structure definitions aren't necessary for Wireshark. Change-Id: I6fadce0d4823842270be89bbed6081d37254ff2b Reviewed-on: https://code.wireshark.org/review/16791 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-20Manually add protocol dependencies derived from find_dissector.Michael Mann1-3/+4
Started by grepping call_dissector_with_data, call_dissector_only and call_dissector and traced the handles passed into them to a find_dissector within the dissector. Then replaced find_dissector with find_dissector_add_dependency and added the protocol id from the dissector. "data" dissector was not considered to be a dependency. Change-Id: I15d0d77301306587ef8e7af5876e74231816890d Reviewed-on: https://code.wireshark.org/review/14509 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-06Nstrace: Fix field name for nstrace.tcpdbg.rtrttUli Heilmeier1-1/+1
Wrong fieldname for nstrace.tcpdbg.tcprtt (was nstrace.tcpdbg.tcpack) Bug: 11964 Change-Id: Ic3e6131eeb3d46f77e4042020afb7c4ecf8dcc9f Reviewed-on: https://code.wireshark.org/review/13079 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09new_create_dissector_handle -> create_dissector_handle for dissector directory.Michael Mann1-1/+1
Some of the ASN.1 dissectors still generate a new_create_dissector_handle from the tool itself, so leave those for now. Change-Id: Ic6e5803b1444d7ac24070949f5fd557909a5641f Reviewed-on: https://code.wireshark.org/review/12484 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-07Spelling fixes for errors found by lintianBalint Reczey1-2/+2
Change-Id: I889283902875193f4d3f3fd59788f59f8d9bcc20 Reviewed-on: https://code.wireshark.org/review/11945 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-20More spelling fixes found by lintianBalint Reczey1-1/+1
Change-Id: Id218dec9e5a721d6c63fd34962ffe50b6ab8dd56 Reviewed-on: https://code.wireshark.org/review/11946 Reviewed-by: Guy Harris <guy@alum.mit.edu> Reviewed-by: Diederik de Groot <dkgroot@talon.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-16create_dissector_handle -> new_create_dissector_handleMichael Mann1-3/+5
Picking off "easy" dissectors that only have one or two exit points at most. Change-Id: I96aa9cf53533cbb07105aa400d42922baf3016b3 Reviewed-on: https://code.wireshark.org/review/11860 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-02Interpret reserved fields netscaler header.anilkumar9111-0/+35
Change-Id: I64d6ae733bda880f5afbe1a755799823d835bfa4 Reviewed-on: https://code.wireshark.org/review/9466 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-22Netscaler: Add support to read MTCP record.anilkumar9111-4/+45
Change-Id: I73aadb10e44aa64c6f4c9cc2145a63f5bd9c74e5 Reviewed-on: https://code.wireshark.org/review/8580 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-22Convert proto_tree_add_boolean to ↵Michael Mann1-28/+13
proto_tree_add_bitmask_[value|value_with_flags|list] Part 2 of a few Change-Id: Ic1f1aafe2ed02dce95b15c03a91cbd68807a5cf4 Reviewed-on: https://code.wireshark.org/review/8165 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-04-20Make offset unsigned int. anilkumar9111-1/+1
Change-Id: Ieb7f8a7735b8dd73f180a385294c3b8ca7ceaefb Reviewed-on: https://code.wireshark.org/review/8060 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-13More casts.Guy Harris1-3/+3
Change-Id: I0c8969bcb986350fa58f65d8e67394766b734286 Reviewed-on: https://code.wireshark.org/review/8055 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-13Cast away some warnings.Guy Harris1-6/+6
offsetof() doesn't necessarily return an int-sized value; cast it to guint. Change-Id: Ie0072d62de0178f87bc3168e3f8f1a03d9ec69d5 Reviewed-on: https://code.wireshark.org/review/8053 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-13Support for new netscaler 3.5 trace format.anilkumar9111-5/+657
Change-Id: Ica74f3f9239a96486967cf248feb4313bc390734 Reviewed-on: https://code.wireshark.org/review/7751 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-23NetScaler Trace: Missing break in switch (CID 281457, 727776 & 1021060)Alexis La Goutte1-1/+3
Change-Id: I575114ba364da1b1d63eea8fc7b48c8c0e0bc99d Reviewed-on: https://code.wireshark.org/review/5991 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-2/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-04Add editor modelines; Reformat as appropriate.Bill Meier1-0/+13
Change-Id: I8e9c58b75eea85877d22024201e5d8d0e9a3dbfd Reviewed-on: https://code.wireshark.org/review/4459 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-07-04convert to proto_tree_add_subtree[_format]Michael Mann1-5/+2
Change-Id: Idd1b20ab32c0960ea52c6f3bc5346462c37c5684 Reviewed-on: https://code.wireshark.org/review/2853 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-04-06Apply found fix-encoding-args.pl errors in the dissector directory.Michael Mann1-2/+2
I coincidentally found a few files with errors, so I thought it might be time to run it on the whole directory again. Change-Id: Ia32e54b3b1b94e5a418ed758ea79807c8bc7e798 Reviewed-on: https://code.wireshark.org/review/978 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-16Support to version 3.0 of netscaler packet wire format.Guy Harris1-3/+8
From shekhar.chandra@citrix.com. See bug 9280. Change-Id: If3abbc653bb1f127b151976d4183af4c4f1e71eb Reviewed-on: https://code.wireshark.org/review/658 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-14Fix some trivial warnings.Jakub Zawadzki1-0/+3
svn path=/trunk/; revision=54085
2013-10-28Revert SVN #52914;Bill Meier1-8/+3
OSX-10.6-x64 buildbot still givs an error (At least we now know which line of code gives the error). svn path=/trunk/; revision=52915
2013-10-28From Shekhar Chandra: support for version 3.0 of netscaler packet wire format.Bill Meier1-3/+8
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9280 (Revised patch: let's see if this version compiles w/o error on all the buildbots) svn path=/trunk/; revision=52914
2013-10-18Revert SVN #52665.Bill Meier1-7/+1
Compilation fails on (only the ?) OSX-10.6-x64 buildbot with error: netscaler.c: In function 'nstrace_read_v30': netscaler.c:1295: warning: implicit conversion shortens 64-bit value into a 32-bit value (Life is too short for me to dig multiple levels deep into a set of macros to try to see which actual line of code is causing the problem. Maybe the patch submitter can identify the problem). svn path=/trunk/; revision=52666
2013-10-18From Shekhar Chandra: support for version 3.0 of netscaler packet wire format.Bill Meier1-1/+7
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9280 From me: fix indentation(tabs->spaces) and trailing whitespace. svn path=/trunk/; revision=52665
2013-09-15emem -> wmemPascal Quantin1-4/+7
svn path=/trunk/; revision=52063
2013-09-15Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if ↵Michael Mann1-2/+2
hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly. The script didn't catch as many as I would have liked, but it's a start. The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum. svn path=/trunk/; revision=52045
2013-07-01Do whitespace cleanup;Bill Meier1-123/+171
Reformat hf[] entries. svn path=/trunk/; revision=50307
2013-07-01Define certain 'const char *...' arrays as static.Bill Meier1-1/+1
Reduces code memory usage and execution time. (See SVN #50271) svn path=/trunk/; revision=50292
2013-05-11From Ravi Kondamuru via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8637Evan Huus1-0/+61
Add support for version 2.6 of netscaler capture format. svn path=/trunk/; revision=49250
2013-02-19How can I get a new tvbuff that starts at an offset within a givenGuy Harris1-1/+1
tvbuff and runs to the end of the tvbuff? Let me count the ways.... Replace a bunch of different ways of doing that (some incorrect, in that they're not properly handling tvbuffs where the captured and reported lengths are different) with tvb_new_subset_remaining(). svn path=/trunk/; revision=47751
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-14Address buildbot error:Anders Broman1-1/+1
packet-nstrace.c: In function 'dissect_nstrace': packet-nstrace.c:131: warning: 'dst_vmname_len' may be used uninitialized in this function packet-nstrace.c:131: warning: 'src_vmname_len' may be used uninitialized in this function svn path=/trunk/; revision=44898
2012-09-14From Nikhil Kalu:Anders Broman1-0/+39
Enhancement to add more trace record fields in Citrix NetScaler capture file format. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7713 svn path=/trunk/; revision=44895
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-03-22From Krishna:Anders Broman1-4/+100
Enhancement to add more trace record fields in Citrix NetScaler capture file format. https://bugs.wireshark.org/bugzilla/show_bug.cgi? svn path=/trunk/; revision=41740
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-8/+8
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-2/+2
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-04-06#include <string.h> not needed.Bill Meier1-1/+0
svn path=/trunk/; revision=32410
2009-12-04From: Ravi Kondamuru:Bill Meier1-11/+17
"... a patch to make the netscaler wiretap code independent of the host system endian-ness. I have taken care of (1) reading and writing nstrace files (netscaler.c) and (2) reading in dissector code (packet-nstrace.c) also." See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3540#c26 svn path=/trunk/; revision=31171
2009-06-01Removed some unused hf_ entries.Stig Bjørlykke1-20/+10
Renamed filter abbrev from ns. to nstrace. svn path=/trunk/; revision=28571
2009-06-01From Ravi Kondamuru via bug 3457: Stig Bjørlykke1-0/+191
Add support to read citrix netscaler capture file format. From me: - Renamed packet-ns.c to packet-nstrace.c - Rewrote to not use "goto" in netscaler.c - Moved dissecting of coreid svn path=/trunk/; revision=28564