aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-nat-pmp.c
AgeCommit message (Collapse)AuthorFilesLines
2016-10-13Convert most UDP dissectors to use "auto" preferences.Michael Mann1-6/+3
Similar to the "tcp.port" changes in I99604f95d426ad345f4b494598d94178b886eb67, convert dissectors that use "udp.port". More cleanup done on dissectors that use both TCP and UDP dissector tables, so that less preference callbacks exist. Change-Id: If07be9b9e850c244336a7069599cd554ce312dd3 Reviewed-on: https://code.wireshark.org/review/18120 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-04Add length checks.Guy Harris1-24/+58
While scanning through the Prefix64 option, check to make sure we haven't run past the end of the option. The Prefix64 option requires that the prefix length be <= 12, and, if it's not, we end up with part of the prefix having a negative length. Check to make sure that it is <= 12. While we're at it, use proto_tree_add_item_ret_uint(), update IETF document references to use RFCs rather tha earlier I-Ds, and add references for RFC 7220 and RFC 7225. Hopefully this fixes the *real* problem that CID 1363032 was complaining about. Change-Id: I1592de31f1d4f4ed6e6cdc141516fb764f21d2fb Reviewed-on: https://code.wireshark.org/review/16287 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-09new_create_dissector_handle -> create_dissector_handle for dissector directory.Michael Mann1-2/+2
Some of the ASN.1 dissectors still generate a new_create_dissector_handle from the tool itself, so leave those for now. Change-Id: Ic6e5803b1444d7ac24070949f5fd557909a5641f Reviewed-on: https://code.wireshark.org/review/12484 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-06-15TFS: Mutualize Response/Request TFSAlexis La Goutte1-5/+0
move tfs_response_request to epan/tfs.[ch] and use this Change-Id: I29d5894fade721b5234649a7c2d83dd1d6a19a0d Reviewed-on: https://code.wireshark.org/review/8930 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-06-15PCP: fix dissection of R bitPascal Quantin1-4/+4
Request and response values were inverted. Bug: 11278 Change-Id: I9b337f423055578252cc01211d74c77837b7ae87 Reviewed-on: https://code.wireshark.org/review/8924 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-11-27Fix a number of dup hf[] filter-names probably mostly resulting from ↵Bill Meier1-1/+1
cut/paste errs Change-Id: Id658b9e1803b2f5b92e711a3ce981ff602333d98 Reviewed-on: https://code.wireshark.org/review/5513 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-07-04convert to proto_tree_add_subtree[_format]Michael Mann1-2/+1
Change-Id: Idd1b20ab32c0960ea52c6f3bc5346462c37c5684 Reviewed-on: https://code.wireshark.org/review/2853 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-20Rename dissector_add_handle() to dissector_add_for_decode_as().Guy Harris1-1/+1
Hopefully that name makes it clear what the routiner's purpose is, and will encourage people to use it rather than using dissector_add_uint() with a bogus integer value. Change-Id: Ic5be456d0ad40b176aab01712ab7b13aed5de2a8 Reviewed-on: https://code.wireshark.org/review/2483 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-05-20PCP: Remove whitespace before (Alexis La Goutte1-93/+93
Change-Id: I199895718311867be4c589137074c18ac4d45eea Reviewed-on: https://code.wireshark.org/review/1701 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-05-20PCP: Discovering NAT64 IPv6 Prefixes Using the Port Control Protocol (RFC7225)Alexis La Goutte1-0/+59
Change-Id: Ib404c3db8c13ebb0a2e1f6d9f767a183896f869f Reviewed-on: https://code.wireshark.org/review/1700 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-05-20PCP: Add Description Option for the Port Control Protocol (RFC 7220)Alexis La Goutte1-0/+11
Change-Id: I2931b14855981e71d1135a8ff7cc3b494a2a7572 Reviewed-on: https://code.wireshark.org/review/1699 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-05-20PCP : Enhance display of Option...Alexis La Goutte1-13/+23
* Display reserved using FT_BYTES * Set option code in option subtree Change-Id: Ie6cf32ed260ddccceaa9f617f0a74982c95f08f5 Reviewed-on: https://code.wireshark.org/review/1698 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-14Fix [-Wmissing-prototypes]Jakub Zawadzki1-0/+3
svn path=/trunk/; revision=54095
2013-10-13whitespace fixes; mostly: remove trailing blanksBill Meier1-9/+9
svn path=/trunk/; revision=52591
2013-09-09expert_add_info_format_text -> expert_add_info_formatMichael Mann1-3/+3
svn path=/trunk/; revision=51852
2013-05-27Batch of filterable expert infosMichael Mann1-3/+22
svn path=/trunk/; revision=49596
2013-05-20From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8631Alexis La Goutte1-13/+30
Fix to honour the Response Bit/Opcode implementation, as e.g. a map response opcode is not 129 as per 1000 0001 but should be Response bit =1 / Opcode =1. * Rename opcode variable to ropcode (and pcp_ropcode_vals) * Use pcp_opcode for hf_pcp_opcode * Add hf for R item (and add tfs) * Fix bitmask for opcode Also fix warning found by encoding-args tool. svn path=/trunk/; revision=49445
2013-05-07From Christian Koenning via ↵Alexis La Goutte1-4/+4
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8631 RFC 6887 Port Control Protocol Response 96 bit reserved not 64 bit As per RFC 6887 the response header has 96bit reserved bit, not 64. Without the attached patch, the PCP Responses are parsed incorrectly svn path=/trunk/; revision=49202
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus1-2/+2
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-02-01Fix format string error.Evan Huus1-1/+1
svn path=/trunk/; revision=47406
2013-02-01Add Port Control Protocol dissector and convert NAT-PMP dissector to "new" ↵Michael Mann1-15/+488
style. The Port Control Protocol overtakes the NAT-PMP IANA UDP ports, but is backwards compatible enough to trigger off of the version number (NAT-PMP is version 0). NAT-PMP can still use Decode As. Left the two dissectors with their own unique display filters despite a few overlapping fields. Didn't want it to turn into a BOOTP/DHCP situation. svn path=/trunk/; revision=47405
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-2/+0
svn path=/trunk/; revision=45017
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2011-09-21Fix ex "modeline" so it works;Bill Meier1-1/+1
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748 svn path=/trunk/; revision=39081
2011-07-19Use ENC_NA as encoding for FT_PROTOCOL, FT_NONE and FT_BYTES.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=38122
2011-07-19Use correct encoding for proto_tree_add_item().Stig Bjørlykke1-15/+15
svn path=/trunk/; revision=38107
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-2/+2
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2009-09-06s/col_add_fstr/col_add_strKovarththanan Rajaratnam1-1/+1
svn path=/trunk/; revision=29727
2009-09-06Don't pass ep_alloc()'ed strings to col_set_str().Kovarththanan Rajaratnam1-1/+1
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3984 svn path=/trunk/; revision=29726
2009-07-23Set editor modelines to be consistent between emacs and vi/ex;Bill Meier1-2/+2
Indentation and whitespace cleanup; svn path=/trunk/; revision=29180
2009-07-07Remove some check_col() calls.Stig Bjørlykke1-7/+3
svn path=/trunk/; revision=28974
2009-03-15Adjusted my name to use only ASCII characters.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=27733
2009-03-03Moved the dissector_handle_t.Stig Bjørlykke1-2/+2
svn path=/trunk/; revision=27596
2009-02-25Port Mapping Protocol, not Plug-'n-Play.Guy Harris1-0/+240
Give the I-D number and a URL to the (now-expired) draft. svn path=/trunk/; revision=27538
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-12 06:38:18 +0000