aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-mpeg-descriptor.c
AgeCommit message (Collapse)AuthorFilesLines
2017-01-29Bugfix MPEG descriptor Logon Initialize Descriptor tag.Michael Mann1-53/+65
Do length checks in case not all fields are present to prevent malformed packets. Bug: 13237 Change-Id: Ie7cc3006fa33f1dedeffb09a4f35adb8dee8e9f6 Ping-Bug: 13238 Reviewed-on: https://code.wireshark.org/review/19390 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-13Adjust proto_tree_add_[float|double]_format_value calls to use unit stringMichael Mann1-6/+6
Several calls to proto_tree_add_[float|double]_xxx could be better served using BASE_UNIT_STRING with a "unit string" in hf_ field. Added a few more "common" unit string values to unit_strings.[ch] Change-Id: Id0da7b579403898d20c2667d6c4abcd59d5a48d4 Reviewed-on: https://code.wireshark.org/review/19241 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-11Add support for PMT parsing of ATSC A/52 Audio stream type and AC-3 descriptorDevin Heitmueller1-0/+300
The ATSC A/52 specification introduces a new PMT stream type, as well as a new descriptor if the A/52 stream contains AC-3 audio. Add dissection for both. Change-Id: I859c76cc4fc6550c72711f00582e6bfa12607fa2 Reviewed-on: https://code.wireshark.org/review/16679 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-08Fix a lot of typos and misspellingsmoshekaplan1-4/+4
Change-Id: I8512cfa1d424f82a873a0e0e1d22c7b075fdd7f3 Reviewed-on: https://code.wireshark.org/review/13069 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-28The symbol rate in the Cable Delivery System Descriptor is in Mega-Symbols/sMartin Kaiser1-1/+1
Change-Id: I1446500f1c5c89b8ed94c04b04bb6985ae827731 Reviewed-on: https://code.wireshark.org/review/6095 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-3/+2
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-13Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...Bill Meier1-1/+1
(for some dissectors which fetch all other integral fields using ENC_BIG_ENDIAN). Change-Id: Ic18e3172aad76af12b12d6732c88497be22aed56 Reviewed-on: https://code.wireshark.org/review/5748 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-18Fix encoding-arg mostly for FT_UINT_STRING; Also: Do misc as needed.Bill Meier1-3/+2
Misc: (as needed) - Add editor modelines; - Adjust whitespace. Change-Id: I0e5d877a2a6273842ad8e771ac0c0acbfcb83200 Reviewed-on: https://code.wireshark.org/review/4173 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-08-21add component descriptor values for HEVC servicesMartin Kaiser1-0/+6
Change-Id: I28e55dc95a55ad80aa2ce59ab6c5d495d8eb7d99 Reviewed-on: https://code.wireshark.org/review/3779 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-08-21add service type for HEVC digital television serviceMartin Kaiser1-0/+1
Change-Id: I9aab67250d9fe7dc83243b55bbc2cb964c140e46 Reviewed-on: https://code.wireshark.org/review/3778 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-08-14Eliminate proto_tree_add_text from some dissectors.Michael Mann1-3/+10
Other minor cleanup while in the neighborhood. Change-Id: If73a029f564219782c313d4154c24c7ce7458b52 Reviewed-on: https://code.wireshark.org/review/3574 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-07-04convert to proto_tree_add_subtree[_format]Michael Mann1-20/+13
Change-Id: I621f2e2cad9403449cb78f45302388f0c874d3bc Reviewed-on: https://code.wireshark.org/review/2852 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-05-31do a plausibility check for interaction channel dataMartin Kaiser1-1/+7
in the linkage descriptor Change-Id: I7ebca539076b2b881e82fd6baec5bb223e778a52 Reviewed-on: https://code.wireshark.org/review/1896 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-31make population id filterableMartin Kaiser1-3/+4
Change-Id: I3381e1c35795ac33331cdddb8cefa8b0a16907cc Reviewed-on: https://code.wireshark.org/review/1894 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-30make terrestrial centre frequency filterableMartin Kaiser1-5/+8
Change-Id: I007ff5215f52f80f25622cab6980128eabd39c5f Reviewed-on: https://code.wireshark.org/review/1888 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-30make next time offset filterableMartin Kaiser1-8/+8
Change-Id: I18c2b7992b237eaaacbec04d504fc293b03558a3 Reviewed-on: https://code.wireshark.org/review/1887 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-30make local time offset filterableMartin Kaiser1-8/+10
Change-Id: Icccc07706287df4b6a7481108f9921b939aae2d5 Reviewed-on: https://code.wireshark.org/review/1886 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-29convert cable freq, symbol rate into doublesMartin Kaiser1-12/+12
Change-Id: Iaddd3c4847e803af855c847212ae822b2529ff06 Reviewed-on: https://code.wireshark.org/review/1860 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-29conver sat freq and symbol rate into doubles in order to make theMartin Kaiser1-13/+14
filtering work, fix typos Change-Id: I7ed989807826d1322dab00d13d998488caaf73ff Reviewed-on: https://code.wireshark.org/review/1859 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-27use proto_tree_add_float_format_value() correctlyMartin Kaiser1-5/+5
Change-Id: I927a2f32aa0016b5b0c476fa4c16fc1dbe0aebb0 Reviewed-on: https://code.wireshark.org/review/1825 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-27make cable symbol rate filterableMartin Kaiser1-12/+9
Change-Id: I034b351d4bc12f6c00a0224a5c5b9f85496657b6 Reviewed-on: https://code.wireshark.org/review/1824 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-27make cable frequency filterableMartin Kaiser1-10/+10
Change-Id: I8464fb8e98e485523127dd95948a717554b6aee4 Reviewed-on: https://code.wireshark.org/review/1823 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-27make the satellite symbol rate filterableMartin Kaiser1-12/+10
Change-Id: I301d0804e097c62cd8bf7b27003918eedab9616a Reviewed-on: https://code.wireshark.org/review/1816 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-27make satellite orbital position filterableMartin Kaiser1-9/+6
Change-Id: Ibd4edd30eca969699fea1971e1885299e4d3e552 Reviewed-on: https://code.wireshark.org/review/1813 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-22Wrong length of Modulation Type and Modulation System fields in Satellite ↵Roman Volkov1-2/+2
Delivery Descriptor According EN300468 in Satellite Delivery Descriptor 'Modulation System' field has 1 bit length. 'Modulation Type' has 2 bits length. But in my Wireshark 'Modulation System' is 2 bit long and 'Modulation Type' is 1 bit long. bug: 10119 Change-Id: I762145418bbfc9c0621ee7ca1a07d35afb6d7d92 Reviewed-on: https://code.wireshark.org/review/1718 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-05-19change the satellite frequency into a float (freq in GHz)Martin Kaiser1-10/+9
and make it filterable Change-Id: I0644e5c69ff58301c00ea3d37e80f25b856168e4 Reviewed-on: https://code.wireshark.org/review/1689 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-04-10display LCNs as decimal numberMartin Kaiser1-1/+1
this makes them easier to compare with your TVs channel list Change-Id: Ie78d1a7df8aa83455ff723fa523b84a067231e5f Reviewed-on: https://code.wireshark.org/review/1063 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-04-10use the CI+ value string for CI+ descriptor tagsMartin Kaiser1-1/+2
Change-Id: I48f3304f74263672a65a74f523f14ebb7950d2d6 Reviewed-on: https://code.wireshark.org/review/1062 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-03skip empty service provider name and empty service nameMartin Kaiser1-11/+15
Change-Id: I355600320865a9c7c17093d37fc693b02f0a7f0c Reviewed-on: https://code.wireshark.org/review/457 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-03-03service provider name is a DVB-SI stringMartin Kaiser1-2/+12
Change-Id: Idea44f0e4678f738336215f4a250b9e9d9a60fbc Reviewed-on: https://code.wireshark.org/review/456 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-03-03service name is a DVB-SI stringMartin Kaiser1-3/+15
Change-Id: I81ef4cd363acf6cff99fd0f75b135962c4c22f53 Reviewed-on: https://code.wireshark.org/review/455 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-01-08use a DVB string for the text field in the extended event descriptorMartin Kaiser1-9/+21
check for text length 0 while we're at it svn path=/trunk/; revision=54666
2014-01-05use a DVB string for the event text in the short evt descriptorMartin Kaiser1-3/+13
svn path=/trunk/; revision=54599
2013-12-18Fix [-Wmissing-prototypes]Anders Broman1-0/+1
svn path=/trunk/; revision=54209
2013-12-15Fix [-Wmissing-prototypes]Jakub Zawadzki1-0/+2
svn path=/trunk/; revision=54135
2013-12-15improve DVB-SI string handlingMartin Kaiser1-3/+3
new function dvb_add_chartbl() adds a tree entry for an encoding use FT_BTYES as type for encoding hfs string hfs for DVB-SI strings must have STR_UNICODE, not BASE_NONE make dvb_string_encoding_vals[] internal to dvb_chartbl.c svn path=/trunk/; revision=54128
2013-12-15as requested, move the functions/defines for DVB character tablesMartin Kaiser1-1/+1
to separate files svn path=/trunk/; revision=54113
2013-12-10use large positve values for illegal DVB-SI string encodingsMartin Kaiser1-2/+2
interpret encoding fields as UINT32 so that the displayed value matches the actual bytes in the packet svn path=/trunk/; revision=53927
2013-12-09ignore empty textsMartin Kaiser1-5/+8
svn path=/trunk/; revision=53892
2013-12-09use the DVB-SI string hadling for the short event descriptorMartin Kaiser1-3/+14
svn path=/trunk/; revision=53891
2013-11-14share Data Broadcast IDs between MPEG descriptor and DVB-CIMartin Kaiser1-1/+2
svn path=/trunk/; revision=53323
2013-11-14add Data Broadcast ID for CI+ and HbbTVMartin Kaiser1-0/+2
svn path=/trunk/; revision=53321
2013-11-13share service type descriptions between MPEG descriptor and DVB-CIMartin Kaiser1-1/+2
svn path=/trunk/; revision=53307
2013-10-30add one more private data specifierMartin Kaiser1-3/+5
svn path=/trunk/; revision=52986
2013-10-23#if 0 numerous "unused const variables" (mostly value-string-arrays);Bill Meier1-0/+2
Also; fix a few "set but not used" warnings. svn path=/trunk/; revision=52780
2013-10-07dissect mpeg registration descriptorMartin Kaiser1-0/+33
svn path=/trunk/; revision=52437
2013-09-29Convert proto_tree_add_time_format to either proto_tree_add_time or ↵Michael Mann1-3/+1
proto_tree_add_time_format_value. Only proto_tree_add_time_format calls remaining are in packet-ncp2222.inc, which may just need some additional filters. svn path=/trunk/; revision=52269
2013-09-15Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if ↵Michael Mann1-1/+1
hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly. The script didn't catch as many as I would have liked, but it's a start. The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum. svn path=/trunk/; revision=52045
2013-09-02Fix warning found by fix-encoding-args toolsAlexis La Goutte1-2/+2
svn path=/trunk/; revision=51684