aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-mac-lte.c
AgeCommit message (Collapse)AuthorFilesLines
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-3/+3
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-05-25MAC LTE: fix dissection of Extended Power Headroom control elementPascal Quantin1-19/+36
Change-Id: Ia57b4769732f2e18dd2864b576c5c77fc68deb20 Reviewed-on: https://code.wireshark.org/review/1798 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-05-25Grab-bag of dead initializers and two actual bugs.Evan Huus1-2/+4
All caught by cppcheck. The two (semi)-interesting bugs are: - in asn1/atn-cpdlc/packet-atn-cpdlc-template.c where the break statement should have been inside the brace, causing potential control-flow weirdness with exceptions - in epan/dissectors/packet-ieee80211.c where the bounds check for tag_len did not match the expert info given Change-Id: Ie173fb8d917aabb9b4571435d671d6f16e1c7569 Reviewed-on: https://code.wireshark.org/review/1793 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-05-08MAC LTE: add a comment explaining why g_hash_table_lookup_extended is usedPascal Quantin1-0/+2
Change-Id: I9d7310359d5972c603396a802abc2a82b46fe57e Reviewed-on: https://code.wireshark.org/review/1563 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-05-08MAC LTE: fix copy/paste errorPascal Quantin1-1/+1
Change-Id: I59fd7745d454357d3eeaf48ed8700581a8aa0018 Reviewed-on: https://code.wireshark.org/review/1556 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-05-08MAC LTE: get extended BSR sizes configuration from RRCPascal Quantin1-9/+111
Change-Id: I09afa7c17be5e0ed902a2c2f5ea9989df3380615 Reviewed-on: https://code.wireshark.org/review/1550 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-05-05MAC/RLC/PDCP LTE: replace obsolete APIsPascal Quantin1-19/+19
Change-Id: I5368cc7b1986c6a87cb70a3fd3cb5e589d73f870 Reviewed-on: https://code.wireshark.org/review/1520 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-05-04MAC LTE: fix compilation errorPascal Quantin1-4/+10
error: assignment discards 'const' qualifier from pointer target type [-Werror] also add the missing definition of hf_mac_lte_bsr_size_median Change-Id: I31e172a16b4afd59ba8cf5a9b281bbeaf15b6c56 Reviewed-on: https://code.wireshark.org/review/1492 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-05-03Have RRC tell MAC about RAPID ranges so it can show for RAPIDs seenMartin Mathieson1-5/+62
Change-Id: Ie9adbe3015c63e53997068053b6f8ec224a5bf82 Reviewed-on: https://code.wireshark.org/review/1474 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-04-28Update SR and DRX tracking when see UL CRC error'd frame, and add anMartin Mathieson1-17/+161
option to add generated items corresponding to the middle of BSR ranges (suitable for plotting/stats). Change-Id: I73b4e82ea5fb869d93d9666b9f8c9a10562db365 Reviewed-on: https://code.wireshark.org/review/1419 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-03-12MAC LTE: fix a typo in Buffer Size value_stringMartin Mathieson1-1/+1
Change-Id: Ie38726fb51a74bbcdc630550e61fa0e934ffdd1e Reviewed-on: https://code.wireshark.org/review/618 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-25Remove trailing whitespace.Bill Meier1-17/+17
Change-Id: Ia03a1cd4590aceda30ead4aa93ad413d90c6aea6 Reviewed-on: https://code.wireshark.org/review/372 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-03Fix all -fstrict-alias warnings found by gcc 4.1.2Gilbert Ramirez1-1/+1
The majority of the fixes are for calls to uat_new(). Instead of having each caller cast its private data to (void**), we use void* in the uat_new() API itself. Inside uat_new(), we cast the void* to void**. Some dissectors use val64_string arrays, so a VALS64() macro was added for those, to avoid using VALS(), which is useful only for value_string arrays. packet-mq.c was changed because dissect_nt_sid() requires a char**, not a guint**. All other callers of dissect_nt_sid() use char*'s (and take the address of it) for their local storage. So, this was changed to follow the other practices. A confusion between gint and absolute_time_display_e in packet-time.c was cleared up. The ugliest fix is the addition of ip6_guint8_to_str(), for exactly one caller. The caller uses one type of ip6 address byte array, while ip6_to_str() expects another. This new function is in place until the various address implementations can be consolidated. Add VALS64() to the developer documentation. Change-Id: If93ff5c6c8c7cc3c9510d7fb78fa9108e4552805 Reviewed-on: https://code.wireshark.org/review/48 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-01-28Comment out unused hf[] entries and related found by checkhf.Bill Meier1-2/+6
svn path=/trunk/; revision=54989
2013-12-22From Fabrice Bellard:Pascal Quantin1-26/+83
Add Carrier Id and detailed PHY info to MAC LTE UDP framing dissector svn path=/trunk/; revision=54370
2013-12-19Add out-of-band send_preamble event to UDP framing protocolPascal Quantin1-0/+7
svn path=/trunk/; revision=54277
2013-12-19Add System Frame Number to UDP framing protocol and display it in info columnPascal Quantin1-6/+11
svn path=/trunk/; revision=54272
2013-12-14Fix const warnings.Jakub Zawadzki1-3/+6
svn path=/trunk/; revision=54092
2013-12-14Fix warningsJakub Zawadzki1-0/+2
svn path=/trunk/; revision=54089
2013-12-12Trivial: Tab -> spaces.Chris Maynard1-2/+2
svn path=/trunk/; revision=53967
2013-12-12Remove some TODOs that have now been addressedMartin Mathieson1-3/+0
svn path=/trunk/; revision=53961
2013-12-11Remove an unused variableMartin Mathieson1-2/+0
svn path=/trunk/; revision=53933
2013-12-11Convert to new-style dissector, change crcStatusValid to a gboolean, and ↵Martin Mathieson1-109/+139
rework DRX timers (again) svn path=/trunk/; revision=53932
2013-11-23Create the ability to have packet scoped "proto" data. Bug 9470 ↵Michael Mann1-8/+8
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9470) I'm not sold on the name or module the proto_data functions live in, but I believe the function arguments are solid and gives us the most flexibility for the future. And search/replace of a function name is easy enough to do. The big driving force for getting this in sooner rather than later is the saved memory on ethernet packets (and IP packets soon), that used to have file_scope() proto data when all it needed was packet_scope() data (technically packet_info->pool scoped), strictly for Decode As. All dissectors that use p_add_proto_data() only for Decode As functionality have been converted to using packet_scope(). All other dissectors were converted to using file_scope() which was the original scope for "proto" data. svn path=/trunk/; revision=53520
2013-11-22Tweak filter names for expert items, mostly to consistently use - rather than _Martin Mathieson1-21/+21
svn path=/trunk/; revision=53514
2013-11-10Add missing includes in order to remove exceptions.h from proto.h (next commit).Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53230
2013-10-22Handle long gaps between PDUs by resetting timers, and show ↵Martin Mathieson1-7/+26
short-cycle-timer as part of state svn path=/trunk/; revision=52770
2013-10-22Show state of other DRX timers, and update some comments.Martin Mathieson1-7/+41
svn path=/trunk/; revision=52765
2013-10-21Improve the way DRX before and after state is shown.Martin Mathieson1-42/+82
svn path=/trunk/; revision=52747
2013-10-16Remove trailing blanks; Fix some indentation;Bill Meier1-4/+16
Add editor modelines. svn path=/trunk/; revision=52653
2013-10-13DRX: start to show state prior to and after current PDU.Martin Mathieson1-71/+96
svn path=/trunk/; revision=52594
2013-10-13whitespace fixes; mostly: remove trailing blanksBill Meier1-20/+20
svn path=/trunk/; revision=52591
2013-10-09Don't update DRX state when preference is turned offMartin Mathieson1-77/+90
svn path=/trunk/; revision=52482
2013-10-08Separate state struct into separate config and running_state structs. Also, ↵Martin Mathieson1-55/+63
mod startOffset when working out if short cycle onDuration should be started svn path=/trunk/; revision=52450
2013-10-07Starting to debug DRX supportMartin Mathieson1-38/+45
svn path=/trunk/; revision=52443
2013-10-04More DRX changesMartin Mathieson1-27/+99
svn path=/trunk/; revision=52365
2013-10-03Try to please Linux and OSX buildbotsPascal Quantin1-0/+1
svn path=/trunk/; revision=52344
2013-10-03More DRX changes - getting closer (still mostly untested)Martin Mathieson1-81/+159
svn path=/trunk/; revision=52342
2013-10-02Remove C++ commentsPascal Quantin1-3/+3
svn path=/trunk/; revision=52339
2013-10-02More progress on DRX checkingMartin Mathieson1-67/+134
svn path=/trunk/; revision=52333
2013-10-01Call mac_lte_drx_control_element_received and make it static againMartin Mathieson1-5/+5
svn path=/trunk/; revision=52318
2013-09-30Deep copy needed (clang warning flagged by Alexis!)Martin Mathieson1-2/+2
svn path=/trunk/; revision=52291
2013-09-27And also where it is declared. Doesn't VSC++ warn about anything?Martin Mathieson1-1/+2
svn path=/trunk/; revision=52232
2013-09-27Temporarily make an uncalled function non-static, until it gets calledMartin Mathieson1-2/+2
svn path=/trunk/; revision=52231
2013-09-27Remove unused parameterMartin Mathieson1-2/+2
svn path=/trunk/; revision=52230
2013-09-27Another step towards DRX support in LTE MACMartin Mathieson1-67/+147
svn path=/trunk/; revision=52229
2013-09-23Another step towards tracking UE DRX stateMartin Mathieson1-5/+67
svn path=/trunk/; revision=52190
2013-09-09expert_add_info_format_text -> expert_add_info_formatMichael Mann1-45/+45
svn path=/trunk/; revision=51852
2013-09-05Move where timing reference for DRX timers will be setMartin Mathieson1-27/+29
svn path=/trunk/; revision=51783