aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-lte-rrc.c
AgeCommit message (Collapse)AuthorFilesLines
2016-06-23LTE RRC: fix display of info column when receiving a BR SIBPascal Quantin1-7/+29
Change-Id: Ic288cb10fad3bd34fe088479e7a79f77985808e0 Reviewed-on: https://code.wireshark.org/review/16098 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-15Allow control of individual columns to be (un)writable.Michael Mann1-2/+2
Most protocols just want to limit COL_INFO or COL_PROTOCOL so give that level of granularity. Bug: 12144 Bug: 5117 Bug: 11144 Change-Id: I8de9b7d2c69e90d3fbfc0a52c2bd78c3de58e2f8 Reviewed-on: https://code.wireshark.org/review/15894 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-05-31LTE-RRC: fix dissection of GPRS containerPascal Quantin1-1/+15
Payload embedded in LTE message does not include the first byte identifying the message type. Let's prepend a fake one before calling the gsm_rlcmac dissector Change-Id: Ibcf9b52902474a556b55e9b0a076d09d341f868c Reviewed-on: https://code.wireshark.org/review/15642 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-04-03LTE RRC: upgrade dissector to v13.1.0Pascal Quantin1-4279/+11585
Change-Id: I830c97f6f228a61b942f3b4df46ccdd22a043b5e Reviewed-on: https://code.wireshark.org/review/14796 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-13Move /asn1 to /epan/dissectorsJoão Valverde1-16/+16
Change-Id: I1208fe3c2ba428995526f561e8f792b8d871e9a9 Reviewed-on: https://code.wireshark.org/review/14388 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: João Valverde <j@v6e.pt>
2016-02-22LTE RRC: add a unit to gnss-TOD-msec fieldPascal Quantin1-0/+1
Change-Id: I48b15d47d9bdf1bb4078a03ee7183f05bb57fa04 Reviewed-on: https://code.wireshark.org/review/14072 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-02-10LTE RRC: fix defragmentation of ETWS / CMAS messagesPascal Quantin1-8/+8
Change-Id: I59d7e3dc3398973290746fc15a2dc9f24cfc03e3 Reviewed-on: https://code.wireshark.org/review/13884 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-02-04Fix asn2wrs warnings [-Wredundant-decls]João Valverde1-5/+4
Change-Id: Iced801f17c56618eaaf1bb7c85d68ecdebd633a1 Reviewed-on: https://code.wireshark.org/review/13705 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-01LTE RRC: add system info modification for eDRX UEs in info columnPascal Quantin1-4/+10
Change-Id: I8041bf74c37665f1fd70f0d8c39157e09f79d96c Reviewed-on: https://code.wireshark.org/review/13638 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-31RLC LTE: upgrade dissector to v13.0.0Pascal Quantin1-6/+38
Change-Id: Ibe4586925ffe49f5aaab72956c40e123855a1a1e Reviewed-on: https://code.wireshark.org/review/13620 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-26PDCP LTE: upgrade dissector to v13.0.0Pascal Quantin1-0/+7
Change-Id: Iae4a38ac7b80978d1ad02168e79c0fe0bffd8d2e Reviewed-on: https://code.wireshark.org/review/13549 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-25Move the proto data stuff out of frame_data.[ch].Guy Harris1-7/+8
It's not tied to the frame_data structure any more, so it belongs by itself. Clean up some #includes while we're at it; in particular, frame_data.h doesn't use anything related to tvbuffs, so don't have it gratuitiously include tvbuff.h. Change-Id: Ic32922d4a3840bac47007c5d4c546b8842245e0c Reviewed-on: https://code.wireshark.org/review/13518 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-24Add the packet number to the packet_info structure, and use it.Guy Harris1-3/+3
That removes most of the uses of the frame number field in the frame_data structure. Change-Id: Ie22e4533e87f8360d7c0a61ca6ffb796cc233f22 Reviewed-on: https://code.wireshark.org/review/13509 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-15LTE RRC: upgrade dissector to v13.0.0Pascal Quantin1-1748/+12527
Change-Id: Ie41471f79191097c491d58949c4e90b314cade04 Reviewed-on: https://code.wireshark.org/review/13300 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-10Convert ASN.1 dissectors to remove "new" from "new-style" dissector function ↵Michael Mann1-11/+11
names that were generated from asn2wrs.py This includes: 1. new_create_dissector_handle -> create_dissector_handle 2. new_register_dissector -> register_dissector 3. new_register_ber_oid_dissector -> register_ber_oid_dissector 4. new_register_ber_syntax_dissector -> register_ber_syntax_dissector Also remove PDU_NEW, SYNTAX_NEW and REGISTER_NEW as there is no need for the distinction anymore. Change-Id: I82c7de7c8ffeeab3259d1b55bb4afc5f6a1e0329 Reviewed-on: https://code.wireshark.org/review/12491 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09"new" dissector API -> dissector API for ASN.1 dissectors.Michael Mann1-10/+10
Change-Id: I7b794cba2feda2cae40411e2b1cb9fb091d08220 Reviewed-on: https://code.wireshark.org/review/12480 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-22register_dissector -> new_register_dissector for ASN.1 dissectors.Michael Mann1-33/+43
Change-Id: I0476519c02ffdd426b4fdfe8a206d61b728c327a Reviewed-on: https://code.wireshark.org/review/12026 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-04Don't include "file.h" if you don't need it.Guy Harris1-7/+9
It ends up dragging in libwireshark headers, which programs not linking with libwireshark shouldn't do. In particular, including <epan/address.h> causes some functions that refer to libwireshark functions to be defined if the compiler doesn't handle "static inline" the way GCC does, and you end up requiring libwireshark even though you shouldn't require it. Move plurality() to wsutil/str_util.h, so that non-libwireshark code can get it without include epan/packet.h. Fix includes as necessary. Change-Id: Ie4819719da4c2b349f61445112aa419e99b977d3 Reviewed-on: https://code.wireshark.org/review/11545 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-09-29LTE RRC: upgrade dissector to v12.7.0Pascal Quantin1-606/+1718
Change-Id: I95660eb302fde06c2034b023e60c7b83c67fe71b Reviewed-on: https://code.wireshark.org/review/10680 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-09-11LTE RRC: add a top level function for SBCCH SL BCH messagesPascal Quantin1-3/+18
Change-Id: I91c66f81d245b4398fecbd4c6b655baad5431b53 Reviewed-on: https://code.wireshark.org/review/10489 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-09-11LTE RRC: remove tree tests before decoding top level messagesPascal Quantin1-35/+21
It prevents proper update of Info column, and various other things Change-Id: I355c46e6f6b3f923250d6b5bf720ea052ef3b646 Reviewed-on: https://code.wireshark.org/review/10488 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-09-10LTE RRC: catch bounds errors triggered by subdissectorsPascal Quantin1-16/+30
Report the exception and continue dissection of the end of RRC message This is useful when there is an invalid NAS EPS message like in bug 11513 Change-Id: I74154892fe8125df57ef5a6966273d6df777977a Reviewed-on: https://code.wireshark.org/review/10463 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-07-21LTE RRC: fix a typoPascal Quantin1-1/+1
Let's have consistent naming for dissectors Change-Id: I03d14e208692f39a7ae5017bd539f38f14abaa1f Reviewed-on: https://code.wireshark.org/review/9737 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-07-16LTE RRC: fix dissection of ETWS/CMAS warning messagesPascal Quantin1-18/+266
Change-Id: I20bb219a32b6c7e39ac415c5c13ad5379f78cba2 Reviewed-on: https://code.wireshark.org/review/9658 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-07-10LTE RRC: upgrade dissector to v12.6.0Pascal Quantin1-17/+181
Change-Id: I6e8271f98cba0074b27df73a21337d388efcdc7a Reviewed-on: https://code.wireshark.org/review/9578 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-07-04asn1: split off cleanup routinesPeter Wu1-7/+8
General approach: 1. Split allocation (e.g. g_hash_table_new) from deallocation (g_hash_table_destroy) into functions named "init" and "cleanup". 2. Remove guards that test whether the hash tables are set as init is always called before cleanup. 3. Remove setting hash tables to NULL after destruction. 4. Copy register_init_routine function call and change init to cleanup. 5. Add cleanup function that calls reassembly_table_destroy if there is a reassembly_table_init function. Some templates were modified as follows: - snmp: split renew into init+cleanup, but keep renew for the uat_new callback. - ldap,ros: Rename init to cleanup as there was no initialization. - camel: remove init function from header, make it static. Remove debug print. - tcap: remove unused ssn_range assignment. Files in epan/ were regenerated using cmake && make asn1 Change-Id: Idac16ebf0ec304e0c8becaab5d32904e56eb69b9 Reviewed-on: https://code.wireshark.org/review/9136 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-04-01LTE RRC: fix a typo introduced in g9aa624dPascal Quantin1-2/+2
Change-Id: Ia1bb68c64ca4cb820790dc84abee9cc222a1d0e4 Reviewed-on: https://code.wireshark.org/review/7874 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-03-31LTE RRC: upgrade dissector to v12.5.0Pascal Quantin1-12601/+15396
Change-Id: I9e3dfb17b4b7f96be999ccea88fec754a936d312 Reviewed-on: https://code.wireshark.org/review/7869 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-03-13LTE RRC: enhance dissection of Extended Access Barring CategoryPascal Quantin1-12/+12
Change-Id: I6e13ae8c4e95f5915541bc33d89faa61dade2058 Reviewed-on: https://code.wireshark.org/review/7674 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-02-18Add a CF_FUNC macro for casting BASE_CUSTOM functions.Gerald Combs1-96/+96
Add a CF_FUNC macro to match VALS, TFS, etc. This should help us to avoid the following warning: warning: ISO C forbids initialization between function pointer and 'void *' [-Wpedantic] We could start adding DIAG_OFF+DIAG_ON everywhere but this seems to be more consistent with the other macros in proto.h. Update each instance of BASE_CUSTOM to use CF_FUNC. Adjust a dummy variable name generated by asn2wrs.py that was triggering an invalid error in checkhf.pl. Fix an encoding arguement in packet-elasticsearch.c found by fix-encoding-args.pl. Change-Id: Id0e75076c2d71736639d486f47b87bab84e07d22 Reviewed-on: https://code.wireshark.org/review/7150 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-02LTE RRC: only display band mapping for the initial supportedBandListEUTRA IEPascal Quantin1-21/+45
Handling bands > 64 would require to store the mapping in file scope and current code is broken for the Carrier Aggregation band combination list Change-Id: I9f10022a50520ca9bc16a33f2c16361729f1b01b Reviewed-on: https://code.wireshark.org/review/6917 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-01-13MAC LTE: upgrade dissector to v12.4.0Pascal Quantin1-4/+38
Change-Id: Ieb5395a6ae7a1d7625fe645d0caf14008993d3d9 Reviewed-on: https://code.wireshark.org/review/6521 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-01-11LTE RRC: upgrade dissector to v12.4.0Pascal Quantin1-1476/+6681
Change-Id: I0bd6c124bd3aa0efe09db81135adc690751e08ae Reviewed-on: https://code.wireshark.org/review/6477 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-12-23asn1 generated dissectors: cleanup #include usageBill Meier1-10/+7
Change-Id: I36b2731d67f9345d2fd0c23800bba7d2be94c387 Reviewed-on: https://code.wireshark.org/review/6008 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-09LTE RRC: upgrade dissector to v12.3.0Pascal Quantin1-752/+4391
Change-Id: Iac974bf505bed270fc1f9409a7d61c80ebca17a5 Reviewed-on: https://code.wireshark.org/review/5691 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-12-09LTE: Update MAC and RLC dissectors to Release 12Pascal Quantin1-20/+22
Change-Id: I036a0d1180b6481e8cc27210ed44eda4ba078a27 Reviewed-on: https://code.wireshark.org/review/5659 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-09-24Allow the HandoverPreparationInfoPDU dissector to be looked up by name and ↵Martin Mathieson1-3/+27
called. Change-Id: I9c22b74d5c3329b6c7d74547d26e940c84ffc66c Reviewed-on: https://code.wireshark.org/review/4247 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-15Show RRC Release cause in the Info columnMartin Mathieson1-1/+6
Change-Id: I138859ce735a9ff6541d6852dec29a13c1034c36 Reviewed-on: https://code.wireshark.org/review/4114 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-09-08Try to fix build error by giving function a return typeMartin Mathieson1-1/+1
Change-Id: I157b6309bc8cb0bef6fc0cd213fd4ec7e4c375ef Reviewed-on: https://code.wireshark.org/review/4035 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-09-08Show band info for inter-freq entries in UE capabilities. Addresses ↵Martin Mathieson1-7/+64
Pascal's comments. Change-Id: Ie60dc73e40a2ac1d80197fa712075ccff83cf797 Reviewed-on: https://code.wireshark.org/review/4032 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-08-09LTE RRC: fix dissection of CDMA System Time broken in gcd02af5Pascal Quantin1-6/+6
Also put back initial text indentation Change-Id: I6fe207086018a806a258b1de2888ac0b9310aac6 Reviewed-on: https://code.wireshark.org/review/3524 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-08-09Eliminate (almost all) proto_tree_add_text calls from ASN.1 dissectors.Michael Mann1-15/+34
This mostly involved adding expert info capabilities to many of the dissectors so that they could correctly flag error conditions. Only remaining proto_tree_add_text calls are in H248.cnf, which has a convoluted way of using hf_ data to make its tree. Change-Id: I6412150c2ec1977d7fa38f3f0ed416680bdfb141 Reviewed-on: https://code.wireshark.org/review/3500 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-07-08LTE RRC: upgrade dissector to v11.8.0Pascal Quantin1-126/+535
Change-Id: I2bb0861029d0d30ae372b0b8085fbedeb4932217 Reviewed-on: https://code.wireshark.org/review/2949 Tested-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-22convert to proto_tree_add_subtree[_format] for ASN.1 dissectorsMichael Mann1-6/+6
Change-Id: I753ca95e2e1b38bad2c09955317e648c525e40ef Reviewed-on: https://code.wireshark.org/review/2509 Tested-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-20Rename dissector_add_handle() to dissector_add_for_decode_as().Guy Harris1-1/+1
Hopefully that name makes it clear what the routiner's purpose is, and will encourage people to use it rather than using dissector_add_uint() with a bogus integer value. Change-Id: Ic5be456d0ad40b176aab01712ab7b13aed5de2a8 Reviewed-on: https://code.wireshark.org/review/2483 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-16Convert a bunch of time_to_str functions to wmemEvan Huus1-6/+6
Change-Id: I24fe3cc4a3589dadc4528a77fe7ff13d06b1a983 Reviewed-on: https://code.wireshark.org/review/2245 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-1/+1
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-05-08MAC LTE: get extended BSR sizes configuration from RRCPascal Quantin1-0/+12
Change-Id: I09afa7c17be5e0ed902a2c2f5ea9989df3380615 Reviewed-on: https://code.wireshark.org/review/1550 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-05-03Have RRC tell MAC about RAPID ranges so it can show for RAPIDs seenMartin Mathieson1-0/+2
Change-Id: Ie9adbe3015c63e53997068053b6f8ec224a5bf82 Reviewed-on: https://code.wireshark.org/review/1474 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-04-15LTE RRC: break the sr-configIndex down into periodicity and subframe offsetMartin Mathieson1-12/+70
Change-Id: I5e153ebba9957f3dc5551f540cf333a1d0ff89f7 Reviewed-on: https://code.wireshark.org/review/1141 Reviewed-by: Anders Broman <a.broman58@gmail.com>