aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-ldap.c
AgeCommit message (Collapse)AuthorFilesLines
2012-07-08UATs could be put into "categories". The categories were defined onlyguy1-2/+4
implicitly by the #define name and string they were defined to; not all UATs neatly fit into any of the categories, so some of them were put into categories that weren't obviously correct for them, and one - the display filter macro UAT - wasn't put into any category at all (which caused crashes when editing them, as the GUI code that handled UAT changes from a dialog assumed the category field was non-null). The category was, in practice, used only to decide, in the aforementioned GUI code, whether the packet summary pane needed to be updated or not. It also offered no option of "don't update the packet summary pane *and* don't redissect anything", which is what would be appropriate for the display filter macro UAT. Replace the category with a set of fields indicating what the UAT affects; we currently offer "dissection", which applies to most UATs (any UAT in libwireshark presumably affects dissection at a minimum) and "the set of named fields that exist". Changing any UAT that affects dissection requires a redissection; changing any UAT that affects the set of named fields that exist requires a redissection *and* rebuilding the packet summary pane. Perhaps we also need "filtering", so that if you change a display filter macro, we re-filter, in case the display is currently filtered with a display filter that uses a macro that changed. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43603 f5534014-38df-0310-8fa8-9805f1628bb7
2012-06-28Update Free Software Foundation address.darkjames1-1/+1
(COPYING will be updated in next commit) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43536 f5534014-38df-0310-8fa8-9805f1628bb7
2012-06-20Use separate filters for the RTT found on a SACK and the RTT found on amorriss1-327/+515
DATA chunk: having them in both places is helpful when looking at the messages but having them separate is helpful when graphing the RTTs. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43406 f5534014-38df-0310-8fa8-9805f1628bb7
2012-03-02Remove now unused variables.etxrab1-4/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@41319 f5534014-38df-0310-8fa8-9805f1628bb7
2012-03-02Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clangalagoutte1-7/+6
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@41298 f5534014-38df-0310-8fa8-9805f1628bb7
2011-11-20Get rid of Warnings.etxrab1-31/+31
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39954 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-15Update generated ASN1 *.[hc] files after recent work done by Jeff Morriss;wmeier1-1/+1
The only change in each file is in a comment showing the asn2wrs cmd used to build that file. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39427 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-10Convert 'encoding' parameter of certain proto_tree_add_item() calls in asn1/*:wmeier1-2/+2
Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_IPv6 use ENC_NA. (This was missed in SVN #39260) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39332 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in asn1 ↵wmeier1-6/+6
dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39294 f5534014-38df-0310-8fa8-9805f1628bb7
2011-05-13Regenerate ASN.1 dissectors to update the #line directive.stig1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37118 f5534014-38df-0310-8fa8-9805f1628bb7
2011-04-21From Stefan Metzmacher and Gregor Beck via ↵morriss1-5/+34
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5850 : The smallest LDAP PDU is 7 bytes, not 4. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36777 f5534014-38df-0310-8fa8-9805f1628bb7
2011-04-11Regenerate the ANSI MAP, LDAP, and TETRA dissectors so that Coverity cangerald1-58/+58
locate their template files. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36569 f5534014-38df-0310-8fa8-9805f1628bb7
2011-03-14Properly initialize our filter counters.gerald1-27/+31
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36190 f5534014-38df-0310-8fa8-9805f1628bb7
2011-03-01If we encounter an excessively long filter string or one with too manygerald1-16/+33
elements, add an expert item and throw a ReportedBoundsError. We may want to handle this more cleanly in the future but this avoids allocating a huge amount of memory. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36101 f5534014-38df-0310-8fa8-9805f1628bb7
2011-02-23Split get_dns_name() into get_dns_name() and expand_dns_name().gerald1-62/+18
In dissect_ms_compressed_string() dissect_mscldap_string() simply call expand_dns_name() instead of using duplicate (and insecure) code. This *might* break CLDAP and SMB dissection. If that's the case we should probably revert get_dns_name() and simplify expand_dns_name(). Fixes infinite recursion errors found by joernchen of Phenoelit. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36029 f5534014-38df-0310-8fa8-9805f1628bb7
2011-02-10Declare ett's as gint, not guint.cmaynard1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35902 f5534014-38df-0310-8fa8-9805f1628bb7
2011-01-11ldap.cnf:782: warning: ISO C90 forbids mixed declarations and codeetxrab1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35476 f5534014-38df-0310-8fa8-9805f1628bb7
2011-01-11From Matthieu Patou <mat@samba.org>sahlberg1-22/+94
Dissect LDAP DirSyncFlags to show the bits of this bitmap. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35474 f5534014-38df-0310-8fa8-9805f1628bb7
2011-01-06More misc. CLDAP improvements for Active Directory including updatingsfisher1-36/+48
field names and adding descriptions, changing the Domain GUID in the "LDAP ping" response to a FT_GUID instead of FT_BYTES, etc. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35407 f5534014-38df-0310-8fa8-9805f1628bb7
2011-01-06More minor cleanup/fixes for MS Active Directory's use of CLDAP.sfisher1-26/+19
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35404 f5534014-38df-0310-8fa8-9805f1628bb7
2011-01-06Minor corrections to NtVer dissection for NETLOGON_NT_VERSION Options Bitssfisher1-72/+75
in MSCLDAP packets per Microsoft's MS-ADTS specification, section 7.3.1.1, revision 26 (11/19/2010). Also re-format code a bit. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35403 f5534014-38df-0310-8fa8-9805f1628bb7
2010-12-20Rename the routines that handle dissector tables with unsigned integerguy1-6/+6
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35224 f5534014-38df-0310-8fa8-9805f1628bb7
2010-12-06Make some prefs callback functions static. (These modules don't use ↵morriss1-2/+4
proto_reg_handoff_*() as their prefs callback.) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35138 f5534014-38df-0310-8fa8-9805f1628bb7
2010-09-21The CLDAP attribute value on a CLDAP reply is no longer being decodedetxrab1-1/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5239 It got broken in Revision 33390 I think, if attr_type is unset at this point it should be set in the calling function. http://anonsvn.wireshark.org/viewvc/trunk/asn1/ldap/ldap.cnf?r1=33388&r2=33390 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34176 f5534014-38df-0310-8fa8-9805f1628bb7
2010-07-01Initialize more variables.gerald1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33392 f5534014-38df-0310-8fa8-9805f1628bb7
2010-06-30Initialize a variable.gerald1-29/+31
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33390 f5534014-38df-0310-8fa8-9805f1628bb7
2010-06-30Initialize a variable.gerald1-10/+11
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33388 f5534014-38df-0310-8fa8-9805f1628bb7
2010-06-27Initialize attributedesc_string in a couple of places so that wegerald1-21/+19
don't end up trying to use an invalid pointer. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33341 f5534014-38df-0310-8fa8-9805f1628bb7
2010-05-13Use find_or_create_conversation() in some ASN.1 dissectorsmorriss1-19/+7
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32791 f5534014-38df-0310-8fa8-9805f1628bb7
2010-05-11Add a little more code to avoid not-very-useful blurbs:morriss1-32/+32
- Change spaces in the name to underscores before comparing it to the blurb. - Check if the type simply as T_ prepended to the name. - Don't put in a blurb of "NULL". and regenerate the dissectors. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32748 f5534014-38df-0310-8fa8-9805f1628bb7
2010-05-11Regenerate a few more of the ASN.1 dissectorsmorriss1-143/+143
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32744 f5534014-38df-0310-8fa8-9805f1628bb7
2010-04-06#include <stdio.h> not needed.wmeier1-7/+6
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32405 f5534014-38df-0310-8fa8-9805f1628bb7
2010-02-23Try to fix compilation with MSVC.etxrab1-6/+6
Please review. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31962 f5534014-38df-0310-8fa8-9805f1628bb7
2010-02-23Squelch a bunch of compiler warnings.guy1-23/+23
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31961 f5534014-38df-0310-8fa8-9805f1628bb7
2010-01-25Export the dissect_mscldap_string() that is used to dissectsahlberg1-1/+1
compressed dns strings. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31650 f5534014-38df-0310-8fa8-9805f1628bb7
2010-01-17Get rid of check_col();etxrab1-60/+51
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31552 f5534014-38df-0310-8fa8-9805f1628bb7
2009-12-24Add NULL pointer checks. Fixes the fuzz crash in bug 4351.gerald1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31362 f5534014-38df-0310-8fa8-9805f1628bb7
2009-12-12From Mathieu Parent:jake1-48/+126
As defined in rfc4511 [Lightweight Directory Access Protocol (LDAP): The Protocol], see the attached patch that dissects IntermediateMessage. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31251 f5534014-38df-0310-8fa8-9805f1628bb7
2009-12-09From Mathieu Parent:dimeg1-49/+339
Dissector for LDAP Content Synchronization Operation (Modified in order to remove the unneeded oid_add_from_string's) https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4309 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31218 f5534014-38df-0310-8fa8-9805f1628bb7
2009-12-04From Bug 4298:dimeg1-2/+8
Add additional LDAP OIDs for LDAP Content Synchronization Operation (Slightly modified in order to add code in packet-ldap-template.c) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31179 f5534014-38df-0310-8fa8-9805f1628bb7
2009-11-21Use gint when declaring a tree type variablekrj1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31040 f5534014-38df-0310-8fa8-9805f1628bb7
2009-10-30Apply r30376 to asn1 template files.stig1-6/+6
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30767 f5534014-38df-0310-8fa8-9805f1628bb7
2009-10-25From Jakub Zawadzki:etxrab1-3/+1
Cleanup dissector code - use proper memory functions. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30691 f5534014-38df-0310-8fa8-9805f1628bb7
2009-10-11Remove unused variablekrj1-1/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30506 f5534014-38df-0310-8fa8-9805f1628bb7
2009-10-10Regenerate asn1 dissectors (no functionality change)krj1-6/+6
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30476 f5534014-38df-0310-8fa8-9805f1628bb7
2009-10-09Backport r29665 to template file so that the change is not overwritten when ↵krj1-58/+57
we regenerate the dissector git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30455 f5534014-38df-0310-8fa8-9805f1628bb7
2009-10-09Regenerate asn1 dissectors (no change, only some line offset changes)krj1-36/+37
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30454 f5534014-38df-0310-8fa8-9805f1628bb7
2009-09-24* Prefer col_append_str instead of col_append_fstr for constant stringskrj1-2/+1
* Remove check_col guards git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30127 f5534014-38df-0310-8fa8-9805f1628bb7
2009-09-02No need to include packet-frame.hjmayer1-1/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29665 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-16Switch a bunch of dissectors over to using tvb_new_subset_remaining()krj1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29446 f5534014-38df-0310-8fa8-9805f1628bb7