aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-jxta.c
AgeCommit message (Collapse)AuthorFilesLines
2011-01-08If the lack of a peer conversation is a bug, use one of theGuy Harris1-9/+7
dissector-bug macros. If it's just that we're missing some packets, we should handle that as best we can and, if there's stuff we can't do, maybe put something into the protocol summary or tree saying "not enough information". Don't just spit out a warning message which the user might not even see. svn path=/trunk/; revision=35426
2010-05-13As suggested in ↵Jeff Morriss1-10/+1
http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html (as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 : Write a new convenience routine for finding a conversation and, if it is not found, create it. The frame number and addresses are taken from pinfo (as is the common case). Use this function in a bunch of dissectors. svn path=/trunk/; revision=32790
2010-04-03Remove unneeded #include <stdio.h>Bill Meier1-1/+0
svn path=/trunk/; revision=32367
2009-10-09From Didier Gautheron:Anders Broman1-3/+3
Dissectors using call_dissector() function inside a 'if (tree) {}' block. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4107 svn path=/trunk/; revision=30415
2009-09-06Rename address_to_str() to ep_address_to_str() because:Kovarththanan Rajaratnam1-12/+12
1) This indicates that the string has ephemeral lifetime 2) More consistent with its existing seasonal counterpart, se_address_to_str(). svn path=/trunk/; revision=29747
2009-08-16Switch a bunch of dissectors over to using tvb_new_subset_remaining()Kovarththanan Rajaratnam1-8/+8
svn path=/trunk/; revision=29446
2009-08-09Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-12/+4
svn path=/trunk/; revision=29345
2009-07-07Changed flags_set_truth -> tfs_set_notsetStig Bjørlykke1-11/+11
svn path=/trunk/; revision=28989
2009-07-07From Kovarththanan Rajaratnam:Stig Bjørlykke1-220/+220
Move hf/ett into proto_register_jxta() and do some field cleanup svn path=/trunk/; revision=28984
2009-06-24From Kovarththanan Rajaratnam:Stig Bjørlykke1-2/+2
More hf_register_info related cleanup. svn path=/trunk/; revision=28832
2009-05-14Apply some of the patches from:Anders Broman1-2/+1
http://wiki.wireshark.org/Development/Optimization svn path=/trunk/; revision=28363
2009-04-06Fix compiler warning/errorsStephen Fisher1-1/+1
svn path=/trunk/; revision=27969
2009-04-06More size_t casts/fixes, and string buffers.Gerald Combs1-40/+35
svn path=/trunk/; revision=27968
2009-01-17Use ascii_strdown_inplace instead of g_ascii_strdown in a few places.Bill Meier1-5/+3
This also fixes a few cases where memory was not freed after g_ascii_strdown. svn path=/trunk/; revision=27254
2008-10-27Minor rework related to proto_reg_handoffBill Meier1-9/+6
svn path=/trunk/; revision=26588
2008-06-25Constify a bunch of stuff, to squelch -Wwrite-strings warnings. Guy Harris1-1/+1
epan/dissectors/packet-ncp2222.inc is a bit hard to fix, so we're not ready to enable that warning by default yet. Throw in some casts to handle GLib routines that take arbitrary non-const pointers (they can later return the pointers, and some callers might want to modify or free up those pointers in cases where they're known to be writable or allocated). Use ep_tvb_memdup() rather than a combination of ep_alloc() and tvb_memcpy(). Clean up some indentation. svn path=/trunk/; revision=25601
2008-04-07- Remove GLIB1 codeStephen Fisher1-5/+0
- Change ugly GLIB version checking statements to GLIB_CHECK_VERSION - Remove ws_strsplit files because we no longer need to borrow GLIB2's g_strsplit code for the no longer supported GLIB1 builds svn path=/trunk/; revision=24829
2008-03-02Added missing array for hf_jxta_element2_encodingid.Stig Bjørlykke1-0/+4
svn path=/trunk/; revision=24530
2008-01-29cleanup initial comment. fix urls and email addresses.Mike Duigou1-6/+7
svn path=/trunk/; revision=24224
2007-12-05svn path=/trunk/; revision=23758Mike Duigou1-12/+1
2007-11-26Get rid of C++/C99 style comments--not all compilers support themJeff Morriss1-37/+37
svn path=/trunk/; revision=23608
2007-10-23Apply the small performance enhancment patches for:Anders Broman1-1/+1
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster. Replace - col_append_fstr() with faster col_append_str() - col_add_str() with col_set_str() when it's safe svn path=/trunk/; revision=23252
2007-10-02coverity 263 check if variable is null before dereferencing itRonnie Sahlberg1-2/+3
svn path=/trunk/; revision=23046
2007-09-29"pinfo->match_string" is a "const char *"; save it into a variable ofGuy Harris1-1/+1
the same type - that makes compilers much happier. svn path=/trunk/; revision=23029
2007-09-28Improves dissection of JXTA traffic from http connections. Mike Duigou1-282/+360
Improved address display in packet summary panes. more options for jxta pdu filtering by addresses. svn path=/trunk/; revision=23019
2007-08-21Fix a known- and marked-by-a-comment memory leak: replace g_strdup() with ↵Jeff Morriss1-2/+1
se_strdup(). (The address in question is stored in a conversation structure so it's "seasonal".) svn path=/trunk/; revision=22579
2007-08-21Change COPY_ADDRESS to SE_COPY_ADDRESS: all of these appear to have ↵Jeff Morriss1-7/+7
"seasonal" scope (e.g., they are used in conversations or similar). svn path=/trunk/; revision=22573
2007-04-14fix MacOSX gcc-3.3 warnings about unused tfs/value_string variablesSebastien Tandel1-4/+0
most have been tagged unused (few have been deleted if dissector has not been modified since a long time) move packet-ssl-utils.c to DISSECTOR_SRC svn path=/trunk/; revision=21431
2007-04-03From Mike Duigou:Richard van der Hoff1-7/+7
The enclosed patch corrects a problem where jxta elements were being added to the protocol tree for segments that did not contain complete jxta frames. This patch ensures that the jxta proto elements are only added those the segments that end a complete, assembled jxta frame. The patch has been fuzz tested with a broad selection of jxta captures and ran successfully overnight for over 4000 iterations. svn path=/trunk/; revision=21305
2007-03-28Remove almost all of the casts I committed recently and in place ofStephen Fisher1-12/+12
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it. svn path=/trunk/; revision=21253
2007-03-27Fix about 100 simple to fix warnings from gcc 4.0 in epan/dissectors Stephen Fisher1-12/+12
svn path=/trunk/; revision=21233
2007-03-24Clean up some more warnings: unused variables, unitialized variables, wrong ↵Jeff Morriss1-24/+31
format (%ld instead of %d) in packet-sccp.c svn path=/trunk/; revision=21167
2007-03-23fix a lot more warningsUlf Lamping1-4/+4
svn path=/trunk/; revision=21142
2007-02-18From Mike Duigou:Stephen Fisher1-67/+572
Adds support for dissecting the new version 2 binary wire format messages. svn path=/trunk/; revision=20836
2007-02-13From Sebastien Tandel:Stephen Fisher1-0/+1
Create two new files (ws_strsplit.[ch]) that use GTK2 code to override the buggy g_strsplit() function when compiling for GTK1. Include this work-around function (ws_strsplit) in libwireshark.def. Add notes on usage to README.developer. Include epan/ws_strsplit.h in all files that use g_strsplit(). svn path=/trunk/; revision=20804
2007-01-29Fix potential buffer overruns in address_to_str_buf() found by Andrej Gerald Combs1-41/+41
Mikus. Add a buf_len parameter to ip_to_str_buf(), and make sure it's enforced. Copy the release notes over from the 0.99.5 trunk and add a note about the ISUP dissector (which is affected by the overrun). svn path=/trunk/; revision=20607
2006-06-23coverity 172Ronnie Sahlberg1-1/+1
remove a dead code condition svn path=/trunk/; revision=18565
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-2/+2
svn path=/trunk/; revision=18196
2006-05-01UDP and SCTP aren't byte-stream protocols, so they don't offer TCP-styleGuy Harris1-3/+106
reassembly. UDP has no notion of reassembly - that's done at the IP layer - and SCTP has its own notions of reassembly which it currently doesn't provide. As such, TCP-style reassembly isn't possible for JXTA-over-UDP or JXTA-over-SCTP. As for TCP, a heuristic dissector for a TCP-based protocol can't request more data if it's rejecting a packet; make it not do so. That should fix the recent buildbot crash, although there are still some reassembly problems with that capture (c05-http-reply-r1.pcap.gz in the menagerie and on the SampleCaptures page of the Wiki) that aren't fixed yet. svn path=/trunk/; revision=18049
2006-03-23From Mike Duigou:Anders Broman1-19/+26
> I have improved the heuristics and the display tree building code in > dissect_jxta_udp() and dissect_jxta_stream() to avoid this problem. svn path=/trunk/; revision=17709
2006-03-09don't use g_message() inside dissector codeUlf Lamping1-12/+12
svn path=/trunk/; revision=17557
2006-03-08fix bug 772: and again, don't pass a NULL pointer to a printf like function ↵Ulf Lamping1-1/+1
on WIN32 svn path=/trunk/; revision=17535
2006-02-13From Mike Duigou:Anders Broman1-124/+278
- Improves ability of dissector to find conversations without seeing whole stream. - Fixes some issues with dissection of data which requires reassembly. - Adds the ability to dissect jxta conversations from SCTP streams. - Better handling of welcome message. - Adds direct dissection of compressed SRDI data. - Has been run through extensive fuzz testing. - Fixes compiler warnings with previous patch 17141 svn path=/trunk/; revision=17282
2005-09-29From Mike DuigouAnders Broman1-18/+22
A patch to allow the JXTA dissector to pass fuzz testing. It also removes a couple of unused things and optimizes handling of the raw data dissector. svn path=/trunk/; revision=16051
2005-08-21From Mike Duigou:Anders Broman1-214/+286
A patch to the JXTA dissector. It's purpose is to improve the behaviour of the dissector when dissecting captures that do not include the whole conversation. The dissector is now more capable of isolating a conversation without seeing the beginning of the conversation. It's still not always able to pick up all conversations (suggestions, patches and hints welcome). improved some of the doxygen docs and comments. svn path=/trunk/; revision=15500
2005-08-13some more gmemchunk -> se_alloc() updatesRonnie Sahlberg1-31/+2
there are only 5 gmemchunks left but they have different litetime for their allocations than the 100+ ones that have been removed. The remaining 5 should be converted some other way. svn path=/trunk/; revision=15328
2005-08-10rename ep_tvb_get_string() to tvb_get_ephemeral_string() asnd update the ↵Ronnie Sahlberg1-4/+4
documentation in README.developer svn path=/trunk/; revision=15270
2005-08-08various code cleanup:Ulf Lamping1-4/+4
-use g_snprintf instead of sprintf and snprintf -use g_strdup_printf where appropriate -remove #include "snprintf.h" (as only g_snprintf should be used) -replace some more alloc/realloc/calloc/free with their glib pendants svn path=/trunk/; revision=15264
2005-07-29Include <epan/emem.h> to declare ep_alloc().Guy Harris1-0/+1
svn path=/trunk/; revision=15136
2005-07-28ememify some more tvb_get_string() callsRonnie Sahlberg1-17/+6
one memleak in vnc related to tvb_get_string() closed. svn path=/trunk/; revision=15130
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-29 05:12:28 +0000