aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-ipdr.c
AgeCommit message (Collapse)AuthorFilesLines
2016-10-08Combine Decode As and port preferences for tcp.port dissector table.Michael Mann1-1/+1
This patch introduces new APIs to allow dissectors to have a preference for a (TCP) port, but the underlying data is actually part of Decode As functionality. For now the APIs are intentionally separate from the regular APIs that register a dissector within a dissector table. It may be possible to eventually combine the two so that all dissectors that register with a dissector table have an opportunity to "automatically" have a preference to adjust the "table value" through the preferences dialog. The tcp.port dissector table was used as the guinea pig. This will eventually be expanded to other dissector tables as well (most notably UDP ports). Some dissectors that "shared" a TCP/UDP port preference were also converted. It also removed the need for some preference callback functions (mostly when the callback function was the proto_reg_handoff function) so there is cleanup around that. Dissectors that has a port preference whose default was 0 were switched to using the dissector_add_for_decode_as_with_preference API rather than dissector_add_uint_with_preference Also added comments for TCP ports used that aren't IANA registered. Change-Id: I99604f95d426ad345f4b494598d94178b886eb67 Reviewed-on: https://code.wireshark.org/review/17724 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09new_create_dissector_handle -> create_dissector_handle for dissector directory.Michael Mann1-1/+1
Some of the ASN.1 dissectors still generate a new_create_dissector_handle from the tool itself, so leave those for now. Change-Id: Ic6e5803b1444d7ac24070949f5fd557909a5641f Reviewed-on: https://code.wireshark.org/review/12484 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-18IPDR: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-7/+0
Change-Id: Icf1686e9f1530a602ec5b03572be53d4f245d70c Reviewed-on: https://code.wireshark.org/review/8520 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-18IPDR: fix comma at end of enumerator list [-Wpedantic]Alexis La Goutte1-1/+1
Change-Id: I4f78a3a15aa04c52042f7461d11b31c95f7e9590 Reviewed-on: https://code.wireshark.org/review/8519 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-17Add IPDR dissectorMichael Mann1-0/+393
Bug: 2771 Change-Id: Ic2904c981a182be5859c3840025e7ffa9ea387ed Reviewed-on: https://code.wireshark.org/review/8501 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>