aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-ieee1905.c
AgeCommit message (Collapse)AuthorFilesLines
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-07ieee1905: Fix the handling of AP Metric Queries.Richard Sharpe1-0/+9
They changed when the spec was updated. This seems to be the last change needed here. Change-Id: Id47c1de5b5890bffa0842c33ae02033ddf6c8325 Reviewed-on: https://code.wireshark.org/review/25656 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-30ieee1905: add missing NULL terminatator to ieee1905_reporting_policy_flags[].Jakub Zawadzki1-1/+2
Add missing NULL terminator to ieee1905_reporting_policy_flags[], in order to fix buffer overflow. ASAN report: ERROR: AddressSanitizer: global-buffer-overflow on address 0x0000092a4af8 at pc 0x00000062afd2 bp 0x7ffce7e468d0 sp 0x7ffce7e468c8 READ of size 8 at 0x0000092a4af8 thread T0 #0 0x62afd1 in proto_item_add_bitmask_tree /src/wireshark/epan/proto.c:10406:9 #1 0x62953f in proto_tree_add_bitmask_with_flags /src/wireshark/epan/proto.c:10786:3 #2 0xfb8271 in dissect_metric_reporting_policy /src/wireshark/epan/dissectors/packet-ieee1905.c:2762:9 #3 0xfb2997 in dissect_ieee1905_tlv_data /src/wireshark/epan/dissectors/packet-ieee1905.c:4390:18 #4 0xfb23c8 in dissect_ieee1905 /src/wireshark/epan/dissectors/packet-ieee1905.c:4577:18 Found by oss-fuzz/5298. Change-Id: I35dbd6d29d0a3a5560286146fbed172c810e5b2d Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=5298 Reviewed-on: https://code.wireshark.org/review/25520 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
2018-01-19ieee1905: Bring AP Metric TLVs into conformance with the SPECRichard Sharpe1-15/+68
There was a missing field in the initial version of the spec. Add the flags bits that define the subsequenct fields. Change-Id: Ie237075f4f7f30adc4b280358fe5c985c63f5281 Reviewed-on: https://code.wireshark.org/review/25375 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-01-13ieee1905: More changes from the recent bakathon including two more TLVs.Richard Sharpe1-21/+207
Change-Id: I010c9aa1a3ad7c599a6de13ac79320233698426b Reviewed-on: https://code.wireshark.org/review/25293 Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-05ieee1905: Fix a bunch of issues after testing and spec changes.Richard Sharpe1-30/+23
Change-Id: I8f61ed9866760d13daa0cc65c2a771da3dcf280f Reviewed-on: https://code.wireshark.org/review/25151 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-12-14ieee1905: Fix an incorrect flags dissection.Richard Sharpe1-1/+1
Change-Id: Iebb434875eac08aeabab6b9179a882817149012c Reviewed-on: https://code.wireshark.org/review/24820 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-12-14ieee1905: Fix for a malformed packet with a Steering request.Richard Sharpe1-5/+27
If the mode bit is zero, we have to do different things than if it is 1. Change-Id: I5ed8bec1d350c02b736818cad5ab864748145686 Reviewed-on: https://code.wireshark.org/review/24775 Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
2017-11-20ieee1905: fix typo bandwith => bandwidthAlexis La Goutte1-1/+1
found by lintian Change-Id: Id9b113eddae5bcbcfb0c9b3d1dfb6008aa3d7269 Reviewed-on: https://code.wireshark.org/review/24502 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2017-11-20ieee1905: fix typo addres => addressAlexis La Goutte1-1/+1
found by lintian Change-Id: Idb5ee47b709e10d53192ac966b638e160cec60ea Reviewed-on: https://code.wireshark.org/review/24501 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2017-11-18ieee1905: Fix the incorrect dissection of radio operation restrictionRichard Sharpe1-4/+11
The dissection was really wrong. Fixed now I have seen captures. Change-Id: I038fbf8786306fad9c65c87aa5d58c155113c442 Reviewed-on: https://code.wireshark.org/review/24476 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-12ieee1905: Use BASE_UNIT_STRING and &units_dbm rather than appendingRichard Sharpe1-31/+16
the string 'dBm'. Change-Id: I5f4ddcf98902c53f6f014e64b51eb4c3c263e7e1 Reviewed-on: https://code.wireshark.org/review/24368 Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-06IEEE1905: Add a break to fix a malformed packet issue and dissect Multi-APRichard Sharpe1-1/+1
Extension types in EAPWPS. Change-Id: Ib7dca0f83897839072eaaeb9c95f406f6ad5c8e6 Reviewed-on: https://code.wireshark.org/review/24256 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-28IEEE 1905.1a: fix an infinite loop (CID 1420355)Alexis La Goutte1-0/+2
Change-Id: Iaa8e82cb5dc9f32e5c9dbf1db1068868d6fd3f18 Reviewed-on: https://code.wireshark.org/review/24144 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-27IEEE 1905.1a: fix an infinite loop (CID 1420356)Pascal Quantin1-0/+1
Change-Id: I39b75acbf3598ad4e32e268f4b4378f16ca273c6 Reviewed-on: https://code.wireshark.org/review/24107 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-27IEEE 1905.1a: remove an unused hf variablePascal Quantin1-5/+0
Change-Id: I03d37495937020407783d366d01e3ad353889e80 Reviewed-on: https://code.wireshark.org/review/24098 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-10-27IEEE 1905.1a: add what seems to be missing breaksPascal Quantin1-0/+2
Change-Id: I60b41e503bc8933fb2efb2016b565caa0ec3bb97 Reviewed-on: https://code.wireshark.org/review/24097 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-10-27Fix typo.Guy Harris1-1/+1
Change-Id: I27373dd3823d3527ad3ebf272169feb7323b1a83 Reviewed-on: https://code.wireshark.org/review/24094 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-10-26Initial coding of the ieee1905 dissector with Multi-AP support.Richard Sharpe1-0/+5686
Change-Id: I94da228cba6baf20a2cd02bafc9704492f2cfc9f Reviewed-on: https://code.wireshark.org/review/23956 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>