aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-hartip.c
AgeCommit message (Collapse)AuthorFilesLines
2014-06-28convert to proto_tree_add_subtree[_format]Michael Mann1-5/+5
Change-Id: Ia7014003a3cff5181295172978d6c613c3b83b0b Reviewed-on: https://code.wireshark.org/review/2676 Tested-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-04-12Get rid of more tvb_get_nstringz* calls.Guy Harris1-35/+17
Add an FT_STRINGZPAD type, for null-padded strings (typically fixed-length fields, where the string can be up to the length of the field, and is null-padded if it's shorter than that), and use it. Use IS_FT_STRING() in more cases, so that less code needs to know what types are string types. Add a tvb_get_stringzpad() routine, which gets null-padded strings. Currently, it does the same thing that tvb_get_string_enc() does, but that might change if we don't store string values as null-terminated strings. Change-Id: I46f56e130de8f419a19b56ded914e24cc7518a66 Reviewed-on: https://code.wireshark.org/review/1082 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-15Fix [-Wmissing-prototypes]Jakub Zawadzki1-0/+3
svn path=/trunk/; revision=54135
2013-12-14Fix const warnings.Jakub Zawadzki1-3/+3
svn path=/trunk/; revision=54092
2013-12-13Do one or more of the following:Bill Meier1-31/+31
- Convert "4 space tabs" to spaces; - Remove some unneeded initializers; - 'offset++' --> 'offset += 1' for consistency; - Reformat hf[] entries; - Rework/add whitespace; - Adjust editor modelines (set tab-width to 8). svn path=/trunk/; revision=54005
2013-11-09Add data parameter to tcp_dissect_pdus() as well as convert it to using ↵Michael Mann1-5/+5
"new" style dissectors. Now that "bytes consumed" can be determined, should tcp_dissect_pdus() take advantage of that? Should tcp_dissect_pdus return length (bytes consumed)? There are many dissectors that just call tcp_dissect_pdus() then return tvb_length(tvb). Seems like that could all be rolled into one. svn path=/trunk/; revision=53198
2013-09-15Convert a few more dissectors to wmem APIPascal Quantin1-4/+5
svn path=/trunk/; revision=52053
2013-06-29Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-6/+6
svn path=/trunk/; revision=50240
2013-05-26Batch of filterable expert infos.Michael Mann1-2/+13
svn path=/trunk/; revision=49584
2013-03-19From beroset:Anders Broman1-5/+5
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48426
2013-02-20From Chris Maynard via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8360Evan Huus1-1/+3
Bail out if length is less than the minimum required length. svn path=/trunk/; revision=47776
2013-02-20Fix Coverity CID 984638: Unused pointer value.Chris Maynard1-1/+1
svn path=/trunk/; revision=47754
2013-02-19Don't call expert_add_info_format() from within an if (tree) {} block.Chris Maynard1-94/+93
Misc. whitespace changes, remove tabs, add modelines to match current scheme. svn path=/trunk/; revision=47742
2013-02-18Use tcp_dissect_pdus for better dissection on TCP. Adjusted UDP dissection ↵Michael Mann1-149/+160
accordingly. Various cleanup to use proto_tree_add_item more often. svn path=/trunk/; revision=47739
2012-12-26Fix a bunch of warnings.Guy Harris1-6/+6
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-10-11Fix infinite loop in HART/IP dissector ↵Michael Mann1-70/+62
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7845) I also did a small bit of cleanup dissection while I was there, but it could definitely use more. I just want to fix the fuzztest crash I discovered before the buildbots get a hold of it. svn path=/trunk/; revision=45469
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-03-22Removed unused 'msg_type_val' argument to some functions.Stig Bjørlykke1-13/+8
svn path=/trunk/; revision=41737
2012-03-21Fix Coverity CID's 1452-1453: UNUSED_VALUE.Chris Maynard1-2/+2
svn path=/trunk/; revision=41704
2012-03-18From Bill Schiller: New dissector for the HART/IP protocolBill Meier1-0/+1561
I'm contributing a new dissector for the HART/IP protocol. This protocol is specified by the HART Conformance Foundation (HCF). It is a standard protocol used in the process control industry. It essential wraps the multip-drop serial HART packets in TCP or UDP packets. The standard has been approved by the HCF and has been assigned UDP/TCP port 5094 by IANA. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6961 --This line, and those below, will be ignored-- M AUTHORS M epan/CMakeLists.txt M epan/dissectors/Makefile.common AM epan/dissectors/packet-hartip.c M ui/gtk/main_menubar.c svn path=/trunk/; revision=41644