aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-h248.c
AgeCommit message (Collapse)AuthorFilesLines
2015-02-18H.248: fix dissection of ServiceChangeReason for version 1Pascal Quantin1-51/+4
My understanding of RFC 3015 is that the encoding of this field was not different in version 1 compared to newer releases Bug: 10879 Change-Id: Iaa81679388860c0df4adc673ca6e56aff6f4591c Reviewed-on: https://code.wireshark.org/review/7195 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-07tvb_bytes_to_ep_str -> tvb_bytes_to_strMichael Mann1-1/+1
Change-Id: I79c613cbdd8dc939dd4c29ebc477fb6eefd5bfc4 Reviewed-on: https://code.wireshark.org/review/6371 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-23asn1 generated dissectors: cleanup #include usageBill Meier1-2/+2
Change-Id: I36b2731d67f9345d2fd0c23800bba7d2be94c387 Reviewed-on: https://code.wireshark.org/review/6008 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-11-17H248: Fix Dereference of null pointer found by Clang analyzerAlexis La Goutte1-20/+22
Also fix some indent issue Change-Id: I262bdddd031fec6a0f91b7172bb2d67be3c33000 Reviewed-on: https://code.wireshark.org/review/5370 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-29Don't include ctype.h and replace isascii() with _ascii_isprint().AndersBroman1-9/+8
Remove deprecated APIs while at it. Change-Id: I002ed4a696782caaeeb70a3e4ced4ae81f3d5372 Reviewed-on: https://code.wireshark.org/review/4983 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-08-09Eliminate (almost all) proto_tree_add_text calls from ASN.1 dissectors.Michael Mann1-6/+11
This mostly involved adding expert info capabilities to many of the dissectors so that they could correctly flag error conditions. Only remaining proto_tree_add_text calls are in H248.cnf, which has a convoluted way of using hf_ data to make its tree. Change-Id: I6412150c2ec1977d7fa38f3f0ed416680bdfb141 Reviewed-on: https://code.wireshark.org/review/3500 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-20batch of tvb-length conversionsEvan Huus1-6/+6
Change-Id: I5e40df8af6841e3dad71c41d7e43c7971611b15f Reviewed-on: https://code.wireshark.org/review/2473 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-8/+8
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-8/+8
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-3/+3
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-05-05Add the possibillity to add a string to the termination id.AndersBroman1-11/+24
Change-Id: I3b48b28273a8c1a1558045d2a4ab5104160840de Reviewed-on: https://code.wireshark.org/review/1510 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-26Remove trailing whitespace from asn1 .cnf & template.[hc] files. Regenerate ↵Bill Meier1-16/+16
dissectors. Change-Id: I0e779b2ac2f608356649c5bbfca438141070dea4 Reviewed-on: https://code.wireshark.org/review/412 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-22Fix Called function pointer is null (null dereference) found by ClangAlexis La Goutte1-6/+5
../../asn1/h248/packet-h248-template.c:1222:31: warning: Value stored to 'prop' is never read if (!prop->dissector) prop = &no_param; Change-Id: I6d380fbb5fef9dc548385b0b470aea1cb3c34df1 Reviewed-on: https://code.wireshark.org/review/301 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-18Remove $Id$ from the ASN.1 dissectors and regenerate them.Jeff Morriss1-57/+55
Change-Id: Ie476c6f82f318188b41ed922b92c6fec119ea954 Reviewed-on: https://code.wireshark.org/review/244 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-01-14Don't make claims of constness that can't be guaranteed in terms the CGuy Harris1-1/+1
compiler can verify. svn path=/trunk/; revision=54792
2013-12-19Rename a couple of to_str functions to have ep_ in the name. This makes itEvan Huus1-2/+2
obvious that the returned string is ephemeral, and opens up the original names in the API for versions that take a wmem pool (and thus can work in any scope). svn path=/trunk/; revision=54249
2013-12-17Make local functions static. Include *.h when needed.Anders Broman1-7/+9
svn path=/trunk/; revision=54201
2013-11-10Pass "wild_card" directly to dissector instead of using private_data. ↵Michael Mann1-8/+7
"h248term" dissector is not in Wireshark source, so third-party will need to update accordingly. svn path=/trunk/; revision=53241
2013-11-10Add missing includes in order to remove exceptions.h from proto.h (next commit).Jakub Zawadzki1-5/+6
svn path=/trunk/; revision=53230
2013-09-22emem -> wmem conversion:Pascal Quantin1-1/+1
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-05Get rid of a duplicated filter name.Anders Broman1-13/+7
svn path=/trunk/; revision=51792
2013-09-01More dissectors to wmem. There are no more dissectors using se_tree now, just aEvan Huus1-8/+8
few other places. svn path=/trunk/; revision=51622
2013-08-04Convert proto_item_set_expert_flags into filterable items.Michael Mann1-10/+23
svn path=/trunk/; revision=51140
2013-08-04Convert proto_item_set_expert_flags to "filterable" items in alcap ↵Michael Mann1-1/+1
dissector. Unfortunately it had a few tentacles, so they needed to be brought along for the ride. svn path=/trunk/; revision=51136
2013-07-06Use epan-scoped memory for h248 packages. Fixes another ~24KB of leaks.Evan Huus1-3/+3
svn path=/trunk/; revision=50414
2013-06-19Apparently one of our major global headers must include emem.h, because I justEvan Huus1-15/+15
found a bunch more asn1 dissectors using emem without ever directly including the header. Convert those to wmem as well, which involves add a number of #include directives since dissectors do *not* automatically pull in the wmem headers. svn path=/trunk/; revision=50066
2013-06-03Convert ASN.1 dissectors to use filterable expert info.Michael Mann1-5/+13
NOTE: Kerberos ASN.1 template was updated, but not generated to source. svn path=/trunk/; revision=49707
2013-05-27Postfix FT_NONE fields with "_element" string to reduce number of ↵Pascal Quantin1-129/+129
incompatible filters in ASN.1 dissectors https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2402 svn path=/trunk/; revision=49599
2013-04-11Update the ASN.1 based dissectors following the changes done in r48812Pascal Quantin1-2/+2
svn path=/trunk/; revision=48820
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus1-8/+8
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-03-19From beroset:Anders Broman1-9/+8
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48429
2013-02-26its ==> it's & it's ==> its as needed.Bill Meier1-2/+2
svn path=/trunk/; revision=47892
2013-02-20Clean up white space - get rid of 4-space tabs.Guy Harris1-168/+178
Reformat the hf[] array to be consistent, and get rid of some bogus blurbs (probably copy-and-pasteos). svn path=/trunk/; revision=47759
2013-02-02Hack: disguise '/*' in text strings to prevent checkAPIs & etc seeing 'start ↵Bill Meier1-6/+6
of comment' within a text string. svn path=/trunk/; revision=47446
2013-01-19Use epan-scoped memory to clean up another 1Kb+ of valgrindEvan Huus1-3/+4
sorta-false-positive leaks. svn path=/trunk/; revision=47170
2012-12-13From John Batty via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8087 :Pascal Quantin1-1/+1
H.248 MEGACO PkgName property is poorly formatted svn path=/trunk/; revision=46526
2012-09-24Regenerate asn.1 dissectors.Jakub Zawadzki1-5/+5
svn path=/trunk/; revision=45110
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-07-11Revert part of revision 43107 which broke sub dissection ofAnders Broman1-37/+42
Signal and events as a new tvb wasn't created. |BASE_EXT_STRING also removed. svn path=/trunk/; revision=43661
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-20Add a link to IANA registry.Anders Broman1-1/+2
svn path=/trunk/; revision=43403
2012-06-05from Alex Lindberg:Anders Broman1-348/+336
Update to packet-h248.c and associated h248 dissecorts. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7332 svn path=/trunk/; revision=43107
2012-05-07Get rid of remaining Booleans-as-encoding-arguments inGuy Harris1-9/+19
proto_tree_add_item() calls. svn path=/trunk/; revision=42488
2012-03-13H.248 Annex E dissector does not properly dissect event parametersAnders Broman1-122/+161
(Update the h.248 dissector's package registration to support v1 packets.) Applying part of the patch from Alex Lindberg in bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6915 by hand. Fixes bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4842 svn path=/trunk/; revision=41526
2012-02-03Create a list of MTP Service Indicator macros and use them.Jeff Morriss1-10/+8
svn path=/trunk/; revision=40828
2011-11-14[-Wunused-but-set-variable]Anders Broman1-2/+2
svn path=/trunk/; revision=39829
2011-11-12fix [-Wunused-but-set-variable]Anders Broman1-17/+6
svn path=/trunk/; revision=39803
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-15Update generated ASN1 *.[hc] files after recent work done by Jeff Morriss;Bill Meier1-1/+1
The only change in each file is in a comment showing the asn2wrs cmd used to build that file. svn path=/trunk/; revision=39427
2011-05-27Make TVBs opaque for most users.Jeff Morriss1-13/+13
Convert TVB_RAW_OFFSET() and TVB_GET_DS_TVB() into functions. svn path=/trunk/; revision=37422
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-02 16:15:50 +0000