aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-gsmtap.c
AgeCommit message (Collapse)AuthorFilesLines
2017-08-22GSMTAP: Add UMTS RRC message type fieldDarien Spencer1-0/+72
Showing a description of the 'sub_type' in the fields tree for RRC payloads. Change-Id: Ie4fd4498690db27d4b996fff99fa74b676be9ddb Reviewed-on: https://code.wireshark.org/review/23133 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-31Don't force people to do a Web search to find the header layout.Guy Harris1-0/+4
Change-Id: Ie71db56327e1cb17b46da0d0675e3485bebd2439 Reviewed-on: https://code.wireshark.org/review/22885 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-07-30GSMTAP: Treat PDTCH identical to PACCH (hand into packet-gsm-rlcmac.c)Harald Welte1-0/+1
The RLC/MAC dissector decodes both signalling (PACCH) and data (PDTCH) RLC/MAC blocks, so let's make sure we dispatch both logical channels into that dissector. Change-Id: Ia26a1ba74468a49da071185cc5ee876ade907207 Reviewed-on: https://code.wireshark.org/review/22861 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-30GSMTAP: Proper name for PDTCH (not PDCH)Harald Welte1-1/+1
PDCH is the physical channel name, while PDTCH is one of the logical channels (goether with PTCCH and PACCH) on the PDTCH. Let's call it by its proper name, rather than keeping the misnomer. Change-Id: I724fcfba595c9c861b64a30d5510468ec007424c Reviewed-on: https://code.wireshark.org/review/22860 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-11GSMTAP: add LTE RRC message supportMartin Heusse1-4/+42
This code is borrowed from a patch proposed by altaf329@gmail.com in june 2015 (Ice136a9cb950bb97a11bee4486071b6883a0cad7) and adapted to fit current wireshark code (and minus the LTE MAC frame dissector). Change-Id: Iaa1ea8b2d7a3e618f8aa14203449f2c77b4727f5 Reviewed-on: https://code.wireshark.org/review/22515 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-05-27LAPDm: Support the LAPDm B4 Frame FormatHarald Welte1-2/+14
The B4 Frame Format is used on the downlink SACCH and has no length field. While the comment on top of packet-lapdm.c claimed ever since its introduction in 2009 that B4 was a supported format, in fact it was not supported yet. This patch makes handling the length field conditional to a frame format that has a length field, and introduces lapdm_data_t that can be passed using call_dissector_with_data(). The GSMTAP dissector is updated to use this mechanism to specify the frame format based on the channel type. Change-Id: I52cb1cedbc8c7baf65e70d3e050e8932573647aa Reviewed-on: https://code.wireshark.org/review/21767 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-16Add GSMTAP logging sub-dissectorHarald Welte1-0/+1
Applications can also use GSMTAP framing to convey log messages which would traditionally be printed on stderr or on log files. This allows the ordered/interspersed display of protocol messages with log lines from the applications that send or received those messages. The osmocom logging framework (part of libosmocore) implements this in libosmocore.git Change-Id I9a7e72b8c9c6f6f2d76d1ea2332dcdee12394625 Change-Id: I0de723445e5b5ce0199a4081808111240a9ed047 Reviewed-on: https://code.wireshark.org/review/19183 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-12-13Adjust proto_tree_add_uint_format_value calls to use unit stringMichael Mann1-4/+3
Several calls to proto_tree_add_uint_format_value could be better served using BASE_UNIT_STRING with a "unit string" in hf_ field. There also a few cases where proto_tree_add_uint_format_value could just be proto_tree_add_uint. Added a few more "common" unit string values to unit_strings.[ch] Change-Id: Iaedff82c515269c9c31ab9100dff19f5563c932d Reviewed-on: https://code.wireshark.org/review/19242 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-10gsmtap: Introduce a new packet-gsmtap.h header fileHarald Welte1-132/+1
Move the GSMTAP protocol related #defines to packet-gsmtap.h, as there are other dissectors (like packet-gsm_sim.c and future dissectors) need access to some of those #defines. Change-Id: Ibb3517bd773be63b7e3cd30104a5351427e22ebf Reviewed-on: https://code.wireshark.org/review/19185 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-13Convert most UDP dissectors to use "auto" preferences.Michael Mann1-1/+1
Similar to the "tcp.port" changes in I99604f95d426ad345f4b494598d94178b886eb67, convert dissectors that use "udp.port". More cleanup done on dissectors that use both TCP and UDP dissector tables, so that less preference callbacks exist. Change-Id: If07be9b9e850c244336a7069599cd554ce312dd3 Reviewed-on: https://code.wireshark.org/review/18120 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-31Don't do any Decode As stuff for dissector tables not used with Decode As.Guy Harris1-1/+1
Have all dissector tables have a "supports Decode As" flag, which defaults to FALSE, and which is set to TRUE if a register_decode_as() refers to it. When adding a dissector to a dissector table with a given key, only add it for Decode As if the dissector table supports it. For non-FT_STRING dissector tables, always check for multiple entries for the same protocol with different dissectors, and report an error if we found them. This means there's no need for the creator of a dissector table to specify whether duplicates of that sort should be allowed - we always do the check when registering something for "Decode As" (in a non-FT_STRING dissector table), and just don't bother registering anything for "Decode As" if the dissector table doesn't support "Decode As", so there's no check done for those dissector tables. Change-Id: I4a1fdea3bddc2af27a65cfbca23edc99b26c0eed Reviewed-on: https://code.wireshark.org/review/17402 Petri-Dish: Guy Harris <guy@alum.mit.edu> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-20Manually add protocol dependencies derived from find_dissector.Michael Mann1-82/+82
Started by grepping call_dissector_with_data, call_dissector_only and call_dissector and traced the handles passed into them to a find_dissector within the dissector. Then replaced find_dissector with find_dissector_add_dependency and added the protocol id from the dissector. "data" dissector was not considered to be a dependency. Change-Id: I15d0d77301306587ef8e7af5876e74231816890d Reviewed-on: https://code.wireshark.org/review/14509 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-17Associate dissector tables and heuristic subdissector lists with a protocol.Michael Mann1-1/+1
This will make it easier to determine protocol dependencies. Some LLC OUI dissector tables didn't have an associated protocol, so they were left without one (-1 used) Change-Id: I6339f16476510ef3f393d6fb5d8946419bfb4b7d Reviewed-on: https://code.wireshark.org/review/14446 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09new_create_dissector_handle -> create_dissector_handle for dissector directory.Michael Mann1-1/+1
Some of the ASN.1 dissectors still generate a new_create_dissector_handle from the tool itself, so leave those for now. Change-Id: Ic6e5803b1444d7ac24070949f5fd557909a5641f Reviewed-on: https://code.wireshark.org/review/12484 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-25create_dissector_handle -> new_create_dissector_handleMichael Mann1-5/+6
This finalizes the transformation for dissectors. Change-Id: Ie5986b72bb69a6e8779ca3f5e20a80357c9e6fea Reviewed-on: https://code.wireshark.org/review/12122 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-04Don't allow multiple registrations of a protocol in dissector tables.Michael Mann1-1/+1
The target here is the Decode As dialog where protocols have multiple registrations into a dissector table and that shows up as multiple entries in the Decode As dialog list with the same name so users are unsure which "dissector" they are choosing. The "default" behavior (done in this commit) is to not allow duplicates for a dissector table, whether its part of Decode As or not. It's just ENFORCED for Decode As. Bug: 3949 Change-Id: Ibe14fa61aaeca0881f9cc39b78799e314b5e8127 Reviewed-on: https://code.wireshark.org/review/11405 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-04-15Fix gsmtap signal and snr.Anton Thomasson1-6/+6
-Correct parsrsing to get correct value (corect position in header). -Rename hf_gsmtap_noise_dbm to hf_gsmtap_snr_db to reflect use and name in struct. -Change order of decalaration/use of signal and snr to reflect position in struct. -Change registered types to signed to reflect possible values and definition in struct. Change-Id: I748bd19757c0dd87fe4ad0969dfcc8427b908aa2 Reviewed-on: https://code.wireshark.org/review/8077 Reviewed-by: Sylvain Munaut <246tnt@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-12-23Deleting unneccessary #includes from dissectors.Martin Mathieson1-1/+0
Second batch (packet-eth.c -> packet-icmpv6.d). Will look at cleaning up and committing script afterwards. Change-Id: I14295758b81a59115d8c88899f166cc3d5d17594 Reviewed-on: https://code.wireshark.org/review/6013 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-1/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-11-21Replace tvb_length()AndersBroman1-1/+1
Change-Id: I0b5ad4d588f0b658abaf3892d08d6520ecd2f645 Reviewed-on: https://code.wireshark.org/review/5431 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-06Adjust indentation to match editor modelines; Do other minor whitespace changes.Bill Meier1-6/+6
Change-Id: Ic020b2c92db5d14a2be9dc4d35aef4514b8b0353 Reviewed-on: https://code.wireshark.org/review/4502 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-08-15Remove unneeded #include <epan/prefs.h>; As needed: Add editor-modelines & ↵Bill Meier1-1/+0
adjust whitespaxcce. Change-Id: I6f79357e0f3906f6ccc5b68eb451b69b68636335 Reviewed-on: https://code.wireshark.org/review/3613 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-07-08gsmtap: do not abort if dissector is unavailablePeter Wu1-1/+16
Encountered with the following attachments from bugs: 6575-test-dlmapc-wmx 6577-test-dlmapc-wmx 6579-test-dlmapc-wmx Also added modelines. Change-Id: I3859bed618830ad359bd0b2b1fdfc3c5fc13269e Reviewed-on: https://code.wireshark.org/review/2920 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-1/+1
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-1/+1
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-5/+3
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-15Fix [-Wmissing-prototypes]Jakub Zawadzki1-0/+3
svn path=/trunk/; revision=54135
2013-09-16Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if ↵Michael Mann1-2/+2
hf_ field name is the first part of the formatted string. This was all manual inspection and most cases were either: 1. Case sensitivity differences between hf_ field name and formatted string. 2. Unnecessary whitespace between hf_ field name and colon in formatted string There are cases where the hf_ field name doesn't quite match the proto_tree_add_uint_format, but it's close enough that one of them should be "right", I'm just not sure which is, I just know the string in proto_tree_add_uint_format is the one displayed. svn path=/trunk/; revision=52098
2013-04-14Update some of the old FSF addresses caught by the new licensecheck buildbotEvan Huus1-3/+1
step. svn path=/trunk/; revision=48848
2013-02-26Fix warning: 'rrc_sub_handle' may be used uninitialized in this functionPascal Quantin1-1/+1
svn path=/trunk/; revision=47904
2013-02-25Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8397 :Pascal Quantin1-0/+3
Prevent an out of bounds access when trying to call RRC sub dissectors and fallback to DATA dissector svn path=/trunk/; revision=47876
2013-02-21From Harald Welte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8365 :Pascal Quantin1-4/+157
Add GSMTAP support for UMTS RRC captures svn path=/trunk/; revision=47792
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-08-25From Sylvain Munaut via ↵Pascal Quantin1-0/+5
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7664 : packet-gsmtap: Call GMR-1 RACH dissector when appropriate svn path=/trunk/; revision=44671
2012-03-09From Sylvain Munaut:Anders Broman1-0/+7
packet-gsmtap: Call the GMR-1 CCCH dissector when appropriate (Step 3). https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6921 svn path=/trunk/; revision=41449
2012-03-07From Sylvain Munaut: Call the new dissector from the GSMTap dissector for ↵Anders Broman1-0/+8
GMR-1 channels using LAPSat svn path=/trunk/; revision=41405
2012-02-08From Harald Welte:Anders Broman1-1/+9
GSMTAP: add new GPRS/EGPRS RLC related sub-types https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6812 svn path=/trunk/; revision=40936
2012-02-08From Harald Welte:Anders Broman1-3/+3
GSMTAP: whitespace / indent cleanup https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6811 svn path=/trunk/; revision=40935
2012-02-08From Harald Welte:Anders Broman1-5/+7
GSMTAP dissector: introduce a dissector table. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6810 svn path=/trunk/; revision=40934
2012-02-08From Sylvain Munaut:Anders Broman1-0/+74
Fix the windows build by filling up stuct with dummy member https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6798 svn path=/trunk/; revision=40932
2012-02-05Checked in, with the following changes:Jörg Mayer1-16/+25
- Adapted packet-gsm_sim.c and CmakeLists.txt to match current content (trivial) - Fixed warnings about //-style comments that were found running ../../tools/checkAPIs.pl -g deprecated -g prohibited -g abort -g termoutput packet-gsm_sim.c packet-etsi_card_app_toolkit.c Error: Found C++ style comments in packet-gsm_sim.c - Not fixed (will lead to dissector abort if in a packet): ../../tools/checkhf.pl packet-gsm_sim.c packet-etsi_card_app_toolkit.c ERROR: NO ARRAY: packet-gsm_sim.c, hf_tprof_b19 ERROR: NO ARRAY: packet-gsm_sim.c, hf_tprof_b18 ERROR: NO ARRAY: packet-etsi_card_app_toolkit.c, hf_ctlv_bearer_descr Please provide the necessary element entries for the hf[] array in a followup patch. svn path=/trunk/; revision=40854
2012-02-04From Harald Welte:Anders Broman1-2/+8
lapdm dissector tries to defragment segment of different streams. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6659 svn path=/trunk/; revision=40842
2012-01-26From Mike Morrin:Anders Broman1-16/+35
The gsmtap patch related to Add dissectors for GSM and UMTS Cell Broadcast protocols. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6770 svn path=/trunk/; revision=40738
2011-10-11From Harald Welte:Anders Broman1-0/+16
In order to ensure one consistent GSMTAP definition, some comments are added to the code in order to make sure modifications are first merged in the GSMTAP mainline header file, and then propagated to wireshark. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6442 svn path=/trunk/; revision=39366
2011-10-10 Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-1/+1
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260) svn path=/trunk/; revision=39328
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-16/+16
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-07-22From Ludovic Haessler:Anders Broman1-0/+12
Add 3GPP LLC/SNDCP protocols management in GSMTAP dissecto. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6145 svn path=/trunk/; revision=38166
2011-07-11From Ludovic Haessler:Anders Broman1-0/+16
Add 3GPP TS44.060 RLC/MAC control blocks management in GSMTAP dissector. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6103 svn path=/trunk/; revision=37960
2011-07-06From HAESSLER:Anders Broman1-0/+3
Abis interface not correctly handled in gsmtap dissector https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6097 svn path=/trunk/; revision=37918
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-20 05:50:48 +0000