aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-gsm_rlcmac.c
AgeCommit message (Collapse)AuthorFilesLines
2019-06-18GSM RLC/MAC: fix dissection of SI Message List IEPascal Quantin1-1/+40
Change-Id: Ia3a4255ecd78e480135bbbbeccd9c0268c105400 Reviewed-on: https://code.wireshark.org/review/33648 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-14GSM RLC/MAC: fix another global-buffer-overflow error reported by ASANPascal Quantin1-1/+4
Same root cause as gf751918 Bug: 13708 Change-Id: I9d1089c3a632ca82370d14beb06ebcd554901415 Reviewed-on: https://code.wireshark.org/review/21639 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-11GSM RLC/MAC: fix global-buffer-overflow error reported by ASANPascal Quantin1-1/+4
After a M_NEXT_EXIST(), you should always have another variable (like M_UINT, M_TYPE, ...) and not immediately end the structure with CSN_DESCR_END. Note that this is a workaround as the current description does not allow a proper parsing anyway (as the structure is reentrant). But at least it solves the buffer overflow. Bug: 13692 Change-Id: I8e607aadcced2d8cc636dc10f9690c5c679ad581 Reviewed-on: https://code.wireshark.org/review/21585 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-09[GSM RLCMAC] Add comments.AndersBroman1-0/+10
Change-Id: I2d98d8f318fdbe160974a69f50c456683669e57e Reviewed-on: https://code.wireshark.org/review/21562 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-08[GSM RLCMAC] Update : PACKET RESOURCE REQUEST to Release 14.0.0AndersBroman1-1/+473
Change-Id: I41e6ebf862f0bd9523778053d40f18ae7385a5bd Reviewed-on: https://code.wireshark.org/review/21560 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-21[GSM RLCMAC] Fix column info.AndersBroman1-7/+7
Change-Id: Ib9dc9de7da088ab14e5f52b706e0c367c576b978 Reviewed-on: https://code.wireshark.org/review/20221 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-16[GSM RLCMAC] Use rtlli_valsStig Bjørlykke1-1/+1
Change-Id: I491bdfd3c206971244f26dfc2cfd8172347313c6 Reviewed-on: https://code.wireshark.org/review/20146 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-16[GSM RLCMAC] Added parsing of EC-EGPRS DL and UL data messages.AndersBroman1-2/+277
Change-Id: Ia7c74a834d2384642cac7f9a2899313b9bac7c26 Reviewed-on: https://code.wireshark.org/review/20141 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-28gsm_rlcmac: fix fix spelling typo found by lintianAlexis La Goutte1-1/+1
Change-Id: I949067c5f18f48ba954e54e6ca0c224744f85e41 Reviewed-on: https://code.wireshark.org/review/18535 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-08GSM RLC/MAC: register dissectors for EC-GSM-IoT control messagesPascal Quantin1-0/+22
Change-Id: I8fe84cc98b8967c529c07ff17014648610ad8660 Reviewed-on: https://code.wireshark.org/review/16340 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-13GSM RLC/MAC: add dissection of EC-GSM-IoT control messagesAnton Thomasson1-7/+936
Change-Id: Ib7096039aa9761fda96ed8552899833597ba70a6 Reviewed-on: https://code.wireshark.org/review/15812 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-11GSM RLC/MAC: improve dissection of Packet Resource Request messageVincent Helfre1-16/+167
Change-Id: I8513ef550e81a97e1a8ac1c1f365355118d5ebae Reviewed-on: https://code.wireshark.org/review/15827 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-03GSM RLC/MAC: better wording for PS HO data sourcesVincent Helfre1-2/+2
Change-Id: Id790e6f9f884181e4fcdda794b2b121ce918cb15 Reviewed-on: https://code.wireshark.org/review/15709 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-02GSM RLC/MAC: add dissection of 2G->3G/4G PS handoverPascal Quantin1-21/+97
Change-Id: Ia24055d7d871b9fbf69a9225a2a273fced950a3c Reviewed-on: https://code.wireshark.org/review/15700 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-01GSM RLC/MAC: add dissection of NAS containerVincent Helfre1-15/+61
While we are at it, let's display other containers in hexadecimal instead of decimal Change-Id: I6ac6dd2a64271cbc2958860550da9024445bfe19 Reviewed-on: https://code.wireshark.org/review/15675 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-20Create call_data_dissector() to call data dissector.Michael Mann1-16/+7
This saves many dissectors the need to find the data dissector and store a handle to it. There were also some that were finding it, but not using it. For others this was the only reason for their handoff function, so it could be eliminated. Change-Id: I5d3f951ee1daa3d30c060d21bd12bbc881a8027b Reviewed-on: https://code.wireshark.org/review/14530 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09new_register_dissector -> register_dissector for dissector directory.Michael Mann1-2/+2
Change-Id: Ie39ef054a4a942687bd079f3a4d8c2cc55d5f22c Reviewed-on: https://code.wireshark.org/review/12485 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-07Spelling fixes for errors found by lintianBalint Reczey1-5/+5
Change-Id: I889283902875193f4d3f3fd59788f59f8d9bcc20 Reviewed-on: https://code.wireshark.org/review/11945 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-09-23GSM RLC/MAC: fix dissection of variable length bitmapsPascal Quantin1-5/+12
Bug: 11534 Change-Id: I857134f21ab6a8a135eba6e784807f3f3734bf6c Reviewed-on: https://code.wireshark.org/review/10607 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-09-20Make CSN.1 dissectors more filterable.Michael Mann1-702/+4814
The intent here is to remove proto_tree_add_text from packet-csn1.c, but the macros setup means A LOT more hf fields needs to be created. Many of those new hf fields were created with a perl script Bug: 11504 Change-Id: If12c7677185f18a7f684fd3746397be92b56b36d Reviewed-on: https://code.wireshark.org/review/10391 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-08-15Eliminate proto_tree_add_text from GSM dissectors.Michael Mann1-26/+19
Change-Id: I36a3d15a4fa86847a83d1dbea40111d36d7cfd61 Reviewed-on: https://code.wireshark.org/review/10036 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-07-16GSM RLC/MAC: fix an infinite loop when analyzing (E)GPRS headerPascal Quantin1-9/+10
Change-Id: Ibba32a2860f80979ee9df3caeeaeda14fde7e7d0 Ping-Bug: 11358 Reviewed-on: https://code.wireshark.org/review/9649 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-03-23GSM RLC/MAC: fix an out of bounds accessPascal Quantin1-1/+1
When GRNTI does not exist in Packet Measurement Report R5 additions, too many lines are skipped Fixes an ASAN failure reported by Alexis Change-Id: I400bc4d9732f1d8e3c6fb8b72bf08a70a636d78c Reviewed-on: https://code.wireshark.org/review/7772 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-01-26gsm-rlcmac: use wmem_new0 for a structEvan Huus1-2/+2
Fixes "Conditional jump or move depends on uninitialised value" from Valgrind. I couldn't really figure out how this code was supposed to function, it seems to initialize one member of the union and then expect *all* the others to just magically work (which they apparently do in most cases, oddly). The real bug could be in csnStreamDissector or who knows, but this at least turns "garbage data" into "zeros" which makes valgrind happy and turns a potential vuln into at worst a bad decoding. Bug: 10891 Change-Id: Ia29dd625b46b3b76ff521b4203148fe8b0c59ec3 Reviewed-on: https://code.wireshark.org/review/6769 Petri-Dish: Evan Huus <eapache@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-3/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-11-20Replace tvb_length...() calls.AndersBroman1-10/+10
Change-Id: Idda7cd56a12b36d18774a1fe324c69eb8f5e4330 Reviewed-on: https://code.wireshark.org/review/5412 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-29convert to proto_tree_add_subtree[_format]Michael Mann1-6/+2
Change-Id: If110de1e0555637264f86f1508858d569871a9c7 Reviewed-on: https://code.wireshark.org/review/2675 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-10/+10
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-10/+10
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-6/+6
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-05-25GSM RLC MAC: Do not skip too many lines of the CSN_DESCR when the field is ↵Pascal Quantin1-4/+3
missing While we are at it, replace an undefined hf_timeslot_allocation_usf_tn by its hf_usf equivalent Bug: 10120 Change-Id: I3fe113279c779a9d8143d07489747a67d7351664 Reviewed-on: https://code.wireshark.org/review/1794 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-01-28Comment out a lot more hf[] entries and related.Bill Meier1-57/+16
(Found by checkhf). Note: There's quite a large amount of hf[] entries which are commented out. I wonder if there are "top-level" entries missing from the "parse-tree" arrays ? svn path=/trunk/; revision=54990
2014-01-13f_k() is used outside packet-gsm_a_rr.c, so it can't be static.Guy Harris1-0/+2
In a source file that defines external functions, the header file that declares the functions must be included, in order to make sure the declarations match the function signature. Make it so - which means creating the header file in the first place. That means f_k() doesn't need to, and shouldn't be, declared in packet-gsm_rlcmac.h. Include packet-gsm_a_rr.h in packet-gsm_rlcmac.c. svn path=/trunk/; revision=54724
2013-12-20Make more items filterable courtesy of convert_proto_tree_add_text.plMichael Mann1-22/+47
svn path=/trunk/; revision=54279
2013-12-18Fix -Wunused-const-variable found by ClangAlexis La Goutte1-0/+4
svn path=/trunk/; revision=54222
2013-12-18Fix warning because of functions defined but not used.Irene Rüngeler1-1/+4
svn path=/trunk/; revision=54211
2013-12-18Fix [-Wmissing-prototypes]Anders Broman1-12/+12
svn path=/trunk/; revision=54209
2013-12-15Fix [-Wmissing-prototypes]Jakub Zawadzki1-0/+3
svn path=/trunk/; revision=54135
2013-11-22Make use of ctrl_ack_vals value_string arrayPascal Quantin1-3/+1
svn path=/trunk/; revision=53506
2013-11-21Comment out *many* unused vars found by CLANG;Bill Meier1-1224/+1460
Fix 2 minor bugs wherein an incorrect (NULL) tree was always used; Remove some unneeded initializers; Localize some variables; Use consistent indentation & whitespace formatting Add editor modelines. svn path=/trunk/; revision=53497
2013-11-07Got burned by forgetting to compile first...Michael Mann1-27/+27
svn path=/trunk/; revision=53129
2013-11-07Have the gsm_rlcmac_ul and gsm_rlcmac_dl use the data parameter of the ↵Michael Mann1-36/+41
dissector function instead of pinfo->private_data to receive a RlcMacPrivateData_t structure. This work was done in bug 7615 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7615), but the tie in to use the RlcMacPrivateData_t structure (passed by the GSMTAP dissector) was never completed. Whenever that picks up again, the data parameter of the dissector should be used instead of pinfo->private_data. svn path=/trunk/; revision=53128
2013-10-29From didier gautheron: remove redundant or use faster col_xxx functionsBill Meier1-6/+6
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster. - same for replace col_append_fstr and col_append_str - remove col_clear() when it's redundant: + before a col_set/col_add if the dissector can't throw an exception. - replace col_append() after a col_clear() with faster col_add... or col_set https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344 svn path=/trunk/; revision=52948
2013-10-13whitespace fixes; mostly: remove trailing blanksBill Meier1-29/+29
svn path=/trunk/; revision=52591
2013-09-03Batch of filterable expert info.Michael Mann1-2/+11
svn path=/trunk/; revision=51689
2013-08-30Convert a few dissectors from EMEM to WMEM APIPascal Quantin1-2/+3
svn path=/trunk/; revision=51597
2013-08-10Fix (-W)documentation error found by ClangAlexis La Goutte1-143/+143
./packet-gsm_rlcmac.h:1086:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< MS Radio Access capability IE > ^~~ /**< ./packet-gsm_rlcmac.h:1089:26: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] typedef guint8 A5_bits_t;/*<A5 bits> ::= < A5/1 : bit> <A5/2 : bit> <A5/... ^~~~~ /**< packet-gsm_rlcmac.c:169:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Global TFI IE >*/ ^~~ /**< packet-gsm_rlcmac.c:171:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Starting Frame Number Description IE >*/ ^~~ /**< packet-gsm_rlcmac.c:174:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Ack/Nack Description IE >*/ ^~~ /**< packet-gsm_rlcmac.c:178:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Packet Timing Advance IE >*/ ^~~ /**< packet-gsm_rlcmac.c:183:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Power Control Parameters IE >*/ ^~~ /**< packet-gsm_rlcmac.c:191:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Global Power Control Parameters IE >*/ ^~~ /**< packet-gsm_rlcmac.c:195:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Global Packet Timing Advance IE >*/ ^~~ /**< packet-gsm_rlcmac.c:197:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Channel Quality Report struct >*/ ^~~ /**< packet-gsm_rlcmac.c:210:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< EGPRS Ack/Nack Description >*/ ^~~ /**< packet-gsm_rlcmac.c:216:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*<P1 Rest Octets>*/ ^~~~~ /**< packet-gsm_rlcmac.c:218:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*<P2 Rest Octets>*/ ^~~~~ /**< packet-gsm_rlcmac.c:264:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< SI 13 Rest Octets >*/ ^~~ /**< packet-gsm_rlcmac.c:288:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Packet TBF Release message content >*/ ^~~ /**< packet-gsm_rlcmac.c:293:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Packet Control Acknowledgement message content >*/ ^~~ /**< packet-gsm_rlcmac.c:299:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Packet Downlink Dummy Control Block message content >*/ ^~~ /**< packet-gsm_rlcmac.c:301:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Packet Uplink Dummy Control Block message content >*/ ^~~ /**< packet-gsm_rlcmac.c:305:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< MS Radio Access capability IE >*/ ^~~ /**< svn path=/trunk/; revision=51267
2013-03-19From beroset:Anders Broman1-2/+2
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48426
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-12 14:44:26 +0000