aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-gsm_abis_om2000.c
AgeCommit message (Collapse)AuthorFilesLines
2016-12-21gsm_abis_om2000: restore offset increment removed by g1643e37Pascal Quantin1-0/+2
Change-Id: I34666a74f8769c63ecc982bd034b2563ba0298ff Reviewed-on: https://code.wireshark.org/review/19370 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-11-12gsm_abis_om2000: Expand bit-width of CON CCP and CI fieldsHarald Welte1-2/+2
It seems more recent RBS2000 models have extended the range of the CON Connection Point (CCP) by one bit, as I'm seeing CCP 1896 in protocol traces. Similarly, the Contiguity Index can at least reach 96. Using the full 8bit value to make sure IS and CON dissectors use the same ranges for connection points and contiguity index. Change-Id: Iece34106fc97a11dc8a01cf2578b5e4245a4c9e8 Reviewed-on: https://code.wireshark.org/review/18753 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-10-28gsm_abis_om2000: Issue Expert Info when Enable Result != ENABLEDHarald Welte1-4/+13
The point of sending an Enable Request is to enable the respective MO. If the MO responds with any MO state != ENABLED there is something fishy. Let's inform the user with some Expert Info about it. Change-Id: Ib33e5dbc37894049b93bb71782787b8c96c04326 Reviewed-on: https://code.wireshark.org/review/18454 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-27gsm_abis_om2000: Introduce expert info for unusual situationsHarald Welte1-7/+39
In OM2000, it is not usual to receive NACK, REJECT or "performed not according to request" type messages. Let's highlight them using expert info as a convenience to the user. Change-Id: I47b865c32fd9ec82ec63699babd31f3849f3006c Reviewed-on: https://code.wireshark.org/review/18453 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-27gsm_abis_om2000: Fix Dead Store (Dead assignement/Dead increment) Warning ↵Alexis La Goutte1-2/+0
found by Clang Change-Id: I980d684676a9c21afe0dced75a35cc40a962619f Reviewed-on: https://code.wireshark.org/review/18499 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-27gsm_abis_om2000: fix spelling typo found by lintianAlexis La Goutte1-1/+1
Change-Id: Ie52831aa218551e0f55d5479f47cc7cf92c2b069 Reviewed-on: https://code.wireshark.org/review/18507 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-26gsm_abis_om2000: Add very basic dissection of "MO Record"Harald Welte1-0/+23
The MO Record is returned in response to a Capabilities Request and describes the capabilities of he MO in more detail. The exact coding of the contents is not yet known at this point. Change-Id: Iddfe60d286a85585bec58d340bdee793d3bfca2e Reviewed-on: https://code.wireshark.org/review/18456 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-25gsm_abis_om2000: Decode the IWD Type/Gen/Rev in Negotiation RequestHarald Welte1-2/+73
The Negotiation Request and Negotiation Requeset ACK contain IWD (Inter Working Document) revision numbers for the different A-bis protocols OML, RSL, GSL (GPRS) and TRA (TRAU). Decode them in a way suitable for human consumption. Change-Id: I5b11e64ca252b7349900ba5b700c2faefd568441 Reviewed-on: https://code.wireshark.org/review/18452 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-25gsm_abis_om2000: Dissect TLV structure of 0xa3/0xa5/0xa6 TLVsHarald Welte1-0/+9
We have no idea what those TLVs are, but the message hex-dumps clearly indicate a 8-bit tag followed by 8-bit length and then 'length' amount of bytes, so we can at least dissect that high-level structure for now. They appear in equally unknown message type 0x126, which appears to be sent in intervals of 300s by the RBS. Change-Id: I91817eb20de1a4557399235c1fc42b638b9c935b Reviewed-on: https://code.wireshark.org/review/18460 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-25gsm_abis_om2000: Add "TG" and "DP" MO Class namesHarald Welte1-0/+4
Change-Id: Ice9d0601b2b1aa0691b7fcacaf61b4e287c7725c Reviewed-on: https://code.wireshark.org/review/18455 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-05gsm_abis_om2000: Dissect "Reason Code" and "Result Code"Harald Welte1-0/+33
Change-Id: Ie2495b6333b021de53c674ca8bdad0712228a7c1 Reviewed-on: https://code.wireshark.org/review/16820 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-05gsm_abis_om2000: Decode "Attribute ID" Information ElementHarald Welte1-0/+66
The "Attribute ID" IE is used by the RBS to indicate which particular setting has caused it to reject a given request by the BSC. Change-Id: I05621831f70fb53b5b752afceed9337f6cd0edb7 Reviewed-on: https://code.wireshark.org/review/16819 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09new_register_dissector -> register_dissector for dissector directory.Michael Mann1-1/+1
Change-Id: Ie39ef054a4a942687bd079f3a4d8c2cc55d5f22c Reviewed-on: https://code.wireshark.org/review/12485 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-14register_dissector -> new_register_dissectorMichael Mann1-7/+5
Picking off "easy" dissectors that only have one or two exit points at most. Change-Id: I25fe6a0aac93980333217d007702799d16946563 Reviewed-on: https://code.wireshark.org/review/11816 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-07Remove some unnecessary includes.Guy Harris1-4/+0
Either remove them completely, or put them inside an #ifdef. Change-Id: Iceff4909e250c17812f38d94e067f7c37ab72e1b Reviewed-on: https://code.wireshark.org/review/11630 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-07tvb_bytes_to_ep_str -> tvb_bytes_to_strMichael Mann1-1/+1
Change-Id: I79c613cbdd8dc939dd4c29ebc477fb6eefd5bfc4 Reviewed-on: https://code.wireshark.org/review/6371 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-23Deleting unneccessary #includes from dissectors.Martin Mathieson1-2/+0
Second batch (packet-eth.c -> packet-icmpv6.d). Will look at cleaning up and committing script afterwards. Change-Id: I14295758b81a59115d8c88899f166cc3d5d17594 Reviewed-on: https://code.wireshark.org/review/6013 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-3/+1
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-30Add editor modelines; Adjust whitespace; Remove boilerplate commentsBill Meier1-0/+12
Change-Id: I1f5f83ed441f6009125cf2cbe5023af04986898a Reviewed-on: https://code.wireshark.org/review/4392 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-19Rename a couple of to_str functions to have ep_ in the name. This makes itEvan Huus1-1/+1
obvious that the returned string is ephemeral, and opens up the original names in the API for versions that take a wmem pool (and thus can work in any scope). svn path=/trunk/; revision=54249
2013-12-15Fix [-Wmissing-prototypes]Jakub Zawadzki1-0/+2
svn path=/trunk/; revision=54135
2013-03-27Fix the incorrectly duplicated display filter for hf_om2k_cbi.Chris Maynard1-1/+1
#BACKPORT(1.8) svn path=/trunk/; revision=48595
2013-03-19From beroset:Anders Broman1-3/+3
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48426
2012-12-03Fix SVN #46348 (iow, do it properly).Bill Meier1-2/+2
(Fixes compile warning) svn path=/trunk/; revision=46349
2012-12-03Remove duplicated code added as part of SVN #44777;Bill Meier1-18/+6
Move the SVN #44777 new (unduplicated) code to the correct place. Also: fixes [-Wshadow] warning. svn path=/trunk/; revision=46348
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-05From Harald Welte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7696 :Pascal Quantin1-0/+30
packet-gsm_abis_om2000: Add support for MO IF bytes 2 and 3 svn path=/trunk/; revision=44777
2012-09-05From Harald Welte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7695 :Pascal Quantin1-3/+2
Fix minor inconsistency in packet-gsm_abis_om2000.c svn path=/trunk/; revision=44776
2012-07-31Follow-up of r44162: A-bis interface is not the same thing as A interface; ↵Pascal Quantin1-72/+72
update filters and protocol names accordingly svn path=/trunk/; revision=44172
2012-07-31Updated GSM dissectors display filters per checkfiltername.plMichael Mann1-72/+72
Tried to provide consistency with GSM dissector (protocol) names, even if the filenames now don't match the dissector name. svn path=/trunk/; revision=44162
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-04-04Replace a:Jeff Morriss1-1/+1
proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, tvb_get_ptr(tvb, offset, length), [...]) with: proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, NULL, [...]) svn path=/trunk/; revision=41942
2012-03-18From Reinhard Speyerer: Fix several misspellings/typos in WiresharkBill Meier1-1/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6967 svn path=/trunk/; revision=41645
2012-03-16Fix some of the incorrect hf[] FT_BOOLEAN 'display' and 'bitmask' fields;Bill Meier1-16/+15
(Additional instances requiring feedback from the dissector author have been marked with XXX). For 'hf_om2k_aop' use a bitmask in the hf[] entry rather than shifting & etc in the proto_tree_add_uint() call. See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6792 Comment #8. svn path=/trunk/; revision=41612
2012-03-06Don't use FT_BOOLEAN with value_strings: the code to generateJeff Morriss1-2/+2
representations of former is expecting true_false_strings--which are quite different than the latter. svn path=/trunk/; revision=41363
2012-03-05Various changes:Bill Meier1-370/+367
- Use proper proto_tree_add_item() 'encoding' arg (instead of TRUE/FALSE); - Call col_append_fstr() even when 'tree==NULL'; - Use value_string_ext to access the larger value_string tables; - Handle tvb_reported_length() can return -1; - Remove 'set but never used' variable and associated line of code; - Remove unneeded #include <prefs.h>; - Remove empty proto_reg_handoff(); - Do minor whitespace cleanup. svn path=/trunk/; revision=41357
2012-02-26Harald Welte <laforge@gnumonks.org>Jörg Mayer1-0/+1421
via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6792 This is a new dissector for the non-standard Ericsson OM2000 protocol, as it is used for the OML on A-bis of Ericsson RBS 2xxx BTSs. It also includes a dissector for a shim-layer protocol that Ericsson uses for IP-based A-bis like the RBS 2409. As the protocol is not publicly documented, I have invented the name "EHDLC" (Ericsson HLDC) for it. svn path=/trunk/; revision=41195
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-20 15:00:31 +0000