aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-gsm_a_common.c
AgeCommit message (Collapse)AuthorFilesLines
2014-12-23Deleting unneccessary #includes from dissectors.Martin Mathieson1-2/+0
Second batch (packet-eth.c -> packet-icmpv6.d). Will look at cleaning up and committing script afterwards. Change-Id: I14295758b81a59115d8c88899f166cc3d5d17594 Reviewed-on: https://code.wireshark.org/review/6013 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-4/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-043GPP: upgrade 2G/3G NAS dissector to v12.7.0 and NAS EPS dissector to v12.6.0Pascal Quantin1-3/+57
Change-Id: I1e5bc5d28cb956b333c302b1cb18335b59d096a8 Reviewed-on: https://code.wireshark.org/review/5621 Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-11-26Remove sccp_info member from packet_info structure.Michael Mann1-1/+0
sccp_msg_info_t* is now passed from SCCP dissector to its subdissectors through dissector data parameter. Change-Id: Iab4aae58f8995e844f72e02e9f2de36e83589fc0 Reviewed-on: https://code.wireshark.org/review/5442 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-29Add editor modelines; fix indentation as needed.Bill Meier1-0/+12
Change-Id: I1ad94654343e5a018a0b3159481d45ffb3a91263 Reviewed-on: https://code.wireshark.org/review/4363 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-08-19Use dissect_e212_imsi() to dissect IMSIAndersBroman1-23/+19
fix offset in dissect_e212_mcc_mnc_in_address(). Change-Id: I68006ea3e2c79e2549e6f2d2c8a997e44fc3cdf1 Reviewed-on: https://code.wireshark.org/review/3722 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-29convert to proto_tree_add_subtree[_format]Michael Mann1-79/+67
Change-Id: If110de1e0555637264f86f1508858d569871a9c7 Reviewed-on: https://code.wireshark.org/review/2675 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-02-23Fix dissection of BCD numbersPascal Quantin1-5/+3
Do not use of tvb_get_string(): what we really want is the byte string, not an ASCII string Change-Id: I8b9a8b7ccacbdaf6d9525771ff8ed883ba01ad34 Reviewed-on: https://code.wireshark.org/review/329 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2013-12-18Add a sixteenth element to all BCD digit sets to avoid garbage values whenEvan Huus1-2/+2
decoding corrupt bytes. Some of these digit sets could probably be deduplicated... svn path=/trunk/; revision=54224
2013-12-15Fix [-Wmissing-prototypes]Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=54135
2013-12-13Fix (presumably) a VS Code analysis warning:Bill Meier1-45/+45
C6385: Invalid data: accessing 'dgt->out', the readable size is '15' bytes, but '18' bytes might be read Also: Do some trivial whitespace and formatting changes. svn path=/trunk/; revision=54048
2013-11-09Include <epan/to_str.h> only when needed.Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53189
2013-10-13whitespace fixes; mostly: remove trailing blanksBill Meier1-1/+1
svn path=/trunk/; revision=52591
2013-09-22More emem -> wmem conversion:Pascal Quantin1-1/+1
- tvb_get_g_stringz()/tvb_get_ephemeral_stringz()/tvb_get_seasonal_stringz() -> tvb_get_stringz() - tvb_get_g_stringz_enc()/tvb_get_ephemeral_stringz_enc() -> tvb_get_stringz_enc() - tvb_get_ephemeral_unicode_stringz() -> tvb_get_unicode_stringz() - tvb_bcd_dig_to_ep_str() -> tvb_bcd_dig_to_wmem_packet_str() - update docs accordingly svn path=/trunk/; revision=52180
2013-09-22emem -> wmem conversion:Pascal Quantin1-1/+1
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-03Code cleanup:Pascal Quantin1-11/+16
- remove some useless trees - prettify the dissection of a few IEs - use ELEM_MAND_VV_SHORT macro where applicable svn path=/trunk/; revision=51741
2013-09-03Batch of filterable expert info.Michael Mann1-8/+19
svn path=/trunk/; revision=51689
2013-08-30Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9085 :Pascal Quantin1-1/+1
GSM A-I/F DTAP - Detach Request - Detach type is not displayed svn path=/trunk/; revision=51599
2013-08-30Convert a few dissectors from EMEM to WMEM APIPascal Quantin1-10/+11
svn path=/trunk/; revision=51597
2013-07-16Replace some tabs with spaces.Jeff Morriss1-7/+7
svn path=/trunk/; revision=50674
2013-07-16Fix the fuzz failure reported in ↵Jeff Morriss1-21/+70
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8940 : Test whether idx is in range or not (by seeing if it was found in the value_string) before using it as an index into any of the elem_var arrays. This fuzz failure was in elem_telv() but apply the fix to all the elem_*() functions. svn path=/trunk/; revision=50672
2013-07-10Upgrade NAS disssectors to v11.7.0Pascal Quantin1-1/+14
svn path=/trunk/; revision=50494
2013-03-28Properly dissect lat and long according to 3GPP TS 23.032. Fix incorrect ↵Chris Maynard1-15/+20
display filters for hf_gsm_a_geo_loc_deg_of_lat and hf_gsm_a_geo_loc_deg_of_long. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8532 #BACKPORT(1.6,1.8) svn path=/trunk/; revision=48613
2013-03-19Upgrade NAS disssectors to v11.6.0Pascal Quantin1-1/+45
svn path=/trunk/; revision=48427
2013-03-18Add a missing staticPascal Quantin1-1/+1
svn path=/trunk/; revision=48410
2013-03-18As suggested by Evan Huus, use extended value_stringsPascal Quantin1-48/+49
svn path=/trunk/; revision=48407
2013-03-18use enum values instead of hardcoded valuesPascal Quantin1-18/+18
(as suggested by Sylvain Munaut in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8487) svn path=/trunk/; revision=48397
2013-01-22Try to fix dissection of GSM protocol family broken by r47209.Pascal Quantin1-42/+42
Using val_to_str seemed to be a good idea, but most value_string arrays were not properly filled or were using hacks. (I hope I got everything right...) svn path=/trunk/; revision=47218
2013-01-22Fix for CID 717414-717435.Jaap Keuter1-25/+28
Never ever access a string in a value string by its array index. Use the proper access functions (val_to_str[_ext] and friends). Also: make clean compile, so move out of dirty dissectors. svn path=/trunk/; revision=47209
2012-12-30Use tvb_bcd_dig_to_ep_strAnders Broman1-27/+15
svn path=/trunk/; revision=46858
2012-12-29Upgrade NAS disssectors to v11.5.0Pascal Quantin1-8/+8
svn path=/trunk/; revision=46842
2012-12-26Fix a bunch of warnings.Guy Harris1-0/+1
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-11-25Fix several purported [-Wshadow] warnings;Bill Meier1-51/+51
svn path=/trunk/; revision=46189
2012-11-09GSM classmark3 8-PSK decode errorAnders Broman1-1/+16
proto_tree_add_bits_item() can't be called with a length value of -1. Calculate the value, fixes BUG: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7964 #BACKOPRT svn path=/trunk/; revision=45980
2012-10-04Upgrade NAS dissector to v11.4.0 (Release 11)Pascal Quantin1-1/+13
svn path=/trunk/; revision=45325
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-08-25Following r44648, revert part of r44162 and followups so as to have a top ↵Pascal Quantin1-2/+2
level gsm_a filter name svn path=/trunk/; revision=44667
2012-08-01Follow-up of r44162: clean more filtersPascal Quantin1-1/+20
svn path=/trunk/; revision=44187
2012-07-25Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7524 :Pascal Quantin1-7/+36
8-PSK structure in GSM Classmark 3 is not properly dissected svn path=/trunk/; revision=44008
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-06-23Fix copy/paste errorsPascal Quantin1-4/+4
svn path=/trunk/; revision=43447
2012-06-04Get rid of a couple of warnings.Anders Broman1-11/+12
svn path=/trunk/; revision=43064
2012-05-21Display Element ID in hexadecimal (like in 3GPP specs)pascal1-4/+4
Display EPS bearer ID in decimal svn path=/trunk/; revision=42755
2012-05-20Upgrade NAS dissector to Release 10 (v10.6.1)pascal1-2/+42
svn path=/trunk/; revision=42728
2012-05-20Upgrade NAS EPS dissector to Release 10 (10.6.1)pascal1-3/+35
svn path=/trunk/; revision=42722
2012-05-15Remove unneeded #includes (stdlib, stdio, ctypes, time);Bill Meier1-1/+2
In a few cases: do some whitespace, indentation cleanup & reformatting. svn path=/trunk/; revision=42632
2012-04-15checkapi saidGuy Harris1-1/+1
Error: the blurb for field "NMO I" ("gsm_a.nmo_1") has trailing space in packet-gsm_a_common.c so remove the trailing space. svn path=/trunk/; revision=42087
2012-04-15Update RRC to V10.7.0 and add dissection of Core Network System Information IEspascal1-13/+110
svn path=/trunk/; revision=42081
2012-03-15FT_BOOLEAN hf[] entries with a 0 'bitmask' should have 'display' = BASE_NONE;Bill Meier1-3361/+3358
Convert "4 space tabs" to "4 spaces"; General whitespace & formatting changes. svn path=/trunk/; revision=41580
2012-03-14hg_gsm_a_vamos_level --> hf_gsm_a_vamos_levelBill Meier1-3/+3
svn path=/trunk/; revision=41550