aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-gprs-llc.c
AgeCommit message (Collapse)AuthorFilesLines
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-2/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-01Use proto_tree_add_bitmask for groups of proto_tree_add_boolean.Michael Mann1-30/+23
Part 2 of many Change-Id: I50815e7738b011382392f3078a7107d3d9eec4ec Reviewed-on: https://code.wireshark.org/review/5542 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-11-03tvb_length -> tvb_reported_lengthAndersBroman1-3/+3
Change-Id: I48b618008c8c8accd6f161bdc42e02906a4765b7 Reviewed-on: https://code.wireshark.org/review/5085 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-30Add editor modelines; Adjust whitespace; Remove boilerplate commentsBill Meier1-10/+17
Change-Id: I1f5f83ed441f6009125cf2cbe5023af04986898a Reviewed-on: https://code.wireshark.org/review/4392 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-08-08Get rid of no-longer-used variable.Guy Harris1-1/+0
Change-Id: I63bde706a6561c834aab9b10975dbb242c65d998 Reviewed-on: https://code.wireshark.org/review/3495 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-08-08Eliminate proto_tree_add_text from some dissectors.Michael Mann1-29/+33
Change-Id: I6f1710a093fc548c718defa9b40ab68877ede977 Reviewed-on: https://code.wireshark.org/review/3470 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-29convert to proto_tree_add_subtree[_format]Michael Mann1-46/+31
Change-Id: If110de1e0555637264f86f1508858d569871a9c7 Reviewed-on: https://code.wireshark.org/review/2675 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-2/+2
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-2/+2
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-3/+3
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-21Add missing includesJakub Zawadzki1-0/+1
svn path=/trunk/; revision=54332
2013-12-15Fix [-Wmissing-prototypes]Jakub Zawadzki1-0/+3
svn path=/trunk/; revision=54135
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-04-30Fix a few clang warningspascal1-1/+0
svn path=/trunk/; revision=42343
2011-05-18#include <stdlib.h> not req'd;Bill Meier1-527/+601
Reformat hf[] definition; Misc whitespace cleanup; svn path=/trunk/; revision=37266
2011-05-18Add a missing creation of a subtree: Fixes Coverity 907 [UNUSED];Bill Meier1-2/+2
Don't create an unused subtree: Fixes Coverity 908 [UNUSED]; svn path=/trunk/; revision=37265
2011-01-13Use value_string_ext.Anders Broman1-7/+11
svn path=/trunk/; revision=35517
2011-01-13Remove an unused variable.Anders Broman1-1/+0
svn path=/trunk/; revision=35516
2011-01-13Make it possible to dissect the part pressent in short frames.Anders Broman1-89/+82
svn path=/trunk/; revision=35515
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-4/+4
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-08-02Fix cases where the type of a for loop variable is smaller than the type of ↵Bill Meier1-2/+2
the "end" variable. In some cases the usage may have been benign since it can be seen by code inspection that the maximum value of the end variable can't exceed the maximum value of the loop variable. However, on general principles, all the usages have been fixed. svn path=/trunk/; revision=33692
2010-04-06#include <string.h> not needed.Bill Meier1-1/+0
svn path=/trunk/; revision=32410
2010-04-03Remove unneeded #include <stdio.h>Bill Meier1-1/+0
svn path=/trunk/; revision=32367
2010-01-25From Mike Morrin:Anders Broman1-1/+1
Empty GPRS LLC S frames cause truncated data exception. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4417 svn path=/trunk/; revision=31667
2009-09-24Don't guard col_append_str with check_colKovarththanan Rajaratnam1-4/+1
svn path=/trunk/; revision=30125
2009-08-21Sanitize epan includesKovarththanan Rajaratnam1-1/+1
svn path=/trunk/; revision=29499
2009-08-09Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-8/+2
svn path=/trunk/; revision=29345
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-7/+7
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2008-12-18Fix various typos and spelling errors (mostly in text strings)Bill Meier1-1/+1
svn path=/trunk/; revision=27050
2008-12-13From Vincent Helfre:Anders Broman1-2/+12
Fix sndcp_xid_offset. svn path=/trunk/; revision=26990
2008-10-07Fix for bug 2944:Jaap Keuter1-6/+6
Textual correction: Unnumbered Information format-> Unconfirmed Information format, among others. svn path=/trunk/; revision=26369
2008-09-30Minor proto_reg_handoff cleanup: use find_dissector when appropriate.Bill Meier1-1/+1
svn path=/trunk/; revision=26308
2008-09-07From Neil Piercy: Anders Broman1-1/+1
Empty GPRS LLC S frames cause truncated data exception https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2855 svn path=/trunk/; revision=26160
2008-08-01Fix packet-gprs-llc.c:413: warning: format '%lu' expects type 'long unsigned ↵Anders Broman1-1/+1
int', but argument 7 has type 'guint32' and the modified makfiloe.common missed in previous checkin. svn path=/trunk/; revision=25891
2008-08-01From Vincent Helfre:Anders Broman1-55/+93
Implementation of a dissector for SNDCP XID parameters svn path=/trunk/; revision=25889
2008-07-28packet-gprs-llc.c:431: warning: 'ui_ti' may be used uninitialized in this ↵Anders Broman1-1/+1
function svn path=/trunk/; revision=25856
2008-07-28packet-gprs-llc.c:324: warning: unused parameter 'ui_ti'Anders Broman1-1/+1
svn path=/trunk/; revision=25855
2008-07-28From Vincent Helfre :Anders Broman1-399/+354
GPRS LLC CRC24 badly calculated for non protected frames https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2290 svn path=/trunk/; revision=25854
2008-06-28Fix some warnings reported by gcc -Wshadow ...Bill Meier1-9/+9
svn path=/trunk/; revision=25628
2008-03-04match_strval() may return NULL so don't blindly pass its return value into ↵Jeff Morriss1-161/+163
col_add_*() or proto_add_*(); use val_to_str() (returning "Unknown (%d)" if no match is found) instead. svn path=/trunk/; revision=24557
2007-10-11Implement some of the minor possible speed improvment patches.Anders Broman1-2/+2
svn path=/trunk/; revision=23150
2007-08-20From Cyrille Colin:Anders Broman1-1/+1
gsm_a : http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1754 SMS CP (gsm_a_dtap), RP (gsm_a_rp) and T-PDU (gsm_sms) protocol stacks are decoded in Wireshark when called by BSSAP or RANAP. Same protocol stack can be called by GPRS-LLC (sapi 7). Simple modification needed in packet-gsm_a.c to add dtap dissector to llcgprs.sapi 7. Me a comment in gprs-llc. svn path=/trunk/; revision=22559
2006-05-28Ethereal->WiresharkAnders Broman1-3/+3
svn path=/trunk/; revision=18234
2006-05-23Dissect rrlp payload.Anders Broman1-4/+4
svn path=/trunk/; revision=18211
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-3/+3
svn path=/trunk/; revision=18196
2005-10-12From Rene Pilz:Anders Broman1-4/+18
- LLC XID patch (reaability patch). - Dissection of the MS Radio Capabilities. svn path=/trunk/; revision=16199
2005-08-28add missing value_string terminationRonnie Sahlberg1-0/+3
svn path=/trunk/; revision=15580
2005-08-08various code cleanup:Ulf Lamping1-4/+0
-use g_snprintf instead of sprintf and snprintf -use g_strdup_printf where appropriate -remove #include "snprintf.h" (as only g_snprintf should be used) -replace some more alloc/realloc/calloc/free with their glib pendants svn path=/trunk/; revision=15264