aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-fc.h
AgeCommit message (Collapse)AuthorFilesLines
2020-12-15FC: use ETHERTYPE_UNK when applicable, no excusesJaap Keuter1-0/+1
Two interlocking problems cause the dissection of FC to fail in some cases, as shown in the capture of the related issue. The FC dissector assumes that ETHERTYPE_UNK in the data structure passed to it is coming from the MDS header dissector only, and thus that header sizes have to be taken into account. This is not / no longer the case. It always passes down ETHERTYPE_FCFT. Therefore the MDS header size checking does not apply to ETHERTYP_UNK, so is removed as condition. The other FC related dissectors were forced to setup a data structure to pass to FC for it to handle that part of the frame. Because these weren't related to ethernet, these lazily set the ethertype field in the data structure to 0. This unfortunately matches ETHERTYPE_UNK, triggering the MDS header size checking in FC, leading to this issue. With the first problem resolved, now make it explicit that unknown ethertype is indicated by ETHERTYPE_UNK, not '0'. Addresses primary part of issue #17084
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-18Remove unneeded #include epan/dissectors/packet-scsi.hAlexis La Goutte1-1/+0
svn path=/trunk/; revision=54234
2013-11-28Adjust fc_stat.c to use newer fc_exchange_t structure for its stats.Michael Mann1-0/+1
svn path=/trunk/; revision=53621
2013-11-28Bugfix Negative Fibre Channel scsi_time value. Bug 3209 ↵Michael Mann1-1/+6
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3209) The solution was to move the itlq_nexus_t structure handling from the FC dissector to the FCS dissector since it's actually the one with the LUN field. OXID+LUN makes a unique exchange at FC layer so track that separately. Also needed some additional OXID->LUN mapping at the FC layer to keep LUN correctly persistent. Not backporting because this was partially made possible by r53569, which won't be backported. svn path=/trunk/; revision=53620
2013-11-25Remove Fibre Channel specific fields from packet_info and just have the ↵Michael Mann1-0/+17
fc_hdr or fc_data_t structure passed between all necessary dissectors. svn path=/trunk/; revision=53569
2013-10-13whitespace fixes; mostly: remove trailing blanksBill Meier1-4/+4
svn path=/trunk/; revision=52591
2013-03-01Export libwireshark symbols using WS_DLL_PUBLIC defineBalint Reczey1-1/+2
Also remove old WS_VAR_IMPORT define and related Makefile magic everywhere in the project. svn path=/trunk/; revision=47992
2012-12-08Bugfix FCP lun request/response tracking.Michael Mann1-1/+0
This works towards bug 3209 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3209) by at least satisfying the layer under SCSI. All of the dissectors that feed into SCSI seem to have similar "lun tracking" issues, so I think a more general solution may be needed to fix the bug "right" #BACKPORT svn path=/trunk/; revision=46464
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-01-19fix compile errors found by dumpabi targetBalint Reczey1-0/+2
svn path=/trunk/; revision=40595
2007-06-13Fix for bug 1633:Jaap Keuter1-0/+1
Adding BLS ABTS handling. svn path=/trunk/; revision=22087
2006-10-13if FC type is FPC/SCSI and the relative offset bit is set in f_ctl then the ↵Ronnie Sahlberg1-0/+1
parameter field is 4 bytes and contain the relative offset of the data for data in/out decode this field as relative offset and also store it in the fc_hdr structure so that FCP can pick it up and pass if to the SCSI payload data in/out dissector later svn path=/trunk/; revision=19510
2006-10-11move the ITL and the ITLQ structure to packet-scsi.h where it belongsRonnie Sahlberg1-45/+0
svn path=/trunk/; revision=19492
2006-09-30add an extra_data pointer to the itlq structure where specific ↵Ronnie Sahlberg1-1/+1
commandsets/cdbs can hang additional data that are unique to that commandset/cdb make the scsi osd service action and getsetattributetype use this facility furhter enhancements to scsi osd svn path=/trunk/; revision=19374
2006-09-30scsi osd additionsRonnie Sahlberg1-0/+1
we also need to track the serviceaction in the itlq structure so we can decode the data in/out properly svn path=/trunk/; revision=19371
2006-06-20Change ETH_VAR_IMPORT to WS_VAR_IMPORT. Try to fix a duplicate variableGerald Combs1-1/+1
definition in the Catapult DCT2000 code. svn path=/trunk/; revision=18524
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-3/+3
svn path=/trunk/; revision=18196
2006-05-05update the itl structure so that it sets the cmdset field to the current ↵Ronnie Sahlberg1-1/+10
command set even for the case where we have not detected it by seeing the inquiry response. Make teh msb of the cmdset variable indicate whether we detected the commandset from the trace or whether we used the default value from preferences. indicate in the dissection of the packet whether the command set is "known" or whether we are using the default one. make scsi srt stats work even for when we are using the "default" dommandset. Previously scsi srt would ignore all pdus for itl sessions where the "default" command set was used. svn path=/trunk/; revision=18098
2006-04-24change the signature for dissect_scsi_snsinfo() to take itlq and itl structuresRonnie Sahlberg1-0/+13
update the comment in packet-scsi.c to reflect that it is the transport now that is responsible to track itl and itlq data make scsi tapable svn path=/trunk/; revision=17974
2006-04-22the scsi transports (fc/fcp and iscsi) now track both itl and itlqRonnie Sahlberg1-0/+4
structures for scsi. we no longer need the scsi_task_id structure passed by pinfo->private_data so get rid of it. we no longer need the (broken by design) scsi_task_data hash table since this has been replaced byt hte itl and itlq structures and tracking svn path=/trunk/; revision=17952
2006-04-21updates to get the fc and scsi dissectorsRonnie Sahlberg1-1/+9
and get rid of some breakage in the design let the scsi transport keep track of itl (initiator, target, lun) matching and let it pass a itl structure to scsi that is persistent across packets. let scsi use this itl structure to track device type for a specific itl instead of the (must have been) broken hashtable. update both iscsi and fc to track the itl structure for scsi and schange the scsi signature to accept itl as a parameter. more to come. svn path=/trunk/; revision=17942
2006-04-20rename hte itlq structures to itlqRonnie Sahlberg1-1/+1
svn path=/trunk/; revision=17922
2006-04-20rename the fc_exchange_data structure to the more appropriate itlq_nexus_tRonnie Sahlberg1-6/+8
svn path=/trunk/; revision=17921
2006-04-06add a field for storing the scsi opcode in the exchange struct.Ronnie Sahlberg1-1/+2
it is silly that scsi has to track these things itself when all the transports already keep track of exchanges. the scsi transports should all use the fc_exchange_data structure to pass lun to scsi and where scsi kan store the opcode between requests and data/response packets svn path=/trunk/; revision=17829
2006-04-06use the fc exchange structure to track LUN values from fcp command all the ↵Ronnie Sahlberg1-0/+1
way through to the response and get rid of the broken hashtable used for the same purpose previously. some additional cleanups. svn path=/trunk/; revision=17827
2006-04-05cleaning up bits and piecesRonnie Sahlberg1-3/+0
replacing the hashtables with a better exchange se_tree svn path=/trunk/; revision=17809
2005-09-14From Dinesh G DuttAnders Broman1-0/+2
Support some new messages and fix a couple of bugs. packet-fc.h - Added a #define for a Cisco MDS-specific frame called OHMS (online health mgmt srv) packet-fc.c - Support for OHMS frame, fixed an incorrect "malformed frame" error caused on ACK1 frames (they don't contain anything but (encap hdr + FC hdr + encap trailer), fixed incorrect detection of last-data-frame packet-fcct.h - Support for new service type, "Fabric Controller", used in conjunction with FC-SW3 ESS message, exported the service name value string definitions and packet-fcct.c - Support for recognizing "Fabric Controller" service type and "vendor-specific" service packet-fcswils.h - Support for ESS & MRRA messages, defined as part of FC-SW3 packet-fcswils.c - Support for ESS & MRRA messages, defined as part of FC-SW3 packet-scsi.c - Support for Verify and Write&Verify SBC commands. svn path=/trunk/; revision=15799
2004-07-18Move dissectors to epan/dissectors directory.Gilbert Ramirez1-0/+152
Also move ncp222.py, x11-fields, process-x11-fields.pl, make-reg-dotc, and make-reg-dotc.py. Adjust #include lines in files that include packet-*.h files. svn path=/trunk/; revision=11410
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-01 05:53:56 +0000