aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-dcm.c
AgeCommit message (Collapse)AuthorFilesLines
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-2/+2
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-12-06Fix various typos and spelling errors.Bill Meier1-1/+1
svn path=/trunk/; revision=35126
2010-08-09From David Aggeler:Jaap Keuter1-356/+627
- Finally, better reassembly using fragment_add_seq_next(). The previous mode is still supported. - Fixed sporadic decoding and export issues. Always decode association negotiation, since performance check (tree==NULL) is now only in dissect_dcm_pdv_fragmented(). - Added one more PDV length check - Show Association Headers as individual items - Code cleanup. i.e. moved a few lookup functions to be closer to the dissection. svn path=/trunk/; revision=33751
2010-06-09Do some constifying [or other] based upon gcc -Wwrite-strings warnings.Bill Meier1-4/+4
svn path=/trunk/; revision=33198
2010-05-14From David Aggeler via ↵Jeff Morriss1-51/+67
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4762 : - Fixed HF to separate signed & unsigned values and to have BASE_DEC all signed - Fixed private sequences with undefined length in ILE - Fixed some spellings in comments svn path=/trunk/; revision=32815
2010-04-03Remove unneeded #include <stdio.h>Bill Meier1-1/+0
svn path=/trunk/; revision=32367
2010-03-19Squelch a bunch of compiler warnings.Guy Harris1-55/+57
svn path=/trunk/; revision=32246
2010-01-25From Didier Gautheron via bug 4419:Stig Bjørlykke1-100/+34
se_alloc and ep_alloc never return NULL and se_alloc0 already initialized data with 0. svn path=/trunk/; revision=31654
2010-01-18Fix a number of gcc _Wshadow warningsBill Meier1-5/+5
svn path=/trunk/; revision=31557
2009-11-04tvb_format_text() always returns a non NULL pointer so don't check return ↵Kovarththanan Rajaratnam1-3/+3
value for NULL pointer svn path=/trunk/; revision=30821
2009-10-25From Jakub Zawadzki:Anders Broman1-45/+29
Cleanup dissector code - use proper memory functions. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164 svn path=/trunk/; revision=30691
2009-08-28Fix possible memmove with a NULL poiunter.Bill Meier1-2/+4
svn path=/trunk/; revision=29599
2009-08-09Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-3/+1
svn path=/trunk/; revision=29345
2009-07-10From David Aggeler:Jaap Keuter1-159/+78
* - Fixed corrupt files on DICOM Export * - Fixed memory limitation on DICOM Export * - Removed minimum packet length for static port mode * - Simplified checks for heuristic mode * - Removed unused functions svn path=/trunk/; revision=29060
2009-05-18From David Aggeler:Jaap Keuter1-59/+178
Not much, just a little bit of fine tuning: - Spelling - Added expert_add_info() for status responses with warning & error level - Added command details in info column (optionally) Also plugging memory leak. svn path=/trunk/; revision=28392
2009-03-29More size_t casts.Anders Broman1-1/+1
svn path=/trunk/; revision=27880
2009-03-15From Jakub Zawadzki:Stig Bjørlykke1-5/+3
More remove checking for NULL before g_free(). svn path=/trunk/; revision=27728
2008-12-19Back out r27047 and r27053.Gerald Combs1-9/+9
svn path=/trunk/; revision=27062
2008-12-18Update calls to proto_tree_add_bytes_format to reflect r27047.Gerald Combs1-9/+9
svn path=/trunk/; revision=27053
2008-12-18Fix two typosBill Meier1-2/+2
svn path=/trunk/; revision=27052
2008-12-18Fix various typos and spelling errors (mostly in text strings)Bill Meier1-15/+15
svn path=/trunk/; revision=27050
2008-12-17Fix typos and spelling (mostly in text strings) Bill Meier1-5/+5
svn path=/trunk/; revision=27028
2008-10-31From David Aggeler:Jaap Keuter1-88/+156
Added Tag matching based on masks for remaining tags in the standard. Now all tags (except private tags) should be supported. svn path=/trunk/; revision=26662
2008-10-31Fix some "format not a string literal and no format arguments" warnings.Stig Bjørlykke1-6/+6
svn path=/trunk/; revision=26646
2008-10-12From David Aggeler:Anders Broman1-24/+25
Reworked the item creation. svn path=/trunk/; revision=26424
2008-10-11Really make it compile. Someone should have a look at this.Stig Bjørlykke1-7/+7
svn path=/trunk/; revision=26417
2008-10-11Just try to make it compile.Anders Broman1-8/+8
svn path=/trunk/; revision=26416
2008-10-11From David Aggeler: Anders Broman1-797/+4218
packet-dcm, improved DICOM Tag support, misc fixes. svn path=/trunk/; revision=26413
2008-08-09From Shinsuke SUZUKI (bug 2789):Stig Bjørlykke1-4/+4
Remove some non-ASCII characters. svn path=/trunk/; revision=25972
2008-07-25From David Aggeler:Anders Broman1-62/+89
Follow-up from SVN 25825 check in The g_slist_free() is really needed in export_object.c, otherwise, the export list has false (repetitive) entries in it, that cause a crash when selecting them. Whether false entries are in the list, only depends on the speed of the export processing, since this tap is Replaced all guchar with gchar. This should eliminate the warnings on solaris. I guess I used the wrong reference. Added patch for 'Authors' in case I need to add myself to the list. svn path=/trunk/; revision=25834
2008-07-25static variable declarations don't belong in header filesJeff Morriss1-8/+281
svn path=/trunk/; revision=25830
2008-07-25Remove an unused variable and cast a string constant into a guchar. Also ↵Jeff Morriss1-3/+2
add newline at the end of the file. svn path=/trunk/; revision=25829
2008-07-25Try to fix some of the warnings.Anders Broman1-2/+0
svn path=/trunk/; revision=25827
2008-07-25Try to fix some of the warnings.Anders Broman1-11/+7
svn path=/trunk/; revision=25826
2008-07-25From David Aggeler:Anders Broman1-498/+1359
multiple PDV per PDU support - Support multiple PDVs per PDU - Better summary, in PDV, PDU header and in INFO Column, e.g. show commands like C-STORE - Fixed Association Reject (was working before my changes) - Fixed PDV Continuation with very small packets. Reduced minimum packet length from 10 to 2 Bytes for PDU Type 4 - Fixed PDV Continuation. Last packet was not found correctly. - Fixed complilation warning (build 56 on solaris) - Fixed tree expansion (hf_dcm_xxx) - Added expert_add_info() for Assoctiation Reject - Added expert_add_info() for Assoctiation Abort - Added expert_add_info() for short PDVs (i.e. last fragment, but PDV is not completed yet) - Clarified and grouped data structures and its related code (dcmItem, dcmState) to have consistent _new() & _get() functions and to be be according to coding conventions - Added more function declaration to be more consistent - All dissect_dcm_xx now have (almost) the same parameter order - Removed DISSECTOR_ASSERT() for packet data errors. Not designed to handle this. - Handle multiple DICOM Associations in a capture correctly, i.e. if presentation contexts are different. svn path=/trunk/; revision=25824
2008-07-25From David Aggeler:Anders Broman1-500/+1411
DICOM dissector bugfixes and features svn path=/trunk/; revision=25823
2007-11-09Apply yet another set of the optimization patches:Anders Broman1-1/+1
janitor work, replace col_add_fstr/ col_set_fstr. svn path=/trunk/; revision=23411
2007-04-23Add some GCC warnings to the standard set, and add some others to theGuy Harris1-13/+17
--enable-extra-gcc-checks set. If we turn on -pedantic, try turning on -Wno-long-long as well, so that it's not *so* pedantic that it rejects the 64-bit integral data types that we explicitly require. Constify a bunch of stuff, and make some other changes, to get rid of warnings. Clean up some indentation. svn path=/trunk/; revision=21526
2007-03-29Fix some more warningsStephen Fisher1-2/+2
svn path=/trunk/; revision=21273
2007-03-28Remove almost all of the casts I committed recently and in place ofStephen Fisher1-3/+3
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it. svn path=/trunk/; revision=21253
2007-03-27Fix about 100 simple to fix warnings from gcc 4.0 in epan/dissectors Stephen Fisher1-3/+3
svn path=/trunk/; revision=21233
2006-11-14nikai@nikai.net:Jörg Mayer1-1/+0
Remaining fixes from: http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1225 svn path=/trunk/; revision=19895
2006-10-31change the signature for the get_pdu_len() function pointer passed to ↵Ronnie Sahlberg1-1/+1
tcp_dissect_pdus() to also include a packet_info pointer. there are many reasons why some protocols actually need to be able to access the pinfo structure while determining the pdu size svn path=/trunk/; revision=19751
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-5/+5
svn path=/trunk/; revision=18196
2006-01-20packet-bgp.c: Fix incorrect use of g_snprintf return valueJörg Mayer1-9/+18
mp_addr_to_str was unnecessary 'complex' - simplified it packet-dns.c: Fix incorrect use of g_snprintf return value packet-dcm.c: Fix incorrect use of g_snprintf return value Someone who understands the protocol should look at the "vr, tr might be used uninitialized..." warning. packet-x11.c: Fix incorrect use of g_snprintf return value packet-kerberos.c: Fix incorrect use of g_snprintf return value Someone should take a look at the "longjump might clobber ..." messages packet-diameter.c: Fix incorrect use of g_snprintf return value Get rid of unsigned < 0 check packet-pgm.c: Fix incorrect use of g_snprintf return value packet-nbns.c: Fix incorrect use of g_snprintf return value packet-winsrepl.c: Collateral damage to packet-nbns.c fix packet-netbios.c: Collateral damage to packet-nbns.c fix packet-netbios.h: Collateral damage to packet-nbns.c fix packet-kerberos.c: Collateral damage to packet-nbns.c fix packet-nbipx.c: Collateral damage to packet-nbns.c fix svn path=/trunk/; revision=17065
2005-10-16get rid of some strcpyRonnie Sahlberg1-29/+10
svn path=/trunk/; revision=16234
2005-09-17remove some strcpy()Ronnie Sahlberg1-8/+4
svn path=/trunk/; revision=15849
2005-08-27sprintf removalRonnie Sahlberg1-10/+12
svn path=/trunk/; revision=15550
2005-08-14change a g_malloc() that was never released into ep_alloc()Ronnie Sahlberg1-9/+10
this function would always leak memory when called. this fixes a memleak in dcm svn path=/trunk/; revision=15352
2005-08-12gmemchunk -> se_alloc() improvementsRonnie Sahlberg1-11/+2
svn path=/trunk/; revision=15323