aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-dcm.c
AgeCommit message (Collapse)AuthorFilesLines
2013-11-10Add missing includes in order to remove exceptions.h from proto.h (next commit).Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53230
2013-10-29From didier gautheron: remove redundant or use faster col_xxx functionsBill Meier1-2/+1
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster. - same for replace col_append_fstr and col_append_str - remove col_clear() when it's redundant: + before a col_set/col_add if the dissector can't throw an exception. - replace col_append() after a col_clear() with faster col_add... or col_set https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344 svn path=/trunk/; revision=52948
2013-10-13whitespace fixes; mostly: remove trailing blanksBill Meier1-10/+10
svn path=/trunk/; revision=52591
2013-09-22emem -> wmem conversion:Pascal Quantin1-5/+5
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-15Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if ↵Michael Mann1-12/+12
hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly. The script didn't catch as many as I would have liked, but it's a start. The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum. svn path=/trunk/; revision=52045
2013-09-14Convert some dissectors to wmem (leaving uat-like memory with emem for now)Pascal Quantin1-51/+51
svn path=/trunk/; revision=52031
2013-09-09expert_add_info_format_text -> expert_add_info_formatMichael Mann1-4/+4
svn path=/trunk/; revision=51852
2013-09-07Batch of filterable expert infoMichael Mann1-33/+56
svn path=/trunk/; revision=51823
2013-08-28Fix a copy-paste error.Anders Broman1-1/+1
svn path=/trunk/; revision=51569
2013-08-28Use dissector_delete_uint_range/dissector_add_uint_rangeAnders Broman1-11/+3
svn path=/trunk/; revision=51567
2013-07-17Remove fragment_data, add fragment_head, fragment_item - for now alias it to ↵Jakub Zawadzki1-1/+1
the same structure. This is begin of work to split fragment head and fragments items. svn path=/trunk/; revision=50708
2013-03-22Don't wire into the reassembly code the notion that reassemblies shouldGuy Harris1-8/+6
be done on flows from one address to another; reassembly for protocols running atop TCP should be done on flows from one TCP endpoint to another. We do this by: adding "reassembly table" as a data structure; associating hash tables for both in-progress reassemblies and completed reassemblies with that data structure (currently, not all reassemblies use the latter; they might keep completed reassemblies in the first table); having functions to create and destroy keys in that table; offering standard routines for doing address-based and address-and-port-based flow processing, so that dissectors not needing their own specialized flow processing can just use them. This fixes some mis-reassemblies of NIS YPSERV YPALL responses (where the second YPALL response is processed as if it were a continuation of a previous response between different endpoints, even though said response is already reassembled), and also allows the DCE RPC-specific stuff to be moved out of epan/reassembly.c into the DCE RPC dissector. svn path=/trunk/; revision=48491
2013-02-26it's ==> its & its ==> it's as needed.Bill Meier1-3/+3
svn path=/trunk/; revision=47891
2013-02-17Support for SCU/SCP Role Selection and Asynchronous Operations Window ↵Michael Mann1-53/+377
Negotiation From Stefan Allers. Bug 8347 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8347) svn path=/trunk/; revision=47715
2013-02-06From Stefan Allers viaEvan Huus1-13/+163
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8282 Extended Negotiation support for the DICOM dissector. svn path=/trunk/; revision=47520
2013-02-04'#if 0' out an unused hf[] entry;Bill Meier1-56/+51
Do some minor cleanup. svn path=/trunk/; revision=47464
2012-12-26Fix a bunch of warnings.Guy Harris1-14/+12
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-6/+3
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-09-07From Robert Bullen via ↵Jeff Morriss1-0/+2
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7683 : The reassembled fragments tree in the Packet Details view is awesome, but it lacks one thing: a field that exposes the reassembled data. tcp.data already exists for exposing a single TCP segment's payload as a byte array. It would be handy to have something similar for a single application layer PDU when TCP segment reassembly is involved. I propose tcp.reassembled.data, named and placed after the already existing field tcp.reassembled.length. My primary use case for this feature is outputting tcp.reassembled.data with tshark for further processing with a script. The attached patch implements this very feature. Because the reassembled fragment tree code is general purpose, i.e. not specific to just TCP, any dissector that relies upon it can add a similar field very cheaply. In that vein I've also implemented ip.reassembled.data and ipv6.reassembled.data, which expose reassembled fragment data as a single byte stream for IPv4 and IPv6, respectively. All other protocols that use the reassembly code have been left alone, other than inserting NULL into their initializer lists for the newly introduced struct field reassemble.h:fragment_items.hf_reassembled_data. svn path=/trunk/; revision=44802
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-05-15Remove unneeded #includes (stdlib, stdio, ctypes, time);Bill Meier1-3/+1
In a few cases: do some whitespace, indentation cleanup & reformatting. svn path=/trunk/; revision=42632
2012-04-30Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+0
svn path=/trunk/; revision=42362
2011-12-27Corrected some obvious typos.Chris Maynard1-54/+54
svn path=/trunk/; revision=40302
2011-11-09Fix a number of proto_tree_add_item() encoding args.Bill Meier1-1/+1
svn path=/trunk/; revision=39774
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-2/+2
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-06-19Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.Bill Meier1-2/+0
svn path=/trunk/; revision=37716
2011-05-27Make TVBs opaque for most users.Jeff Morriss1-1/+1
Convert TVB_RAW_OFFSET() and TVB_GET_DS_TVB() into functions. svn path=/trunk/; revision=37422
2011-05-27Treat TVBs as opaque: use the accessor functions instead of accessing the fieldsJeff Morriss1-6/+7
directly. svn path=/trunk/; revision=37420
2011-05-04Cleanup: replace sizeof(arr)/sizeof(arr[0]) with shorter array_length(arr)Jakub Zawadzki1-3/+3
svn path=/trunk/; revision=36986
2011-04-30Check our PDU length. Fixes the infinite loop found in bug 5876.Gerald Combs1-0/+7
svn path=/trunk/; revision=36958
2011-04-16Fix Coverity CIDs 603 & 604.Gerald Combs1-2/+2
svn path=/trunk/; revision=36672
2011-03-23Removed "comparing an array to null", with no effect.Stig Bjørlykke1-2/+1
Coverity 532. svn path=/trunk/; revision=36279
2011-03-22Remove two tests for fail return from g_malloc(); Fixes Coverity #424 ↵Bill Meier1-8/+4
"FORWARD_NULL" svn path=/trunk/; revision=36267
2011-02-10Modify proto_tree_add_bytes_format() and proto_tree_add_bytes_format_value()Jeff Morriss1-13/+11
so that if the start_ptr is NULL the bytes are extracted from the given TVB using the given offset and length. Replace a bunch of: proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, tvb_get_ptr(tvb, offset, length), [...]) with: proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, NULL, [...]) svn path=/trunk/; revision=35896
2011-01-31Fix two cases of 'if (x = y)' which should be 'if (x == y)'.Bill Meier1-1/+1
Found by reviewing msvc level 4 warnings "assignment within conditional expression". (Unfortunately most of the warnings are false positives so this warning can't be enabled) svn path=/trunk/; revision=35726
2011-01-30Introduce "Fragment count" filter element for all protocols doing reassembly.Stig Bjørlykke1-0/+5
svn path=/trunk/; revision=35705
2011-01-20Roll some calls to tvb_get_ptr() into proto_tree_add_bytes_format() (insteadJeff Morriss1-30/+12
of going through a temporary variable). This just makes it more obvious which add_bytes_format() calls are or are not being given pointers into the TVB. Use tvb_ip_to_str() and tvb_ip6_to_str() in a couple spots. svn path=/trunk/; revision=35593
2011-01-16Use tvb_memeql() and tvb_memcpy().Jeff Morriss1-2/+2
Use tvb_ip_to_str() and tvb_ip6_to_str(). There's no need to pass the result of tvb_get_ptr() as the 'value' in proto_tree_add_*(): just use proto_tree_add_item(). Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the return string is NULL terminated. svn path=/trunk/; revision=35546
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-2/+2
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-12-06Fix various typos and spelling errors.Bill Meier1-1/+1
svn path=/trunk/; revision=35126
2010-08-09From David Aggeler:Jaap Keuter1-356/+627
- Finally, better reassembly using fragment_add_seq_next(). The previous mode is still supported. - Fixed sporadic decoding and export issues. Always decode association negotiation, since performance check (tree==NULL) is now only in dissect_dcm_pdv_fragmented(). - Added one more PDV length check - Show Association Headers as individual items - Code cleanup. i.e. moved a few lookup functions to be closer to the dissection. svn path=/trunk/; revision=33751
2010-06-09Do some constifying [or other] based upon gcc -Wwrite-strings warnings.Bill Meier1-4/+4
svn path=/trunk/; revision=33198
2010-05-14From David Aggeler via ↵Jeff Morriss1-51/+67
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4762 : - Fixed HF to separate signed & unsigned values and to have BASE_DEC all signed - Fixed private sequences with undefined length in ILE - Fixed some spellings in comments svn path=/trunk/; revision=32815
2010-04-03Remove unneeded #include <stdio.h>Bill Meier1-1/+0
svn path=/trunk/; revision=32367
2010-03-19Squelch a bunch of compiler warnings.Guy Harris1-55/+57
svn path=/trunk/; revision=32246
2010-01-25From Didier Gautheron via bug 4419:Stig Bjørlykke1-100/+34
se_alloc and ep_alloc never return NULL and se_alloc0 already initialized data with 0. svn path=/trunk/; revision=31654
2010-01-18Fix a number of gcc _Wshadow warningsBill Meier1-5/+5
svn path=/trunk/; revision=31557
2009-11-04tvb_format_text() always returns a non NULL pointer so don't check return ↵Kovarththanan Rajaratnam1-3/+3
value for NULL pointer svn path=/trunk/; revision=30821
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-15 00:19:52 +0000