aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-csn1.h
AgeCommit message (Collapse)AuthorFilesLines
2015-12-31Don't cast away constness.Guy Harris1-1/+1
Change-Id: I75c782185b8847abf8c985572d8280271ba00a5a Reviewed-on: https://code.wireshark.org/review/12968 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-09-23GSM RLC/MAC: fix dissection of variable length bitmapsPascal Quantin1-2/+2
Bug: 11534 Change-Id: I857134f21ab6a8a135eba6e784807f3f3734bf6c Reviewed-on: https://code.wireshark.org/review/10607 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-09-20Make CSN.1 dissectors more filterable.Michael Mann1-75/+79
The intent here is to remove proto_tree_add_text from packet-csn1.c, but the macros setup means A LOT more hf fields needs to be created. Many of those new hf fields were created with a perl script Bug: 11504 Change-Id: If12c7677185f18a7f684fd3746397be92b56b36d Reviewed-on: https://code.wireshark.org/review/10391 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-14Always put editor-modelines at the end of the file ...Bill Meier1-3/+3
... to ensure that there are no potential issues with respect to editors limiting the number of lines scanned at the end of the file when checking for editor modelines. Change-Id: Ic85cbb108bb5159d6ec4116fea11f5eebb4e44a4 Reviewed-on: https://code.wireshark.org/review/4688 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-29Add editor modelines and adjust indentation as needed.Bill Meier1-0/+13
Change-Id: Id57d264299f2026d703c5b08bace4b24b32f184c Reviewed-on: https://code.wireshark.org/review/4371 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-07-07Try to fix cast discards '__attribute__((const))' qualifier from pointerAndersBroman1-8/+8
target type Change-Id: If7efc629247480fbfb231b965a358803b67e1504 Reviewed-on: https://code.wireshark.org/review/2919 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-07-07See if yhis fixes "cast discards '__attribute__((const))' qualifier fromAndersBroman1-1/+1
pointer target type" Change-Id: I0f97b119f1e6151622d360464f12ad399cbaf117 Reviewed-on: https://code.wireshark.org/review/2917 Tested-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-07-23Don't cast away constness.Guy Harris1-1/+1
svn path=/trunk/; revision=50855
2012-12-26Eliminate multiple "const"s.Guy Harris1-1/+1
svn path=/trunk/; revision=46753
2012-12-26Fix a bunch of warnings.Guy Harris1-2/+2
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-09-14From Mike Morrin:Anders Broman1-45/+47
Fix pedantic compiler warnings in csn.1 dissectors. There is some tricky casting going on in csn.1 structures. To eliminate all the warnings, the function pointers needed to be moved out of the object pointer unions. Fortunately macros (mostly) hide these changes from the protocol dissector tables. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7686 svn path=/trunk/; revision=44899
2012-09-07From Mike Morrin:Anders Broman1-2/+2
Interface based on header type rather than MCS. passes in the header type for EGPRS packets. This makes sense because in a real protocol stack, the header type is encoded in the burst stealing bits, allowing the header can be decoded, giving the CPS IE, which then allows the data blocks to be decoded, so wireshark now follows the same practice. I found that there was a (previously overlooked) alignment error in decoding the last octet of some headers due to the last "octet" having less than 8 bits, and both the protocol stacks I have here assume that the left-hand bits are missing (as per the figures in 44.060). I corrected this by making a small extension to the NULL encoding in packet-csn.[ch] to allow a NULL field to consume more than 0 bits. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7615 svn path=/trunk/; revision=44805
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-04-24Minor cleanup: whitespace, indentation, long-lines, style, typos, etc;Bill Meier1-41/+41
Also: remove unneeded #include <stdlib.h> in 2 cases. svn path=/trunk/; revision=42226
2012-02-29From Mike Morrin:Anders Broman1-0/+26
The attached patches add the uses proto_tree_add_split_bits_ret_val() proto_tree_add_split_bits_crumb() https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6885 svn path=/trunk/; revision=41249
2012-02-23From Lei Chen:Anders Broman1-0/+2
a patch to support decode FDD_CELL_INFORMATION of "UTRAN FDD Description" in packet-gsm_rlcmac.c https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6856 svn path=/trunk/; revision=41149
2012-02-05From Sylvain Munaut:Anders Broman1-1/+34
0001-packet-csn1-Fix-indenting-of-the-CSN_UINT-subsection.patch 0002-packet-csn1-Add-new-maro-M_TYPE_LABEL-to-customize-n.patch 0003-packet-csn1-New-macro-M_FIXED_LABEL-to-customize-str.patch 0004-packet-csn1-Allow-CHOICE-elements-to-re-process-the-.patch 0005-packet-csn1-Make-new-M_CHOICE_IL-option-that-doesn-t.patch 0006-packet-csn-Extend-CSN_SERIALIZE-to-allow-0-bit-of-le.patch https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6789 svn path=/trunk/; revision=40847
2012-01-21From Mike Morrin:Anders Broman1-40/+70
a patch which improves several aspects of GSM RLS/MAC dissection. Generic improvements to the csn.1 dissector include: • Added a flag to the type descriptor structure so that any type can (potentially) flagged as xxx_OR_NULL. This was specifically needed for UINT_OR_NULL for the ms capabilities struct. • Corrected the octet calculation in app of the proto_tree_add_text() and proto_item_set_len() calls. • Changed the CSN_SERIALIZE so that the length of the length field can be specified. • For CSN_NEXT_EXIST removed the requirement that the next type be CSN_END, to allow truncation of multiple IEs. • For CSN_LEFT_ALIGNED_VAR_BITMAP corrected the handling of bit_offset. • Added a new type CSN_PADDING_BITS to make inspection of padding bits more convenient. • Improved the CSN_RECURSIVE_TARRAY_1 to show the array index. Improvements to the gsm_rlcmac dissector include: • Comment out a couple of unused hf variables. • Rework the definition of EGPRS Ack/Nack Description so that the length IE (and absence thereof) is handled correctly. This is the original issue for which the bug was raised. • Added Padding Bits definitions to all PDUs • Change the Multislot_capability_t and Content_t definitions to allow truncation at any IE • Added proto_tree_add_protocol_format() calls so that the protocol can be added to a display filter • Append Protocol to the PROTOCOL column and PDU type to the INFO column. From me get rid of C++ style comments. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6375 svn path=/trunk/; revision=40627
2011-03-24From Vincent Helfre:Anders Broman1-9/+12
I updated again the csn1 dissector to associate hf_field to each element. svn path=/trunk/; revision=36306
2011-03-23From Vincent Helfre:Anders Broman1-34/+232
- added documentation in packet-csn1.h - fixed a bug in packet-csn1.c - fixed a BSIC description in packet-gsm_a_rr.c - removed the "_v" suffix in packet-gsm_rlcmac element description svn path=/trunk/; revision=36284
2011-02-28Define some globals as static; Remove uneeded #includes; Whitespace cleanup.Bill Meier1-45/+38
svn path=/trunk/; revision=36100
2011-02-28From Pascal Quantin:Anders Broman1-38/+42
the attached patch should hopefully please the buildbots svn path=/trunk/; revision=36095
2011-02-28From Pascal Quantin:Anders Broman1-37/+37
patch to fix the various issues svn path=/trunk/; revision=36094
2011-02-28From Vincent Helfre:Anders Broman1-37/+97
I change the void * descr field as an union to either store a pointer or a value. Hope it solves the problem. svn path=/trunk/; revision=36092
2011-02-28svn path=/trunk/; revision=36087Anders Broman1-0/+299
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-31 05:59:35 +0000