aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-csn1.c
AgeCommit message (Collapse)AuthorFilesLines
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-28csn1: set pointer before using it (found by clang).Dario Lombardo1-0/+1
Change-Id: I4ff2fb3861725a492736facd2d084baeef8fd09f Reviewed-on: https://code.wireshark.org/review/25993 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-22csn1: fix indentation.Dario Lombardo1-60/+58
Change-Id: I7832cea4d1073df854852aa598c04bcab68bf94c Reviewed-on: https://code.wireshark.org/review/25992 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-05csn1: fix this statement may fall through [-Werror=implicit-fallthrough=] ↵Alexis La Goutte1-3/+3
found by gcc7 Change-Id: I11b943736a4f0835e8432db95b7d471244b08a16 Reviewed-on: https://code.wireshark.org/review/20401 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-02GSM RLC/MAC: add dissection of 2G->3G/4G PS handoverPascal Quantin1-1/+2
Change-Id: Ia24055d7d871b9fbf69a9225a2a273fced950a3c Reviewed-on: https://code.wireshark.org/review/15700 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-01CSN1: fix dissection of variable bitmapsVincent Helfre1-28/+9
Change-Id: I3dbb2a4f8f7ea125e4f96e302ea33ff03706eb1b Reviewed-on: https://code.wireshark.org/review/15674 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-09-23GSM RLC/MAC: fix dissection of variable length bitmapsPascal Quantin1-1/+1
Bug: 11534 Change-Id: I857134f21ab6a8a135eba6e784807f3f3734bf6c Reviewed-on: https://code.wireshark.org/review/10607 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-09-20Make CSN.1 dissectors more filterable.Michael Mann1-202/+164
The intent here is to remove proto_tree_add_text from packet-csn1.c, but the macros setup means A LOT more hf fields needs to be created. Many of those new hf fields were created with a perl script Bug: 11504 Change-Id: If12c7677185f18a7f684fd3746397be92b56b36d Reviewed-on: https://code.wireshark.org/review/10391 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-1/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-29Add editor modelines and adjust indentation as needed.Bill Meier1-1/+12
Change-Id: Id57d264299f2026d703c5b08bace4b24b32f184c Reviewed-on: https://code.wireshark.org/review/4371 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-06-24convert to proto_tree_add_subtree[_format]Michael Mann1-20/+10
Change-Id: I5f573dffabb8685a8e5a334ff2bfb24d9838daa6 Reviewed-on: https://code.wireshark.org/review/2601 Tested-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-11-09Include <epan/to_str.h> only when needed.Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53189
2013-03-17[-Wmissing-prototypes]Anders Broman1-1/+1
Use explicit casts. svn path=/trunk/; revision=48347
2012-12-02Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8037 :Pascal Quantin1-1/+1
Fix an infinite loop in CSN.1 dissector when having more than 255 padding bits svn path=/trunk/; revision=46335
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-14From Mike Morrin:Anders Broman1-18/+18
Fix pedantic compiler warnings in csn.1 dissectors. There is some tricky casting going on in csn.1 structures. To eliminate all the warnings, the function pointers needed to be moved out of the object pointer unions. Fortunately macros (mostly) hide these changes from the protocol dissector tables. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7686 svn path=/trunk/; revision=44899
2012-09-07From Mike Morrin:Anders Broman1-0/+2
Interface based on header type rather than MCS. passes in the header type for EGPRS packets. This makes sense because in a real protocol stack, the header type is encoded in the burst stealing bits, allowing the header can be decoded, giving the CPS IE, which then allows the data blocks to be decoded, so wireshark now follows the same practice. I found that there was a (previously overlooked) alignment error in decoding the last octet of some headers due to the last "octet" having less than 8 bits, and both the protocol stacks I have here assume that the left-hand bits are missing (as per the figures in 44.060). I corrected this by making a small extension to the NULL encoding in packet-csn.[ch] to allow a NULL field to consume more than 0 bits. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7615 svn path=/trunk/; revision=44805
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-14Try to fix a couple of warnings.Anders Broman1-17/+17
svn path=/trunk/; revision=43259
2012-06-04Get rid of a couple of warnings.Anders Broman1-1/+1
svn path=/trunk/; revision=43063
2012-04-24Minor cleanup: whitespace, indentation, long-lines, style, typos, etc;Bill Meier1-3/+3
Also: remove unneeded #include <stdlib.h> in 2 cases. svn path=/trunk/; revision=42226
2012-03-01From Mike Morrin: A small patch to correct the name of the function ↵Anders Broman1-1/+1
proto_tree_add_split_bits_item_ret_val() svn path=/trunk/; revision=41255
2012-02-29From Mike Morrin:Anders Broman1-0/+49
The attached patches add the uses proto_tree_add_split_bits_ret_val() proto_tree_add_split_bits_crumb() https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6885 svn path=/trunk/; revision=41249
2012-02-23From Lei Chen:Anders Broman1-1/+8
a patch to support decode FDD_CELL_INFORMATION of "UTRAN FDD Description" in packet-gsm_rlcmac.c https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6856 svn path=/trunk/; revision=41149
2012-02-05From Sylvain Munaut:Anders Broman1-39/+62
0001-packet-csn1-Fix-indenting-of-the-CSN_UINT-subsection.patch 0002-packet-csn1-Add-new-maro-M_TYPE_LABEL-to-customize-n.patch 0003-packet-csn1-New-macro-M_FIXED_LABEL-to-customize-str.patch 0004-packet-csn1-Allow-CHOICE-elements-to-re-process-the-.patch 0005-packet-csn1-Make-new-M_CHOICE_IL-option-that-doesn-t.patch 0006-packet-csn-Extend-CSN_SERIALIZE-to-allow-0-bit-of-le.patch https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6789 svn path=/trunk/; revision=40847
2012-01-23From Mike Morrin via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6754 :Jeff Morriss1-30/+28
Due to the variable remaining_bits_len getting out of sync with bit_offset (in one case due to a mistake in the patch for bug 6375, and in another case pre-existing). I have shuffled the decrements of remaining_bits_len so that they always occur next to an increment of bit_offset, so that this type of problem is easier to spot. From me: convert tabs to spaces to match the rest of the file. svn path=/trunk/; revision=40662
2012-01-21Try to fixAnders Broman1-1/+1
packet-csn1.c:179: warning: 'pui8' may be used uninitialized in this function svn path=/trunk/; revision=40635
2012-01-21Add the missing file fromAnders Broman1-57/+113
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=40627 Patch was whining about csn1.h fixing that i must have missed that csn1.c did not get patched. svn path=/trunk/; revision=40634
2012-01-05From Mike Morrin:Anders Broman1-1/+1
Wrong tvb_get_bits function call in packet-csn1.c. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6708 svn path=/trunk/; revision=40384
2011-10-24Fix encoding arg for various fcn calls:Bill Meier1-23/+23
- proto_tree_add_bits_item - proto_tree_add_bits_ret_val - proto_tree_add_bitmask - tvb_get_bits - tvb_get_bits16 - tvb_get_bits24 - tvb_get_bits32 - tvb_get_bits64 svn path=/trunk/; revision=39539
2011-09-25From Sylvain Munaut: Fix Bug #6351 (Buildbot fuzztest crash);Bill Meier1-0/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6351 svn path=/trunk/; revision=39140
2011-09-09From Sylvain Munaut via bug 6328:Stig Bjørlykke1-1/+1
Fix bug in CSN_CHOICE implentation preventing subtree processing svn path=/trunk/; revision=38951
2011-08-30From Lei Chen:Anders Broman1-1/+1
fix the wrong display of CSN_BIT under CSN_UNION. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6287 svn path=/trunk/; revision=38807
2011-08-26CSN_LEFT_ALIGNED_VAR_BMP didn't handle more than 8 bits.Anders Broman1-3/+17
(CSN Ack/Nack Description wrongly handled in gsm_rlcmac_dl dissector ) https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6101 svn path=/trunk/; revision=38745
2011-08-09Fix the fuzz failure reported inJeff Morriss1-5/+5
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6139 : Properly initialize the CSN_DESCR type before recursively calling csnStreamDissector(). svn path=/trunk/; revision=38430
2011-07-26From Lei Chen:Anders Broman1-0/+3
CSN_RECURSIVE_TARRAY should count the last '0' bit. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6166 svn path=/trunk/; revision=38205
2011-07-22From Lei Chen:Anders Broman1-2/+6
pDescr should not step on until proto_tree_add_text() has been called. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6151 svn path=/trunk/; revision=38164
2011-07-07From Ludovic Haessler:Anders Broman1-1/+16
CSN Ack/Nack Description wrongly handled in gsm_rlcmac_dl dissector (3GPP TS 44.060) https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6101 svn path=/trunk/; revision=37926
2011-04-12Cleanup ProcessError().Stig Bjørlykke1-11/+6
Coverity 865. svn path=/trunk/; revision=36610
2011-03-26remove a proto_item variable we never useRonnie Sahlberg1-31/+28
coverity 866 svn path=/trunk/; revision=36346
2011-03-24From Vincent Helfre:Anders Broman1-34/+9
I updated again the csn1 dissector to associate hf_field to each element. svn path=/trunk/; revision=36306
2011-03-23Don't use C++/C99-style comments.Jeff Morriss1-1/+1
svn path=/trunk/; revision=36288
2011-03-23From Vincent Helfre:Anders Broman1-9/+8
- added documentation in packet-csn1.h - fixed a bug in packet-csn1.c - fixed a BSIC description in packet-gsm_a_rr.c - removed the "_v" suffix in packet-gsm_rlcmac element description svn path=/trunk/; revision=36284
2011-02-28Define some globals as static; Remove uneeded #includes; Whitespace cleanup.Bill Meier1-131/+132
svn path=/trunk/; revision=36100
2011-02-28From Pascal Quantin:Anders Broman1-7/+7
the attached patch should hopefully please the buildbots svn path=/trunk/; revision=36095
2011-02-28From Pascal Quantin:Anders Broman1-2/+6
patch to fix the various issues svn path=/trunk/; revision=36094
2011-02-28- RE apply checkapi patch.Anders Broman1-1/+1
- Mark unused parameters (From Pascal Quantin). svn path=/trunk/; revision=36093
2011-02-28From Vincent Helfre:Anders Broman1-24/+24
I change the void * descr field as an union to either store a pointer or a value. Hope it solves the problem. svn path=/trunk/; revision=36092
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-29 21:06:23 +0000