aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-couchbase.c
AgeCommit message (Collapse)AuthorFilesLines
2019-12-12couchbase: Fix Dead StoreAlexis La Goutte1-1/+0
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Icd18de17e7564b946ea177df252dffd2370ff1a0 Reviewed-on: https://code.wireshark.org/review/35408 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-11-30couchbase: Update dissector for latest 6.5.0 DCP snapshot markerJim Walker1-17/+40
Decode the v1/v2.0 formats which are relevant for the upcoming 6.5.0 release. Change-Id: Ie726f1ebd2457f6a36b096a0cd0bed9c94f713df Reviewed-on: https://code.wireshark.org/review/35251 Reviewed-by: Ben Huddleston <ben.huddleston@couchbase.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-11-29couchbase: update dissector with missing collection error codesJim Walker1-0/+15
Change-Id: I17a693ebfb09384892febb4139942fea756a50f2 Reviewed-on: https://code.wireshark.org/review/35250 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Ben Huddleston <ben.huddleston@couchbase.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-16Couchbase: Handle extras in mutation responsesMatt Carabine1-7/+29
Previously extras in any mutation (e.g. ADD, SET) response would be marked as illegal, as these used to return no extras. More recently, extras can be returned in mutations if the connection has negotiated the MUTATION_SEQNO feature. The extras can contain the mutation's sequence number and the vBucket UUID. This commit adds a new field (couchbase.extras.mutation_seqno) to achieve this, as the existing field couchbase.extras.seqno is used for a different purpose and is only a UINT32, whereas a UINT64 is returned as part of the extras; the existing couchbase.extras.vbucket_uuid is used for the vBucket UUID. Change-Id: If8a5148f2115fce7a777b96ad22ba92d95c9ff71 Reviewed-on: https://code.wireshark.org/review/34540 Reviewed-by: Dave Rigby <daver@couchbase.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-02couchbase: update command identifiersSergey Avseyev1-0/+8
Change-Id: Ic6eb59a26dc0a9edd216a985bbf94d13b4bc5094 Reviewed-on: https://code.wireshark.org/review/34427 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-19MB-34017: Add HCS to SnapshotMarkerBen Huddleston1-7/+7
Add the optional HCS field to the snapshot marker (only send on when non-zero for disk snapshots). Also, remove the durability timeout field from DCP_PREPARE as it is not sent and the UI warns about invalid extras length. Change-Id: I46955e2a719d28a70377bc6addb65fa3356ea1d4 Reviewed-on: https://code.wireshark.org/review/34323 Reviewed-by: Jim Walker <jim@couchbase.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-17Couchbase: Fix dissector for dcp prepareTrond Norbye1-2/+1
The timeout value was removed from the DCP PREPARE message as it was never used (and will never occur in a released version of Couchbase) Change-Id: I95f5bb3a0878237bf0339da48476fda437740c25 Reviewed-on: https://code.wireshark.org/review/33984 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Jim Walker <jim@couchbase.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-06-24couchbase: Add prepare seqno to DCP_COMMITBen Huddleston1-0/+2
Given that we send the prepare seqno for DCP_ABORT and we have ensured it is sent as non-zero, we may as well send it in the DCP_COMMIT to allow replica nodes to do some additional error checking. Change-Id: I67fb7d3e98a6518ec80c1a713e8d1d5637425a75 Reviewed-on: https://code.wireshark.org/review/33724 Reviewed-by: Jim Walker <jim@couchbase.com> Reviewed-by: Dave Rigby <daver@couchbase.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-19couchbase: Format seqnos as decimalDave Rigby1-15/+15
Couchbase DCP sequence numbers start from zero, incrementing by one for each message; and are generally displayed inside Couchbase as decimal. For ease of use with Wireshark dumps, print them as decimal instead of hex. Change-Id: I590fe137b96263d589e0ccc3161b57ffee40854b Reviewed-on: https://code.wireshark.org/review/33660 Reviewed-by: Ben Huddleston <ben.huddleston@couchbase.com> Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Reviewed-by: Jim Walker <jim@couchbase.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-16couchbase: Add prepare seqno to DCP_ABORTBen Huddleston1-1/+3
DCP_ABORT now needs the prepare seqno for MB-34474. Change-Id: Idf36f85f593735e31c7be96b0c9253d90fdb825f Reviewed-on: https://code.wireshark.org/review/33597 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-24couchbase: Remove 2nd seqno from DCP_{COMMIT,ABORT,SEQNO_ACK}Dave Rigby1-13/+18
DCP_COMMIT, DCP_ABORT and DCP_SEQNO_ACK no longer include two seqnos, just a single one. Add missing status codes for durability-related statuses. Change-Id: I97b847dd43c59405d69410ef28b0b362111c0fbd Reviewed-on: https://code.wireshark.org/review/33339 Reviewed-by: Ben Huddleston <ben.huddleston@couchbase.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-04epan: Convert our PROTO_ITEM_ macros to inline functions.Gerald Combs1-3/+3
Convert our various PROTO_ITEM_ macros to inline functions and document them. Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c Reviewed-on: https://code.wireshark.org/review/32706 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-06couchbase: check shift value before use.Dario Lombardo1-0/+3
Bug: 15439 Change-Id: I5bd702333795f2ed705eadb665516cb27b6e0371 Reviewed-on: https://code.wireshark.org/review/32311 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-14couchbase: Add Collections Get ID opcodeBen Huddleston1-3/+19
Change-Id: If3f318dbaa98df4d991bd447341d1a27048cae50 Reviewed-on: https://code.wireshark.org/review/32031 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Dave Rigby <daver@couchbase.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-28couchbase: update list of HELLO featuresSergey Avseyev1-1/+4
Change-Id: I323c54faaeaf951e284fa3b64c19e9e6671d36ec Reviewed-on: https://code.wireshark.org/review/31767 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-23Update couchbase set/del_with_meta option flagsChristopher Farman1-10/+32
Update the flag descriptors for options inside a set_with_meta and del_with_meta message, whilst also adding a new flag, IS_EXPIRATION, for only del_with_meta. Change-Id: I2f97c5aecb618e90783a39ce026ae0feba110dfd Reviewed-on: https://code.wireshark.org/review/31675 Reviewed-by: Jim Walker <jim@couchbase.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-16Couchbase: Fix another shadow variable.Gerald Combs1-5/+5
Change-Id: Id66535f9e21a9e311cb69af2b46fa896186e8b10 Reviewed-on: https://code.wireshark.org/review/31561 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-03Couchbase: Fixup a shadow variable.Gerald Combs1-4/+4
Rename index to byte_idx. Change-Id: I49d09d6db71d5db9e1c65f2abadc1413b3ccb7ec Reviewed-on: https://code.wireshark.org/review/31313 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-10couchbase: Add durable DCP commandsJim Walker1-0/+101
Adding DCP prepare, seqno-ack, commit and abort Change-Id: Ife7726c91962ab7fc41bc981ee98418474d33385 Reviewed-on: https://code.wireshark.org/review/30989 Reviewed-by: Dave Rigby <daver@couchbase.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-07couchbase: Improve key decoderJim Walker1-5/+5
Using the recent updates occasional 'trailing' byte warnings occur if the key encodes a collection-ID, with these changes we now get much better key decoding, without the warnings with and without collections. Change-Id: I9fc1e0d807c8054065a7346a09b0ce99d05f1e63 Reviewed-on: https://code.wireshark.org/review/30956 Reviewed-by: Dave Rigby <daver@couchbase.com> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-04couchbase: Update for recent collection changesJim Walker1-14/+85
Add support for decoding a collection-ID from the key-bytes. Update DCP as collection_len is no longer in the protocol and the system events have changed. Change-Id: Ib910083d929a906729e2bba2b0f07ba23e093cf5 Reviewed-on: https://code.wireshark.org/review/30895 Reviewed-by: Dave Rigby <daver@couchbase.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-04couchbase: Update FlexFrame dissector to include requestsJim Walker1-86/+267
Update the couchbase packet dissector with some re-factoring of the FlexFrame dissector and then extra functionality for: * FlexFrame on requests (magic 0x08) * Durability * Out-Of-Order requests * DCP Stream ID Additional checks are added to warn/error for invalid frame lengths and for the case where the FlexFrame byte0 is 0xff, which is not defined by the protocol. Change-Id: I5f1fec8293284dadbdef717d02fa1eef27da7a0c Reviewed-on: https://code.wireshark.org/review/30894 Reviewed-by: Dave Rigby <daver@couchbase.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-30Update couchbase dissector for new expiration formatChristopher Farman1-0/+22
Adding delete time to the expirtation packet Change-Id: I1881892122182a7656bde5b93e2de969f6f1b615 Reviewed-on: https://code.wireshark.org/review/30404 Reviewed-by: Jim Walker <jim@couchbase.com> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-25Add obsolete ssl[._]port preferences.Gerald Combs1-1/+2
gcd95e197ca renamed a bunch of "<proto>.ssl.port" preferences to "<proto>.tls.port" but neglected to add obsolete entries for the old preferences. Do so here. Rename couchbase.tls_port to couchbase.tls.port to be in line with the other TLS port preferences. Change-Id: Ie23d6be0a5cb3616f37e41dbfbf13ad1b7206473 Reviewed-on: https://code.wireshark.org/review/29829 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-09-25Rename packet-ssl* to packet-tls*Gerald Combs1-1/+1
Rename packet-ssl{,-utils}.[ch] to packet-tls{,-utils}.[ch]. Change-Id: I4732162ec131ddf0734b3dd191ccc9e48a76ce06 Reviewed-on: https://code.wireshark.org/review/29659 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-15couchbase: fix Unused href entry: epan/dissectors/packet-couchbase.c: ↵Alexis La Goutte1-2/+0
hf_flex_frame Change-Id: I3d0422f0e433ec9f3056b327b5e3da5e0510437d Reviewed-on: https://code.wireshark.org/review/29665 Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-13Start renaming SSL to TLS.Gerald Combs1-2/+2
Rename the "ssl" protocol to "tls" and add an "ssl" alias. Prefer "TLS" over "SSL" in user interface text and in the documentation. Fix the test_tls_master_secret test while we're here. Bug: 14922 Change-Id: Iab6ba2c7c4c0f8f6dd0f6d5d90fac5e9486612f8 Reviewed-on: https://code.wireshark.org/review/29649 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-24Couchbase: update opcodes and decode AUDIT_PUT as JSONSergey Avseyev1-10/+45
Change-Id: I6b9e3455abbf0cbd4eb6513fc652cf2902c9eb79 Reviewed-on: https://code.wireshark.org/review/26570 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-20Update to couchbase dissector for 'flexible framing extras' on errorsJim Walker1-5/+6
The flexible framing extras can be on success and error packets, so move the call to dissect out of the success path. See: https://github.com/couchbase/kv_engine/blob/master/docs/BinaryProtocol.md#response-header-with-flexible-framing-extras Change-Id: I6fdadf4a90bd1e9c2b1e6e37793cc7a105fad3a6 Reviewed-on: https://code.wireshark.org/review/26566 Reviewed-by: Dave Rigby <daver@couchbase.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-02-20Use units for the server recv->send duration.Guy Harris1-9/+7
We *do* support units for FT_FLOAT and FT_DOUBLE, so use them. Change-Id: I94dbce89c785109b2c6ef89243f5611963e63dc8 Reviewed-on: https://code.wireshark.org/review/25917 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-20Clean up the way we handle the server recv->send duration.Guy Harris1-11/+10
There's no guarantee that it'll be integral, and the spec doesn't seem to imply that it's necessarily integral, so don't convert it to an integer. Given that it's a floating-point number, we might as well represent it as an FT_DOUBLE. (XXX - we should support units for FT_FLOAT and FT_DOUBLE.) Change-Id: Ica43510ac147231f5530359cc78bb467f8d3be24 Reviewed-on: https://code.wireshark.org/review/25915 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-13Update couchbase dissector with 'flexible framing extras'Jim Walker1-9/+166
Add support to decode the new response message and then decode the array of flexible frames, currently only the "tracing" durations ID is fully decoded. See: https://github.com/couchbase/kv_engine/blob/master/docs/BinaryProtocol.md#response-header-with-flexible-framing-extras Change-Id: I9ea1e3bb898d9c4dd3b30cd1109b7b70fc17b19e Reviewed-on: https://code.wireshark.org/review/25613 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-05Update couchbase dissector with collections and delete_time DCPJim Walker1-3/+68
Add support for collection commands * SET/GET manifest * DCP changes (mutation/deletion/system_event) Add support for DCP delete_time, a new format for DCP deletion Change-Id: Iec2000a40da37dcb1edf665a157dc7ab30d4c9d0 Reviewed-on: https://code.wireshark.org/review/25612 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-02-05Update couchbase dissector with new HELLO feature valuesJim Walker1-1/+6
Simply add missing feature values to the existing table Change-Id: Ie4b0876df1d736af1cd1171a6645df75e2eb8cf2 Reviewed-on: https://code.wireshark.org/review/25611 Reviewed-by: Dave Rigby <daver@couchbase.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-12-21couchbase: uncompress snappy payloadsSergey Avseyev1-1/+36
Change-Id: I70de47512dfe8ff1a390a243688ef13f012561fa Reviewed-on: https://code.wireshark.org/review/24921 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-14couchbase: detect XERROR responses and dissect them as JSONSergey Avseyev1-1/+10
Change-Id: Ia2565090f8dc30e17cd6a16614136d237577d282 Reviewed-on: https://code.wireshark.org/review/23535 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-05Fix unitialized variable warnings that popped up with -OgJoão Valverde1-1/+1
Using GCC version 7.1.1. Change-Id: I7447a48fc97efb1eb15a016a29165f69d37f40a6 Reviewed-on: https://code.wireshark.org/review/23399 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-02couchbase: fix full-doc commands of subdocSergey Avseyev1-5/+7
They do not have path, so the min_spec_size should be smaller Change-Id: I5a77bcf742be5f8a00f0cf7a215f386a845673fa Reviewed-on: https://code.wireshark.org/review/23349 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Dave Rigby <daver@couchbase.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-25couchbase: update HELLO featuresSergey Avseyev1-7/+12
Change-Id: Icff1932cd41334fcf04016f3616a99ac4293ebef Reviewed-on: https://code.wireshark.org/review/23198 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-18couchbase: update status codesSergey Avseyev1-1/+40
Change-Id: I7f0950d82c50c8f019d844d726ffe7a0015618c5 Reviewed-on: https://code.wireshark.org/review/23117 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-14Couchbase: Add doc flag support to dissectorolivermd1-11/+64
This patch makes required changes to be able to dissect packets that use the new subdoc doc flags. This involved modifying the existing subdoc flags, creating the new docs flags and modifying the extras dissector. Change-Id: Iaaf5e58d778ca5f54f76c9d27680df68eee8b7bd Reviewed-on: https://code.wireshark.org/review/23032 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-08-10Couchbase: Add get error map cmdolivermd1-0/+13
Change-Id: I9ca47fa0f77edd0ce94d2fe4cb098b5ff2786749 Reviewed-on: https://code.wireshark.org/review/23030 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-07-13couchbase: fix decoding last lookup specSergey Avseyev1-1/+1
Change-Id: I96ae6225adee6875adad9e45c0543b9664b96e8a Reviewed-on: https://code.wireshark.org/review/22605 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-21couchbase: Fix Dead Store (Dead assignement/Dead increment) Warning found by ↵Alexis La Goutte1-2/+1
Clang Change-Id: I9f5f91925607582f40855ca1a08875e83d62f4eb Reviewed-on: https://code.wireshark.org/review/20205 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-21Couchbase: Add SSL supportolivermd1-6/+23
Change-Id: I468f92c20184a6e5f5bd1f07d94c0b605c0593dc Reviewed-on: https://code.wireshark.org/review/20149 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-16Couchbase: Add support for XATTRsOliver Downard1-11/+141
Please see https://issues.couchbase.com/browse/MB-22004 Alters subdoc dissecting to support XATTRs Accomodates for the addition of the XATTR HELLO flag Changes SET_WITH_META to support XATTRs Changes DCP mutation/deletion to support XATTRs Change-Id: I4ff6e498b96c329d51167daf58a6d85c1f0c77c4 Reviewed-on: https://code.wireshark.org/review/20062 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-06Couchbase: Add decoding for create_bucket configOliver Downard1-2/+71
Change-Id: I7d84e67723196d9b39f6007950ec8fb95fe9a50e Reviewed-on: https://code.wireshark.org/review/19934 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-02-03Add support for Couchbase LWW *_with_meta commandsolivermd1-0/+87
Decodes the options and meta length fields added with LWW for {set,del}_with_meta request commands. Decodes get_meta responses extra field. Please see https://issues.couchbase.com/browse/MB-22003 Change-Id: Ie5205e8188a32d59145c4f9c499b16c7a7997274 Reviewed-on: https://code.wireshark.org/review/19928 Reviewed-by: Dave Rigby <daver@couchbase.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-01-10Rename tvb_new_subset() to tvb_new_subset_length_caplen().Guy Harris1-4/+4
This emphasizes that there is no such thing as *the* routine to construct a subset tvbuff; you need to choose one of tvb_new_subset_remaining() (if you want a new tvbuff that contains everything past a certain point in an existing tvbuff), tvb_new_subset_length() (if you want a subset that contains everything past a certain point, for some number of bytes, in an existing tvbuff), and tvb_new_subset_length_caplen() (for all other cases). Many of the calls to tvb_new_subset_length_caplen() should really be calling one of the other routines; that's the next step. (This also makes it easier to find the calls that need fixing.) Change-Id: Ieb3d676d8cda535451c119487d7cd3b559221f2b Reviewed-on: https://code.wireshark.org/review/19597 Reviewed-by: Guy Harris <guy@alum.mit.edu>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-29 17:51:38 +0000